Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97253953
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97253035
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -142,4 +138,25 @@ case class ExecutorContext(
case
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97245683
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -40,6 +44,12 @@ class RunningApplication(val
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244923
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244855
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationRuntimeInfo.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244536
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/ClusterMessage.scala ---
@@ -155,9 +158,13 @@ object MasterToClient {
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244280
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -142,4 +138,25 @@ case class ExecutorContext(
case
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244189
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -18,11 +18,11 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216230
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -139,4 +138,47 @@ case class ExecutorContext(
case
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216223
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -139,4 +138,47 @@ case class ExecutorContext(
case
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216701
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationMetaData.scala
---
@@ -19,18 +19,20 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216646
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationMetaData.scala
---
@@ -19,18 +19,20 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216688
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationMetaData.scala
---
@@ -19,18 +19,20 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216725
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationRuntimeInfo.scala
---
@@ -19,20 +19,34 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216757
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/appmaster/ApplicationRuntimeInfo.scala
---
@@ -19,20 +19,34 @@
package
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216886
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -217,40 +206,56 @@ private[cluster] class
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216883
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -217,40 +206,56 @@ private[cluster] class
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/134
[GEARPUMP-265] remove AppMasterRuntimeInfo from AppMasterContext
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make
18 matches
Mail list logo