[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread manuzhang
Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72433772 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413816 --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala --- @@ -92,6 +91,7 @@ abstract

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412991 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaReadWrite.scala --- @@ -86,4 +90,30 @@

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413298 --- Diff: examples/streaming/kafka/src/main/scala/org/apache/gearpump/streaming/examples/kafka/KafkaWriter.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/67#discussion_r72412383 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/source/DataSourceTask.scala --- @@ -46,23 +46,39 @@ class DataSourceTask

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

2016-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395363#comment-15395363 ] ASF GitHub Bot commented on GEARPUMP-32: Github user huafengw commented on a diff in the pull

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

2016-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395359#comment-15395359 ] ASF GitHub Bot commented on GEARPUMP-32: Github user huafengw commented on a diff in the pull

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

2016-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395356#comment-15395356 ] ASF GitHub Bot commented on GEARPUMP-32: Github user huafengw commented on a diff in the pull

[GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...

2016-07-27 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/67 fix GEARPUMP-32, introduce source watermark This is for early review and contains some example codes which will be removed before merge. You can merge this pull request into a Git

[jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate

2016-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395256#comment-15395256 ] ASF GitHub Bot commented on GEARPUMP-32: GitHub user manuzhang opened a pull request: