[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 One question, now the `connection` is a transient value, will there be a NPE after the HBaseSink deserialized? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 @huafengw any more comments ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 @huafengw the current `HBaseSink` constructor is not testable. I'm afraid changing it is the only way to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 Generally my question is that is there any way implementing the HBaseSinkSpec without changing the HBaseSink? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-gearpump issue #86: [GEARPUMP-204]add unit test for external_hbase...
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/86 ## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/86?src=pr) is 70.63% (diff: 22.22%) > Merging [#86](https://codecov.io/gh/apache/incubator-gearpump/pull/86?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will decrease coverage by **0.17%** ```diff @@ master#86 diff @@ == Files 178178 Lines 5903 5909 +6 Methods5584 5403 -181 Messages 0 0 Branches319506 +187 == - Hits 4180 4174 -6 - Misses 1723 1735+12 Partials 0 0 ```  > Powered by [Codecov](https://codecov.io?src=pr). Last update [5cd5b93...3086e45](https://codecov.io/gh/apache/incubator-gearpump/compare/5cd5b9304f0f703c6f89d2865e5bb7adbb631c74...3086e4535fbbaa1c6e652f8e3cc3fdeb7bf24ead?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
