Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
One question, now the `connection` is a transient value, will there be a
NPE after the HBaseSink deserialized?
---
If your project is set up for it, you can reply to this email and have
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
@huafengw any more comments ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
@huafengw the current `HBaseSink` constructor is not testable. I'm afraid
changing it is the only way to go.
---
If your project is set up for it, you can reply to this email and have
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
Generally my question is that is there any way implementing the
HBaseSinkSpec without changing the HBaseSink?
---
If your project is set up for it, you can reply to this email and have
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/86
## [Current
coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/86?src=pr) is
70.63% (diff: 22.22%)
> Merging
