Feature branch cleanup

2017-02-24 Thread Anthony Baker
The following 100+ feature branches are related to closed bugs. I think these can safely be deleted (the branch names aren’t exact but pretty close): GEODE-1017: "Closed" GEODE-1040: "Closed" GEODE-1050: "Closed" GEODE-1056: "Closed" GEODE-1072: "Closed" GEODE-1096: "Closed" GEODE-1109:

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

2017-02-24 Thread Jacob S. Barrett (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884078#comment-15884078 ] Jacob S. Barrett commented on GEODE-2441: - I am still seeing PDX Auto Serializer code in the C++

[jira] [Updated] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

2017-02-24 Thread Jacob S. Barrett (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett updated GEODE-2493: Description: Several platform specific locking and CAS operations are implemented in

[jira] [Comment Edited] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

2017-02-24 Thread Jacob S. Barrett (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869213#comment-15869213 ] Jacob S. Barrett edited comment on GEODE-2493 at 2/25/17 6:05 AM: --

[jira] [Updated] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

2017-02-24 Thread Jacob S. Barrett (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett updated GEODE-2493: Summary: Replace the locking and CAS operations provided in HostAsm with C++11 standards

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884063#comment-15884063 ] ASF GitHub Bot commented on GEODE-2531: --- GitHub user pivotal-jbarrett opened a pull request:

[GitHub] geode-native pull request #37: GEODE-2531: Replace HostAsm::atomic with std:...

2017-02-24 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/37 GEODE-2531: Replace HostAsm::atomic with std::atomic. Focus on commit c3411fd since the others are from pull #36. Replaces the HostAsm::atomic* functions and ACE::Atomic*

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884057#comment-15884057 ] ASF GitHub Bot commented on GEODE-2494: --- GitHub user pivotal-jbarrett opened a pull request:

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

2017-02-24 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/36 GEODE-2494: Replace SpinLock with spinlock_mutex. Replaces our non-standard SpinLock with spinlock_mutex that implements the C++11 standard BasicLockable. Where applicable the spin

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884048#comment-15884048 ] ASF subversion and git services commented on GEODE-2439: Commit

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884049#comment-15884049 ] ASF GitHub Bot commented on GEODE-2439: --- Github user asfgit closed the pull request at:

[GitHub] geode-native pull request #35: GEODE-2439: Fix build breaking merge from mer...

2017-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884046#comment-15884046 ] ASF subversion and git services commented on GEODE-2439: Commit

[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884043#comment-15884043 ] ASF subversion and git services commented on GEODE-2275: Commit

[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884033#comment-15884033 ] Kirk Lund commented on GEODE-2275: -- This reproduced in one of my private precheckin runs. Since there's

Re: [DISCUSS] changes to Redis implementation

2017-02-24 Thread Gregory Green
Hello, I just push the changes to remove the @author tags and updated the RegionProviderTest. On Fri, Feb 24, 2017 at 7:36 PM, Jason Huynh wrote: > It looks like travis ci failed on that pr? Also there are some @author > tags that should probably be scrubbed out > > On Fri,

[jira] [Commented] (GEODE-1995) remove ReliableMessageQueueFactory, ReliableMessageQueue, and getReliableMessageQueueFactory

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884017#comment-15884017 ] ASF GitHub Bot commented on GEODE-1995: --- Github user davinash commented on the issue:

[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...

2017-02-24 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 @metatype , @dschneider-pivotal Please let me know if this is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884015#comment-15884015 ] ASF GitHub Bot commented on GEODE-1887: --- Github user davinash commented on the issue:

[GitHub] geode issue #390: [GEODE-1887] #comment Fix Issue Client PROXY region should...

2017-02-24 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/390 Thanks @kirklund Addressed review comment. Please let me know if this is PR is now good for merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884005#comment-15884005 ] ASF GitHub Bot commented on GEODE-1887: --- Github user davinash commented on a diff in the pull

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

2017-02-24 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/geode/pull/390#discussion_r103070525 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java --- @@ -773,6 +755,73 @@ public void

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884004#comment-15884004 ] ASF GitHub Bot commented on GEODE-1887: --- Github user davinash commented on a diff in the pull

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

2017-02-24 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/geode/pull/390#discussion_r103070526 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java --- @@ -773,6 +755,73 @@ public void

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

2017-02-24 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/geode/pull/390#discussion_r103070521 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java --- @@ -773,6 +755,73 @@ public void

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883972#comment-15883972 ] ASF GitHub Bot commented on GEODE-2428: --- Github user davinash commented on the issue:

[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...

2017-02-24 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/388 Thanks @metatype and @bschuchardt I will fix import issue and check-in the changes to develop, once all the checks have passed. --- If your project is set up for it, you can reply to this

[jira] [Commented] (GEODE-2460) Update dependency versions

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883924#comment-15883924 ] ASF subversion and git services commented on GEODE-2460: Commit

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883913#comment-15883913 ] ASF GitHub Bot commented on GEODE-2428: --- Github user bschuchardt commented on a diff in the pull

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883884#comment-15883884 ] ASF GitHub Bot commented on GEODE-2439: --- GitHub user dgkimura opened a pull request:

[GitHub] geode-native pull request #35: GEODE-2439: Fix build breaking merge from mer...

2017-02-24 Thread dgkimura
GitHub user dgkimura opened a pull request: https://github.com/apache/geode-native/pull/35 GEODE-2439: Fix build breaking merge from merge conflict Build broke after bad merge with commits: GEODE-2439 and GEODE-2440. Conflict was resolved incorrectly by accidentally

Re: [jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

2017-02-24 Thread Darrel Schneider
Cache loaders should only be invoked if you do a "get" operation. In this case you are just registering interest which is not a "get" operation. With register interest you are saying "if this key every exists let me know" and doing that should not cause it to exist. On Fri, Feb 24, 2017 at 4:21

Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

2017-02-24 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57057/ --- Review request for geode, Barry Oglesby, Jason Huynh, nabarun nag, and xiaojian

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-24 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies too much on > >

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883854#comment-15883854 ] ASF GitHub Bot commented on GEODE-2428: --- Github user metatype commented on the issue:

[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...

2017-02-24 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/388 This looks good to me, @bschuchardt what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Updated] (GEODE-2548) Hang in PaginationDUnitTest.alternativelyCloseDataStoresAfterGettingAPageAndThenValidateTheContentsOfTheResults

2017-02-24 Thread Jason Huynh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh updated GEODE-2548: --- Summary: Hang in

[jira] [Commented] (GEODE-2548) Hang in PaginationDUnitTest.

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883850#comment-15883850 ] ASF subversion and git services commented on GEODE-2548: Commit

[jira] [Commented] (GEODE-2543) Remove incorrectly marked deprecated methods from LuceneService and LuceneQueryFactory api

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883849#comment-15883849 ] ASF subversion and git services commented on GEODE-2543: Commit

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883846#comment-15883846 ] ASF GitHub Bot commented on GEODE-2428: --- Github user metatype commented on a diff in the pull

[jira] [Updated] (GEODE-2548) Hang in PaginationDUnitTest.

2017-02-24 Thread Jason Huynh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh updated GEODE-2548: --- Issue Type: Test (was: Bug) > Hang in PaginationDUnitTest. > > >

[jira] [Created] (GEODE-2548) Hang in PaginationDUnitTest.

2017-02-24 Thread Jason Huynh (JIRA)
Jason Huynh created GEODE-2548: -- Summary: Hang in PaginationDUnitTest. Key: GEODE-2548 URL: https://issues.apache.org/jira/browse/GEODE-2548 Project: Geode Issue Type: Bug Components:

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/#review166794 --- Ship it! Ship It! - Kirk Lund On Feb. 24, 2017, 3:12 a.m.,

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Kirk Lund
> On Feb. 24, 2017, 10:58 p.m., Dan Smith wrote: > > Nice! > > > > I'm a bit confused by the guava dependency. Are you saying that it is a > > transitive dependency of something else in geode-core:testCompile, and you > > are trying to change the version that is used? If so you should

[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...

2017-02-24 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/397 The test failure doesn't seem to be related to your changes, though you need to run `gradlew spotlessApply` to format your PR correctly. Thanks! --- If your project is set up for it, you can reply

[GitHub] geode pull request #397: Add junit to try parsing of simple XML file w pool ...

2017-02-24 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/397#discussion_r103062304 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -15,19 +15,25 @@ package

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883837#comment-15883837 ] ASF GitHub Bot commented on GEODE-2526: --- Github user metatype commented on the issue:

[GitHub] geode issue #406: GEODE-2526: Enhance log statement to include ResourceTypeN...

2017-02-24 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/406 Please update the PR after running `gradlew spotlessApply`. Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] geode issue #404: Geode 2469

2017-02-24 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/404 Thanks for the contribution. Could you fix the test failure in `RegionProviderTest`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] changes to Redis implementation

2017-02-24 Thread Jason Huynh
It looks like travis ci failed on that pr? Also there are some @author tags that should probably be scrubbed out On Fri, Feb 24, 2017 at 4:33 PM Michael Stolz wrote: > +1 experimental means changing. Go for it. > > -- > Mike Stolz > Principal Engineer - Gemfire Product

Re: [DISCUSS] changes to Redis implementation

2017-02-24 Thread Kirk Lund
+1 for merging in these changes even though they break rolling upgrade for redis storage format -- it should be ok to break API or data format if it was "experimental" in all releases so far On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt wrote: > Gregory Green has

Re: [jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

2017-02-24 Thread Michael Stolz
Seems to me this is correct behavior. If you registered a cache loader you want it to work -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Feb 24, 2017 5:59 PM, "Barry Oglesby (JIRA)" wrote: > > [

Re: Review Request 57049: GEODE-2545: NPE during lucene query execution when cache is closing or region is destroyed

2017-02-24 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57049/#review166789 --- Ship it! Ship It! - Dan Smith On Feb. 24, 2017, 11:57 p.m.,

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883802#comment-15883802 ] ASF subversion and git services commented on GEODE-2507: Commit

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883801#comment-15883801 ] ASF subversion and git services commented on GEODE-2507: Commit

[GitHub] geode pull request #405: Delete website

2017-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker resolved GEODE-2507. -- Resolution: Fixed > Acquire and populate new geode-site repo for the web site >

[jira] [Closed] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker closed GEODE-2507. > Acquire and populate new geode-site repo for the web site >

Review Request 57049: GEODE-2545: NPE during lucene query execution when cache is closing or region is destroyed

2017-02-24 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57049/ --- Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883790#comment-15883790 ] ASF subversion and git services commented on GEODE-2507: Commit

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-site/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883791#comment-15883791 ] ASF GitHub Bot commented on GEODE-2507: --- Github user asfgit closed the pull request at:

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

2017-02-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/32#discussion_r103054588 --- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp --- @@ -23,7 +23,7 @@ #include "CacheableWrapper.hpp" extern "C"

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883749#comment-15883749 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883748#comment-15883748 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a diff in the

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

2017-02-24 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/32#discussion_r103054617 --- Diff: src/cppcache/src/CacheableBuiltins.cpp --- @@ -19,7 +19,7 @@ #include extern "C" { -#include +#include

[jira] [Commented] (GEODE-2486) Developer can use encrypted ciphers

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883737#comment-15883737 ] ASF subversion and git services commented on GEODE-2486: Commit

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166772 --- Ship it! Nice! I'm a bit confused by the guava dependency.

[jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

2017-02-24 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby reassigned GEODE-2547: Assignee: Barry Oglesby > Interest registration can cause a CacheLoader to be invoked >

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #483 has FAILED

2017-02-24 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #483 failed. --- Scheduled No failed tests found, a possible compilation error.

Re: Locators with --bind-address

2017-02-24 Thread Anilkumar Gingade
Other reasons: one could run multiple locators, and designate one for client connection and other for jmx. -Anil. On Fri, Feb 24, 2017 at 2:20 PM, Galen M O'Sullivan wrote: > I can see that you might want to configure them separately, so it's good to > have both

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883628#comment-15883628 ] ASF GitHub Bot commented on GEODE-2513: --- GitHub user karensmolermiller opened a pull request:

[GitHub] geode-native pull request #34: GEODE-2513 Rebrand Delta Propagation section ...

2017-02-24 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-native/pull/34 GEODE-2513 Rebrand Delta Propagation section of Geode Native documentation - Replace outdated code example with pointer to docs on updated QuickStart examples -

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883624#comment-15883624 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

2017-02-24 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/32#discussion_r103045677 --- Diff: src/tests/cpp/fwklib/Timer.hpp --- @@ -28,18 +28,18 @@ #ifdef _WIN32 -#include -#include -#include

Re: Locators with --bind-address

2017-02-24 Thread Galen M O'Sullivan
I can see that you might want to configure them separately, so it's good to have both options. If I was to design this again, I think I would have the JMX address etc. default to the same as the bind address, but as it is that would break backwards compatibility. -Galen On Fri, Feb 24, 2017 at

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883613#comment-15883613 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in the pull

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

2017-02-24 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/32#discussion_r103044451 --- Diff: src/cppcache/src/Utils.cpp --- @@ -22,7 +22,7 @@ #include extern "C" { -#include +#include --- End diff --

[jira] [Updated] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

2017-02-24 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2546: - Labels: Flaky (was: ) > RollingUpgradeDUnitTest fails intermittently with >

[jira] [Created] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

2017-02-24 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2546: Summary: RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException Key: GEODE-2546 URL: https://issues.apache.org/jira/browse/GEODE-2546

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166763 --- Ship it! Ship It! - Ken Howe On Feb. 24, 2017, 9:37 p.m.,

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883594#comment-15883594 ] ASF GitHub Bot commented on GEODE-2507: --- Github user scmbuildguy commented on a diff in the pull

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103041344 --- Diff: build.gradle --- @@ -16,10 +16,50 @@ */ plugins { - id "org.nosphere.apache.rat" version "0.3.0" + id

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166762 --- Ship it! Ship It! - Mark Bretl On Feb. 24, 2017, 1:37 p.m.,

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166761 --- Ship it! Ship It! - Kevin Duling On Feb. 24, 2017, 1:37

[jira] [Commented] (GEODE-2460) Update dependency versions

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883583#comment-15883583 ] ASF subversion and git services commented on GEODE-2460: Commit

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103040225 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883582#comment-15883582 ] ASF GitHub Bot commented on GEODE-2507: --- Github user metatype commented on a diff in the pull

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883576#comment-15883576 ] ASF GitHub Bot commented on GEODE-2507: --- Github user metatype commented on a diff in the pull

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883577#comment-15883577 ] ASF GitHub Bot commented on GEODE-2507: --- Github user metatype commented on a diff in the pull

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103039403 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103039387 --- Diff: build.gradle --- @@ -16,10 +16,50 @@ */ plugins { - id "org.nosphere.apache.rat" version "0.3.0" + id

Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

2017-02-24 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/ --- Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883565#comment-15883565 ] ASF GitHub Bot commented on GEODE-2507: --- Github user scmbuildguy commented on a diff in the pull

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883566#comment-15883566 ] ASF GitHub Bot commented on GEODE-2507: --- Github user scmbuildguy commented on a diff in the pull

Re: Locators with --bind-address

2017-02-24 Thread Anilkumar Gingade
I believe they need to be separate, which helps to provide better control over application connection (who can connect to what)... They should all have default bind address, right? -Anil. On Fri, Feb 24, 2017 at 12:57 PM, Kevin Duling wrote: > When starting a locator,

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

2017-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883564#comment-15883564 ] ASF GitHub Bot commented on GEODE-2507: --- Github user scmbuildguy commented on a diff in the pull

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103036407 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103036769 --- Diff: build.gradle --- @@ -16,10 +16,50 @@ */ plugins { - id "org.nosphere.apache.rat" version "0.3.0" + id

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103038157 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build

  1   2   >