Re: Build failed in Jenkins: Geode-nightly #879

2017-06-27 Thread Dan Smith
Looks like this build hung in PersistentPartitionedRegionDUnitTest. Here are the last lines in https://builds.apache.org/job/Geode-nightly/879/artifact/geode-core/build/distributedTest/distributedTest-progress.txt : 2017-06-27 09:13:00.547 + Completed test

Re: Review Request 60442: GEODE-3130: Refactoring AcceptorImpl communication mode switch

2017-06-27 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review179072 --- Fix it, then Ship it! Fix `AcceptorImpl.this` reference and

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179071 ---

Re: Review Request 60486: GEODE-3105: Adding handler for GetRegions

2017-06-27 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60486/#review179070 ---

Build failed in Jenkins: Geode-nightly-flaky #48

2017-06-27 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2919: fix lucene security tests [jiliao] GEODE-2919: revert: fix lucene security tests [bschuchardt] GEODE-3072: Events do not get removed from the client queue for 1.0

Build failed in Jenkins: Geode-nightly #879

2017-06-27 Thread Apache Jenkins Server
See Changes: [kmiller] GEODE-2819 Document http status code 414 for PUT [hkhamesra] GEODE-3075: Initial refactor adding NewProtocolServerConnection [hkhamesra] GEODE-3075: Add an integration test for the

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

2017-06-27 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/608#discussion_r124434616 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java --- @@ -48,13 +49,13 @@ public class

Re: Review Request 60375: GEODE-3117: fix Gateway authentication with legacy security

2017-06-27 Thread Jinmei Liao
> On June 26, 2017, 11:58 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java > > Line 82 (original), 82 (patched) > > > > > > since we already pass

[GitHub] geode issue #608: GEODE-3140: Removed DiskDirRule and replaced use with Temp...

2017-06-27 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/608 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

2017-06-27 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/608 GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder… … rule Thank you for submitting a contribution to Apache Geode. In order to streamline the review of

Failed: jinmeiliao/geode#2 (extractCommandRefactor - 5d676d1)

2017-06-27 Thread Travis CI
Build Update for jinmeiliao/geode - Build: #2 Status: Failed Duration: 27 minutes and 3 seconds Commit: 5d676d1 (extractCommandRefactor) Author: Jinmei Liao Message: wip View the changeset:

Re: New Apache commons-validato.jar

2017-06-27 Thread Kirk Lund
+1 for adding Commons-Validator On Tue, Jun 27, 2017 at 9:58 AM, Hitesh Khamesra < hitesh...@yahoo.com.invalid> wrote: > We are planning to include Apache commons-validator_1.6.jar in Geode. As > part of GEODE-2804, we need to validate whether host string is configured > as IP or not. Please let

Re: New Apache commons-validato.jar

2017-06-27 Thread Anthony Baker
Thanks for the heads up. It’s Apache licensed so no problems with that. To add it to the runtime classpath you’ll need to modify geode-assembly/build.gradle and fix the expected_jars.txt file. Anthony > On Jun 27, 2017, at 9:58 AM, Hitesh Khamesra > wrote: > >

Re: Review Request 60375: GEODE-3117: fix Gateway authentication with legacy security

2017-06-27 Thread Kirk Lund
> On June 26, 2017, 11:58 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java > > Line 82 (original), 82 (patched) > > > > > > since we already pass

[GitHub] geode pull request #607: GEODE-3105: adding GetRegion handler for protobuf p...

2017-06-27 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/607 GEODE-3105: adding GetRegion handler for protobuf protocol Added a handler which will catch incoming getRegion requests and will call into the cache's rootRegion and return the names of the region

Review Request 60486: GEODE-3105: Adding handler for GetRegions

2017-06-27 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60486/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/#review178937 ---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #599 was SUCCESSFUL (with 1908 tests)

2017-06-27 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #599 was successful. --- Scheduled 1910 tests in total. https://build.spring.io/browse/SGF-NAG-599/ -- This

Review Request 60483: GEODE-3139 remove geode-core/src/main artifacts from classpath of backward-compatibility tests

2017-06-27 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60483/ --- Review request for geode, Kirk Lund and Dan Smith. Bugs: GEODE-3139

[GitHub] geode pull request #605: GEODE-2996: incorporating review feedback and addin...

2017-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/605 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #602: GEODE-3130: Refactoring AcceptorImpl

2017-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #606: GEODE-2601: Fixing startup configurations logging t...

2017-06-27 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/606 GEODE-2601: Fixing startup configurations logging twice [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2601) The original fix (pull request #582) fixed the

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/ --- (Updated June 27, 2017, 8:04 p.m.) Review request for geode, Alexander

[GitHub] geode pull request #601: GEODE-3117: fix Gateway authentication with legacy ...

2017-06-27 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/601#discussion_r124376469 --- Diff: geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java --- @@ -0,0 +1,429 @@ +/*

[GitHub] geode issue #601: GEODE-3117: fix Gateway authentication with legacy securit...

2017-06-27 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/601 +1. Huzzah for more test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/ --- (Updated June 27, 2017, 12:11 p.m.) Review request for geode and Barry

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review179017 --- Ship it! All my concerns are about refactoring and code

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review179016 --- Ship it! Ship It! - Alexander Murmann On June 26, 2017,

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review179014 ---

[GitHub] geode pull request #605: GEODE-2996: incorporating review feedback and addin...

2017-06-27 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/605 GEODE-2996: incorporating review feedback and adding integration test Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Galen O'Sullivan
> On June 27, 2017, 6:19 p.m., Galen O'Sullivan wrote: > > The diff doesn't apply cleanly on develop on my machine. What's the base > > commit? Or better, can you merge or rebase on develop please? - Galen --- This is an automatically

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/#review179009 --- The diff doesn't apply cleanly on develop on my machine. What's

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/#review178995 ---

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Bruce Schuchardt
> On June 27, 2017, 10:53 a.m., Galen O'Sullivan wrote: > > MembershipID seems like a good candidate for extraction into its own class. > > This would make, for example, `equals` cleaner. I guess there are > > performance reasons for it. > > > > When does the problem occur? Is it when a

Re: Review Request 60442: GEODE-3130: Refactoring AcceptorImpl communication mode switch

2017-06-27 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review179007 --- Ship it! Ship It! - Galen O'Sullivan On June 26, 2017, 6:31

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-27 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review178935 --- Fix it, then Ship it! MembershipID seems like a good candidate

Fixed: apache/geode#3023 (develop - 718583b)

2017-06-27 Thread Travis CI
Build Update for apache/geode - Build: #3023 Status: Fixed Duration: 26 minutes and 4 seconds Commit: 718583b (develop) Author: Jinmei Liao Message: GEODE-2919: revert: fix lucene security tests View the changeset:

Broken: apache/geode#3019 (develop - e5204ce)

2017-06-27 Thread Travis CI
Build Update for apache/geode - Build: #3019 Status: Broken Duration: 21 minutes and 27 seconds Commit: e5204ce (develop) Author: Jinmei Liao Message: GEODE-2919: fix lucene security tests View the changeset:

Re: Review Request 60442: GEODE-3130: Refactoring AcceptorImpl communication mode switch

2017-06-27 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review178989 --- Ship it! Ship It! - Alexander Murmann On June 26, 2017,

New Apache commons-validato.jar

2017-06-27 Thread Hitesh Khamesra
We are planning to include Apache commons-validator_1.6.jar in Geode. As part of GEODE-2804, we need to validate whether host string is configured as IP or not. Please let us know if there is any issue with it. Thanks. Hitesh

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #598 was SUCCESSFUL (with 1908 tests). Change made by John Blum.

2017-06-27 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #598 was successful. --- This was manually triggered by John Blum. 1910 tests in total.

want to encrypt default username/password in properties files or xml with default encrypted values.

2017-06-27 Thread Dinesh Akhand
Hi Team, Default user name /password are defined in spring-security.xml and pulse.properties file. As below. ./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_20248_pulse/webapp/WEB-INF/spring-security.xml: https://www.amdocs.com/about/email-disclaimer