Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/#review179219 ---

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179218 --- geode-protobuf/src/main/proto/region_API.proto Lines 117

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179217 ---

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179216 ---

Re: Review Request 60451: GEODE-2996: adding Put handler

> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java > > Lines 68 (patched) > > > > > > This has nothing to do with the

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

> On June 28, 2017, 11:09 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > > Lines 223 (patched) > > > > > > How about

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

> On June 28, 2017, 7:31 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > > Lines 106 (patched) > > > > > > Can we move

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/ --- (Updated June 29, 2017, 12:20 a.m.) Review request for geode, anilkumar

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179202 ---

[GitHub] geode pull request #612: GEODE-3121: ensure that the protobuf protocol works...

GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/612 GEODE-3121: ensure that the protobuf protocol works over SSL This just introduces a new test where we run the put/get integration test of the protocol module, but sets up a SSL cache and socket.

Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179201 --- Ship it! Ship It! - Alexander Murmann On June 28, 2017,

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179198 ---

Review Request 60523: GEODE-3141 New flow: GetRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #600 was SUCCESSFUL (with 1908 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #600 was successful. --- Scheduled 1910 tests in total. https://build.spring.io/browse/SGF-NAG-600/ -- This

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/610#discussion_r124667734 --- Diff: geode-docs/developing/partitioned_regions/set_join_redundancy_recovery.html.md.erb --- @@ -19,23 +19,38 @@ See the License for the

Errored: jinmeiliao/geode#3 (refactor-day3 - 486d663)

Build Update for jinmeiliao/geode - Build: #3 Status: Errored Duration: 14 minutes and 53 seconds Commit: 486d663 (refactor-day3) Author: Jinmei Liao Message: wip View the changeset: https://github.com/jinmeiliao/geode/compare/3aa990531554^...486d6634223f

Fixed: apache/geode#3043 (develop - b0fafd3)

Build Update for apache/geode - Build: #3043 Status: Fixed Duration: 22 minutes and 23 seconds Commit: b0fafd3 (develop) Author: Brian Rowe Message: GEODE-3105: adding GetRegions handler for protobuf protocol Added a handler which will catch incoming

Fixed: apache/geode#3042 (develop - 6107561)

Build Update for apache/geode - Build: #3042 Status: Fixed Duration: 24 minutes and 45 seconds Commit: 6107561 (develop) Author: Jared Stewart Message: Fix spotless failure View the changeset:

[GitHub] geode pull request #611: GEODE-3145 Add new protocol to Geode JAR

GitHub user pivotal-amurmann opened a pull request: https://github.com/apache/geode/pull/611 GEODE-3145 Add new protocol to Geode JAR Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60507/#review179170 --- Ship it! Ship It! - Alexander Murmann On June 28, 2017,

[GitHub] geode issue #610: GEODE-3146 Remove doc reference to GemFire 8.2

Github user karensmolermiller commented on the issue: https://github.com/apache/geode/pull/610 Reviewers, please consider this PR despite the failed build. From the detail, the failure was from a spotless failure in an unrelated code commit (copied here): FAILURE: Build

[GitHub] geode pull request #607: GEODE-3105: adding GetRegion handler for protobuf p...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/610 GEODE-3146 Remove doc reference to GemFire 8.2 @lgallinat @dschneider-pivotal @nreich @pivotal-eshu @agingade @joeymcallister @davebarnes97 plus any others who care, please review this

Re: Review Request 60451: GEODE-2996: adding Put handler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179145 --- Remove the use of getLogger(). The rest looks okay to me.

[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...

Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 Single successful run on course when only running the Distributed tests in geode-assembly. Testing again with fully concourse run. 🤞 --- If your project is set up for it, you can reply to

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/#review179156 ---

Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60513/ --- Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/ --- (Updated June 28, 2017, 6:48 p.m.) Review request for geode, Alexander

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/608#discussion_r124621529 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java --- @@ -48,13 +49,13 @@ public

Broken: apache/geode#3036 (develop - 0254a60)

Build Update for apache/geode - Build: #3036 Status: Broken Duration: 21 minutes and 41 seconds Commit: 0254a60 (develop) Author: Bruce Schuchardt Message: GEODE-3052 Restarting 2 locators together causes potential locator split brain The fix for this issue

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60507/#review179135 --- Ship it! Ship It! - Hitesh Khamesra On June 28, 2017, 5:26

Re: Review Request 60447: GEODE-3132 EndBucketCreationMessage should not partitcipate in a transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60447/#review179130 --- Ship it! Ship It! - Darrel Schneider On June 26, 2017, 2:51

Build failed in Jenkins: Geode-nightly #880

See Changes: [jiliao] GEODE-2919: fix lucene security tests [jiliao] GEODE-2919: revert: fix lucene security tests [bschuchardt] GEODE-3072: Events do not get removed from the client queue for 1.0 [hkhamesra]

Re: want to encrypt default username/password in properties files or xml with default encrypted values.

Hi, if you are using the Geode1.1, Pulse uses the integrated security from your cluster now instead of having to resort to its own security. So the admin/admin username/password is only used when your cluster is not secured. If your cluster has a security manager, when logging into Pulse, you

[GitHub] geode-native issue #104: GEODE-3143 : close socket before deteting

Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 When connect() is invoked from one of TcpConn::TcpConn the TcpConn object is not created since the exception is thrown from the constructor, so ~TcpConn will not be invoked. --- If your

[GitHub] geode-native issue #104: Develop

Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/104 Please open a JIRA and include it in your commit message. GEODE-1234: blah blah --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode-native issue #104: Develop

Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/104 @fdaniel7 What is the GEODE ticket you are working on? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode-native issue #104: Develop

Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 There's no ticket for this as far as I know. I'm fixing this as part of reviewing geode client code --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] geode-native issue #104: Develop

Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 Hi I'm still new with github, it is indeed a small change. On next contributions I'll pay more attention. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode-native issue #104: Develop

Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/104 It looks like your reverts were to undo changes to .gitignore. I'd suggest not building from within the source tree at all. If you do there is an ignore already for "build" that you

Build failed in Jenkins: Geode-release-flaky #19

See Changes: [bschuchardt] GEODE-3072: Events do not get removed from the client queue for 1.0 -- [...truncated 98.55 KB...] Download

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/609 GEODE-2886 : sent IllegalStateException instead of throwing IllegalArgumentException inside WaitUntilFlushedFunction 1. sent IllegalStateException instead of throwing IllegalArgumentException

Build failed in Jenkins: Geode-release #70

See Changes: [bschuchardt] GEODE-3072: Events do not get removed from the client queue for 1.0 -- [...truncated 103.44 KB...] :geode-common:check :geode-common:build

RE: want to encrypt default username/password in properties files or xml with default encrypted values.

Hi team, Is there any way to encrypted default username/password in pulse.properties: # JMX User Properties pulse.jmxUserName=admin pulse.jmxUserPassword=admin spring-security.xml:

[GitHub] geode-native pull request #104: Develop

GitHub user fdaniel7 opened a pull request: https://github.com/apache/geode-native/pull/104 Develop Closing socket before deleting it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fdaniel7/geode-native develop Alternatively