Re: [Proposal] Change default gemfire.memoryEventTolerance from 1 to 0

2019-01-24 Thread Alexander Murmann
Great points, Ryan. I agree, if this is a bug fix rather than a feature/improvement we should fix it. On Thu, Jan 24, 2019 at 9:58 AM Ryan McMahon wrote: > Hi Alexander, > > Thanks for bring up those concerns. I think in this case the default of 1 > is potentially masking behavior that the

PR review request

2019-01-24 Thread Kirk Lund
Anyone want to review my PR, please? GEODE-6313: Make ControllableProcess fail if status is only whitespace #3112 https://github.com/apache/geode/pull/3112 Thanks, Kirk

Re: [Proposal] Change default gemfire.memoryEventTolerance from 1 to 0

2019-01-24 Thread Ryan McMahon
Hi Alexander, Thanks for bring up those concerns. I think in this case the default of 1 is potentially masking behavior that the user would definitely want to see and react to (such as heap memory read outliers/spikes), so it is a bit different than other cases where changing the default would