+1 Looks good
On Mon, Jun 10, 2019 at 5:13 PM Aaron Lindsey wrote:
> +1
>
> I like this approach compared to the previous proposals because it's
> simpler (doesn't require a custom registry) and makes it more
> straightforward to replace stats with Micrometer meters in the future.
>
> - Aaron
>
+1
I like it!
I like that we are not having to maintain duplicate meter and stat code.
Also, I think keeping hiding metrics and stats inside an instrumentation
class with methods like regionAdded makes it much easier to unit test
classes that record metrics.
-Dan
On Mon, Jun 10, 2019, 5:13 PM
