Re: [DISCUSS] Tweak to branch protection rules

2019-10-29 Thread Nabarun Nag
+1 On Tue, Oct 29, 2019 at 6:21 PM Darrel Schneider wrote: > +1 > > On Tue, Oct 29, 2019 at 6:08 PM Owen Nichols wrote: > > > +1 …this has already bitten me a few times > > > > > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote: > > > > > > Hi all, > > > > > > It seems we've configured our branch

Re: [DISCUSS] Tweak to branch protection rules

2019-10-29 Thread Darrel Schneider
+1 On Tue, Oct 29, 2019 at 6:08 PM Owen Nichols wrote: > +1 …this has already bitten me a few times > > > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote: > > > > Hi all, > > > > It seems we've configured our branch protection rules such that pushing a > > change to a PR that has been approved

Re: [DISCUSS] Tweak to branch protection rules

2019-10-29 Thread Jinmei Liao
+1 On Tue, Oct 29, 2019, 6:08 PM Owen Nichols wrote: > +1 …this has already bitten me a few times > > > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote: > > > > Hi all, > > > > It seems we've configured our branch protection rules such that pushing a > > change to a PR that has been approved

Re: [DISCUSS] Tweak to branch protection rules

2019-10-29 Thread Owen Nichols
+1 …this has already bitten me a few times > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote: > > Hi all, > > It seems we've configured our branch protection rules such that pushing a > change to a PR that has been approved invalidates the previous approval. > > I think we should turn this off -

[DISCUSS] Tweak to branch protection rules

2019-10-29 Thread Dan Smith
Hi all, It seems we've configured our branch protection rules such that pushing a change to a PR that has been approved invalidates the previous approval. I think we should turn this off - it looks like it's an optional feature. We should trust people to rerequest reviews if needed. Right now

Re: Deprecate SystemFailure Class

2019-10-29 Thread Bill Burcham
The SystemFailure class is in the org.apache.geode package which means it is part of the public API. My purpose in messaging the dev list was to discover any concerns or objections to adding the deprecated flag to SystemFailure per GEODE-7369. Related to that work, I intend to eliminate calls to

Another Successful Apache Geode Summit - highlights and links to videos

2019-10-29 Thread Jagdish Mirani
Hello Apache Geode Community: We wrapped up another great Geode Summit, with 12 content rich, well organized and delivered, highly relevant Geode sessions at Geode Summit 2019. Thanks to everybody who made this event successful. The Geode project, and the Geode Summit, have come a long way over

Re: The 1.11.0 branch we be cut on November 4th, 2019.

2019-10-29 Thread Anthony Baker
Heads up, I’m planning to merge a bunch of dependency updates today. > On Oct 28, 2019, at 4:32 PM, Mark Hanson wrote: > > Please ensure that your changes are in November 3rd, 2019 at the latest. I > will pick the SHA of the first successful build on November 4th, 2019. > > > If you realize

Re: Deprecate SystemFailure Class

2019-10-29 Thread Bruce Schuchardt
Bill, are you proposing to remove calls to SystemFailure.initiateFailure() and remove all of the emergency-class stuff or just add a Deprecated flag to SystemFailure? On 10/28/19 12:01 PM, Bill Burcham wrote: The SystemFailure class is a clearing house for detecting and attempting to

Re: Deprecate SystemFailure Class

2019-10-29 Thread Joris Melchior
+1. On Mon, Oct 28, 2019 at 4:22 PM Robert Houghton wrote: > +1. > > On Mon, Oct 28, 2019 at 12:11 PM Bill Burcham > wrote: > > > The SystemFailure class is a clearing house for detecting and attempting > to > > mitigate SystemFailure exceptions e.g. VirtualMachineError and > >

Special certificates for multisite

2019-10-29 Thread Mario Ivanac
Hi, We are trying to find a solution for an situation we have. Below is the explanation of the issue, as well as a proposed way forward. We would appreciate comments from the community regarding this approach. Also, suggestions for a different approach to solve this issue would be welcome.