Concourse `geode-build-version` is not being incremented

2019-11-07 Thread Robert Houghton
Sometime around when we created a release branch for v1.11.0, and bumped develop to v1.12.0, the semver resource stopped incrementing our SNAPSHOT number. The 1.11 main pipeline is stuck at 1.11.0 (the initial version) instead of having continued on from 1.11.0-SNAPSHOT.303 The develop main

Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5

2019-11-07 Thread Udo Kohlmeyer
@Naba, Thank you for this. I think we have identified quite a few PR's (I think we could name around 5 ppl who have started this). The intent is to align the versions with verified BOM versions. THAT should hopefully help this exercise be simplified. --Udo On 11/7/19 3:37 PM, Nabarun Nag

Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5

2019-11-07 Thread Nabarun Nag
Initial attempts have been made : https://github.com/apache/geode/pull/4256 This PR has Maintainers edit permissions enabled. We need to figure out a plan on these following springframework dependencies too. - spring-hateos [geode - 0.25.0 RELEASE latest 1.0.1 RELEASE] - spring-plugin-core

Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5

2019-11-07 Thread Jason Huynh
+1 On Thu, Nov 7, 2019 at 1:28 PM Dan Smith wrote: > +1 > > On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe wrote: > > > +1 > > > > On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer wrote: > > > > > Sorry, > > > > > > To clarify... When we change the Spring version we would be looking at > > > looking

Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5

2019-11-07 Thread Dan Smith
+1 On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe wrote: > +1 > > On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer wrote: > > > Sorry, > > > > To clarify... When we change the Spring version we would be looking at > > looking to use the latest version and it's associated BOM. > > > > That might be

Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5

2019-11-07 Thread Jens Deppe
+1 On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer wrote: > Sorry, > > To clarify... When we change the Spring version we would be looking at > looking to use the latest version and it's associated BOM. > > That might be inclusive of other Spring project upgrades. > > --Udo > > On 10/30/19 1:35

RE: geode-native integration tests

2019-11-07 Thread Alberto Bustamante Reyes
Thanks for the answer Jake, I have sent a PR with the changes. I already know the plans to use concourse instead of travis in the Geode client, I have it in mind, its a good opportunity to learn about concourse. De: Jacob Barrett Enviado: jueves, 7 de noviembre

Re: Lucene upgrade

2019-11-07 Thread Xiaojian Zhou
Oh, I misunderstood option-1 and option-2. What I vote is Jason's option-1. On Thu, Nov 7, 2019 at 9:19 AM Jason Huynh wrote: > Gester, I don't think we need to write in the old format, we just need the > new format not to be written while old members can potentially read the > lucene files.

Re: Lucene upgrade

2019-11-07 Thread Jason Huynh
Gester, I don't think we need to write in the old format, we just need the new format not to be written while old members can potentially read the lucene files. Option 1 can be very similar to Dan's snippet of code. I think Option 2 is going to leave a lot of people unhappy when they get stuck

Re: bug fix needed for release/1.11.0

2019-11-07 Thread Mark Hanson
Based on the lack of “-1” votes, I have cherry-picked the change… Thanks, Mark > On Nov 7, 2019, at 8:54 AM, Bruce Schuchardt wrote: > > The change passed in SSL benchmark testing and can be cherry-picked into the > release branch. The Benchmark job as a whole failed due to perf degradation

Re: bug fix needed for release/1.11.0

2019-11-07 Thread Darrel Schneider
+1 to include the fix On Thu, Nov 7, 2019 at 8:54 AM Bruce Schuchardt wrote: > The change passed in SSL benchmark testing and can be cherry-picked into > the release branch. The Benchmark job as a whole failed due to perf > degradation with the Security Manager, but that's a different set of

Re: bug fix needed for release/1.11.0

2019-11-07 Thread Bruce Schuchardt
The change passed in SSL benchmark testing and can be cherry-picked into the release branch.  The Benchmark job as a whole failed due to perf degradation with the Security Manager, but that's a different set of tests. On 11/6/19 3:57 PM, Helena Bales wrote: +1 to cherry-picking the fix. The

Re: Update geode-native-build image as part of release process

2019-11-07 Thread Dick Cavender
+1 On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > +1 > > On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes > wrote: > > > Hi all, > > > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > > "geode-native-build", because I saw that it was using 1.6.0 although >

Re: geode-native integration tests

2019-11-07 Thread Jacob Barrett
> On Nov 7, 2019, at 7:41 AM, Alberto Bustamante Reyes > wrote: > > Im curious about the geode-native integration tests. I have seen there are > two kind of tests, depending on the framework they are based on. But no one > of them are included in the CI executed by travis. Are they

Re: Update geode-native-build image as part of release process

2019-11-07 Thread Owen Nichols
+1 On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes wrote: > Hi all, > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > "geode-native-build", because I saw that it was using 1.6.0 although 1.9.0 > was available. After this change, other ticket was needed to build and

geode-native integration tests

2019-11-07 Thread Alberto Bustamante Reyes
Hi Geode community, Im curious about the geode-native integration tests. I have seen there are two kind of tests, depending on the framework they are based on. But no one of them are included in the CI executed by travis. Are they executed only as part of the Geode release process? What is

Update geode-native-build image as part of release process

2019-11-07 Thread Alberto Bustamante Reyes
Hi all, Some time ago I opened GEODE-7056 to update the Dockerfile of the "geode-native-build", because I saw that it was using 1.6.0 although 1.9.0 was available. After this change, other ticket was needed to build and update the image in Dockerhub. I think this task (update file, build

Odg: gateway sender queue

2019-11-07 Thread Mario Ivanac
Hi, thanks for answers. Some more details regarding 1st question. Is this behavior same (for serial and parallel gateway sender) in case queue is persistent? Meaning, should queue (persistent) be purged if we restart gateway sender? Thanks, Mario Šalje: Dan