Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Jacob Barrett
+1 for 3.1 > On Nov 15, 2019, at 3:08 PM, Jens Deppe wrote: > > +1 to bumping the documented support to 3.1. > > The prompting for this proposal is due to this PR which specifically wants > to utilize a *3.0* API: https://github.com/apache/geode/pull/4311 > > Thus implementing this change wil

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Jens Deppe
+1 to bumping the documented support to 3.1. The prompting for this proposal is due to this PR which specifically wants to utilize a *3.0* API: https://github.com/apache/geode/pull/4311 Thus implementing this change will not preclude being able to use the Session Module in a 3.0 container (even i

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread John Blum
1 more thing... You can provide additional/dedicated support for newer versions (e.g. Servlet 4.0) without (unduly) sacrificing backwards compatibility. This is done by many popular Java frameworks in fact, which also simultaneously constitute a minimum baseline (e.g. Servlet 3.1). Be current an

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread John Blum
I would minimally bump it to 3.1 then. Not only does Servlet 3.1 open up more doors (e.g. NIO), but is also implemented by all current Servlet Container providers (Tomcat, Jetty, etc). Additionally, given all the Servlet Containers Jens mentioned at the version that started supporting Servlet 3.0

Benchmark instability

2019-11-15 Thread Helena Bales
Hi All, We are dealing with some instability in benchmarks that is making the pass/fail signal from CI irrelevant. Since it isn't giving us any useful information, and is mostly failing, we will be removing it as a blocking task in the main CI pipeline. This will be a temporary change until we are

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Dan Smith
+1 to bumping to servlet 3.0. -Dan On Fri, Nov 15, 2019 at 12:16 PM Charles Smith wrote: > Seems to me as long as newer Servlet specs do not deprecate > functionality/api that the session module requires AND that the session > module is not missing any important functionality provided by newer

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Charles Smith
Seems to me as long as newer Servlet specs do not deprecate functionality/api that the session module requires AND that the session module is not missing any important functionality provided by newer Servlet specs that it's best to base support the oldest Servlet spec that is still supported by

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread John Blum
Since the Servlet 3.1 spec is available and the current version is 4.0, why not consider 3.1 or even 4.0, actually? -j On Fri, Nov 15, 2019 at 8:59 AM Jens Deppe wrote: > Hello Charles; thanks very much for bringing this up. > > I vote +1 on this proposal. > > Just to add a bit more details for

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Jens Deppe
Hello Charles; thanks very much for bringing this up. I vote +1 on this proposal. Just to add a bit more details for others: The 3.0 Servlet Spec was finalized at the end of 2009. The *earliest* versions of various containers that supported it are: - Jetty 8 (EOL'd since 11/2014) [1] - To

Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-15 Thread Charles Smith
Hello, The Geode HTTP Session Management Module for AppServers currently states: This approach is a generic solution, which is supported by any container that implements the Servlet 2.4 specification. I would like to suggest that this official support be bumped up to the Servlet 3.0 specificatio

Review for #4310

2019-11-15 Thread Mario Ivanac
Hi all, please could someone review https://issues.apache.org/jira/browse/GEODE-7414 PR https://github.com/apache/geode/pull/4310 Thanks, Mario