Re: [VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread John Blum
+1 On Tue, Dec 17, 2019 at 3:25 PM Dick Cavender wrote: > +1 > > On Tue, Dec 17, 2019 at 3:03 PM Patrick Johnson > wrote: > > > +1 > > > > > On Dec 17, 2019, at 3:01 PM, Owen Nichols wrote: > > > > > > +1 > > > > > >> On Dec 17, 2019, at 2:57 PM, Udo Kohlmeyer wrote: > > >> > > >> Hi there Ap

Re: [VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread John Blum
+1 On Tue, Dec 17, 2019 at 3:25 PM Dick Cavender wrote: > +1 > > On Tue, Dec 17, 2019 at 3:01 PM Patrick Johnson > wrote: > > > +1 > > > > > On Dec 17, 2019, at 2:59 PM, Owen Nichols wrote: > > > > > > +1 > > > > > >> On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer wrote: > > >> > > >> Hi there Ap

Re: [VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread Dick Cavender
+1 On Tue, Dec 17, 2019 at 3:03 PM Patrick Johnson wrote: > +1 > > > On Dec 17, 2019, at 3:01 PM, Owen Nichols wrote: > > > > +1 > > > >> On Dec 17, 2019, at 2:57 PM, Udo Kohlmeyer wrote: > >> > >> Hi there Apache Devs. > >> > >> I can we please vote on the inclusion of GEODE-7531. This issue

Re: [VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread Dick Cavender
+1 On Tue, Dec 17, 2019 at 3:01 PM Patrick Johnson wrote: > +1 > > > On Dec 17, 2019, at 2:59 PM, Owen Nichols wrote: > > > > +1 > > > >> On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer wrote: > >> > >> Hi there Apache Devs. > >> > >> I can we please vote on the inclusion of GEODE-7159. This issue

Re: [VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread Patrick Johnson
+1 > On Dec 17, 2019, at 3:01 PM, Owen Nichols wrote: > > +1 > >> On Dec 17, 2019, at 2:57 PM, Udo Kohlmeyer wrote: >> >> Hi there Apache Devs. >> >> I can we please vote on the inclusion of GEODE-7531. This issue is to fix an >> bug which assumes that all `Pool` objects are of type `PoolIm

Re: [VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread Owen Nichols
+1 > On Dec 17, 2019, at 2:57 PM, Udo Kohlmeyer wrote: > > Hi there Apache Devs. > > I can we please vote on the inclusion of GEODE-7531. This issue is to fix an > bug which assumes that all `Pool` objects are of type `PoolImpl` and > immediately casts Pool -> PoolImpl. > > In the case of te

Re: [VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread Patrick Johnson
+1 > On Dec 17, 2019, at 2:59 PM, Owen Nichols wrote: > > +1 > >> On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer wrote: >> >> Hi there Apache Devs. >> >> I can we please vote on the inclusion of GEODE-7159. This issue is to fix an >> bug which assumes that all `Pool` objects are of type `PoolIm

Re: [VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread Owen Nichols
+1 > On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer wrote: > > Hi there Apache Devs. > > I can we please vote on the inclusion of GEODE-7159. This issue is to fix an > bug which assumes that all `Pool` objects are of type `PoolImpl` and > immediately casts Pool -> PoolImpl. This issue is related

[VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread Udo Kohlmeyer
Hi there Apache Devs. I can we please vote on the inclusion of GEODE-7159. This issue is to fix an bug which assumes that all `Pool` objects are of type `PoolImpl` and immediately casts Pool -> PoolImpl. This issue is related to GEODE-7531, and is specific to the emergencyClose method. In th

[VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread Udo Kohlmeyer
Hi there Apache Devs. I can we please vote on the inclusion of GEODE-7531. This issue is to fix an bug which assumes that all `Pool` objects are of type `PoolImpl` and immediately casts Pool -> PoolImpl. In the case of testing with Mocks, the type casts fail, because the Pool-mocks are not o

Re: Reviewer for GEODE-7534: Add example for query with bind params (documentation)

2019-12-17 Thread Jason Huynh
Hi Alberto, Looks like Dan and Dave have both reviewed it. I took a look and didn't see anything wrong so I squash merged it in. Thanks! -Jason On Fri, Dec 13, 2019 at 3:30 AM Alberto Gomez wrote: > Hi, > > I'd appreciate some extra reviewer (I already had one, thanks @Dave > Barnes) and if e

Re: [VOTE] Adding a couple user APIs dealing with RegionFactory.

2019-12-17 Thread Mark Hanson
Hi All, In working with Udo, I moved the needed public API into a helper class. The RegionFactory copy constructor still remains in RegionFactory but is protected. The only way to use the method now is by creating a helper class that extends RegionFactory. Thanks for you all your help. I thin

Odg: Odg: Odg: Odg: Odg: Lucene upgrade

2019-12-17 Thread Mario Kevo
Hi Jason, Nice catch! I tried with larger number of retries(with your changes) and it passed. I will try to make it time based. Thanks for a help! BR, Mario Šalje: Jason Huynh Poslano: 13. prosinca 2019. 23:10 Prima: Mario Kevo Kopija: geode Predmet: Re: Odg: