Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Raymond Ingles
+1 On 8/31/20, 7:19 PM, "Owen Nichols" wrote: Recently shiro-1.5.3.jar is getting flagged for ‘high’ security vulnerability CVE-2020-13933. Analysis shows that Geode does not use Shiro in a manner that would expose this vulnerability. The risk of bringing GEODE-8456 is low

Re: [PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Dave Barnes
OK Bruce, go for it. Thanks for the fix. Dave On Tue, Sep 1, 2020 at 10:43 AM Sarah Abbey wrote: > +1 > > From: Donal Evans > Sent: Tuesday, September 1, 2020 1:38 PM > To: dev@geode.apache.org > Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13 > > +1 >

Re: [PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Sarah Abbey
+1 From: Donal Evans Sent: Tuesday, September 1, 2020 1:38 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13 +1 From: Dave Barnes Sent: Tuesday, September 1, 2020 10:25 AM To:

Re: [PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Donal Evans
+1 From: Dave Barnes Sent: Tuesday, September 1, 2020 10:25 AM To: dev@geode.apache.org Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13 > Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES, let's do it. On Tue, Sep 1, 2020 at 10:24

Re: [PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Dave Barnes
> Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES, let's do it. On Tue, Sep 1, 2020 at 10:24 AM Dave Barnes wrote: > +1 > GEODE-8467 addresses one of the few remaining 1.13 release blockers. > I see it's been approved and merged into the develop branch. Assuming that >

Re: [PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Dave Barnes
+1 GEODE-8467 addresses one of the few remaining 1.13 release blockers. I see it's been approved and merged into the develop branch. Assuming that it's passed applicable testing, let's do it. On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt wrote: > I’d like to cherry-pick this change into

Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Owen Nichols
Done, thanks! On 9/1/20, 10:22 AM, "Dave Barnes" wrote: Looks like more than enough approvals, Owen. Please port, as you proposed. Thanks, Dave On Tue, Sep 1, 2020 at 7:45 AM Alexander Murmann wrote: > +1 > > On Tue, Sep 1, 2020 at 6:19 AM Sarah Abbey wrote:

Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Dave Barnes
Looks like more than enough approvals, Owen. Please port, as you proposed. Thanks, Dave On Tue, Sep 1, 2020 at 7:45 AM Alexander Murmann wrote: > +1 > > On Tue, Sep 1, 2020 at 6:19 AM Sarah Abbey wrote: > > > +1 > > > > From: Ju@N > > Sent: Tuesday, September

Re: [DISCUSS] Shipping patch releases

2020-09-01 Thread Alexander Murmann
I would feel much more comfortable if the default behavior was to always port back in reverse order without skipping a support branch. This makes it much harder to forget poring to a support branch. Few things are more frustrating to users than upgrading to a new patch release to get a bug fix and

Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Alexander Murmann
+1 On Tue, Sep 1, 2020 at 6:19 AM Sarah Abbey wrote: > +1 > > From: Ju@N > Sent: Tuesday, September 1, 2020 4:10 AM > To: dev@geode.apache.org > Subject: Re: Proposal to bring GEODE-8456 (shiro upgrade) to support > branches > > +1 > > On Tue, 1 Sep 2020 at

[PROPOSAL] port GEODE-8467 to support/1.13

2020-09-01 Thread Bruce Schuchardt
I’d like to cherry-pick this change into support/1.13: There is a flaw in the code that handles a server being forced out of the cluster. The flaw keeps the server from shutting down and leaves the server in a hung state. The PR adds error handling to two methods, one in the Cache’s

Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Sarah Abbey
+1 From: Ju@N Sent: Tuesday, September 1, 2020 4:10 AM To: dev@geode.apache.org Subject: Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches +1 On Tue, 1 Sep 2020 at 01:11, Donal Evans wrote: > +1 > > We still have outstanding release

Re: Proposal to bring GEODE-8456 (shiro upgrade) to support branches

2020-09-01 Thread Ju@N
+1 On Tue, 1 Sep 2020 at 01:11, Donal Evans wrote: > +1 > > We still have outstanding release blockers for 1.13, so getting this fix > in now just prevents extra work in the future without slowing us down now. > > From: Owen Nichols > Sent: Monday, August 31,