[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

2017-08-13 Thread darrenfoong
Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 Thanks Jared! Will find time to make the changes and get feedback on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-08-13 Thread darrenfoong
Github user darrenfoong commented on a diff in the pull request: https://github.com/apache/geode/pull/668#discussion_r132833299 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -111,10 +113,31 @@ public void

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

2017-08-04 Thread darrenfoong
Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 Hi Jared, thank you for your feedback. The initial use case that I was thinking of involved a user wanting to: - use Geode with another JDK (which doesn't have

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

2017-08-03 Thread darrenfoong
Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 I've added code to unset/clear the temporarily-set system properties for testing. Thank you Kenneth for your feedback. --- If your project is set up for it, you can reply to this email

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

2017-08-03 Thread darrenfoong
Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 I just realised I'll need to unset the property to prevent any side effects in the other tests; working on it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-07-29 Thread darrenfoong
GitHub user darrenfoong opened a pull request: https://github.com/apache/geode/pull/668 GEODE-3306: Remove whitespace StringBuffers/nodes created by Apache X… …erces This commit makes Geode compatible with the official Apache Xerces implementation, which calls