Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Dave Barnes
e limit. > > >> > > >> Anyway, while this is decided, a quick action could be to add a new > line > > >> to the PR template, at least to remember it: > > >> > > >> - [ ] Is your commit message length below the limit of 50 characters? > >

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Ernest Burghardt
message length below the limit of 50 characters? > >> > >> > >> > >> > >> > >> > >> De: Juan José Ramos > >> Enviado: martes, 8 de octubre de 2019 11:32 > >> Para: dev@geode.apac

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Owen Nichols
e to add a new line >> to the PR template, at least to remember it: >> >> - [ ] Is your commit message length below the limit of 50 characters? >> >> >> >> >> >> ________________ >> De: Juan José Ramos >> Envia

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Juan José Ramos
_ > De: Juan José Ramos > Enviado: martes, 8 de octubre de 2019 11:32 > Para: dev@geode.apache.org > Asunto: Re: [DISCUSS]: Commit Message Format too Short? > > Hello Owen, > > Yes, I fully agree with you. And just to be clear, I wasn't trying to > discourage descr

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Juan José Ramos
t; > > > > > ________ > > De: Juan José Ramos > > Enviado: martes, 8 de octubre de 2019 11:32 > > Para: dev@geode.apache.org > > Asunto: Re: [DISCUSS]: Commit Message Format too Short? > > > > Hello Owen, > > > >

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Ernest Burghardt
octubre de 2019 11:32 > Para: dev@geode.apache.org > Asunto: Re: [DISCUSS]: Commit Message Format too Short? > > Hello Owen, > > Yes, I fully agree with you. And just to be clear, I wasn't trying to > discourage descriptive commit messages, on the contrary, we certainly must

RE: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Alberto Bustamante Reyes
: [DISCUSS]: Commit Message Format too Short? Hello Owen, Yes, I fully agree with you. And just to be clear, I wasn't trying to discourage descriptive commit messages, on the contrary, we certainly must encourage them at all cost!!. It was decided that we should, however, try to keep consistency across

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Juan José Ramos
Hello Owen, Yes, I fully agree with you. And just to be clear, I wasn't trying to discourage descriptive commit messages, on the contrary, we certainly must encourage them at all cost!!. It was decided that we should, however, try to keep consistency across all commits and make the subject brief,

Re: [DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Owen Nichols
I don’t care how long it is, but knowing that many tools show only the first bit, it’s helpful if the message is phrased with the most important words near the beginning. I’d much prefer to encourage rather than discourage descriptive commit messages. Even better if all commit messages mentioned

[DISCUSS]: Commit Message Format too Short?

2019-10-08 Thread Ju@N
Hello devs, I've notice that, lately, not everybody is following the guidelines we have highlighted in our Wiki under *Commit Message Format [1]*, specially the first requirement: *GEODE-nn: Capitalized, 50 chars or less summary. *As an example, out of the last 33 commits in develop, only 11