INFRA has added the status to the required list for merging PRs to
geode/develop. Thanks everyone.
On Fri, May 15, 2020 at 3:03 PM Robert Houghton
wrote:
> Please refer to https://issues.apache.org/jira/browse/INFRA-20270
>
> On Fri, May 15, 2020 at 2:58 PM Robert Houghton
> wrote:
>
>>
Please refer to https://issues.apache.org/jira/browse/INFRA-20270
On Fri, May 15, 2020 at 2:58 PM Robert Houghton
wrote:
> Support seems to be unanimously good, and folks voted in this thread. I'm
> going to make the ASF-INFRA request.
>
> On Fri, May 15, 2020 at 11:47 AM Anthony Baker wrote:
Support seems to be unanimously good, and folks voted in this thread. I'm
going to make the ASF-INFRA request.
On Fri, May 15, 2020 at 11:47 AM Anthony Baker wrote:
> Barry and I tossed up a draft PR to fix a problem in session state
> replication with Tomcat. If we can get this completed I’d
Barry and I tossed up a draft PR to fix a problem in session state replication
with Tomcat. If we can get this completed I’d like to include it with v1.13.0.
I believe our tests will fail with any version of Tomcat after 9.0.21.
Anthony
> On May 15, 2020, at 1:27 AM, Ju@N wrote:
>
> +1
>
+1
On Thu, 14 May 2020 at 22:19, Mark Hanson wrote:
> +1. The more we can automate this types of checks the better.
>
> Thanks,
> Mark
>
>
--
Ju@N
+1. The more we can automate this types of checks the better.
Thanks,
Mark
ike a good thing to have.
> >
> > +1
> >
> > From: Robert Houghton
> > Sent: May 13, 2020 17:32
> > To: dev@geode.apache.org ; Mario Ivanac
> >
> > Subject: [DISCUSS] enable GitHub PR blocking on API breaking changes
&
oughton
> Sent: May 13, 2020 17:32
> To: dev@geode.apache.org ; Mario Ivanac
>
> Subject: [DISCUSS] enable GitHub PR blocking on API breaking changes
>
> We have enabled this job on the develop and support 1.13 branches, and it
> is going well. I would like this to be a
This seems like a good thing to have.
+1
From: Robert Houghton
Sent: May 13, 2020 17:32
To: dev@geode.apache.org ; Mario Ivanac
Subject: [DISCUSS] enable GitHub PR blocking on API breaking changes
We have enabled this job on the develop and support 1.13
@donal There is a violation filter in place for major version changes that
would currently allow any change. That can be narrowed down to only allow
deletion of already-deprecated signatures.
On Wed, May 13, 2020 at 5:18 PM Owen Nichols wrote:
> If ApiChecker fails on your PR, and you merge
If ApiChecker fails on your PR, and you merge anyway, it will fail on develop,
so there’s no question it should be a required PR check.
We left some checks optional to avoid blocking merges on unrelated flaky
failures. ApiChecker should never be flaky.
If/when Geode decides it’s time for a
Given that this job takes less than 10 minutes to run, pass or fail, I
don't see it adding any additional friction to the PR process in terms of
having to wait for things to finish. I am curious if there are any
circumstances we could envisage where skipping or bypassing this check
would be
We have enabled this job on the develop and support 1.13 branches, and it
is going well. I would like this to be a blocking job for our pull
requests.
Are there any issues around this test that we want to address, or reasons
to *not* have it be a blocking job in the PR pipeline?
To seed the
13 matches
Mail list logo
