[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...

2017-03-09 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-native/pull/50#discussion_r105272239 --- Diff: src/quickstart/cpp/CMakeLists.txt --- @@ -26,6 +26,9 @@ elseif(UNIX) set(DYNAMIC_LIBRARY_PATH

[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...

2017-03-09 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/50#discussion_r105266335 --- Diff: src/quickstart/cpp/PdxSerializer.cpp --- @@ -165,15 +165,15 @@ int main(int argc, char** argv) { LOGINFO("Registered Person

[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...

2017-03-09 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/50#discussion_r105265184 --- Diff: src/quickstart/cpp/PdxSerializer.cpp --- @@ -165,15 +165,15 @@ int main(int argc, char** argv) { LOGINFO("Registered Person

[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...

2017-03-09 Thread PivotalSarge
GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-native/pull/50 GEODE-2636: Switch to CMake variable for library name. - Parameterize the name of the library for which the quickstarts look. - Fix warnings that obfuscate when the quickstarts can not