[GitHub] geode issue #368: [GEODE-2381] make complex enums more readable

2017-02-06 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/368 @kirklund no problem, the change is what counts. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] geode issue #368: [GEODE-2381] make complex enums more readable

2017-02-06 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/368 I squashed your 2 commits into 1 and then realized you did that on purpose. I'm going to leave it since I already pushed it. --- If your project is set up for it, you can reply to this email and

[GitHub] geode issue #368: [GEODE-2381] make complex enums more readable

2017-02-06 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/368 PS: I'm all for making more improvements to our format (including longer lines) and either making the eclipse+intellij formatters consistent (they produce different results presently) or moving to

[GitHub] geode issue #368: [GEODE-2381] make complex enums more readable

2017-02-01 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/368 +1, this looks much better! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #368: [GEODE-2381] make complex enums more readable

2017-02-01 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/368 I don't really understand what the `48` means, but it's used elsewhere and looks something like "put everything on its own line". --- If your project is set up for it, you can reply to this