[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Hello Darrel, I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork. I'll close this PR

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-24 Thread dschneider-pivotal
Github user dschneider-pivotal commented on the issue: https://github.com/apache/geode/pull/525 Your diffs now show 51 files changed. It now shows a removal of deprecated FunctionService API. Perhaps you are picking this up from changes others made? You might need to close this PR

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-23 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/525 Why is `notExecutedMembers` null? Is that the issue that should be addressed instead of changing the message? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-22 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Do I need write test code for this minor change? If so, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If