Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/712
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843663
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +92,21 @@ task createGeodeClasspathsFile {
new FileOutputStream(classpathsFile).withStream {
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843603
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -553,8 +555,30 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843558
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -586,6 +610,20 @@ public int
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133827499
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -553,8 +555,30 @@ public void
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133827419
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -586,6 +610,20 @@ public int
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133270585
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
---
@@ -34,7 +34,6 @@
import
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133268501
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
---
@@ -34,7 +34,6 @@
import
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133256792
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
---
@@ -18,6 +18,7 @@
import java.io.FileInputStream;
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133013984
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +100,71 @@ task createGeodeClasspathsFile {
new
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133013329
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
---
@@ -34,6 +34,7 @@
import
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133012849
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
---
@@ -0,0 +1,254 @@
+/*
+ *
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133012057
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133011336
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133010884
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java
---
@@ -134,6 +134,7 @@ public
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/712
GEODE-3434: Allow the modules to be interoperable with current and olâ¦
â¦der versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase
an earlier
16 matches
Mail list logo
