Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-07-01 Thread Dave Barnes
OK, Gester, please merge. Thanks, Dave On Wed, Jul 1, 2020 at 8:33 AM Bruce Schuchardt wrote: > +1 > I reviewed this PR and, as Gester said, it's low risk. If it fixes a > problem someone is having let's backport it. > > On 6/30/20, 3:51 PM, "Xiaojian Zhou" wrote: > > Customer

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-07-01 Thread Bruce Schuchardt
+1 I reviewed this PR and, as Gester said, it's low risk. If it fixes a problem someone is having let's backport it. On 6/30/20, 3:51 PM, "Xiaojian Zhou" wrote: Customer encountered a singlehop getAll failure due to SerializationException which is identified as socket error. The

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Dave Barnes
n Tue, Jun 30, 2020 at 3:58 PM Jinmei Liao wrote: > >> +1 >> >> From: Owen Nichols >> Sent: Tuesday, June 30, 2020 3:56 PM >> To: dev@geode.apache.org >> Subject: Re: [PROPOSAL] merge GEODE-8259 to support branc

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Dave Barnes
n Nichols > Sent: Tuesday, June 30, 2020 3:56 PM > To: dev@geode.apache.org > Subject: Re: [PROPOSAL] merge GEODE-8259 to support branches > > +1 > > On 6/30/20, 3:51 PM, "Xiaojian Zhou" wrote: > > Customer encountered a singlehop getAll failure due to &g

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Kirk Lund
+1 On Tue, Jun 30, 2020 at 3:58 PM Jinmei Liao wrote: > +1 > > From: Owen Nichols > Sent: Tuesday, June 30, 2020 3:56 PM > To: dev@geode.apache.org > Subject: Re: [PROPOSAL] merge GEODE-8259 to support branches > > +1 > > On 6/

[PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Xiaojian Zhou
Customer encountered a singlehop getAll failure due to SerializationException which is identified as socket error. The solution is to retry the getAll in this race condition (currently we did not retry). The fix is tested in both develop and support branches. The fix is conservative and very

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Jinmei Liao
+1 From: Owen Nichols Sent: Tuesday, June 30, 2020 3:56 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] merge GEODE-8259 to support branches +1 On 6/30/20, 3:51 PM, "Xiaojian Zhou" wrote: Customer encountered a singlehop getAll f

Re: [PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Owen Nichols
+1 On 6/30/20, 3:51 PM, "Xiaojian Zhou" wrote: Customer encountered a singlehop getAll failure due to SerializationException which is identified as socket error. The solution is to retry the getAll in this race condition (currently we did not retry). The fix is tested in both

[PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Xiaojian Zhou
Customer encountered a singlehop getAll failure due to SerializationException which is identified as socket error. The solution is to retry the getAll in this race condition (currently we did not retry). The fix is tested in both develop and support branches. The fix is conservative and very low