Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-20 Thread Galen O'Sullivan
On Tue, Mar 20, 2018 at 9:06 AM, Patrick Rhomberg wrote: > > @Galen, I had thought it already did that. > I guess it does. I never knew. Excellent!

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-20 Thread Patrick Rhomberg
Glad to see a positive response! @Galen, I had thought it already did that. On Mon, Mar 19, 2018 at 4:52 PM, Galen O'Sullivan wrote: > +1 to all of the above. > > Will Spotless also reorder imports according to our canonical ordering? > > On Mon, Mar 19, 2018 at 4:17 PM,

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-20 Thread Bruce Schuchardt
+1 On 3/19/18 2:51 PM, Patrick Rhomberg wrote: Hello all! I'm making another pass at patching up some of our smellier broken windows, to mix metaphors. To that end, there are a few things I'd like to add to spotless to more closely enforce adherence to our own style guide. I'd like to do

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-19 Thread Galen O'Sullivan
+1 to all of the above. Will Spotless also reorder imports according to our canonical ordering? On Mon, Mar 19, 2018 at 4:17 PM, Sai Boorlagadda wrote: > +1 > > On Mon, Mar 19, 2018 at 4:03 PM, Kirk Lund wrote: > > > +1 > > > > On Mon, Mar 19, 2018

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-19 Thread Sai Boorlagadda
+1 On Mon, Mar 19, 2018 at 4:03 PM, Kirk Lund wrote: > +1 > > On Mon, Mar 19, 2018 at 2:51 PM, Patrick Rhomberg > wrote: > > > Hello all! > > > > I'm making another pass at patching up some of our smellier broken > > windows, to mix metaphors. To that

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-19 Thread Kirk Lund
+1 On Mon, Mar 19, 2018 at 2:51 PM, Patrick Rhomberg wrote: > Hello all! > > I'm making another pass at patching up some of our smellier broken > windows, to mix metaphors. To that end, there are a few things I'd like to > add to spotless to more closely enforce

Re: [Discussion] Improving Spotless to be Even More Beautiful

2018-03-19 Thread Jared Stewart
+1 to all of the above On Mon, Mar 19, 2018 at 2:51 PM, Patrick Rhomberg wrote: > Hello all! > > I'm making another pass at patching up some of our smellier broken > windows, to mix metaphors. To that end, there are a few things I'd like to > add to spotless to more