Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review174050 --- Ship it! I have now finished reviewing the changes to to

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 4, 2017, 11:08 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > > Line 8918 (original), 8603 (patched) > > > > > > Was this intended to be

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173972 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173942 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173929 --- Ship it! Ship It! - Jared Stewart On May 3, 2017, 10:10

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173912 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173845 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173839 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173837 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated May 3, 2017, 10:10 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated May 3, 2017, 10:02 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173821 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173832 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 2, 2017, 9:57 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java > > Line 1230 (original), 1187 (patched) > > > > > > This looks like a

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 2, 2017, 8:36 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java > > Line 549 (original), 483 (patched) > > > > > > These two booleans (`asc`

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 3, 2017, 6:35 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java > > Lines 910-913 (original), 847-850 (patched) > > > > > > If I

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 2, 2017, 5:24 p.m., Jared Stewart wrote: > > extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java > > Line 301 (original), 310 (patched) > > > > > > Is

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 2, 2017, 10:46 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/ColocationHelper.java > > Line 137 (original), 139 (patched) > > > > > > Why was `"/"` changed to

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 2, 2017, 5:50 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledLike.java > > Line 39 (original), 37 (patched) > > > > > > Does logger need to be static? By

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 3, 2017, 8:34 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/query/internal/index/FunctionalIndexCreationHelper.java > > Line 105 (original), 111 (patched) > > > > > > typo?

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173809 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173759 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173786 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 3, 2017, 5:19 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionAttributesImpl.java > > Line 770 (original), 766 (patched) > > > > > > I think this sort of

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 3, 2017, 5:13 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > > Line 125 (original), 125 (patched) > > > > > > Why do we want to make this class

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173688 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173754 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173740 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173644 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173644 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173644 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173668 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173665 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173660 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173655 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173653 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173650 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173619 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173596 --- Posting my review of the next chunk of files

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173605 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 1, 2017, 10:28 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java > > Line 237 (original), 232 (patched) > > > > > > {@code byteThreshold should be > >

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173543 ---

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 1, 2017, 11:34 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/cache/query/CacheUtils.java > > Line 77 (original), 80 (patched) > > > > > > These AssertionError changes may cause

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated May 2, 2017, 12:06 a.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 1, 2017, 9:14 p.m., Darrel Schneider wrote: > > For all the RegionEntry subclasses do the following: > > * Do not modify this class. It was generated. Instead modify > > LeafRegionEntry.cpp and then run > > * ./dev-tools/generateRegionEntryClasses.sh (it must be run from the top > >

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

> On May 1, 2017, 10:28 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java > > Line 237 (original), 232 (patched) > > > > > > {@code byteThreshold should be > >

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review173500 --- Posting my review in chunks. So far I've gotten through the first