Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 15, 2017, 3:33 a.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177951 --- I pulled this diff and incorporated everything into my

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177920 --- Ship it! Ship It! - Kirk Lund On June 13, 2017, 9:28 p.m.,

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 9:28 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 8:26 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-13 Thread Jinmei Liao
> On June 13, 2017, 7 p.m., Kirk Lund wrote: > > -1 I don't see why these changes are needed other than to wipe out what I > > did? For example, you've undone my introduction of RealmInitializer and > > ConfigInitializer. I introduced those so I can continue writing more > > mocking tests for

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-13 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177781 --- -1 I don't see why these changes are needed other than to wipe

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 4:49 p.m.) Review request for geode, Emily Yeh, Jared