Hi Robert,
Thanks! You answered the question the way I intended.
Thanks,
Mark
On 2/25/21, 12:57 PM, "Robert Houghton" wrote:
Hi Mark,
Yes, each area of ownership only needs one review-by-owner.
Your following question, I do not understand, but I'll try: Any PR that
needs review,
Hi Mark,
Yes, each area of ownership only needs one review-by-owner.
Your following question, I do not understand, but I'll try: Any PR that needs
review, will have text in the "reviewers needed and status-required" area, that
states who is still needed to review. However, there is not a direct
Hi Owen,
Two more questions.
Is it the case that only one of the code owners for that area has to review the
PR?
Also, is there a way to tell that a code owner has reviewed an area, so you
don't have to as one of the other code owners?
Thanks,
Mark
On 2/25/21, 10:31 AM, "Owen Nichols" wrote
GitHub does not add reviewers from CODEOWNERS to PRs created as draft PRs
(until you mark it not-draft by clicking Ready For Review). However if you
subsequently change it back to a draft, GitHub will not remove any reviewers.
On 2/25/21, 10:28 AM, "Mark Hanson" wrote:
Hi Owen,
Is t
Hi Owen,
Is there a way to ensure that draft mode PRs aren't requesting reviews from
code owners?
Thanks,
Mark
On 2/19/21, 11:44 AM, "Owen Nichols" wrote:
GitHub provides some tools to answer this kind of question.
Step 1: Under the PR's "Files Changed" tab, click File Filter > Your
Thanks Owen. Good to know about the keyhole/shield icons. The filter function
doesn't work as well as I hoped. The shield icons that matched my username in
CODEOWNERS are BOLD while the others are a bit greyed out;
Using that I was able to identify a few files that matched line 28 in
CODEOWN
GitHub provides some tools to answer this kind of question.
Step 1: Under the PR's "Files Changed" tab, click File Filter > Your CODEOWNER
files
Step 2: Hover over the keyhole/shield icon (to the left of the red/green
changecount graphic to the left of each filename) to see who else is also owne
