Re: Redis PubSubTest started failing

2020-02-19 Thread Jens Deppe
Not at this time since I do believe the issue is just a flaky test and not a flaky implementation. I've merged in the change to ignore this test for now. --Jens On Wed, Feb 19, 2020 at 9:46 AM Udo Kohlmeyer wrote: > Does that mean we will revert from develop pls? > > On 2/19/20 9:33 AM, Jens D

Re: Redis PubSubTest started failing

2020-02-19 Thread Udo Kohlmeyer
Does that mean we will revert from develop pls? On 2/19/20 9:33 AM, Jens Deppe wrote: Me too :) I've had it pass several StressNewTest runs but yet, it seems to still fail at times. On Wed, Feb 19, 2020 at 9:29 AM Kirk Lund wrote: PubSubTest now fails for me in every PR I submit (3 yesterda

Re: Redis PubSubTest started failing

2020-02-19 Thread Jens Deppe
I've created a PR to ignore this test for now (GEODE-7798 is tracking the problem). On Wed, Feb 19, 2020 at 9:33 AM Jens Deppe wrote: > Me too :) > > I've had it pass several StressNewTest runs but yet, it seems to still > fail at times. > > On Wed, Feb 19, 2020 at 9:29 AM Kirk Lund wrote: > >>

Re: Redis PubSubTest started failing

2020-02-19 Thread Jens Deppe
Me too :) I've had it pass several StressNewTest runs but yet, it seems to still fail at times. On Wed, Feb 19, 2020 at 9:29 AM Kirk Lund wrote: > PubSubTest now fails for me in every PR I submit (3 yesterday). I'm really > curious how this change made it past PR and into develop. > > On Wed, F

Re: Redis PubSubTest started failing

2020-02-19 Thread Kirk Lund
PubSubTest now fails for me in every PR I submit (3 yesterday). I'm really curious how this change made it past PR and into develop. On Wed, Feb 19, 2020 at 9:18 AM Kirk Lund wrote: > PubSubTest is an integration test. Confusion from test names is why I > prefer to include *IntegrationTest or *D

Re: Redis PubSubTest started failing

2020-02-19 Thread Kirk Lund
PubSubTest is an integration test. Confusion from test names is why I prefer to include *IntegrationTest or *DistributionTest in the name like the wiki prescribes. I recommend naming this test PubSubIntegrationTest. On Wed, Feb 19, 2020 at 9:06 AM Owen Nichols wrote: > StressNew is cross-cutting

Re: Redis PubSubTest started failing

2020-02-19 Thread Udo Kohlmeyer
@Owen.. off topic.. but i think it is worth the discussion On 2/19/20 9:00 AM, Owen Nichols wrote: Perhaps also worth considering: can we get WindowsStressNew added to the PR checks? On Wed, Feb 19, 2020 at 8:50 AM Udo Kohlmeyer wrote: Is this something that can be fixed in a short time (2hr

Re: Redis PubSubTest started failing

2020-02-19 Thread Owen Nichols
StressNew is cross-cutting. Unit tests are historically the very least likely to exhibit windows-specific modes of failure. On Wed, Feb 19, 2020 at 9:02 AM Robert Houghton wrote: > We don't even have windows unit tests for PRs. Walk before we run... > > On Wed, Feb 19, 2020, 09:00 Owen Nichols

Re: Redis PubSubTest started failing

2020-02-19 Thread Robert Houghton
We don't even have windows unit tests for PRs. Walk before we run... On Wed, Feb 19, 2020, 09:00 Owen Nichols wrote: > Perhaps also worth considering: can we get WindowsStressNew added to the PR > checks? > > On Wed, Feb 19, 2020 at 8:50 AM Udo Kohlmeyer wrote: > > > Is this something that can

Re: Redis PubSubTest started failing

2020-02-19 Thread Owen Nichols
Perhaps also worth considering: can we get WindowsStressNew added to the PR checks? On Wed, Feb 19, 2020 at 8:50 AM Udo Kohlmeyer wrote: > Is this something that can be fixed in a short time (2hrs)? If not, can > be revert and get back to a clean pipeline? > > --Udo > > On 2/19/20 8:23 AM, Jens

Re: Redis PubSubTest started failing

2020-02-19 Thread Udo Kohlmeyer
Is this something that can be fixed in a short time (2hrs)? If not, can be revert and get back to a clean pipeline? --Udo On 2/19/20 8:23 AM, Jens Deppe wrote: Thanks Kirk, We're working on fixing this. --Jens On Tue, Feb 18, 2020 at 3:23 PM Kirk Lund wrote: I just started seeing the Red

Re: Redis PubSubTest started failing

2020-02-19 Thread Jens Deppe
Thanks Kirk, We're working on fixing this. --Jens On Tue, Feb 18, 2020 at 3:23 PM Kirk Lund wrote: > I just started seeing the Redis PubSubTest fail in IntegrationTest after > rebasing on develop this afternoon. Looks like I have Jens' latest commit > for this test: > > > > > > > > *commit 1be

Redis PubSubTest started failing

2020-02-18 Thread Kirk Lund
I just started seeing the Redis PubSubTest fail in IntegrationTest after rebasing on develop this afternoon. Looks like I have Jens' latest commit for this test: *commit 1befce17eaae2403828769840f86639e13fce81f (origin/develop, origin/HEAD, develop)Author: Jens Deppe >Date: Tue Feb 18 13:0