Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review162331 --- Ship it! Ship It! - Jared Stewart On Jan. 17, 2017, 11:27 p.

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-19 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review162318 --- Ship it! Ship It! - Kevin Duling On Jan. 17, 2017, 3:27 p.m.

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review161991 --- geode-core/src/main/java/org/apache/geode/management/internal/con

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/ --- (Updated Jan. 17, 2017, 11:27 p.m.) Review request for geode, Jared Stewart, Ke

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/ --- (Updated Jan. 17, 2017, 10:21 p.m.) Review request for geode, Jared Stewart, Ke

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-16 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/ --- (Updated Jan. 17, 2017, 5:07 a.m.) Review request for geode, Jared Stewart, Kev

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-16 Thread Jared Stewart
> On Jan. 16, 2017, 6:32 p.m., Jared Stewart wrote: > > Ship It! +1 after Kevin's comment is addressed - Jared --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review161765

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-16 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review161765 --- Ship it! Ship It! - Jared Stewart On Jan. 14, 2017, 3:52 a.m

Re: Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-16 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/#review161751 --- Wouldn't you want all of your lock/release calls to be in a try/fi

Review Request 55532: GEODE-2198: close and re-create the cache on a server when importing new cluster configuration

2017-01-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/ --- Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Repositor