Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/#review167906 --- Ship it! Ship It! - Jared Stewart On March 3, 2017, 10:17

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/#review167900 --- Ship it! Ship It! - Kevin Duling On March 3, 2017, 2:17

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/#review167899 --- Ship it! LGTM. I reviewed the diffs from the original to the

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/ --- (Updated March 3, 2017, 10:17 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Jinmei Liao
> On March 2, 2017, 7:24 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java > > Lines 308 (patched) > > > > > > You should create CliUtilTest or

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/ --- (Updated March 3, 2017, 4:17 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/ --- (Updated March 2, 2017, 4:32 p.m.) Review request for geode, Jared Stewart,

Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-03-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57243/ --- Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.