Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-17 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/#review172121 --- Ship it! Ship It! - Ken Howe On April 17, 2017, 7:09 p.m.,

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/ --- (Updated April 17, 2017, 7:09 p.m.) Review request for geode, Darrel

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/ --- (Updated April 17, 2017, 7:08 p.m.) Review request for geode, Darrel

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-14 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/#review172030 ---

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-14 Thread Jinmei Liao
> On April 14, 2017, 8:43 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java > > Lines 65 (patched) > > > > > > We probably need to do some vetting on those

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-14 Thread Kirk Lund
> On April 14, 2017, 8:43 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java > > Lines 65 (patched) > > > > > > We probably need to do some vetting on those

Re: Review Request 58460: GEODE-2632: refactoring part 1

2017-04-14 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/#review172027 ---

Review Request 58460: GEODE-2632: refactoring part 1

2017-04-14 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Patrick