Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/#review173100 --- Ship it! Ship It! - Kirk Lund On April 26, 2017, 7:48 p.m.,

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-26 Thread Kirk Lund
> On April 25, 2017, 5:43 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > > Lines 238 (patched) > > > > > > Insert one line above the throw

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-26 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/ --- (Updated April 26, 2017, 7:48 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-25 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/ --- (Updated April 25, 2017, 9:19 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-25 Thread Jinmei Liao
> On April 25, 2017, 5:43 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > > Lines 238 (patched) > > > > > > Insert one line above the throw

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-25 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/#review172962 ---

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/#review172950 --- Huge changeset! I'm excited to get this merged into develop. All

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/ --- (Updated April 25, 2017, 1:08 a.m.) Review request for geode, Jared Stewart,

Re: Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/ --- (Updated April 24, 2017, 3:24 p.m.) Review request for geode, Jared Stewart,