Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175940 ---

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175805 --- Ship it! Ship It! - Kirk Lund On May 23, 2017, 3:45 p.m.,

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175804 --- Ship it! Ship It! - Jared Stewart On May 23, 2017, 3:45

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/ --- (Updated May 23, 2017, 3:45 p.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175794 --- Hold off on reviewing this update! The IDE didn't handle the

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/ --- (Updated May 23, 2017, 2:52 p.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-23 Thread Ken Howe
> On May 22, 2017, 10:08 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > > Line 300 (original), 268 (patched) > > > > > > If I

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175719 ---

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175681 --- Ship it! Ship It! - Patrick Rhomberg On May 22, 2017, 6:14

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Ken Howe
> On May 16, 2017, 5:59 p.m., Jinmei Liao wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > > Lines 149 (patched) > > > > > > looks like the locator

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Ken Howe
> On May 15, 2017, 8:53 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java > > Lines 160 (patched) > > > > > > My merge to develop might

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Ken Howe
> On May 16, 2017, 5:19 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > > Line 230 (original), 300 (patched) > > > > > > It doesn't

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Ken Howe
> On May 17, 2017, 5:38 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java > > Line 28 (original), 28 (patched) > > > > > > Are

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/ --- (Updated May 22, 2017, 6:14 p.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-17 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175282 --- On a Mac, Alt-Shift-I does all the inspections for the current

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-16 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175127 ---

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-16 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175123 ---

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-15 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/ --- (Updated May 15, 2017, 10:09 p.m.) Review request for geode, Jinmei Liao,

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175023 --- Ship it!

Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

2017-05-15 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/ --- Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick