Build failed in Jenkins: Geode-nightly-flaky #36

2017-06-14 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2294: revert to avoid rest protocol change [jiliao] Resolve Eclipse/IntelliJ import order disagreement in style files. [jiliao] GEODE-2818: add alias to any command's options that

Build failed in Jenkins: Geode-nightly #866

2017-06-14 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2294: revert to avoid rest protocol change [jiliao] Resolve Eclipse/IntelliJ import order disagreement in style files. -- [...truncated 134.84

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 15, 2017, 3:33 a.m.) Review request for geode, Emily Yeh, Jared

Re: Revert gradle upgrade

2017-06-14 Thread Mark Bretl
I think I figured it out. Here is what I did: Fix was to declare the version of Antlr in the dependencies{} because if no version is set, the ANTLR plugin would default to 2.7.7. This was causing issues since the ANTLR plugin was trying to 'change' the version after dependency resolution for its

Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-14 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60106/ --- Review request for geode and Hitesh Khamesra. Bugs: GEODE-3052

Re: release 1.2

2017-06-14 Thread Anthony Baker
Agreed. Please merge to release/1.2.0 when ready. Anthony > On Jun 14, 2017, at 1:46 PM, Lynn Hughes-Godfrey > wrote: > > We would like to include the fix for (GEODE-3072) Events do not get removed > from the client queue when 1.0 clients connect to 1.2 servers >

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/#review177963 --- Ship it! Ship It! - Darrel Schneider On June 14, 2017, 3:24

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/#review177962 ---

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-06-14 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r122085382 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -1472,6 +1472,19 @@ public boolean

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #585 was SUCCESSFUL (with 1868 tests)

2017-06-14 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #585 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-585/ -- This

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/ --- (Updated June 14, 2017, 10:24 p.m.) Review request for geode, anilkumar

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r122067285 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java --- @@ -228,4 +139,55 @@ void

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r122066276 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java --- @@ -228,4 +139,55 @@ void

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177951 --- I pulled this diff and incorporated everything into my

Re: release 1.2

2017-06-14 Thread Lynn Hughes-Godfrey
We would like to include the fix for (GEODE-3072) Events do not get removed from the client queue when 1.0 clients connect to 1.2 servers On Wed, Jun 14, 2017 at 12:25 PM, Fred Krone wrote: > Reviewing our JTA transaction manager implementation during a recent issue > we

Build failed in Jenkins: Geode-release-flaky #14

2017-06-14 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2294: revert to avoid rest protocol change [abaker] Update LICENSE after review [abaker] GEODE-3024 race condition between server locator preparing membership [abaker] GEODE-3024

[GitHub] geode pull request #579: GEODE-3070: Fix gemfire.jar to be geode-dependencie...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r122055572 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java --- @@ -45,78 +44,50 @@ public OrderByComparator(List

Re: release 1.2

2017-06-14 Thread Fred Krone
Reviewing our JTA transaction manager implementation during a recent issue we thought it would be useful to log message for users when our implementation is being used (which is by default but potentially unknown). It's small but not critical -- we thought we might get it in if the 1.2 release

Re: release 1.2

2017-06-14 Thread Anthony Baker
> On Jun 14, 2017, at 12:03 PM, Eric Shu wrote: > > I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE > implementation of JTA transaction manager) > > -Eric Thanks Eric. Can you make a case for why this change needs to go into 1.2.0? We’re pretty locked

Re: release 1.2

2017-06-14 Thread Eric Shu
I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE implementation of JTA transaction manager) -Eric On Wed, Jun 14, 2017 at 11:50 AM, Anthony Baker wrote: > Status update: > > - I think we have all changes needed in the release/1.2.0 branch [1]. > Please

Re: release 1.2

2017-06-14 Thread Anthony Baker
Status update: - I think we have all changes needed in the release/1.2.0 branch [1]. Please shout out if not. - The last 2 Geode-release jenkins runs have timed out / hung [2]. Please review to see if there are changes needed. - I’ve completed the LICENSE review [3]. Anthony [1]

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/580 GEODE-2936: Refactoring OrderByComparator [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2936) `OrderByComparator.java` contained a lot of redundant and confusing

Build failed in Jenkins: Geode-release #63

2017-06-14 Thread Apache Jenkins Server
See Changes: [abaker] GEODE-3023: TcpServer move soTimout for the socket for SSL Locators [abaker] GEODE-3023: removing incorrect assertion [abaker] Fix spotless failure --

Upgrade to Mockito 2.8.9 and PowerMock 1.7.0RC4

2017-06-14 Thread Kirk Lund
In February, I started upgrading our use of Mockito from 1.10.19 to 2.7.11. I'm happy to report that we have completed this with the help of Srikanth and Jared. A few more releases of Mockito have come out since 2.7.11, so we are now upgraded to Mockito 2.8.9 and PowerMock 1.7.0RC4. Thanks, Kirk

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177928 --- Ship it! Ship It! - Ken Howe On June 13, 2017, 4:29 p.m.,

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Jared Stewart
> On June 12, 2017, 7:59 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > > Lines 327 (patched) > > > > > > Are you sure that we want to keep this

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177927 --- Ship it! Ship It! - Jared Stewart On June 13, 2017, 4:29

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177920 --- Ship it! Ship It! - Kirk Lund On June 13, 2017, 9:28 p.m.,

Re: [VOTE] Using Pull Requests over Review Board

2017-06-14 Thread Kenneth Howe
-1 per my comments on the [DISCUSS] thread > On Jun 11, 2017, at 9:51 AM, Jacob Barrett wrote: > > After a few days of discussion [1] this thread has quieted down so I would > like to take it to a vote. The proposal is to modify the workflow of > committers to match that of

[GitHub] geode pull request #564: GEODE-3023 TcpServer thread can be blocked in proce...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is