Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60217/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen

Re: [VOTE] Apache Geode release - v1.2.0 RC1

fix for the above 2 issues are merged to 1.2 branch. On Mon, Jun 19, 2017 at 1:36 PM, Jinmei Liao wrote: > -1, due the recent discovery of GEODE-3095 > and GEODE-3092 > > > >

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

> On June 19, 2017, 4:24 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > > Lines 1424-1426 (original), 1424-1426 (patched) > > > > > > this

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

> On June 19, 2017, 6:40 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > > Line 1426 (original), 1426 (patched) > > > > > > It seems to me

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60157/ --- (Updated June 20, 2017, 12:53 a.m.) Review request for geode, Alexander

Re: Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/#review178262 --- Ship it! Ship It! - Jared Stewart On June 19, 2017, 4:09

Re: Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/#review178266 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 4:09 p.m.,

[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60106/ --- (Updated June 19, 2017, 4:09 p.m.) Review request for geode and Hitesh

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60157/#review178152 ---

Re: Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/#review178272 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 4:09 p.m.,

Re: Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60142/ --- (Updated June 19, 2017, 3:19 p.m.) Review request for geode, Anthony Baker,

Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

[GitHub] geode issue #592: GEODE-2707: Removing TXLockToken

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/592 👍 thanks for pushing this through! It had completely fallen off my radar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [VOTE] Apache Geode release - v1.2.0 RC1

-1, due the recent discovery of GEODE-3095 and GEODE-3092 On Sat, Jun 17, 2017 at 2:57 PM, Anthony Baker wrote: > Thanks Mike! Here’s the corrected text: > > This is the

[GitHub] geode pull request #592: GEODE-2707: Removing TXLockToken

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/592 GEODE-2707: Removing TXLockToken [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2707) It seems that there are no other classes that use the `TXLockToken` class,

Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60157/#review178279 --- I just have a few small things.

Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178295 --- Ship it! Ship It! - Patrick Rhomberg On June 19, 2017, 6:04

Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/#review178297 --- Ship it! Ship It! - Patrick Rhomberg On June 19, 2017, 7:08

Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/#review178302 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 7:08 p.m.,

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178305 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 9:12 p.m.,

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178313 --- Ship it! Ship It! - Ken Howe On June 19, 2017, 9:45 p.m.,

Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/#review178296 ---

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/ --- (Updated June 19, 2017, 9:12 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178306 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 9:12 p.m.,

[GitHub] geode issue #585: GEODE-3091: remove empty method

Github user agingade commented on the issue: https://github.com/apache/geode/pull/585 The changes looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode issue #592: GEODE-2707: Removing TXLockToken

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/592 After the fix Ken pointed out, `++n;` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: Geode-nightly #871

See -- [...truncated 970.53 KB...] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #590 was SUCCESSFUL (with 1868 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #590 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-590/ -- This

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/591#discussion_r122848112 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java --- @@ -1415,11 +1413,7 @@ public boolean

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/591#discussion_r122849064 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java --- @@ -941,17 +940,16 @@ private SelectResults