Re: Nightly build failures caused by attempted use of default ports

I like the sound of #1: 1) use Docker for AcceptanceTest and IntegrationTest targets? Does anyone know of a downside to running these tests in docker? On Wed, Aug 23, 2017 at 12:06 PM, Jared Stewart wrote: > I think we just need to have AcceptanceTest (and possibly

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/739#discussion_r135055785 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -50,26 +53,52 @@

eviction files

Hi, I am looking into the internals of the eviction process, Can anyone point me to the most important classes, the main mechanism "wheels" etc.? Thanks, Roi -Original Message- From: Roi Apelker Sent: Wednesday, August 16, 2017 8:38 PM To: dev@geode.apache.org Subject: RE:

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/739#discussion_r135055386 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -50,26 +53,52 @@

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/#review183747 --- Ship it!

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/734 Precheckin green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r135087207 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java --- @@ -297,6 +297,8 @@ public Object call() throws

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/740 GEODE-3513: Removing the use of native sessions session caching In the session module for generic app servers, we were asking the application server for a 'native' session and then

[GitHub] geode issue #740: GEODE-3513: Removing the use of native sessions session ca...

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/740 @jhuynh1 @boglesby --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: eviction files

Hi Roi, I would probably start from NewLRUClockHand. That's the class that maintains the actual state of what entries are least recently used. You can follow the callers of getLRUEntry back to see how it's being used. One key place is AbstractLRUMap.lruUpdateCallback, which gets called after

Visibility of Skipped tests in Jenkins

In local instances of Jenkins, I can see a list of "Skipped" tests -- these are JUnit tests which were skipped because they are marked with @Ignore or because they have an org.junit.Assume check that wasn't satisfied (example: Assume.assumeTrue(isWindows())). I can't figure out where that view is

Re: Visibility of Skipped tests in Jenkins

Hi Kirk, I think you are looking for this page, https://builds.apache.org/blue/organizations/jenkins/Geode-nightly/detail/Geode-nightly/930/tests ? I see 'Skipped' under the Failed tests. --Mark On Thu, Aug 24, 2017 at 11:09 AM, Kirk Lund wrote: > In local instances of

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r135089666 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23

Re: [DISCUSS] Updating Spotless

+1 for consistency... -Anil. On Wed, Aug 23, 2017 at 4:42 PM, Kirk Lund wrote: > I'm for making our spotless better match our style guide, and it's easy > enough to update branches with this. > > On Wed, Aug 23, 2017 at 4:31 PM, Patrick Rhomberg >

[GitHub] geode pull request #741: GEODE-3512 Doc removal of gfsh encrypt password

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/741 GEODE-3512 Doc removal of gfsh encrypt password This revises the documentation to go with GEODE-1958. @jaredjstewart @jinmeiliao @davebarnes97 @joeymcallister, please review. You

Re: [GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...

Udo, Once we switch to git box we will be able to close prs. Sent from my iPhone > On Aug 24, 2017, at 3:16 PM, kohlmu-pivotal wrote: > > Github user kohlmu-pivotal commented on the issue: > >https://github.com/apache/geode/pull/245 > >@doribd @fdaniel7 could

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/740#discussion_r135148933 --- Diff:

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #657 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #657 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-657/ -- This

[GitHub] geode pull request #743: GEODE-3131: Increasing the time

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/743 GEODE-3131: Increasing the time * Increasing the time elapsed before the dispatchers are started. * All validations must be done before the dispatcher start dispatching. Thank

Re: Visibility of Skipped tests in Jenkins

Yup. I've tested accessing that same page without any authentication and seems to work fine here as well.. On Thu, Aug 24, 2017 at 1:29 PM, Mark Bretl wrote: > Hi Kirk, > > I think you are looking for this page, https://builds.apache. >

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/740#discussion_r135151782 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/Jetty9CachingClientServerTest.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/740#discussion_r135150238 --- Diff: extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionListener.java --- @@ -22,6 +22,11 @@

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/740#discussion_r135150926 --- Diff: extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/SessionCountingListener.java --- @@ -12,28 +12,35 @@ *

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135153564 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java --- @@ -41,20 +43,29 @@ public void

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135153452 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java --- @@ -44,9 +46,15 @@ public

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135153161 --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java --- @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135154701 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/AuthorizationIntegrationTest.java --- @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] geode pull request #742: GEODE-3473: Initial commit of the internal package ...

GitHub user kohlmu-pivotal opened a pull request: https://github.com/apache/geode/pull/742 GEODE-3473: Initial commit of the internal package renaming refactor. Changing the protobuf file refactor first. Thank you for submitting a contribution to Apache Geode. In

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/742 @galen-pivotal @bschuchardt @pivotal-amurmann @WireBaron @hiteshk25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/742 This looks good. However, I'd like to understand what the plan is for moving the files to the location suggested by the package name/path. Maybe the Commit message could clarify that? ---

Re: Nightly build failures caused by attempted use of default ports

Vince just told me that we can't use Docker in Windows. So that's one downside. On Thu, Aug 24, 2017 at 7:27 AM, Darrel Schneider wrote: > I like the sound of #1: > 1) use Docker for AcceptanceTest and IntegrationTest targets? > > Does anyone know of a downside to running

Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61895/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat,

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/#review183798 --- Ship it! Ship It!

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/742 @pivotal-amurmann no files should have been moved. Only class import locations have changed. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 24, 2017, 10:02 p.m.) Review request for geode, Emily Yeh,

[GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/245 @doribd @fdaniel7 could you please close this PR if it is not required anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61895/#review183799 --- Would it be possible to add a unit test for this fix? - Darrel

[GitHub] geode issue #325: merge new version

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/325 @zmyer could you please confirm that this PR is still relevant. If not I will close it CoB tomorrow ( 25 Aug) --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/737#discussion_r135157183 --- Diff: geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java --- @@ -0,0 +1,226 @@ +/* + * Licensed to

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/737#discussion_r135156514 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java --- @@ -119,7 +119,14 @@ public void

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135158491 --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java --- @@ -46,6 +44,14 @@ void receiveMessage(InputStream

[GitHub] geode pull request #743: GEODE-3131: Increasing the time

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/743 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: Geode-nightly #933

See Changes: [dbarnes] GEODE-3395 Variable-ize product version and name in user guide - [huynhja] GEODE-3184: Cleaned up Cargo tests [lgallinat] GEODE-3507 PartitionedRegionRedundancyTracker now does not allow

Jenkins build is back to normal : Geode-release-flaky #31

See

Build failed in Jenkins: Geode-nightly-flaky #101

See Changes: [dbarnes] GEODE-3395 Variable-ize product version and name in user guide - [huynhja] GEODE-3184: Cleaned up Cargo tests [lgallinat] GEODE-3507 PartitionedRegionRedundancyTracker now does not