Request: Build flag to skip download of previous Geode versions

2017-09-18 Thread Kirk Lund
So my build has been stuck on our favorite download for the last 10 minutes and is only up to 13% which tells me it could take 20+ minutes this morning... Download https://www.apache.org/dyn/closer.cgi?action=download=geode/1.2.0/apache-geode-1.2.0.tar.gz <=> 13% EXECUTING >

Re: Request: Build flag to skip download of previous Geode versions

2017-09-18 Thread Kirk Lund
Turns out the 13% has nothing to do with the download, but I still think a build flag to skip this would be a good idea. On Mon, Sep 18, 2017 at 9:38 AM, Kirk Lund wrote: > So my build has been stuck on our favorite download for the last 10 > minutes and is only up to 13%

Re: How gitbox works

2017-09-18 Thread Kirk Lund
Apparently I no longer have commit access. Anyone know who/how I get access restored? Thanks, Kirk On Mon, Sep 18, 2017 at 9:49 AM, Jacob Barrett wrote: > GitBox is just a fancy name Apache has given to their service that allows > us to use GitHub as the source of

Re: Request: Build flag to skip download of previous Geode versions

2017-09-18 Thread Kirk Lund
I filed GEODE-3639: "Request: build flag to skip download of previous Geode versions" for this request. Thanks, Kirk On Mon, Sep 18, 2017 at 9:40 AM, Kirk Lund wrote: > Turns out the 13% has nothing to do with the download, but I still think a > build flag to skip this would

Re: Request: Build flag to skip download of previous Geode versions

2017-09-18 Thread Jared Stewart
I think this might do it: ./gradlew build -x :geode-old-versions:compileJava -x :geode-old-versions:verifyGeodetest120 -x :geode-old-versions:downloadZipFiletest120 -x :geode-old-versions:downloadAndUnzipFiletest120 > On Sep 18, 2017, at 9:46 AM, Kirk Lund wrote: > > I

How gitbox works

2017-09-18 Thread Kirk Lund
I've searched and not found a good summary on how gitbox works. Anyone know of a good resource? The kinds of questions I have are: if other devs approve my PR, do I still need to find another dev to commit for me or can I commit my own PR if has been approved? Thanks, Kirk

Re: How gitbox works

2017-09-18 Thread Jacob Barrett
GitBox is just a fancy name Apache has given to their service that allows us to use GitHub as the source of authority for our Git repo. Everything is done on GitHub using the GitHub processes. Anyone with write access to GitHub can merge a PR. The PR can be merged from the PR GitHub website.

Build failed in Jenkins: Geode-nightly #958

2017-09-18 Thread Apache Jenkins Server
See -- [...truncated 117.85 KB...] :geode-json:distributedTest NO-SOURCE :geode-json:integrationTest NO-SOURCE :geode-junit:javadoc :geode-junit:javadocJar :geode-junit:sourcesJar

Build failed in Jenkins: Geode-nightly-flaky #125

2017-09-18 Thread Apache Jenkins Server
See -- Started by upstream project "Geode-nightly" build number 958 originally caused by: Started by timer [EnvInject] - Loading node environment variables. Building remotely on H14

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Mark Hanson
If you think this is a significant ease of use benefit, why have to invoke move? I understand this code, but I have not seen it in recent memory. I agree that this may make use of a copy(move) constructor easier, but... If the consensus is that this is a significant ease of use benefit for the

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Mark Hanson
Sounds good to me. +1 > On Sep 18, 2017, at 11:36 AM, David Kimura wrote: > > Application code doesn't need to invoke move (and probably shouldn't). In > the examples, I think it's more of an exercise to show what would happen if > invoked. And really, I expect same

Re: INFRA Jira URL

2017-09-18 Thread Joey McAllister
I think this is it: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=25=INFRA. (At least, that's the JIRA link I got from Infra's contact page.) On Mon, Sep 18, 2017 at 10:17 AM Kirk Lund wrote: > Does anyone know the URL for Apache INFRA Jira? > > Thanks, >

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread David Kimura
The benefit I see isn't for performance, it's flexibility and ease of use by application developer. Anything we can do to achieve this, I think is a significant win. I think the reason for the various approaches is to determine whether we can safely create the simple/flexible API without

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread David Kimura
Application code doesn't need to invoke move (and probably shouldn't). In the examples, I think it's more of an exercise to show what would happen if invoked. And really, I expect same badness to happen using shared pointer method if we dereferenced a moved pointer. Thanks, David On Mon, Sep

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Mark Hanson
Hi All, As we are creating a user API, unless there is a significant performance benefit, I think we should try to take the simpler route. I see benefit to the approach being proposed, but I don’t see a significant benefit. Someone please school me if I am wrong. I am still in the shared

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Ernest Burghardt
+1 to passing in CacheConfig - might be a bit of refactoring (needed) but complexity level should be low +1 value approach as well as dumping the Factory On Mon, Sep 18, 2017 at 11:14 AM, David Kimura wrote: > +1 value approach (via some implementation from this thread)

INFRA Jira URL

2017-09-18 Thread Kirk Lund
Does anyone know the URL for Apache INFRA Jira? Thanks, Kirk

Re: How gitbox works

2017-09-18 Thread Kirk Lund
Yeah, I followed all of the directions shared by Jens and Bruce. I also had my github account added to my Apache account for the last 2-3 years. Apparently the switchover to gitbox removed by commit permission. /Users/klund/dev/geode [525]$ git push ERROR: Permission to

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread David Kimura
+1 value approach (via some implementation from this thread) I think I like this. In all BAD cases, it's the user who shot themselves in the foot by using std::move unsafely. I expect this behavior is the same behavior as for any other object. And if we're ever able to get rid of the

Re: How gitbox works

2017-09-18 Thread Mark Bretl
Hi Kirk, I would go to the GitBox account linking utility page at https://gitbox.apache.org/setup/ and verify all three steps are green. If they are green, then probably need to contact INFRA to figure out the issue with your account. --Mark On Mon, Sep 18, 2017 at 10:13 AM, Kirk Lund

Re: How gitbox works

2017-09-18 Thread Kirk Lund
If I navigate to https://github.com/apache, I see the following at the top with a button to "View invitation" and accept: asfgit invited you to join the The Apache Software Foundation organization on Mar 7, 2016. Is this the expected invitation that I need to accept?!

Re: How gitbox works

2017-09-18 Thread Kirk Lund
After 30 minutes, my MFA box went green (note: I had already enabled two-factor auth on github a long time ago) and all of the following appeared together. You would think that it might be desirable for the page to show "NOTE: Account linking happens every 30 minutes, be patient!" while you're

Re: [VOTE] Apache Geode release - v1.2.1 RC4

2017-09-18 Thread Dan Smith
+1 The jenkins release build was green and release check passed as well - https://github.com/upthewaterspout/geode-release-check -Dan On Sat, Sep 16, 2017 at 8:01 AM, Anthony Baker wrote: > This is the fourth release candidate for Apache Geode, version 1.2.1. > Thanks to

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Jacob Barrett
So I am changing my vote to Value as well. It was great to put together all these samples because it really helped me understand what it buys us. With the current factory model it’s a little less appealing but not significantly enough to really notice. I would say we go GA with the current

Re: [Discuss] Investigation of C++ object return types

2017-09-18 Thread Jacob Barrett
Yup! It works. https://gist.github.com/pivotal-jbarrett/c483f7f41b187f0ed8c80108aa6a I also corrected the solution to use a unique_ptr for the Cache to CacheImpl relationship. Notice the main.cpp uses CacheFactory model as well as the direct allocation model with CacheConfig. So if we ship

Return types form methods on Cache

2017-09-18 Thread Jacob Barrett
So, now that we have selected to use the value model for CacheFactory::create()/Cache, we need to look at what the methods on Cache return. Starting with Cache::createRegionFactory method which returns std::shared_ptr. I think it is very clear that this should be a value type. RegionFactory

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #682 was SUCCESSFUL (with 2042 tests). Change made by Mark Paluch.

2017-09-18 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #682 was successful. --- Scheduled with changes by Mark Paluch. 2044 tests in total.

Re: [VOTE] Apache Geode release - v1.2.1 RC4

2017-09-18 Thread William Markito Oliveira
+1 Checked: - Basic operations from command line - Checksums match - Release build green (blue actually) ( https://builds.apache.org/job/Geode-release/lastBuild/) On Mon, Sep 18, 2017 at 3:57 PM, Dan Smith wrote: > +1 > > The jenkins release build was green and release

Re: Return types form methods on Cache

2017-09-18 Thread Kirk Lund
I would vote +1 for a more attractive, professional and user-friendly API. I'm not sure if there's a perf or memory-usage reason for using "std::shared_ptr" to types instead of returning values, but the end result does not look like a professional API to me. I would favor a more user-friendly

Re: Return types form methods on Cache

2017-09-18 Thread Jacob Barrett
> On Sep 18, 2017, at 7:34 PM, Kirk Lund wrote: > > I would vote +1 for a more attractive, professional and user-friendly API. > I'm not sure if there's a perf or memory-usage reason for using > "std::shared_ptr" to types instead of returning values, but the end > result does

Passed: apache/geode#3900 (develop - 280b5d7)

2017-09-18 Thread Travis CI
Build Update for apache/geode - Build: #3900 Status: Passed Duration: 12 minutes and 12 seconds Commit: 280b5d7 (develop) Author: Amey Barve Message: GEODE-2719: corrected GEODE versions to 1.3.0 instead of 1.2.2 for the respective deprecated API javadocs.

Re: How gitbox works

2017-09-18 Thread Kirk Lund
Third box on https://gitbox.apache.org/setup/ still isn't GREEN. On Mon, Sep 18, 2017 at 12:51 PM, Kirk Lund wrote: > If I navigate to https://github.com/apache, I see the following at the > top with a button to "View invitation" and accept: > > asfgit

Re: How gitbox works

2017-09-18 Thread Jared Stewart
Https://github.com/apache is where I had to accept the invite and get the third box green. I didn't seem to get an email invite either. - Jared On Sep 18, 2017 12:51 PM, "Kirk Lund" wrote: If I navigate to https://github.com/apache, I see the following at the top with a

Re: How gitbox works

2017-09-18 Thread Jacob Barrett
Mine are too. It's "normal". On Mon, Sep 18, 2017 at 1:20 PM Kirk Lund wrote: > After 30 minutes, my MFA box went green (note: I had already enabled > two-factor auth on github a long time ago) and all of the following > appeared together. You would think that it might be

Re: [VOTE] Apache Geode release - v1.2.1 RC4

2017-09-18 Thread Karen Miller
+1 Ran the 1.2.1 RC4 partitioned geode-example against Geode 1.2.1 RC4. So, built Geode from source, built one of the examples, ran gfsh commands to start locator and servers as well as ran a query, and did some puts and gets via API. Also checked that the manual builds and contains 1.2.1

Re: [VOTE] Apache Geode release - v1.2.1 RC4

2017-09-18 Thread Dick Cavender
+1 Downloaded source and binary dists. Built and tested sources on Ubuntu against JDK 1.8.0_111 Ran gfsh full version followed by 5 minute tutorial on binary dist. Review LICENSE file and copyrights. -Dick On Sat, Sep 16, 2017 at 8:01 AM, Anthony Baker wrote: > This is the