Re: PR to add unique ID to DUnit log output

2022-01-04 Thread Mark Hanson
I support Jens' change until something better is identified. I think just this minor change will have a big impact on our ability to decipher what is going on in dunit tests. Thanks for making the change Jens! Mark On 1/4/22, 10:44 AM, "Dale Emery" wrote: Hi Jens and all, A

Re: PR to add unique ID to DUnit log output

2022-01-04 Thread Dale Emery
Hi Jens and all, A possibility to consider: Instead of generating an arbitrary-but-unique ID, use an existing identifier from the test environment… such as the ID in the test worker directory name. That might make it easier to map a given log line to the other artifacts from the test. So if

Re: [DISCUSS] proposal to pare down old-version testing

2022-01-04 Thread Alexander Murmann
+1 Great compromise! Let's not forget about this whenever we change the protocol -- Please provide anonymous feedback for me here. From: Anilkumar Gingade Sent: Tuesday, January 4, 2022 07:09 To: dev@geode.apache.org

Re: [VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2

2022-01-04 Thread Nabarun Nag
As it is primarily created for Confluent Marketplace we need to follow the steps required for hosting in the marketplace, which included how things are to be named, folder structure etc. Looking at the list of things to do and conflicts with Geode / Confluent requirements. We can remove it

LGTM as a gating job on PRs not actually gating?

2022-01-04 Thread Donal Evans
I just noticed something when reviewing a PR. We recently voted to make the LGTM check a required precheckin job, but even if that job finds newly introduced alerts, it doesn't turn red and block the PR. This seems like it's not working as intended. The comment from LGTM showing that there are

Re: [VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2

2022-01-04 Thread Nabarun Nag
+1 Checked with building source and running tests. Regards Naba From: Dan Smith Sent: Tuesday, January 4, 2022 2:37 PM To: dev@geode.apache.org Subject: Re: [VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2 This is the same release I started a VOTE on in

Re: LGTM as a gating job on PRs not actually gating?

2022-01-04 Thread Robert Houghton
The test has successfully found a failure! Isn’t that interesting! I’m going to have to look more at how we can configure this via .asf.yml… From: Donal Evans Date: Tuesday, January 4, 2022 at 3:20 PM To: dev@geode.apache.org Subject: LGTM as a gating job on PRs not actually gating? I just

Re: [VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2

2022-01-04 Thread Owen Nichols
Quibbles: - artifact naming does not follow standard naming convention of THING-VERSION.tgz and THING-VERSION-src.tgz (also Geode decided to stop distributing .zip files years ago) - not based on the latest Geode 1.12 patch. I would like to see Geode 1.12.8 picked up once it's available later

[VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2

2022-01-04 Thread Dan Smith
Hello Geode Dev Community, This is a release candidate for Apache Geode Kafka Connector version 1.1.0. This contains a bump to log4j 2.16. Please do a review and give your feedback. Voting deadline: 3PM PST Tuesday, Jan 11, 2022. Please note that we are voting upon the source tag: rel/v1.1.0

Re: [VOTE] - Apache Geode Kafka Connector 1.1.0 - Take 2

2022-01-04 Thread Dan Smith
This is the same release I started a VOTE on in December and canceled due to Christmas. Here was my earlier comment on where this release is coming from: On Dec 16, 2021 11:33 AM, Dan Smith wrote: This is related to the earlier discussion about the kafka connector. This code was already linked

Re: [DISCUSS] proposal to pare down old-version testing

2022-01-04 Thread Anilkumar Gingade
+1 Thanks for bringing this and taking care of this. -Anil. On 1/3/22, 10:41 AM, "Dan Smith" wrote: Looking at KnownVersion.java - we did make protocol changes in 1.12.1 and 1.13.2. So, my suggestion would be to keep 1.12.0 and 1.13.1, but dop all the other patch versions that aren't