Re: Review Request 54915: GEODE-2215: GatewaySenderAdvisor checks the current processor to see if it has started

2016-12-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54915/#review159786 --- Ship it! Ship It! - xiaojian zhou On Dec. 20, 2016, 9:58

Build failed in Jenkins: Geode-nightly #691

2016-12-20 Thread Apache Jenkins Server
See Changes: [abarve] GEODE-1541 : Made statsListUniqueId to be an AtomicLong. This closes [bschuchardt] GEODE-1550 MembershipJUnitTest.testMultipleManagersInSameProcess failure [bschuchardt] GEODE-1580: [bschuchardt] GEODE-2215 NPE

[jira] [Assigned] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2016-12-20 Thread Alyssa Kim (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Kim reassigned GEODE-728: Assignee: Alyssa Kim (was: Dan Smith) > Rename Execution.withArgs to Execution.setArguments >

[jira] [Assigned] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith reassigned GEODE-2238: Assignee: Dan Smith >

[jira] [Commented] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765782#comment-15765782 ] Dan Smith commented on GEODE-2238: -- I was able to reproduce this running the test in my IDE 50 times. I

[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...

2016-12-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/322 +1 Awesome!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Review Request 54918: GEODE-2099: The GfshConnectorRule has been refactored to use awaitility to wait and retry till connection is ready.

2016-12-20 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54918/#review159775 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 2:57

Re: Review Request 54586: GEODE-2172: CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2016-12-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54586/#review159770 --- Ship it! Ship It! - Jinmei Liao On Dec. 19, 2016, 12:45

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159771 --- Ship it! Ship It! - Jinmei Liao On Dec. 20, 2016, 10:46

Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/ --- Review request for geode, Jason Huynh and Dan Smith. Bugs: GEODE-2238

[jira] [Updated] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2238: - Labels: Flaky (was: ) >

[jira] [Commented] (GEODE-2109) calling submit on ExecutionService can cause exceptions to be lost

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765414#comment-15765414 ] ASF GitHub Bot commented on GEODE-2109: --- Github user upthewaterspout commented on the issue:

[GitHub] geode issue #296: GEODE-2109 : Calling submit on ExecutionService can cause ...

2016-12-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/296 Hi @deepakddixit Sorry for the slow response. I'm a little concerned that with your changes to the test in ef4d38d, the test is no longer actually testing what happens if the

[jira] [Created] (GEODE-2237) Geode product classes should use Log4J2 Logger instead of JUL or LogWriter

2016-12-20 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2237: Summary: Geode product classes should use Log4J2 Logger instead of JUL or LogWriter Key: GEODE-2237 URL: https://issues.apache.org/jira/browse/GEODE-2237 Project: Geode

[jira] [Assigned] (GEODE-2237) Geode product classes should use Log4J2 Logger instead of JUL or LogWriter

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2237: Assignee: Kirk Lund > Geode product classes should use Log4J2 Logger instead of JUL or LogWriter >

The right way to remove a region's cache listener?

2016-12-20 Thread Kevin Duling
I'm looking at GEODE-2236 and protecting against the NPE is trivial. But the question is, what is the right way to do this? What is the syntax people would expect to use? What if there are multiple listeners and you wanted to delete one or

Re: Review Request 54914: GEODE-1943: Minor modification to SessionReplicationIntegrationJUnitTest.testInvalidateSession9

2016-12-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54914/#review159758 --- Ship it! Ship It! - Dan Smith On Dec. 20, 2016, 9:56 p.m.,

[jira] [Created] (GEODE-2236) Attempting to remove all CacheListeners from a Region using gfsh throws NullPointerException

2016-12-20 Thread Kevin Duling (JIRA)
Kevin Duling created GEODE-2236: --- Summary: Attempting to remove all CacheListeners from a Region using gfsh throws NullPointerException Key: GEODE-2236 URL: https://issues.apache.org/jira/browse/GEODE-2236

Review Request 54916: GEODE-2215: Fixed flakiness of ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/ --- Review request for geode, nabarun nag and Dan Smith. Repository: geode

[jira] [Resolved] (GEODE-2210) Session module class loader should check the thread context class loader

2016-12-20 Thread Jason Huynh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh resolved GEODE-2210. Resolution: Fixed > Session module class loader should check the thread context class loader >

[jira] [Resolved] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-20 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling resolved GEODE-2188. - Resolution: Fixed > ExampleSecurityManager references SampleSecurityManager in javadoc >

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765029#comment-15765029 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on the issue:

[jira] [Resolved] (GEODE-2207) IntegratedSecurityCacheLifecycleDistributedTest is disabled and needs to be fixed

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2207. -- Resolution: Fixed Fix Version/s: 1.1.0 > IntegratedSecurityCacheLifecycleDistributedTest is

[jira] [Updated] (GEODE-2207) IntegratedSecurityCacheLifecycleDistributedTest is disabled and needs to be fixed

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2207: - Affects Version/s: 1.0.0-incubating > IntegratedSecurityCacheLifecycleDistributedTest is disabled and

[jira] [Updated] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1541: - Affects Version/s: 1.0.0-incubating > statsListUniqueId should be an AtomicLong >

[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764880#comment-15764880 ] ASF GitHub Bot commented on GEODE-2167: --- Github user vectorijk commented on the issue:

[jira] [Commented] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764893#comment-15764893 ] Barry Oglesby commented on GEODE-2234: -- I moved the queryExecution stat manipulation to the

[jira] [Assigned] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby reassigned GEODE-2234: Assignee: Barry Oglesby > Lucene query hit stats shows number higher than number of calls

[jira] [Created] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
Barry Oglesby created GEODE-2234: Summary: Lucene query hit stats shows number higher than number of calls Key: GEODE-2234 URL: https://issues.apache.org/jira/browse/GEODE-2234 Project: Geode

[GitHub] geode issue #308: [GEODE-2167] BundledJarsJUnitTest fails on Windows

2016-12-20 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/geode/pull/308 Thanks for the review @jinmeiliao @kirklund @metatype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764806#comment-15764806 ] ASF GitHub Bot commented on GEODE-2167: --- Github user asfgit closed the pull request at:

[GitHub] geode pull request #308: [GEODE-2167] BundledJarsJUnitTest fails on Windows

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764732#comment-15764732 ] ASF subversion and git services commented on GEODE-2188: Commit

[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764593#comment-15764593 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on a diff in the pull

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764592#comment-15764592 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on a diff in the pull

[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...

2016-12-20 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/323#discussion_r93273525 --- Diff: geode-core/src/main/java/org/apache/geode/internal/DistributionLocator.java --- @@ -166,9 +166,9 @@ public void run() { try {

[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...

2016-12-20 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/323#discussion_r93273028 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/Locator.java --- @@ -253,7 +253,7 @@ private static Locator startLocator(int port, File

[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...

2016-12-20 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/320 Thanks @dschneider-pivotal for the review. Will add the unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project