[jira] [Commented] (GEODE-2235) test is missing @Test: PrCqUsingPoolDUnitTest.testCqOnAccessorServerWithUpdatesResultingInDestroyedCQEvents

2016-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772143#comment-15772143 ] ASF GitHub Bot commented on GEODE-2235: --- GitHub user shankarh opened a pull request:

[GitHub] geode pull request #324: GEODE-2235 : Adding missing test annotation

2016-12-22 Thread shankarh
GitHub user shankarh opened a pull request: https://github.com/apache/geode/pull/324 GEODE-2235 : Adding missing test annotation Added @test annotation to testCqOnAccessorServerWithUpdatesResultingInDestroyedCQEvents test You can merge this pull request into a Git repository by run

Re: Permission to Create JIRA Issues

2016-12-22 Thread William Markito Oliveira
There is also a "submit an issue" link available at http://geode.apache.org so that anyone can submit bugs... Sent from my iPhone > On Dec 22, 2016, at 8:13 PM, Dan Smith wrote: > > Hi Sarge, > > I'm a little surprised you weren't able to create an issue actually, > because according to wha

Strategy for Updating Public API Changes

2016-12-22 Thread Alyssa Kim
Hi, Related Jira : https://issues.apache.org/jira/browse/GEODE-1577 Summary : Replacing wildcards with generic types requires changes in applications that use this method. Probably there are other jiras that update public APIs too. How do we to handle this? 1. Just update the API whenever it's co

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
Ok, I will try and explain all of this better. --Udo On 12/22/16 16:42, Darrel Schneider wrote: The @refTypeId is hard to understand. It is unclear to me how it interacts with other things like "dataType" and "subType". I think you can either specify a dataType/subType OR a @refTypeId. Is this

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
The thought was to process the type definition and optimize before generating the type def. Making it more generic or "wider" is a good idea. Maybe I try and keep to the already defined PDX types and see how they could map. --Udo On 12/22/16 16:11, Darrel Schneider wrote: When generating a

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
I think the spec needs to be further extended. This was just draft 1 with the hope to spark some thought. I'll continue refining over time. The thought was to make it a generic "catalogue" which could potentially drive all type definitions, regardless of serialization mechanism. --Udo On 1

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
Correct, The user will not be able to override an existing typeId + type definition. It will fail with the error message that an previous definition already exists. I imagine the process would be to remove a typeId (later feature) which could check if any data exists for that typeId. If no d

Re: Permission to Create JIRA Issues

2016-12-22 Thread Dan Smith
Hi Sarge, I'm a little surprised you weren't able to create an issue actually, because according to what I see in our permissions any jira user ought to be able to create an issue. I went ahead and added you to the contributors group so you should be able to create and assign issues to yourself,

Permission to Create JIRA Issues

2016-12-22 Thread Michael William Dodge
I'd like to create a JIRA issue regarding a problem I've discovered. May I please have permission added for username PivotalSarge? Thanks. Sarge

Re: New proposal for type definitons

2016-12-22 Thread Darrel Schneider
The @refTypeId is hard to understand. It is unclear to me how it interacts with other things like "dataType" and "subType". I think you can either specify a dataType/subType OR a @refTypeId. Is this correct? The current spec makes it look like you can specify both but your example just show one or

Re: New proposal for type definitons

2016-12-22 Thread Darrel Schneider
You proposal seems to be only handle types for JSON. I do not see that you support all the pdx field types. Also you have things like List and "subType" which currently have no support explicit support in the pdx type system. So do you intend this proposal to be specific to JSON? If so the gfsh an

[jira] [Commented] (GEODE-165) Add build support for generating antlr classes from grammar

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771479#comment-15771479 ] ASF subversion and git services commented on GEODE-165: --- Commit 0b021

Re: New proposal for type definitons

2016-12-22 Thread Darrel Schneider
Something I did not see in your proposal was the rules that would be used when a JSON document uses "@typeId" to determine if that type is valid for the current document. For example I think you want to allow the type to have a field that does not exist in the document. I think you also want to say

Re: New proposal for type definitons

2016-12-22 Thread Darrel Schneider
One danger of this solution is users may think they can modify a previously defined type. Since they specify the type they may think they can just edit the file and reload the types with modified definitions. In most cases if data has already been serialized using the old type then modifying the ty

Re: New proposal for type definitons

2016-12-22 Thread Darrel Schneider
When generating a pdx type for a JSON document couldn't we sort the field names from the JSON document so that field order would not generated different pdx types? Also when choosing a pdx field type if we always picked a "wider" type then it would reduce the number of types generated because of di

Re: Review Request 54964: GEODE-2243: reference the formatter relative to geode-core and not the root project

2016-12-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54964/#review160020 --- Ship it! Ship it- this works ... but I wonder if there is a bet

[jira] [Assigned] (GEODE-2240) unexpected NullPointerException from Tombstone service

2016-12-22 Thread Darrel Schneider (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider reassigned GEODE-2240: --- Assignee: Darrel Schneider > unexpected NullPointerException from Tombstone service >

[jira] [Resolved] (GEODE-2240) unexpected NullPointerException from Tombstone service

2016-12-22 Thread Darrel Schneider (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-2240. - Resolution: Fixed Fix Version/s: 1.1.0 > unexpected NullPointerException from Tombs

[jira] [Commented] (GEODE-2240) unexpected NullPointerException from Tombstone service

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771299#comment-15771299 ] ASF subversion and git services commented on GEODE-2240: Commit 81

[jira] [Resolved] (GEODE-2099) Race condition in ConnectToLocatorSSLDUnitTest

2016-12-22 Thread Jinmei Liao (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao resolved GEODE-2099. Resolution: Fixed > Race condition in ConnectToLocatorSSLDUnitTest > ---

[jira] [Updated] (GEODE-2099) Race condition in ConnectToLocatorSSLDUnitTest

2016-12-22 Thread Jinmei Liao (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao updated GEODE-2099: --- Fix Version/s: 1.1.0 > Race condition in ConnectToLocatorSSLDUnitTest > --

[jira] [Commented] (GEODE-2099) Race condition in ConnectToLocatorSSLDUnitTest

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771235#comment-15771235 ] ASF subversion and git services commented on GEODE-2099: Commit 41

Re: Review Request 54948: fix unsafe concurrent mods on expiredTombstones ArrayList

2016-12-22 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54948/#review160009 --- Ship it! Ship It! - anilkumar gingade On Dec. 21, 2016, 9:51

[jira] [Updated] (GEODE-2238) Member may fail to receive cluster configuration from locator

2016-12-22 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-2238: - Assignee: Kirk Lund (was: Dan Smith) > Member may fail to receive cluster configuration from locator > --

[jira] [Commented] (GEODE-2238) Member may fail to receive cluster configuration from locator

2016-12-22 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770954#comment-15770954 ] Dan Smith commented on GEODE-2238: -- I fixed the issues related to the startup message. I

[jira] [Resolved] (GEODE-2242) Destroy operations on PRELOADED regions are not applied in the receiving WAN site

2016-12-22 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby resolved GEODE-2242. -- Resolution: Fixed Fix Version/s: 1.1.0 > Destroy operations on PRELOADED regions are not

Re: Review Request 54916: GEODE-2215: Fixed flakiness of ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/#review159997 --- Fix it, then Ship it! It looks good, but I think we really need

[jira] [Resolved] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-22 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby resolved GEODE-2234. -- Resolution: Fixed Fix Version/s: 1.1.0 > Lucene query hit stats shows number higher than

[jira] [Commented] (GEODE-2242) Destroy operations on PRELOADED regions are not applied in the receiving WAN site

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770890#comment-15770890 ] ASF subversion and git services commented on GEODE-2242: Commit 45

[jira] [Commented] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770889#comment-15770889 ] ASF subversion and git services commented on GEODE-2234: Commit d7

Re: Review Request 54916: GEODE-2215: Fixed flakiness of ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-22 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/ --- (Updated Dec. 22, 2016, 6:38 p.m.) Review request for geode, nabarun nag and Da

Re: Review Request 54945: GEODE-419: Added test to test fail over to javax properties if ssl enabled but relevant properties are not set

2016-12-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54945/#review159990 --- I think you should save the system properties in a @Before and res

Re: New proposal for type definitons

2016-12-22 Thread Udo Kohlmeyer
Hi there Dan, You are correct, the thought is there to add a flag to the registry to indicate that a definition is custom and thus should not conflict with the existing ids. Even if they types were to be stored with the current Pdx type definitions, upon loading/registration of the custom type

[jira] [Resolved] (GEODE-2228) FutureResult.get() does not check for cancellation prior to waiting for a result

2016-12-22 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-2228. - Resolution: Fixed > FutureResult.get() does not check for cancellation prior to waiting f

[jira] [Commented] (GEODE-2238) Member may fail to receive cluster configuration from locator

2016-12-22 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770600#comment-15770600 ] ASF subversion and git services commented on GEODE-2238: Commit f0

[jira] [Resolved] (GEODE-2109) calling submit on ExecutionService can cause exceptions to be lost

2016-12-22 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith resolved GEODE-2109. -- Resolution: Fixed Fix Version/s: 1.1.0 Pull request has been merged, marking this as fixed. > ca

[jira] [Commented] (GEODE-2232) Rename GemFireConfigException

2016-12-22 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770382#comment-15770382 ] Bruce Schuchardt commented on GEODE-2232: - I did some testing to see if renaming G

Re: New proposal for type definitons

2016-12-22 Thread Michael Stolz
+1 for self describing documents -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: 631-835-4771 On Wed, Dec 21, 2016 at 9:20 PM, Dan Smith wrote: > I'm assuming the type ids here are a different set than the type ids used > with regular PDX serialization so they won't conflict i

Jenkins build is back to normal : Geode-nightly #693

2016-12-22 Thread Apache Jenkins Server
See

[jira] [Resolved] (GEODE-165) Add build support for generating antlr classes from grammar

2016-12-22 Thread Avinash Dongre (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avinash Dongre resolved GEODE-165. -- Resolution: Fixed > Add build support for generating antlr classes from grammar > ---

[jira] [Commented] (GEODE-165) Add build support for generating antlr classes from grammar

2016-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769627#comment-15769627 ] ASF GitHub Bot commented on GEODE-165: -- Github user davinash closed the pull request a

[GitHub] geode pull request #322: [GEODE-165] Fix for Add build support for generatin...

2016-12-22 Thread davinash
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena