Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55398/ --- (Updated Jan. 13, 2017, 1:41 a.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-12 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55440/#review161475 --- Ship it! Ship It! - xiaojian zhou On Jan. 12, 2017, 2:08 a.m

Re: Visualize Geode Metrics/Stats with Grafana Dashboards

2017-01-12 Thread Roman Shaposhnik
First of all -- this looks awesome! You're the man! On Wed, Jan 11, 2017 at 3:42 AM, Christian Tzolov wrote: > At the moment the tool uses InfluxDB as a time-series DB. [...] > Another even more interesting angle is to make Geode itself a Grafana > compliant datasource (http://docs.grafana.org/

Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55398/ --- (Updated Jan. 13, 2017, 1:16 a.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55398/ --- (Updated Jan. 13, 2017, 12:50 a.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55398/ --- (Updated Jan. 13, 2017, 12:36 a.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55398/ --- (Updated Jan. 13, 2017, 12:20 a.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Hitesh Khamesra
> On Jan. 12, 2017, 10:55 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java, lines > > 194-197 > > > > > > Maybe this could be a little "smarter". Maybe you have a > >

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-12 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/#review161458 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

[GitHub] geode issue #334: Feature/geode 2031

2017-01-12 Thread karensmolermiller
Github user karensmolermiller commented on the issue: https://github.com/apache/geode/pull/334 +1. LGTM. We can correct anything that goes wrong at deployment of Geode 1.1, when we have more than one version to post. --- If your project is set up for it, you can reply to this emai

[GitHub] geode pull request #336: GEODE-2194: Fix pulse webapp context

2017-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #336: GEODE-2194: Fix pulse webapp context

2017-01-12 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/geode/pull/336 GEODE-2194: Fix pulse webapp context This commit re-adds a line (which turns out to be necessary) that was removed during the review of PR #335. You can merge this pull request into a Git repo

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55389/#review161449 --- geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Hitesh Khamesra
> On Jan. 10, 2017, 9:44 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java, line 104 > > > > > > I don't think you should have this static variable. You should look u

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55389/#review161447 --- geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxIn

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55389/#review161442 --- geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Bruce Schuchardt
> On Jan. 10, 2017, 9:44 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java, line 104 > > > > > > I don't think you should have this static variable. You should look u

Re: Review Request 55389: GEODE-2282 Provide ability to sort field while creating pdxType for jSON document

2017-01-12 Thread Udo Kohlmeyer
> On Jan. 10, 2017, 9:44 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java, line 104 > > > > > > I don't think you should have this static variable. You should look u

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/335#discussion_r95899936 --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml --- @@ -32,7 +32,7 @@ mvc-dispatcher -/pulse/* --- End diff --

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/335#discussion_r95898738 --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml --- @@ -32,7 +32,7 @@ mvc-dispatcher -/pulse/* --- End diff --

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/335#discussion_r95897532 --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml --- @@ -32,7 +32,7 @@ mvc-dispatcher -/pulse/* --- End diff --

Re: Review Request 55398: GEODE-1930: change several Management dunit tests to use ManagementTestRule

2017-01-12 Thread Kirk Lund
> On Jan. 12, 2017, 1:16 a.m., Jared Stewart wrote: > > +1 > > > > I believe `DistributedRunRule` is unused, and `DistributedStatement` is > > only used inside of `DistributedRunRule`. Do you plan to use them later? > > > > It looked to me like RemoteInvoker::invokeEverywhere used to invok

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/335#discussion_r95892864 --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml --- @@ -32,7 +32,7 @@ mvc-dispatcher -/pulse/* --- End diff --

[GitHub] geode pull request #327: GEODE-2236: Remove all cache-listners using Gfsh

2017-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Deploying jars and the class loader

2017-01-12 Thread Kevin Duling
I have been looking in to the behavior of loading classes that have been deployed. When the jar is deployed, the server blindly loads the classes, searching for Geode Functions. Specifically, walks over the classes in the jar, loads each one, and checks to see if both Function and Declarable are

[GitHub] geode issue #335: Pulse fixes

2017-01-12 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/335 Precheckin passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode pull request #335: Pulse fixes

2017-01-12 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/geode/pull/335 Pulse fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaredjstewart/geode pulseFixes Alternatively you can review and apply these ch

Re: ASF Board Report for Geode - Initial Reminder for January 2017

2017-01-12 Thread Anthony Baker
Sounds great, thanks Mark! Anthony > On Jan 12, 2017, at 12:20 PM, Mark Bretl wrote: > > Thanks for your help Anthony. > > I will go ahead and submit this report with the modification we have a new > (Hitesh) release manager for the 1.1.0 release. > > If anyone has additional changes, we can

Re: Apache Geode JIRA maintenance

2017-01-12 Thread Kevin Duling
That happened yesterday, too. On Thu, Jan 12, 2017 at 11:55 AM, Joey McAllister wrote: > FYI: > > "update: issues.a.o is currently rebuilding Jira indexes and will be > unavailable until it's completed. ETA is 4 hours" > 10:27 AM PT - 11 Jan 2017 > https://twitter.com/infrabot/status/81924928361

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-12 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55440/#review161411 --- Fix it, then Ship it! Look good, and maybe this might help fix

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Jared Stewart
Dan and Hitesh - Thank you, this was very informative and exactly what I was looking for. And thank you for clearing up my confusion of PdxSerializable and DataSerializable. - Jared > On Jan 12, 2017, at 12:06 PM, Hitesh Khamesra > wrote: > > Jared: > For new(furture) version we have mechani

Re: ASF Board Report for Geode - Initial Reminder for January 2017

2017-01-12 Thread Mark Bretl
Thanks for your help Anthony. I will go ahead and submit this report with the modification we have a new (Hitesh) release manager for the 1.1.0 release. If anyone has additional changes, we can edit the report until Friday, which is when all project reports begin to be reviewed. One more month a

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Hitesh Khamesra
Jared: For new(furture) version we have mechanism to deal with old version nodes. look InternalDistributedMember class's function (fromDataPre_GFE_7_1_0_0). You can use this mechanism to deal with older version. -Hitesh From: Jared Stewart To: dev@geode.apache.org Sent: Thursday, Ja

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Dan Smith
That Configuration class implements DataSerializable, not PdxSerializable. FYI the PdxReader does have a method to check if a field is present. The way to handle different versions of geode with DataSerializable is to use the versioning support described on this page - https://cwiki.apache.org/co

Apache Geode JIRA maintenance

2017-01-12 Thread Joey McAllister
FYI: "update: issues.a.o is currently rebuilding Jira indexes and will be unavailable until it's completed. ETA is 4 hours" 10:27 AM PT - 11 Jan 2017 https://twitter.com/infrabot/status/819249283618766848

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Anilkumar Gingade
One more option would be, by taking advantage of PDX versioning support...The PDX mechanism can handle multiple versions of the same class, instead of modifying the existing field, you could add a new field with Map typeWhen new locator (with new pdx version) reads the old configuration, it con

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Anilkumar Gingade
Jared, I meant the server/product version number, if it was stored as part of the ClusterConfig definition in the pdx...If its not, we could think about adding one, which could help in the future to identify the version of the cluster configuration saved/created. -Anil. On Thu, Jan 12, 2017 at

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Jared Stewart
Anil - The class does have a serialVersionUID defined, if that’s the type of version number you mean. But the serialVersionUID is not explicitly written out by the toData() method of the class. Could you point me to any examples in the code of checking the version number on a PDX serialized ins

Re: Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Anilkumar Gingade
You can use version numbers, if its available... We use this mechanism in many cases, rolling upgrade(?), Server to client communication... -Anil. On Thu, Jan 12, 2017 at 10:52 AM, Jared Stewart wrote: > Cluster configuration [1] is currently serialized with PDX and stored in > an internal re

Strategy for changing fields in a class serialized with PDX

2017-01-12 Thread Jared Stewart
Cluster configuration [1] is currently serialized with PDX and stored in an internal region that is replicated on all Locators. I would like to change the Configuration class from having a Set jarNames to having a Map jarNamesToJarBytes. However, this would create a problem when a Locator runn

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-12 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/#review161394 --- I'd say actually get rid of the distributed member id part and jus

Build failed in Jenkins: Geode-nightly #714

2017-01-12 Thread Apache Jenkins Server
See Changes: [abarve] GEODE-2049: Replaced unit of measure for all of the tcpfinalCheck [jiliao] GEODE-2261: rename SharedConfig to ClusterConfigurationService [abaker] GEODE-182: Auto-generate member names if needed ---

Review of Pull request #326

2017-01-12 Thread Deepak Dixit
Hello Team, Kindly have a look over the pull request https://github.com/apache/geode/pull/326. This should the fix the JIRA GEODE-2103. Thanks, Deepak

Re: Visualize Geode Metrics/Stats with Grafana Dashboards

2017-01-12 Thread Christian Tzolov
Thanks for the positive feedback! Seems like that the Apache JIRA is down. When they bring it back i will open a JIRA ticket to track the Geode/Grafana integration! @Mike, I fully agree with that "we should start a discussion of exactly what stats should be pulled". At the moment the tool exposes

FOSDEM 2017 Open Source Conference - Brussels

2017-01-12 Thread Sharan F
Hello Everyone This email is to tell you about ASF participation at FOSDEM. The event will be held in Brussels on 4^th & 5^th February 2017 and we are hoping that many people from our ASF projects will be there. https://fosdem.org/2017/ Attending FOSDEM is completely free and the ASF will ag