Feature branch cleanup

[Anthony Baker]

The following 100+ feature branches are related to closed bugs.  I think these 
can safely be deleted (the branch names aren’t exact but pretty close):

GEODE-1017: "Closed"
GEODE-1040: "Closed"
GEODE-1050: "Closed"
GEODE-1056: "Closed"
GEODE-1072: "Closed"
GEODE-1096: "Closed"
GEODE-1109: "Closed"
GEODE-1162: "Closed"
GEODE-1186: "Closed"
GEODE-1199: "Closed"
GEODE-12: "Closed"
GEODE-1204: "Closed"
GEODE-1233: "Closed"
GEODE-124: "Closed"
GEODE-1252: "Closed"
GEODE-1255: "Closed"
GEODE-1257: "Closed"
GEODE-1276: "Closed"
GEODE-1369: "Closed"
GEODE-1370: "Closed"
GEODE-1371: "Closed"
GEODE-1372: "Closed"
GEODE-1374: "Closed"
GEODE-1376: "Closed"
GEODE-1392: "Closed"
GEODE-14: "Closed"
GEODE-14: "Closed"
GEODE-1400: "Closed"
GEODE-1420: "Closed"
GEODE-1426: "Closed"
GEODE-1452: "Closed"
GEODE-1464: "Closed"
GEODE-1493: "Closed"
GEODE-151: "Closed"
GEODE-1565: "Closed"
GEODE-1567: "Closed"
GEODE-1571: "Closed"
GEODE-1573: "Closed"
GEODE-1593: "Closed"
GEODE-160: "Closed"
GEODE-1673: "Closed"
GEODE-17: "Closed"
GEODE-17: "Closed"
GEODE-1701: "Closed"
GEODE-1714: "Closed"
GEODE-1835: "Closed"
GEODE-1861: "Closed"
GEODE-1874: "Closed"
GEODE-1886: "Closed"
GEODE-189: "Closed"
GEODE-1952: "Closed"
GEODE-1952: "Closed"
GEODE-1952: "Closed"
GEODE-1983: "Closed"
GEODE-1985: "Closed"
GEODE-2012: "Closed"
GEODE-2026: "Closed"
GEODE-2104: "Closed"
GEODE-2157: "Closed"
GEODE-217: "Closed"
GEODE-2196: "Closed"
GEODE-2197: "Closed"
GEODE-2207: "Closed"
GEODE-2214: "Closed"
GEODE-227: "Closed"
GEODE-2277: "Closed"
GEODE-2297: "Closed"
GEODE-2297: "Closed"
GEODE-2297: "Closed"
GEODE-233: "Closed"
GEODE-2386: "Closed"
GEODE-280: "Closed"
GEODE-291: "Closed"
GEODE-33: "Closed"
GEODE-37: "Closed"
GEODE-372: "Closed"
GEODE-374: "Closed"
GEODE-377: "Closed"
GEODE-37: "Closed"
GEODE-37: "Closed"
GEODE-38: "Closed"
GEODE-392: "Closed"
GEODE-409: "Closed"
GEODE-41: "Closed"
GEODE-417: "Closed"
GEODE-420: "Closed"
GEODE-52: "Closed"
GEODE-523: "Closed"
GEODE-523: "Closed"
GEODE-53: "Closed"
GEODE-54: "Closed"
GEODE-542: "Closed"
GEODE-544: "Closed"
GEODE-546: "Closed"
GEODE-563: "Closed"
GEODE-564: "Closed"
GEODE-574: "Closed"
GEODE-578: "Closed"
GEODE-580: "Closed"
GEODE-584: "Closed"
GEODE-607: "Closed"
GEODE-608: "Closed"
GEODE-610: "Closed"
GEODE-611: "Closed"
GEODE-622: "Closed"
GEODE-637: "Closed"
GEODE-639: "Closed"
GEODE-678: "Closed"
GEODE-681: "Closed"
GEODE-714: "Closed"
GEODE-715: "Closed"
GEODE-734: "Closed"
GEODE-77: "Closed"
GEODE-773: "Closed"
GEODE-773: "Closed"
GEODE-781: "Closed"
GEODE-805: "Closed"
GEODE-819: "Closed"
GEODE-831: "Closed"
GEODE-835: "Closed"
GEODE-835: "Closed"
GEODE-837: "Closed"
GEODE-840: "Closed"
GEODE-866: "Closed"
GEODE-870: "Closed"
GEODE-917: "Closed"
GEODE-92: "Closed"
GEODE-93: "Closed"
GEODE-949: "Closed"
GEODE-949: "Closed"
GEODE-951: "Closed"
GEODE-953: "Closed"
GEODE-996: "Closed"

Once you’ve merged a feature branch to develop, please make sure to delete the 
remote branch.  If you created one of these branches and you DON”T want it 
deleted, please let me know.  Otherwise I plan to clean these up in a week or 
so.

Anthony

[jira] [Commented] (GEODE-2441) Remove PDXAutoSerializer

[Jacob S. Barrett (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884078#comment-15884078
 ] 

Jacob S. Barrett commented on GEODE-2441:
-

I am still seeing PDX Auto Serializer code in the C++ client. 

- src/pdxautoserializer/ASCLIBuiltins.hpp
- src/cppcache/include/geode/PdxAutoSerializer.hpp
- src/quickstart/cpp/PdxAutoSerializer.cpp 

And referenced in:
- src/tests/cpp/testobject/CMakeLists.txt 
- src/quickstart/cpp/CMakeLists.txt 
- src/quickstart/runcpp.sh.in 
- src/quickstart/runcpp.bat.in 



> Remove PDXAutoSerializer 
> -
>
> Key: GEODE-2441
> URL: https://issues.apache.org/jira/browse/GEODE-2441
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> Remove PDXAutoSerializer utility that generates PDX serialization C++ source 
> that you can include in your project to (de)serialize your C++ classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-2493:

Description: 
Several platform specific locking and CAS operations are implemented in HostAsm 
and related files. These are not portable and require porting efforts. They are 
also not well tested. Converting the C++11 standards allows the compiler to 
choose the code or instructions that optimize the behavior required. Most if 
not all of the functions these files provide can be replaced with C++11 
standard functions.

Some Examples:
On Solaris SPARC we have inline assembly.
On Solaris x86 we use Solaris specific runtime functions.
On Windows we use really old Win32 functions that have some non-standard 
behavior.



  was:
Several platform specific locking and CAS operations are implemented in HostAsm 
and related files. These are not portable and require porting efforts. They are 
also not well tested. Converting the C++11 standards allows the compiler to 
choose the code or instructions that optimize the behavior required. Most if 
not all of the functions these files provide can be replaced with C++11 
standard functions.

Some Examples:
On Solaris SPAC we have inline assembly.
On Solaris x86 we use Solaris specific runtime functions.
On Windows we use really old Win32 functions that have some non-standard 
behavior.




> Replace the locking and CAS operations provided in HostAsm with C++11 
> standards
> ---
>
> Key: GEODE-2493
> URL: https://issues.apache.org/jira/browse/GEODE-2493
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Several platform specific locking and CAS operations are implemented in 
> HostAsm and related files. These are not portable and require porting 
> efforts. They are also not well tested. Converting the C++11 standards allows 
> the compiler to choose the code or instructions that optimize the behavior 
> required. Most if not all of the functions these files provide can be 
> replaced with C++11 standard functions.
> Some Examples:
> On Solaris SPARC we have inline assembly.
> On Solaris x86 we use Solaris specific runtime functions.
> On Windows we use really old Win32 functions that have some non-standard 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

[Jacob S. Barrett (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869213#comment-15869213
 ] 

Jacob S. Barrett edited comment on GEODE-2493 at 2/25/17 6:05 AM:
--

-Replace {{HostAsm::nanoSleep}} and {{ACE_OS::nanosleep}} with 
{{[std::this_thread::sleep_for|http://en.cppreference.com/w/cpp/thread/sleep_for]}}
 using 
{{[std::crono::nanoseconds|http://en.cppreference.com/w/cpp/chrono/duration]}}.-
All uses were eliminated when removing SpinLock.


was (Author: jbarrett):
Replace {{HostAsm::nanoSleep}} and {{ACE_OS::nanosleep}} with 
{{[std::this_thread::sleep_for|http://en.cppreference.com/w/cpp/thread/sleep_for]}}
 using 
{{[std::crono::nanoseconds|http://en.cppreference.com/w/cpp/chrono/duration]}}.

> Replace the locking and CAS operations provided in HostAsm with C++11 
> standards
> ---
>
> Key: GEODE-2493
> URL: https://issues.apache.org/jira/browse/GEODE-2493
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Several platform specific locking and CAS operations are implemented in 
> HostAsm and related files. These are not portable and require porting 
> efforts. They are also not well tested. Converting the C++11 standards allows 
> the compiler to choose the code or instructions that optimize the behavior 
> required. Most if not all of the functions these files provide can be 
> replaced with C++11 standard functions.
> Some Examples:
> On Solaris SPAC we have inline assembly.
> On Solaris x86 we use Solaris specific runtime functions.
> On Windows we use really old Win32 functions that have some non-standard 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2493) Replace the locking and CAS operations provided in HostAsm with C++11 standards

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-2493:

Summary: Replace the locking and CAS operations provided in HostAsm with 
C++11 standards  (was: Replaces the locking and CAS operations provided in 
HostAsm with C++11 standards)

> Replace the locking and CAS operations provided in HostAsm with C++11 
> standards
> ---
>
> Key: GEODE-2493
> URL: https://issues.apache.org/jira/browse/GEODE-2493
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Several platform specific locking and CAS operations are implemented in 
> HostAsm and related files. These are not portable and require porting 
> efforts. They are also not well tested. Converting the C++11 standards allows 
> the compiler to choose the code or instructions that optimize the behavior 
> required. Most if not all of the functions these files provide can be 
> replaced with C++11 standard functions.
> Some Examples:
> On Solaris SPAC we have inline assembly.
> On Solaris x86 we use Solaris specific runtime functions.
> On Windows we use really old Win32 functions that have some non-standard 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884063#comment-15884063
 ] 

ASF GitHub Bot commented on GEODE-2531:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/37

GEODE-2531: Replace HostAsm::atomic with std::atomic.

Focus on commit c3411fd since the others are from pull #36.

Replaces the HostAsm::atomic* functions and ACE::Atomic* templates with 
std::atomic<> template. Removes HostAsm and AtomicInc.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2531

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.

commit c3411fdc3bde88d77dcbdcce183b82d3783010ab
Author: Jacob Barrett 
Date:   2017-02-23T06:38:03Z

GEODE-2531: Replace HostAsm::atomic with std::atomic.




> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #37: GEODE-2531: Replace HostAsm::atomic with std:...

[pivotal-jbarrett]

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/37

GEODE-2531: Replace HostAsm::atomic with std::atomic.

Focus on commit c3411fd since the others are from pull #36.

Replaces the HostAsm::atomic* functions and ACE::Atomic* templates with 
std::atomic<> template. Removes HostAsm and AtomicInc.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2531

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.

commit c3411fdc3bde88d77dcbdcce183b82d3783010ab
Author: Jacob Barrett 
Date:   2017-02-23T06:38:03Z

GEODE-2531: Replace HostAsm::atomic with std::atomic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884057#comment-15884057
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/36

GEODE-2494: Replace SpinLock with spinlock_mutex.

Replaces our non-standard SpinLock with spinlock_mutex that implements the 
C++11 standard BasicLockable. Where applicable the spin lock was completely 
removed and replaced with other thread safe constructs. Singleton protection, 
until singletons are removed entirely, converted to C++11 thread synchronized 
static initialization. Atomic operations converted to std::atomic.

Can I get some reviews form the other C++ contributors before I merge this 
lovely change?

 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2494

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.




> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[pivotal-jbarrett]

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/36

GEODE-2494: Replace SpinLock with spinlock_mutex.

Replaces our non-standard SpinLock with spinlock_mutex that implements the 
C++11 standard BasicLockable. Where applicable the spin lock was completely 
removed and replaced with other thread safe constructs. Singleton protection, 
until singletons are removed entirely, converted to C++11 thread synchronized 
static initialization. Atomic operations converted to std::atomic.

Can I get some reviews form the other C++ contributors before I merge this 
lovely change?

 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2494

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884048#comment-15884048
 ] 

ASF subversion and git services commented on GEODE-2439:


Commit 18d3795fdb15bc2fd572e54bdf29e487a8cc03e7 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=18d3795 ]

GEODE-2439: Fix build breaking merge from merge conflict

This closes #35.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884049#comment-15884049
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/35


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #35: GEODE-2439: Fix build breaking merge from mer...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884046#comment-15884046
 ] 

ASF subversion and git services commented on GEODE-2439:


Commit 9dd03341f3e7a4f8395bf11378f9f19fcb195fda in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=9dd0334 ]

GEODE-2439: Fix build breaking merge from merge conflict


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884043#comment-15884043
 ] 

ASF subversion and git services commented on GEODE-2275:


Commit af2328a79dad6f323350be44b68c33e31b4c3fbf in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=af2328a ]

GEODE-2275: add FlakyTest category to flickering test


> CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM
> ---
>
> Key: GEODE-2275
> URL: https://issues.apache.org/jira/browse/GEODE-2275
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Eric Shu
>  Labels: ci, flaky
>
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest > 
> testPutWithClearDifferentVM FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1.run in VM 0 running 
> on Host d7fcb695b430 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.runLockingTest(ClearTXLockingDUnitTest.java:206)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.performTestAndCheckResults(ClearTXLockingDUnitTest.java:170)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.testPutWithClearDifferentVM(ClearTXLockingDUnitTest.java:115)
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1$$Lambda$21/402256214.run
>  in VM 0 running on Host d7fcb695b430 with 4 VMs
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$$Lambda$24/1595591059.run
>  in VM 1 running on Host d7fcb695b430 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.releaseRegionOperation(ClearTXLockingDUnitTest.java:324)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$100(ClearTXLockingDUnitTest.java:67)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$CommitTestCallback.run(ClearTXLockingDUnitTest.java:408)
> at 
> org.apache.geode.internal.cache.TXState.applyChanges(TXState.java:796)
> at 
> org.apache.geode.internal.cache.TXState.commit(TXState.java:468)
> at 
> org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:254)
> at 
> org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:375)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.doPuts(ClearTXLockingDUnitTest.java:316)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$000(ClearTXLockingDUnitTest.java:67)
> Caused by:
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.lambda$releaseRegionOperation$b6506259$1(ClearTXLockingDUnitTest.java:324)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884033#comment-15884033
 ] 

Kirk Lund commented on GEODE-2275:
--

This reproduced in one of my private precheckin runs. Since there's already a 
ticket filed, I'm going to add FlakyTest category to this test method.


> CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM
> ---
>
> Key: GEODE-2275
> URL: https://issues.apache.org/jira/browse/GEODE-2275
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Eric Shu
>  Labels: ci, flaky
>
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest > 
> testPutWithClearDifferentVM FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1.run in VM 0 running 
> on Host d7fcb695b430 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.runLockingTest(ClearTXLockingDUnitTest.java:206)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.performTestAndCheckResults(ClearTXLockingDUnitTest.java:170)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.testPutWithClearDifferentVM(ClearTXLockingDUnitTest.java:115)
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1$$Lambda$21/402256214.run
>  in VM 0 running on Host d7fcb695b430 with 4 VMs
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$$Lambda$24/1595591059.run
>  in VM 1 running on Host d7fcb695b430 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.releaseRegionOperation(ClearTXLockingDUnitTest.java:324)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$100(ClearTXLockingDUnitTest.java:67)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest$CommitTestCallback.run(ClearTXLockingDUnitTest.java:408)
> at 
> org.apache.geode.internal.cache.TXState.applyChanges(TXState.java:796)
> at 
> org.apache.geode.internal.cache.TXState.commit(TXState.java:468)
> at 
> org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:254)
> at 
> org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:375)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.doPuts(ClearTXLockingDUnitTest.java:316)
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$000(ClearTXLockingDUnitTest.java:67)
> Caused by:
> java.lang.NullPointerException
> at 
> org.apache.geode.internal.cache.ClearTXLockingDUnitTest.lambda$releaseRegionOperation$b6506259$1(ClearTXLockingDUnitTest.java:324)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [DISCUSS] changes to Redis implementation

[Gregory Green]

Hello,

I just push the changes to remove the @author tags and updated the
RegionProviderTest.

On Fri, Feb 24, 2017 at 7:36 PM, Jason Huynh  wrote:

> It looks like travis ci failed on that pr?  Also there are some @author
> tags that should probably be scrubbed out
>
> On Fri, Feb 24, 2017 at 4:33 PM Michael Stolz  wrote:
>
> > +1 experimental means changing. Go for it.
> >
> > --
> > Mike Stolz
> > Principal Engineer - Gemfire Product Manager
> > Mobile: 631-835-4771 <(631)%20835-4771>
> >
> > On Feb 24, 2017 7:30 PM, "Kirk Lund"  wrote:
> >
> > > +1 for merging in these changes even though they break rolling upgrade
> > for
> > > redis storage format -- it should be ok to break API or data format if
> it
> > > was "experimental" in all releases so far
> > >
> > > On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt <
> > bschucha...@pivotal.io>
> > > wrote:
> > >
> > > > Gregory Green has posted a pull request that warrants discussion. It
> > > > improves performance for Sets and Hashes by altering the storage
> format
> > > for
> > > > these collections.  As such it will not permit a rolling upgrade,
> > though
> > > > the Redis adapter is labelled "experimental" so maybe that's okay.
> > > >
> > > > https://github.com/apache/geode/pull/404
> > > >
> > > > The PR also fixes GEODE-2469, inability to handle hash keys having
> > > colons.
> > > >
> > > > There was some discussion about altering the storage format that was
> > > > initiated by Hitesh.  Personally I think Gregory's changes are better
> > > than
> > > > the current implementation and we should accept them, though I
> haven't
> > > gone
> > > > through the code changes extensively.
> > > >
> > > >
> > >
> >
>



-- 
*Gregory Green* (Senior Data Engineer)
ggr...@pivotal.io
201.736.1016

[jira] [Commented] (GEODE-1995) remove ReliableMessageQueueFactory, ReliableMessageQueue, and getReliableMessageQueueFactory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884017#comment-15884017
 ] 

ASF GitHub Bot commented on GEODE-1995:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/315
  
@metatype , @dschneider-pivotal Please let me know if this is good to merge.


> remove ReliableMessageQueueFactory, ReliableMessageQueue, and 
> getReliableMessageQueueFactory
> 
>
> Key: GEODE-1995
> URL: https://issues.apache.org/jira/browse/GEODE-1995
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> ReliableMessageQueueFactory, ReliableMessageQueue, and 
> GemFireCacheImpl.getReliableMessageQueueFactory should all be removed. They 
> are internal and were never used. No tests exist for them.
> They are part of required Roles which is a deprecated feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/315
  
@metatype , @dschneider-pivotal Please let me know if this is good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884015#comment-15884015
 ] 

ASF GitHub Bot commented on GEODE-1887:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/390
  
Thanks @kirklund 
Addressed review comment. Please let me know if this is PR is now good for 
merge.


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #390: [GEODE-1887] #comment Fix Issue Client PROXY region should...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/390
  
Thanks @kirklund 
Addressed review comment. Please let me know if this is PR is now good for 
merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884005#comment-15884005
 ] 

ASF GitHub Bot commented on GEODE-1887:
---

Github user davinash commented on a diff in the pull request:

https://github.com/apache/geode/pull/390#discussion_r103070525
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 ---
@@ -773,6 +755,73 @@ public void 
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
   }
 
 
+  private void proxyRegionClientServerOp(RegionShortcut shortcut) throws 
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r = 
c.createRegionFactory(shortcut).create(REGION_NAME);
+assertNotNull(r);
+return null;
+  }
+});
+
+String host = NetworkUtils.getServerHostName(server1.getHost());
+
+Properties props = new Properties();
+props.setProperty(MCAST_PORT, "0");
+props.setProperty(LOCATORS, "");
+ClientCacheFactory ccf = new ClientCacheFactory(props);
+ccf.addPoolServer(host, PORT1);
+
+ClientCache clientCache = ccf.create();
+Region clientRegion =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY).create(REGION_NAME);
+assertNotNull(clientRegion);
+
+// let us populate this region from client.
+for (int i = 0; i < 10; i++) {
+  clientRegion.put(i, i * 10);
+}
+// Verify using gets
+for (int i = 0; i < 10; i++) {
+  assertEquals(i * 10, clientRegion.get(i));
+}
+assertEquals(10, clientRegion.size());
+assertFalse(clientRegion.isEmpty());
+// delete all the entries from the server
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
--- End diff --

Fixed


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

[davinash]

Github user davinash commented on a diff in the pull request:

https://github.com/apache/geode/pull/390#discussion_r103070525
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 ---
@@ -773,6 +755,73 @@ public void 
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
   }
 
 
+  private void proxyRegionClientServerOp(RegionShortcut shortcut) throws 
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r = 
c.createRegionFactory(shortcut).create(REGION_NAME);
+assertNotNull(r);
+return null;
+  }
+});
+
+String host = NetworkUtils.getServerHostName(server1.getHost());
+
+Properties props = new Properties();
+props.setProperty(MCAST_PORT, "0");
+props.setProperty(LOCATORS, "");
+ClientCacheFactory ccf = new ClientCacheFactory(props);
+ccf.addPoolServer(host, PORT1);
+
+ClientCache clientCache = ccf.create();
+Region clientRegion =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY).create(REGION_NAME);
+assertNotNull(clientRegion);
+
+// let us populate this region from client.
+for (int i = 0; i < 10; i++) {
+  clientRegion.put(i, i * 10);
+}
+// Verify using gets
+for (int i = 0; i < 10; i++) {
+  assertEquals(i * 10, clientRegion.get(i));
+}
+assertEquals(10, clientRegion.size());
+assertFalse(clientRegion.isEmpty());
+// delete all the entries from the server
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
--- End diff --

Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884004#comment-15884004
 ] 

ASF GitHub Bot commented on GEODE-1887:
---

Github user davinash commented on a diff in the pull request:

https://github.com/apache/geode/pull/390#discussion_r103070521
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 ---
@@ -773,6 +755,73 @@ public void 
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
   }
 
 
+  private void proxyRegionClientServerOp(RegionShortcut shortcut) throws 
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
--- End diff --

Fixed.


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

[davinash]

Github user davinash commented on a diff in the pull request:

https://github.com/apache/geode/pull/390#discussion_r103070526
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 ---
@@ -773,6 +755,73 @@ public void 
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
   }
 
 
+  private void proxyRegionClientServerOp(RegionShortcut shortcut) throws 
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r = 
c.createRegionFactory(shortcut).create(REGION_NAME);
+assertNotNull(r);
+return null;
+  }
+});
+
+String host = NetworkUtils.getServerHostName(server1.getHost());
+
+Properties props = new Properties();
+props.setProperty(MCAST_PORT, "0");
+props.setProperty(LOCATORS, "");
+ClientCacheFactory ccf = new ClientCacheFactory(props);
+ccf.addPoolServer(host, PORT1);
+
+ClientCache clientCache = ccf.create();
+Region clientRegion =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY).create(REGION_NAME);
+assertNotNull(clientRegion);
+
+// let us populate this region from client.
+for (int i = 0; i < 10; i++) {
+  clientRegion.put(i, i * 10);
+}
+// Verify using gets
+for (int i = 0; i < 10; i++) {
+  assertEquals(i * 10, clientRegion.get(i));
+}
+assertEquals(10, clientRegion.size());
+assertFalse(clientRegion.isEmpty());
+// delete all the entries from the server
+server1.invoke(new SerializableCallable() {
+  @Override
+  public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r = c.getRegion(REGION_NAME);
+assertNotNull(r);
+for (int i = 0; i < 10; i++) {
+  r.remove(i);
+}
+return null;
+  }
+});
+assertEquals(0, clientRegion.size());
+assertTrue(clientRegion.isEmpty());
+
+clientRegion.destroyRegion();
+clientCache.close();
+  }
+
+  @Test
--- End diff --

Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

[davinash]

Github user davinash commented on a diff in the pull request:

https://github.com/apache/geode/pull/390#discussion_r103070521
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 ---
@@ -773,6 +755,73 @@ public void 
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
   }
 
 
+  private void proxyRegionClientServerOp(RegionShortcut shortcut) throws 
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
--- End diff --

Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883972#comment-15883972
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/388
  
Thanks @metatype and @bschuchardt 
I will fix import issue and check-in the changes to develop, once all the 
checks have passed.


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/388
  
Thanks @metatype and @bschuchardt 
I will fix import issue and check-in the changes to develop, once all the 
checks have passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2460) Update dependency versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883924#comment-15883924
 ] 

ASF subversion and git services commented on GEODE-2460:


Commit 23b7de54226a267e2473f0eb426aa88ea91258b6 in geode's branch 
refs/heads/feature/GEODE-2461 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=23b7de5 ]

GEODE-2460: update dependency versions

* com.fasterxml.jackson.core:jackson-annotation:2.8.6
* com.fasterxml.jackson.core:jackson-core:2.8.6
* com.fasterxml.jackson.core:jackson-databind:2.8.6
* com.fasterxml.jackson.module:jackson-module-scala_2.10:2.8.6
* org.eclipse.persistence:javax.persistence:2.1.1
* org.json4s:json4s-ast_2.10:3.5.0


> Update dependency versions
> --
>
> Key: GEODE-2460
> URL: https://issues.apache.org/jira/browse/GEODE-2460
> Project: Geode
>  Issue Type: Wish
>  Components: build, docs
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the first bunch of dependency version updates that passes precheckin 
> without modifying source code:
> Update the following dependency versions defined in
> gradle/dependency-versions.properties.
> Update major versions (test-only):
> * org.apache.bcel:bcel:6.0
> Update minor versions (test and main):
> * commons-beanutils:1.9.3 
> * commons-fileupload:1.3.2 
> * commons-io:2.5 
> * commons-lang:2.6
> * commons-logging:1.2
> * commons-modeler:2.0.1
> * fastutil:7.0.13
> * guava:21.0
> * jansi:1.14
> * javax.mail-api:1.4.7
> * jline:2.14.3
> * jopt-simple:5.0.3
> * log4j-api:2.7
> * log4j-core:2.7
> * log4j-jcl:2.7
> * log4j-jul:2.7
> * log4j-slf4j-impl:2.7
> * netty-all:4.1.7.Final
> * shiro-core:1.3.2
> * slf4j-api:1.7.22
> Update minor versions (test-only):
> * assertj-core:3.6.2
> * cglib:cglib:3.2.4
> * commons-configuration:1.10
> * derby:10.13.1.1
> * google-gson:2.8.0
> * httpclient:4.5.2
> * httpcore:4.4.6
> * hsqldb:2.3.4
> * javassist:3.21.0-GA
> * jedis:2.9.0
> * JUnitParams:1.0.6
> * mockrunner:1.1.2
> * mortbay-jetty-servlet-api:2.5.20110712
> * phantomjsdriver:1.3.0
> * powermock-core:1.6.6
> * powermock-module-junit4:1.6.6
> * powermock-api-mockito:1.6.6
> * selenium-api:3.0.1
> * selenium-remote-driver:3.0.1
> * selenium-support:3.0.1
> * spymemcached:2.12.2
> * system-rules:1.16.1
> * tomcat-catalina:7.0.73 (tomcat7)
> * tomcat-coyote:7.0.73 (tomcat7)
> * tomcat-juli:7.0.73 (tomcat7)
> * tomcat-catalina:8.5.9 (tomcat8)
> * tomcat-coyote:8.5.9 (tomcat8)
> * tomcat-juli:8.5.9 (tomcat8)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883913#comment-15883913
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user bschuchardt commented on a diff in the pull request:

https://github.com/apache/geode/pull/388#discussion_r103065852
  
--- Diff: geode-core/src/main/java/org/apache/geode/DataSerializer.java ---
@@ -24,23 +24,7 @@
 import java.lang.reflect.Array;
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Comparator;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Hashtable;
-import java.util.IdentityHashMap;
-import java.util.LinkedHashSet;
-import java.util.LinkedList;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
-import java.util.Stack;
-import java.util.TreeMap;
-import java.util.TreeSet;
-import java.util.Vector;
+import java.util.*;
--- End diff --

The intellij formatter does this to you unless you modify it


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883884#comment-15883884
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/35

GEODE-2439: Fix build breaking merge from merge conflict

Build broke after bad merge with commits: GEODE-2439 and GEODE-2440.

Conflict was resolved incorrectly by accidentally removing the signed-ness.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native fix-build-break

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 258c5e39425f00f0dff67776c582811e9274e97f
Author: David Kimura 
Date:   2017-02-25T01:13:13Z

GEODE-2439: Fix build breaking merge from merge conflict




> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #35: GEODE-2439: Fix build breaking merge from mer...

[dgkimura]

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/35

GEODE-2439: Fix build breaking merge from merge conflict

Build broke after bad merge with commits: GEODE-2439 and GEODE-2440.

Conflict was resolved incorrectly by accidentally removing the signed-ness.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native fix-build-break

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 258c5e39425f00f0dff67776c582811e9274e97f
Author: David Kimura 
Date:   2017-02-25T01:13:13Z

GEODE-2439: Fix build breaking merge from merge conflict




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

[Darrel Schneider]

Cache loaders should only be invoked if you do a "get" operation.
In this case you are just registering interest which is not a "get"
operation.
With register interest you are saying "if this key every exists let me
know" and doing that should not cause it to exist.


On Fri, Feb 24, 2017 at 4:21 PM, Michael Stolz  wrote:

> Seems to me this is correct behavior. If you registered a cache loader you
> want it to work
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771
>
> On Feb 24, 2017 5:59 PM, "Barry Oglesby (JIRA)"  wrote:
>
> >
> >  [ https://issues.apache.org/jira/browse/GEODE-2547?page=
> > com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Barry Oglesby reassigned GEODE-2547:
> > 
> >
> > Assignee: Barry Oglesby
> >
> > > Interest registration can cause a CacheLoader to be invoked
> > > ---
> > >
> > > Key: GEODE-2547
> > > URL: https://issues.apache.org/jira/browse/GEODE-2547
> > > Project: Geode
> > >  Issue Type: Bug
> > >  Components: client queues
> > >Reporter: Barry Oglesby
> > >Assignee: Barry Oglesby
> > >
> > > A simple scenario to reproduce this issue is:
> > > - configure a Region with a CacheLoader
> > > - destroy a key (it doesn't matter if the entry exists)
> > > - register interest in that key
> > > The CacheLoader will be invoked
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.15#6346)
> >
>

Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57057/
---

Review request for geode, Barry Oglesby, Jason Huynh, nabarun nag, and xiaojian 
zhou.


Repository: geode


Description
---

Instead of using getAll, fetch the values of a lucene query using a
function that calls getEntry. We can then avoid invoking the cache
loader.


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java
 b50996be8eeb2677537ba7756e33fc199601b3fc 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 cf7b2c9a3e0a78417fa192ceee57441e005536ea 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImpl.java
 5c5d8250cf9c31f0d29964fe5f12f3bae779500d 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/results/LuceneGetPageFunction.java
 PRE-CREATION 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/results/MapResultCollector.java
 PRE-CREATION 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 01bdca40a59422dc0700ff22e867db7717a374ea 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationDUnitTest.java
 cfde4f23305e3e4c6419268d32b04e2c9db4f9db 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneQueryImplJUnitTest.java
 9f826d586479e9e56b9e7130a9f23e7f706693a7 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImplJUnitTest.java
 35a4c9169714ff766a655255d471cb639b7a0404 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/results/LuceneGetPageFunctionTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57057/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

[Kirk Lund]

> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote:
> > +1 I know this change is good and would be safe commit it as is, however we 
> > have been trying to create UnitTests for any class that we touch that 
> > doesn't already have a UnitTest. As a whole, the project relies too much on 
> > end-to-end tests which take forever to run and tend to be more flaky.
> > 
> > So I still recommend trying to write a UnitTest that at a minimum covers 
> > the method you've modified. My definition of UnitTest here is a very fast 
> > test that uses mocking (Mockito) to mock everything this class method 
> > interacts with and the test does not interact with file system or network. 
> > If this method interacts with file system, then there are generally two 
> > choices: test it in an IntegrationTest or refactor the method to allow you 
> > to UnitTest it in isolation from file system. The test class itself has a 
> > JUnit @Category annotation at the top and  the category is either 
> > UnitTest.class or IntegrationTest.class in this case. 
> > 
> > For testing an exception, I recommend using AssertJ:
> > 
> > assertThatThrownBy(() -> 
> > target.callMethodThatThrows()).isInstanceOf(IllegalStateException.class).hasMessageContaining("resourceTypeId").hasMessageContaining("resourceName");
> > 
> > You could instead use .hasMessage("ResourceType is missing for 
> > resourceTypeId xxx, resourceName yyy") but that does tend to make for a 
> > more brittle test.
> 
> Kirk Lund wrote:
> In this case, you could probably just modify 
> StatArchiveWithMissingResourceTypeRegressionTest
> 
> Kirk Lund wrote:
> Also, the travis CI that's hooked up to the github project for geode is 
> executing test but it doesn't run integrationTest or distributedTest. If you 
> run integrationTest, I think you'll see 
> StatArchiveWithMissingResourceTypeRegressionTest fail due to your change. 
> You'll want to update the assertion in this test:
> ```java
>   @Test // fixed GEODE-2013
>   public void throwsIllegalStateExceptionWithMessage() throws Exception {
> assertThatThrownBy(() -> new StatArchiveReader(new File[] 
> {this.archiveFile}, null, true))
> .isExactlyInstanceOf(IllegalStateException.class) // was 
> NullPointerException
> .hasMessage("ResourceType is missing for resourceTypeId 0"); // 
> was null
>   }
> ```
> 
> Srikanth Manvi wrote:
> Hi Kirk,
> 
> Thank you for the comments and background around Unit/Integration test 
> options.
> I ran ./gradlew build, which was successful, hence I submitted a PR and a 
> review request. Later on (many hours after I started precheckin) I noticed 
> that the test you mentioned in 
> StatArchiveWithMissingResourceTypeRegressionTest did fail. I made changes to 
> the test and pushed a new 
> commit(https://github.com/apache/geode/pull/406/commits/56c2a7fce00b5a44d50f1cc8374d1da3ab214344#diff-a74ae4844c1a648682d8a0d297976e31R62).
> I had a feeling that I was making the test brittle by using 
> `.hasMessage("ResourceType is missing for resourceTypeId 0, resourceName 
> statistics1")`;
> but at the same I felt it was not too brittle as the gfs file was picked 
> up from the 
> org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.gfs
>  which hasnt changed since creation. 
> 
> But I agree, your suggestion of using `.hasMessageContaining(...)` , I 
> will incorporate that and will push a new commit.
> 
> If you dont mind I have few questions, apologies if this is not the right 
> place. 
> 
> 1. I pushed 1 commit and raised a PR and then submitted this review 
> request(https://reviews.apache.org/r/56964/). Later on realized that the 
> regression test in StatArchiveWithMissingResourceTypeRegressionTest fails 
> because of my change. Hence pushed 1 more commit (part of the same PR 
> #406[smanvi-pivotal  wants to merge 2 commits into apache:develop from 
> smanvi-pivotal:feature/GEODE-2526]) to fix the test and did not create a new 
> review request. Should every commit(pushed at different times before the PR 
> is closed) in a PR have its own review request ?
> 
> 2. For non-committers isn`t opening a PR in github equivalent to opening 
> a review request in https://reviews.apache.org ? In future should I keep 
> opening review requests along with PRs or is reviews.apache.org mainly for 
> committers ?
> 
> 3. I let my "./gradlew precheckin" execute for about 5 hrs and it was 
> still not complete. Is there anything that I can do to speed it up ? How do 
> regular contributors/committers push multiple commits/day if each commit 
> needs to be preceeded by a succesfull precheckin ?

1. For a PR, I would use a feature/GEODE-nnn branch and use "git rebase -i 
origin/develop" after doing a git fetch to collapse multiple commits into 1 
commit. Since it's your own branch you can then do a "git push --force" and 
this will automatically update the PR 

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883854#comment-15883854
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/388
  
This looks good to me, @bschuchardt what do you think?


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/388
  
This looks good to me, @bschuchardt what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2548) Hang in PaginationDUnitTest.alternativelyCloseDataStoresAfterGettingAPageAndThenValidateTheContentsOfTheResults

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2548:
---
Summary: Hang in 
PaginationDUnitTest.alternativelyCloseDataStoresAfterGettingAPageAndThenValidateTheContentsOfTheResults
  (was: Hang in PaginationDUnitTest.)

> Hang in 
> PaginationDUnitTest.alternativelyCloseDataStoresAfterGettingAPageAndThenValidateTheContentsOfTheResults
> ---
>
> Key: GEODE-2548
> URL: https://issues.apache.org/jira/browse/GEODE-2548
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Jason Huynh
>
> There is possibly a race condition in starting/stopping the caches with 
> persistent regions.
> It appears to hang with this in the logs:
> [vm0] [info 2017/02/24 16:44:56.609 PST  AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE> tid=0x49] Region 
> /region (and any colocated sub-regions) has potentially stale data.  Buckets 
> [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] are waiting for another offline member to 
> recover the latest data.
> [vm0] My persistent id is:
> [vm0]   DiskStore ID: 110901a3-8e42-4d25-a1ee-4ead6f966a29
> [vm0]   Name: 
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm0/.
> [vm0] Offline members with potentially new data:
> [vm0] [
> [vm0]   DiskStore ID: 582f64c5-d53b-463c-a6a5-b4a0bea79381
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm1/.
> [vm0]   Buckets: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
> [vm0] ]
> [vm0] Use the "gfsh show missing-disk-stores" command to see all disk stores 
> that are being waited on by other members.
> [vm0] 19.470: [GC (Allocation Failure) [PSYoungGen: 72510K->9170K(76288K)] 
> 76117K->12784K(251392K), 0.0057840 secs] [Times: user=0.02 sys=0.00, 
> real=0.00 secs] 
> [vm0] [warn 2017/02/24 16:45:03.778 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:45:33.783 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:46:03.786 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:03.791 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:33.794 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:03.796 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:33.799 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:03.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:33.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:50:03.804 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> 

[jira] [Commented] (GEODE-2548) Hang in PaginationDUnitTest.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883850#comment-15883850
 ] 

ASF subversion and git services commented on GEODE-2548:


Commit 2f2562591859348e6127fb4c0e05042c564d55d6 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2f25625 ]

GEODE-2548: Ignoring 
alternativelyCloseDataStoresAfterGettingAPageAndThenValidateTheContentsOfTheResults
 in PaginationDUnitTest


> Hang in PaginationDUnitTest.
> 
>
> Key: GEODE-2548
> URL: https://issues.apache.org/jira/browse/GEODE-2548
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Jason Huynh
>
> There is possibly a race condition in starting/stopping the caches with 
> persistent regions.
> It appears to hang with this in the logs:
> [vm0] [info 2017/02/24 16:44:56.609 PST  AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE> tid=0x49] Region 
> /region (and any colocated sub-regions) has potentially stale data.  Buckets 
> [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] are waiting for another offline member to 
> recover the latest data.
> [vm0] My persistent id is:
> [vm0]   DiskStore ID: 110901a3-8e42-4d25-a1ee-4ead6f966a29
> [vm0]   Name: 
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm0/.
> [vm0] Offline members with potentially new data:
> [vm0] [
> [vm0]   DiskStore ID: 582f64c5-d53b-463c-a6a5-b4a0bea79381
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm1/.
> [vm0]   Buckets: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
> [vm0] ]
> [vm0] Use the "gfsh show missing-disk-stores" command to see all disk stores 
> that are being waited on by other members.
> [vm0] 19.470: [GC (Allocation Failure) [PSYoungGen: 72510K->9170K(76288K)] 
> 76117K->12784K(251392K), 0.0057840 secs] [Times: user=0.02 sys=0.00, 
> real=0.00 secs] 
> [vm0] [warn 2017/02/24 16:45:03.778 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:45:33.783 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:46:03.786 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:03.791 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:33.794 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:03.796 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:33.799 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:03.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:33.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:50:03.804 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] 

[jira] [Commented] (GEODE-2543) Remove incorrectly marked deprecated methods from LuceneService and LuceneQueryFactory api

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883849#comment-15883849
 ] 

ASF subversion and git services commented on GEODE-2543:


Commit 337f5afc0b65a4ee252e84e2cba698820079ab6f in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=337f5af ]

GEODE-2543: Remove incorrectly marked deprecated methods from LuceneService and 
LuceneQueryFactory api


> Remove incorrectly marked deprecated methods from LuceneService and 
> LuceneQueryFactory api
> --
>
> Key: GEODE-2543
> URL: https://issues.apache.org/jira/browse/GEODE-2543
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In the experimental features, we have a few methods marked as deprecated that 
> should either be removed or throw unsupported operation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883846#comment-15883846
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode/pull/388#discussion_r103062905
  
--- Diff: geode-core/src/main/java/org/apache/geode/DataSerializer.java ---
@@ -24,23 +24,7 @@
 import java.lang.reflect.Array;
 import java.net.InetAddress;
 import java.net.UnknownHostException;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Comparator;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Hashtable;
-import java.util.IdentityHashMap;
-import java.util.LinkedHashSet;
-import java.util.LinkedList;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
-import java.util.Stack;
-import java.util.TreeMap;
-import java.util.TreeSet;
-import java.util.Vector;
+import java.util.*;
--- End diff --

I'd prefer to leave this as explicit import statements instead of wildcard 
import.


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2548) Hang in PaginationDUnitTest.

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2548:
---
Issue Type: Test  (was: Bug)

> Hang in PaginationDUnitTest.
> 
>
> Key: GEODE-2548
> URL: https://issues.apache.org/jira/browse/GEODE-2548
> Project: Geode
>  Issue Type: Test
>  Components: lucene
>Reporter: Jason Huynh
>
> There is possibly a race condition in starting/stopping the caches with 
> persistent regions.
> It appears to hang with this in the logs:
> [vm0] [info 2017/02/24 16:44:56.609 PST  AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE> tid=0x49] Region 
> /region (and any colocated sub-regions) has potentially stale data.  Buckets 
> [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] are waiting for another offline member to 
> recover the latest data.
> [vm0] My persistent id is:
> [vm0]   DiskStore ID: 110901a3-8e42-4d25-a1ee-4ead6f966a29
> [vm0]   Name: 
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm0/.
> [vm0] Offline members with potentially new data:
> [vm0] [
> [vm0]   DiskStore ID: 582f64c5-d53b-463c-a6a5-b4a0bea79381
> [vm0]   Location: 
> /192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm1/.
> [vm0]   Buckets: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
> [vm0] ]
> [vm0] Use the "gfsh show missing-disk-stores" command to see all disk stores 
> that are being waited on by other members.
> [vm0] 19.470: [GC (Allocation Failure) [PSYoungGen: 72510K->9170K(76288K)] 
> 76117K->12784K(251392K), 0.0057840 secs] [Times: user=0.02 sys=0.00, 
> real=0.00 secs] 
> [vm0] [warn 2017/02/24 16:45:03.778 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:45:33.783 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:46:03.786 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:03.791 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:47:33.794 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:03.796 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:48:33.799 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:03.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:49:33.802 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks
> [vm0] [warn 2017/02/24 16:50:03.804 PST  
> tid=0x43] Persistent data recovery for region /region is prevented by offline 
> colocated regions
> [vm0] /index#_region.files
> [vm0] /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
> [vm0] /index#_region.chunks



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2548) Hang in PaginationDUnitTest.

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2548:
--

 Summary: Hang in PaginationDUnitTest.
 Key: GEODE-2548
 URL: https://issues.apache.org/jira/browse/GEODE-2548
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: Jason Huynh


There is possibly a race condition in starting/stopping the caches with 
persistent regions.

It appears to hang with this in the logs:
[vm0] [info 2017/02/24 16:44:56.609 PST  tid=0x49] Region 
/region (and any colocated sub-regions) has potentially stale data.  Buckets 
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9] are waiting for another offline member to 
recover the latest data.
[vm0] My persistent id is:
[vm0]   DiskStore ID: 110901a3-8e42-4d25-a1ee-4ead6f966a29
[vm0]   Name: 
[vm0]   Location: 
/192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm0/.

[vm0] Offline members with potentially new data:
[vm0] [
[vm0]   DiskStore ID: 582f64c5-d53b-463c-a6a5-b4a0bea79381
[vm0]   Location: 
/192.168.1.84:/Users/jhuynh/Pivotal/gemfire/scorpion/open/geode-lucene/dunit/vm1/.
[vm0]   Buckets: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
[vm0] ]
[vm0] Use the "gfsh show missing-disk-stores" command to see all disk stores 
that are being waited on by other members.

[vm0] 19.470: [GC (Allocation Failure) [PSYoungGen: 72510K->9170K(76288K)] 
76117K->12784K(251392K), 0.0057840 secs] [Times: user=0.02 sys=0.00, real=0.00 
secs] 
[vm0] [warn 2017/02/24 16:45:03.778 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:45:33.783 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:46:03.786 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:47:03.791 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:47:33.794 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:48:03.796 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:48:33.799 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:49:03.802 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:49:33.802 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks

[vm0] [warn 2017/02/24 16:50:03.804 PST  tid=0x43] 
Persistent data recovery for region /region is prevented by offline colocated 
regions
[vm0]   /index#_region.files
[vm0]   /AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE
[vm0]   /index#_region.chunks



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56991/#review166794
---


Ship it!




Ship It!

- Kirk Lund


On Feb. 24, 2017, 3:12 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56991/
> ---
> 
> (Updated Feb. 24, 2017, 3:12 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I am putting this up for review for now. It's a big changeset which includes 
> the following JIRA tickets: basically it's using replicated region as a 
> communication channel to transfer logs from remote servers to the 
> jmx-manager/locator that initiates this command, and then gather all the logs 
> as a http response to send it back to the gfsh client:
> 
> GEODE-2414: Determine a mechanism to stream a zip file from server to locator
> GEODE-2415: Write a function to return a zip file for a single server
> GEODE-2414: Create exportLogs region for all locators
> GEODE-2418: enable gfsh to download file from http connection
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
>  11d74c13311923357e82318b32bf0342e156e0c6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
>  bbf0542b80469e11d21a2ed56f52ef9e647e91ea 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  b53c53f91ed63a01bfaa1232d9e194481ae45664 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsTest.java
>  PRE-CREATION 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpDunit.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56991/diff/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Kirk Lund]

> On Feb. 24, 2017, 10:58 p.m., Dan Smith wrote:
> > Nice!
> > 
> > I'm a bit confused by the guava dependency. Are you saying that it is a 
> > transitive dependency of something else in geode-core:testCompile, and you 
> > are trying to change the version that is used? If so you should probably 
> > add a comment to that effect so that someone knows why guava is there in 
> > the first place.

We have two tests that use guava APIs.

Geode-junit has one test that uses guava and geode-junit/build.gradle has an 
explicit dependency on com.google.guava:guava:21.0

Geode-core has one test that uses guava but there is no explicit dependency. 
geode-core/build.gradle defines com.pholser:junit-quickcheck-guava:0.7 as a 
dependency which transitively pulls in com.google.guava:guava:19.0

I thought it might be best to specify guava:21.0 in both geode-junit and 
geode-core.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166772
---


On Feb. 24, 2017, 9:37 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57050/
> ---
> 
> (Updated Feb. 24, 2017, 9:37 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, Mark Bretl, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2461: remove unnecessary explicit dependencies
> 
> * activation - transitive via javax.mail-api
> * annotations - unused
> * cdi-api - unused
> * classmate - transitive via springfox (swagger)
> * hadoop - unused
> * hbase - unused
> * hibernate - unused
> * hibernate-commons-annotations - unused
> * hsqldb - unused
> * jline - transtive via spring-shell
> * jsr305 - unused
> * paranamer - transitive via jackson-module-paranamer
> * quartz - unused
> * scala - transitive via jackson-module-scala_2.10
>  
> Add explicit testCompile dependency for guava to geode-core so that tests 
> using guava API in both geode-junit and geode-core are using the same 
> versions.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
>   geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
>   geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
>   gradle/dependency-versions.properties 
> 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 
> 
> Diff: https://reviews.apache.org/r/57050/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/397
  
The test failure doesn't seem to be related to your changes, though you 
need to run `gradlew spotlessApply` to format your PR correctly.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #397: Add junit to try parsing of simple XML file w pool ...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode/pull/397#discussion_r103062304
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java
 ---
@@ -15,19 +15,25 @@
 package org.apache.geode.internal.cache.xmlcache;
 
 import static org.junit.Assert.*;
+import static org.mockito.Mockito.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
 
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.HashMap;
 import java.util.Locale;
+import java.util.Properties;
 
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 
 import org.apache.geode.test.junit.categories.UnitTest;
+import org.apache.geode.distributed.internal.membership.gms.mgr.*;
+import org.apache.geode.distributed.DistributedSystem;
+import org.apache.geode.distributed.internal.*;
--- End diff --

I'd prefer to see explicit import statements rather than wildcard imports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883837#comment-15883837
 ] 

ASF GitHub Bot commented on GEODE-2526:
---

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/406
  
Please update the PR after running `gradlew spotlessApply`.  Thanks for the 
contribution!


> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #406: GEODE-2526: Enhance log statement to include ResourceTypeN...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/406
  
Please update the PR after running `gradlew spotlessApply`.  Thanks for the 
contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/404
  
Thanks for the contribution.  Could you fix the test failure in 
`RegionProviderTest`?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] changes to Redis implementation

[Jason Huynh]

It looks like travis ci failed on that pr?  Also there are some @author
tags that should probably be scrubbed out

On Fri, Feb 24, 2017 at 4:33 PM Michael Stolz  wrote:

> +1 experimental means changing. Go for it.
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771 <(631)%20835-4771>
>
> On Feb 24, 2017 7:30 PM, "Kirk Lund"  wrote:
>
> > +1 for merging in these changes even though they break rolling upgrade
> for
> > redis storage format -- it should be ok to break API or data format if it
> > was "experimental" in all releases so far
> >
> > On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt <
> bschucha...@pivotal.io>
> > wrote:
> >
> > > Gregory Green has posted a pull request that warrants discussion. It
> > > improves performance for Sets and Hashes by altering the storage format
> > for
> > > these collections.  As such it will not permit a rolling upgrade,
> though
> > > the Redis adapter is labelled "experimental" so maybe that's okay.
> > >
> > > https://github.com/apache/geode/pull/404
> > >
> > > The PR also fixes GEODE-2469, inability to handle hash keys having
> > colons.
> > >
> > > There was some discussion about altering the storage format that was
> > > initiated by Hitesh.  Personally I think Gregory's changes are better
> > than
> > > the current implementation and we should accept them, though I haven't
> > gone
> > > through the code changes extensively.
> > >
> > >
> >
>

Re: [DISCUSS] changes to Redis implementation

[Kirk Lund]

+1 for merging in these changes even though they break rolling upgrade for
redis storage format -- it should be ok to break API or data format if it
was "experimental" in all releases so far

On Fri, Feb 24, 2017 at 3:25 PM, Bruce Schuchardt 
wrote:

> Gregory Green has posted a pull request that warrants discussion. It
> improves performance for Sets and Hashes by altering the storage format for
> these collections.  As such it will not permit a rolling upgrade, though
> the Redis adapter is labelled "experimental" so maybe that's okay.
>
> https://github.com/apache/geode/pull/404
>
> The PR also fixes GEODE-2469, inability to handle hash keys having colons.
>
> There was some discussion about altering the storage format that was
> initiated by Hitesh.  Personally I think Gregory's changes are better than
> the current implementation and we should accept them, though I haven't gone
> through the code changes extensively.
>
>

Re: [jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

[Michael Stolz]

Seems to me this is correct behavior. If you registered a cache loader you
want it to work

--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771

On Feb 24, 2017 5:59 PM, "Barry Oglesby (JIRA)"  wrote:

>
>  [ https://issues.apache.org/jira/browse/GEODE-2547?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Barry Oglesby reassigned GEODE-2547:
> 
>
> Assignee: Barry Oglesby
>
> > Interest registration can cause a CacheLoader to be invoked
> > ---
> >
> > Key: GEODE-2547
> > URL: https://issues.apache.org/jira/browse/GEODE-2547
> > Project: Geode
> >  Issue Type: Bug
> >  Components: client queues
> >Reporter: Barry Oglesby
> >Assignee: Barry Oglesby
> >
> > A simple scenario to reproduce this issue is:
> > - configure a Region with a CacheLoader
> > - destroy a key (it doesn't matter if the entry exists)
> > - register interest in that key
> > The CacheLoader will be invoked
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: Review Request 57049: GEODE-2545: NPE during lucene query execution when cache is closing or region is destroyed

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57049/#review166789
---


Ship it!




Ship It!

- Dan Smith


On Feb. 24, 2017, 11:57 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57049/
> ---
> 
> (Updated Feb. 24, 2017, 11:57 p.m.)
> 
> 
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> If the cache is currently closing (cancelled exception) or a region is 
> destroyed, the returned value from the service will be null.  The 
> LuceneQueryFunction should throw an exception and have the function execution 
> service handle re-execution.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
>  e0a0a22 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
>  0d06cab 
> 
> Diff: https://reviews.apache.org/r/57049/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883802#comment-15883802
 ] 

ASF subversion and git services commented on GEODE-2507:


Commit da3767da67afacbfcdc00939fb5ae53f40a36bef in geode's branch 
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=da3767d ]

GEODE-2507 Remove geode-site files

The geode-site files have been moved to a new repo.

This closes #405


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883801#comment-15883801
 ] 

ASF subversion and git services commented on GEODE-2507:


Commit 875ddf89bf008d2f91861981f37083742954ee5a in geode's branch 
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=875ddf8 ]

GEODE-2507 Update LICENSE, rat for removing geode-site

Remove LICENSE references to files used in geode-site.  Update
rat exclusions for same.  No changes needed to NOTICE.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #405: Delete website

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2507.
--
Resolution: Fixed

> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker closed GEODE-2507.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 57049: GEODE-2545: NPE during lucene query execution when cache is closing or region is destroyed

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57049/
---

Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
---

If the cache is currently closing (cancelled exception) or a region is 
destroyed, the returned value from the service will be null.  The 
LuceneQueryFunction should throw an exception and have the function execution 
service handle re-execution.


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
 e0a0a22 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
 0d06cab 

Diff: https://reviews.apache.org/r/57049/diff/


Testing
---


Thanks,

Jason Huynh

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883790#comment-15883790
 ] 

ASF subversion and git services commented on GEODE-2507:


Commit 50c6a513d8d4da405b74460f2060b226cf6dd9cf in geode-site's branch 
refs/heads/master from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode-site.git;h=50c6a51 ]

GEODE-2507 Add gradle tasks for compile and view

Add gradle tasks to make it really simple to compile and view
the website. The gradle task relies on a docker container,
apachegeode/geode-site-build that has the build chain preinstalled.

There's also a preliminary cut at improvements for publishing the
site content.

This closes #1


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-site/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883791#comment-15883791
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-site/pull/1


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103054588
  
--- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp ---
@@ -23,7 +23,7 @@
 #include "CacheableWrapper.hpp"
 extern "C" {
 #include 
-#include 
+#include 
--- End diff --

Need extern C?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883749#comment-15883749
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103054617
  
--- Diff: src/cppcache/src/CacheableBuiltins.cpp ---
@@ -19,7 +19,7 @@
 
 #include 
 extern "C" {
-#include 
+#include 
--- End diff --

Extern C?


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883748#comment-15883748
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103054588
  
--- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp ---
@@ -23,7 +23,7 @@
 #include "CacheableWrapper.hpp"
 extern "C" {
 #include 
-#include 
+#include 
--- End diff --

Need extern C?


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103054617
  
--- Diff: src/cppcache/src/CacheableBuiltins.cpp ---
@@ -19,7 +19,7 @@
 
 #include 
 extern "C" {
-#include 
+#include 
--- End diff --

Extern C?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2486) Developer can use encrypted ciphers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883737#comment-15883737
 ] 

ASF subversion and git services commented on GEODE-2486:


Commit 98b69468f7093c38f357ca671fd08711390020c0 in geode-native's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=98b6946 ]

GEODE-2486 Developer can use encrypted ciphers. Remove an obsolete file, add a 
copyright header to a new file.


> Developer can use encrypted ciphers
> ---
>
> Key: GEODE-2486
> URL: https://issues.apache.org/jira/browse/GEODE-2486
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, native client
>Reporter: Jacob S. Barrett
>
> SSLImpl does not correctly initialize the OpenSSL library so ciphers other 
> than the NULL cipher can be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166772
---


Ship it!




Nice!

I'm a bit confused by the guava dependency. Are you saying that it is a 
transitive dependency of something else in geode-core:testCompile, and you are 
trying to change the version that is used? If so you should probably add a 
comment to that effect so that someone knows why guava is there in the first 
place.

- Dan Smith


On Feb. 24, 2017, 9:37 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57050/
> ---
> 
> (Updated Feb. 24, 2017, 9:37 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, Mark Bretl, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2461: remove unnecessary explicit dependencies
> 
> * activation - transitive via javax.mail-api
> * annotations - unused
> * cdi-api - unused
> * classmate - transitive via springfox (swagger)
> * hadoop - unused
> * hbase - unused
> * hibernate - unused
> * hibernate-commons-annotations - unused
> * hsqldb - unused
> * jline - transtive via spring-shell
> * jsr305 - unused
> * paranamer - transitive via jackson-module-paranamer
> * quartz - unused
> * scala - transitive via jackson-module-scala_2.10
>  
> Add explicit testCompile dependency for guava to geode-core so that tests 
> using guava API in both geode-junit and geode-core are using the same 
> versions.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
>   geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
>   geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
>   gradle/dependency-versions.properties 
> 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 
> 
> Diff: https://reviews.apache.org/r/57050/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Assigned] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reassigned GEODE-2547:


Assignee: Barry Oglesby

> Interest registration can cause a CacheLoader to be invoked
> ---
>
> Key: GEODE-2547
> URL: https://issues.apache.org/jira/browse/GEODE-2547
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> A simple scenario to reproduce this issue is:
> - configure a Region with a CacheLoader
> - destroy a key (it doesn't matter if the entry exists)
> - register interest in that key
> The CacheLoader will be invoked



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #483 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #483 failed.
---
Scheduled
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-483/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

Re: Locators with --bind-address

[Anilkumar Gingade]

Other reasons: one could run multiple locators, and designate one for
client connection and other for jmx.

-Anil.


On Fri, Feb 24, 2017 at 2:20 PM, Galen M O'Sullivan 
wrote:

> I can see that you might want to configure them separately, so it's good to
> have both options.
>
> If I was to design this again, I think I would have the JMX address etc.
> default to the same as the bind address, but as it is that would break
> backwards compatibility.
>
> -Galen
>
> On Fri, Feb 24, 2017 at 1:40 PM, Anilkumar Gingade 
> wrote:
>
> > I believe they need to be separate, which helps to provide better control
> > over application connection (who can connect to what)...
> >
> > They should all have default bind address, right?
> >
> > -Anil.
> >
> >
> > On Fri, Feb 24, 2017 at 12:57 PM, Kevin Duling 
> wrote:
> >
> > > When starting a locator, gfsh has the --bind-address option to tie to a
> > > particular NIC.  E.g.,
> > >
> > > start locator --name=loc-sec
> > > --security-properties-file=./security.properties
> > > --classpath=/Users/kduling/gfsh-security --bind-address=localhost
> > >
> > > This address is the one the server uses to connect with.  It doesn't
> > affect
> > > the JMX address, however.  To do that, one has to do something like
> this:
> > >
> > > gfsh start locator --name=locator1 --bind-address=192.168.1.45
> > > --J=-Dgemfire.jmx-manager-hostname-for-clients=192.168.1.45
> > >
> > > There are several geode tickets that bring this topic up:
> > >
> > > GEODE-2364
> > >
> > > GEODE-746
> > >
> > > GEODE-1515
> > >
> > > My question is, what is the expected behavior when using
> --bind-address?
> > > Should all services bind to that address and then be optionally
> > overridden
> > > by other flags such as --http-service-bind-address and
> > > --hostname-for-clients?
> > >
> >
>

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883628#comment-15883628
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/34

GEODE-2513 Rebrand Delta Propagation section of

Geode Native documentation

- Replace outdated code example with pointer to
docs on updated QuickStart examples
- Update package names
- Cosmetic wording updates

@PivotalSarge @mmartell @davebarnes97 @joeymcallister  
Please review, paying special attention to the namespace updates.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 6b12ae09fb5aeb78efe1996c78075500572dd76c
Author: Karen Miller 
Date:   2017-02-24T21:31:55Z

GEODE-2513 Rebrand Delta Propagation section of
Geode Native documentation

- Replace outdated code example with pointer to
docs on updated QuickStart examples
- Update package names
- Cosmetic wording updates




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #34: GEODE-2513 Rebrand Delta Propagation section ...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/34

GEODE-2513 Rebrand Delta Propagation section of

Geode Native documentation

- Replace outdated code example with pointer to
docs on updated QuickStart examples
- Update package names
- Cosmetic wording updates

@PivotalSarge @mmartell @davebarnes97 @joeymcallister  
Please review, paying special attention to the namespace updates.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 6b12ae09fb5aeb78efe1996c78075500572dd76c
Author: Karen Miller 
Date:   2017-02-24T21:31:55Z

GEODE-2513 Rebrand Delta Propagation section of
Geode Native documentation

- Replace outdated code example with pointer to
docs on updated QuickStart examples
- Update package names
- Cosmetic wording updates




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883624#comment-15883624
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103045677
  
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
 
 #ifdef _WIN32
 
-#include 
-#include 
-#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 
 #endif
 
 #ifdef _SOLARIS
 
-#include 
-#include 
+#include 
--- End diff --

Yeah.  Still kinda messy with all the platform `ifdef`s.  Because this code 
isn't related to public headers, which is the focus of GEODE-2439, I won't 
invest much time in fixing further.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103045677
  
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
 
 #ifdef _WIN32
 
-#include 
-#include 
-#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 
 #endif
 
 #ifdef _SOLARIS
 
-#include 
-#include 
+#include 
--- End diff --

Yeah.  Still kinda messy with all the platform `ifdef`s.  Because this code 
isn't related to public headers, which is the focus of GEODE-2439, I won't 
invest much time in fixing further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Locators with --bind-address

[Galen M O'Sullivan]

I can see that you might want to configure them separately, so it's good to
have both options.

If I was to design this again, I think I would have the JMX address etc.
default to the same as the bind address, but as it is that would break
backwards compatibility.

-Galen

On Fri, Feb 24, 2017 at 1:40 PM, Anilkumar Gingade 
wrote:

> I believe they need to be separate, which helps to provide better control
> over application connection (who can connect to what)...
>
> They should all have default bind address, right?
>
> -Anil.
>
>
> On Fri, Feb 24, 2017 at 12:57 PM, Kevin Duling  wrote:
>
> > When starting a locator, gfsh has the --bind-address option to tie to a
> > particular NIC.  E.g.,
> >
> > start locator --name=loc-sec
> > --security-properties-file=./security.properties
> > --classpath=/Users/kduling/gfsh-security --bind-address=localhost
> >
> > This address is the one the server uses to connect with.  It doesn't
> affect
> > the JMX address, however.  To do that, one has to do something like this:
> >
> > gfsh start locator --name=locator1 --bind-address=192.168.1.45
> > --J=-Dgemfire.jmx-manager-hostname-for-clients=192.168.1.45
> >
> > There are several geode tickets that bring this topic up:
> >
> > GEODE-2364
> >
> > GEODE-746
> >
> > GEODE-1515
> >
> > My question is, what is the expected behavior when using --bind-address?
> > Should all services bind to that address and then be optionally
> overridden
> > by other flags such as --http-service-bind-address and
> > --hostname-for-clients?
> >
>

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883613#comment-15883613
 ] 

ASF GitHub Bot commented on GEODE-2439:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103044451
  
--- Diff: src/cppcache/src/Utils.cpp ---
@@ -22,7 +22,7 @@
 #include 
 
 extern "C" {
-#include 
+#include 
--- End diff --

Unlikely. Removed now.


> Replace all non-standard types in all public includes / API
> ---
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #32: GEODE-2439: Replace c-style headers with c++ ...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/32#discussion_r103044451
  
--- Diff: src/cppcache/src/Utils.cpp ---
@@ -22,7 +22,7 @@
 #include 
 
 extern "C" {
-#include 
+#include 
--- End diff --

Unlikely. Removed now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2546:
-
Labels: Flaky  (was: )

> RollingUpgradeDUnitTest fails intermittently with 
> ClusterConfigurationNotAvailableException
> ---
>
> Key: GEODE-2546
> URL: https://issues.apache.org/jira/browse/GEODE-2546
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, tests
>Reporter: Kirk Lund
>  Labels: Flaky
>
> This test might be hitting GEODE-2238. If we change the test to await cluster 
> config readiness it should fix this.
> {noformat}
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest > 
> testRollServersOnPartitionedRegion_dataserializable[1] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest$3.run 
> in VM 0 running on Host e41dd4960b22 with 4 VMs with version 110
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at 
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.invokeRunnableInVMs(RollingUpgradeDUnitTest.java:333)
> at 
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.doTestRollAll(RollingUpgradeDUnitTest.java:177)
> at 
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.testRollServersOnPartitionedRegion_dataserializable(RollingUpgradeDUnitTest.java:129)
> Caused by:
> java.lang.RuntimeException: 
> java.lang.reflect.InvocationTargetException
> Caused by:
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.createCache(RollingUpgradeDUnitTest.java:722)
> Caused by:
> org.apache.geode.GemFireConfigException: cluster 
> configuration service not available
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.requestSharedConfiguration(GemFireCacheImpl.java:1067)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1200)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:798)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:783)
> at 
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:178)
> at 
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:218)
> ... 5 more
> Caused by:
> 
> org.apache.geode.internal.process.ClusterConfigurationNotAvailableException: 
> Unable to retrieve cluster configuration from the locator.
> at 
> org.apache.geode.internal.cache.ClusterConfigurationLoader.requestConfigurationFromLocators(ClusterConfigurationLoader.java:245)
> at 
> org.apache.geode.internal.cache.GemFireCacheImpl.requestSharedConfiguration(GemFireCacheImpl.java:1029)
> ... 10 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2546) RollingUpgradeDUnitTest fails intermittently with ClusterConfigurationNotAvailableException

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2546:


 Summary: RollingUpgradeDUnitTest fails intermittently with 
ClusterConfigurationNotAvailableException
 Key: GEODE-2546
 URL: https://issues.apache.org/jira/browse/GEODE-2546
 Project: Geode
  Issue Type: Bug
  Components: configuration, tests
Reporter: Kirk Lund


This test might be hitting GEODE-2238. If we change the test to await cluster 
config readiness it should fix this.
{noformat}
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest > 
testRollServersOnPartitionedRegion_dataserializable[1] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest$3.run in 
VM 0 running on Host e41dd4960b22 with 4 VMs with version 110
at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
at 
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.invokeRunnableInVMs(RollingUpgradeDUnitTest.java:333)
at 
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.doTestRollAll(RollingUpgradeDUnitTest.java:177)
at 
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.testRollServersOnPartitionedRegion_dataserializable(RollingUpgradeDUnitTest.java:129)

Caused by:
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException

Caused by:
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest.createCache(RollingUpgradeDUnitTest.java:722)

Caused by:
org.apache.geode.GemFireConfigException: cluster configuration 
service not available
at 
org.apache.geode.internal.cache.GemFireCacheImpl.requestSharedConfiguration(GemFireCacheImpl.java:1067)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1200)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:798)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:783)
at 
org.apache.geode.cache.CacheFactory.create(CacheFactory.java:178)
at 
org.apache.geode.cache.CacheFactory.create(CacheFactory.java:218)
... 5 more

Caused by:

org.apache.geode.internal.process.ClusterConfigurationNotAvailableException: 
Unable to retrieve cluster configuration from the locator.
at 
org.apache.geode.internal.cache.ClusterConfigurationLoader.requestConfigurationFromLocators(ClusterConfigurationLoader.java:245)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.requestSharedConfiguration(GemFireCacheImpl.java:1029)
... 10 more
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166763
---


Ship it!




Ship It!

- Ken Howe


On Feb. 24, 2017, 9:37 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57050/
> ---
> 
> (Updated Feb. 24, 2017, 9:37 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, Mark Bretl, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2461: remove unnecessary explicit dependencies
> 
> * activation - transitive via javax.mail-api
> * annotations - unused
> * cdi-api - unused
> * classmate - transitive via springfox (swagger)
> * hadoop - unused
> * hbase - unused
> * hibernate - unused
> * hibernate-commons-annotations - unused
> * hsqldb - unused
> * jline - transtive via spring-shell
> * jsr305 - unused
> * paranamer - transitive via jackson-module-paranamer
> * quartz - unused
> * scala - transitive via jackson-module-scala_2.10
>  
> Add explicit testCompile dependency for guava to geode-core so that tests 
> using guava API in both geode-junit and geode-core are using the same 
> versions.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
>   geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
>   geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
>   gradle/dependency-versions.properties 
> 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 
> 
> Diff: https://reviews.apache.org/r/57050/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883594#comment-15883594
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103041344
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

Sounds good.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[scmbuildguy]

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103041344
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

Sounds good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Mark Bretl]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166762
---


Ship it!




Ship It!

- Mark Bretl


On Feb. 24, 2017, 1:37 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57050/
> ---
> 
> (Updated Feb. 24, 2017, 1:37 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, Mark Bretl, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2461: remove unnecessary explicit dependencies
> 
> * activation - transitive via javax.mail-api
> * annotations - unused
> * cdi-api - unused
> * classmate - transitive via springfox (swagger)
> * hadoop - unused
> * hbase - unused
> * hibernate - unused
> * hibernate-commons-annotations - unused
> * hsqldb - unused
> * jline - transtive via spring-shell
> * jsr305 - unused
> * paranamer - transitive via jackson-module-paranamer
> * quartz - unused
> * scala - transitive via jackson-module-scala_2.10
>  
> Add explicit testCompile dependency for guava to geode-core so that tests 
> using guava API in both geode-junit and geode-core are using the same 
> versions.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
>   geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
>   geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
>   gradle/dependency-versions.properties 
> 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 
> 
> Diff: https://reviews.apache.org/r/57050/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166761
---


Ship it!




Ship It!

- Kevin Duling


On Feb. 24, 2017, 1:37 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57050/
> ---
> 
> (Updated Feb. 24, 2017, 1:37 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
> Duling, Ken Howe, Mark Bretl, and Dan Smith.
> 
> 
> Bugs: GEODE-2461
> https://issues.apache.org/jira/browse/GEODE-2461
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2461: remove unnecessary explicit dependencies
> 
> * activation - transitive via javax.mail-api
> * annotations - unused
> * cdi-api - unused
> * classmate - transitive via springfox (swagger)
> * hadoop - unused
> * hbase - unused
> * hibernate - unused
> * hibernate-commons-annotations - unused
> * hsqldb - unused
> * jline - transtive via spring-shell
> * jsr305 - unused
> * paranamer - transitive via jackson-module-paranamer
> * quartz - unused
> * scala - transitive via jackson-module-scala_2.10
>  
> Add explicit testCompile dependency for guava to geode-core so that tests 
> using guava API in both geode-junit and geode-core are using the same 
> versions.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
>   geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
>   geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
>   gradle/dependency-versions.properties 
> 5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 
> 
> Diff: https://reviews.apache.org/r/57050/diff/
> 
> 
> Testing
> ---
> 
> precheckin passed (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2460) Update dependency versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883583#comment-15883583
 ] 

ASF subversion and git services commented on GEODE-2460:


Commit dcc21101ecf02a4113b98e70d794cea3666bf529 in geode's branch 
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=dcc2110 ]

GEODE-2460 Use correct version of commons-beanutils

Add an explicit dependency on commons-beanutils since shiro is
transitively pulling in an old version, different from the one we
specificy in dependency-versions.properties.


> Update dependency versions
> --
>
> Key: GEODE-2460
> URL: https://issues.apache.org/jira/browse/GEODE-2460
> Project: Geode
>  Issue Type: Wish
>  Components: build, docs
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the first bunch of dependency version updates that passes precheckin 
> without modifying source code:
> Update the following dependency versions defined in
> gradle/dependency-versions.properties.
> Update major versions (test-only):
> * org.apache.bcel:bcel:6.0
> Update minor versions (test and main):
> * commons-beanutils:1.9.3 
> * commons-fileupload:1.3.2 
> * commons-io:2.5 
> * commons-lang:2.6
> * commons-logging:1.2
> * commons-modeler:2.0.1
> * fastutil:7.0.13
> * guava:21.0
> * jansi:1.14
> * javax.mail-api:1.4.7
> * jline:2.14.3
> * jopt-simple:5.0.3
> * log4j-api:2.7
> * log4j-core:2.7
> * log4j-jcl:2.7
> * log4j-jul:2.7
> * log4j-slf4j-impl:2.7
> * netty-all:4.1.7.Final
> * shiro-core:1.3.2
> * slf4j-api:1.7.22
> Update minor versions (test-only):
> * assertj-core:3.6.2
> * cglib:cglib:3.2.4
> * commons-configuration:1.10
> * derby:10.13.1.1
> * google-gson:2.8.0
> * httpclient:4.5.2
> * httpcore:4.4.6
> * hsqldb:2.3.4
> * javassist:3.21.0-GA
> * jedis:2.9.0
> * JUnitParams:1.0.6
> * mockrunner:1.1.2
> * mortbay-jetty-servlet-api:2.5.20110712
> * phantomjsdriver:1.3.0
> * powermock-core:1.6.6
> * powermock-module-junit4:1.6.6
> * powermock-api-mockito:1.6.6
> * selenium-api:3.0.1
> * selenium-remote-driver:3.0.1
> * selenium-support:3.0.1
> * spymemcached:2.12.2
> * system-rules:1.16.1
> * tomcat-catalina:7.0.73 (tomcat7)
> * tomcat-coyote:7.0.73 (tomcat7)
> * tomcat-juli:7.0.73 (tomcat7)
> * tomcat-catalina:8.5.9 (tomcat8)
> * tomcat-coyote:8.5.9 (tomcat8)
> * tomcat-juli:8.5.9 (tomcat8)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103040225
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
--- End diff --

You might be able to run under cygwin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883582#comment-15883582
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103040225
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
--- End diff --

You might be able to run under cygwin.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883576#comment-15883576
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103039387
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

I thought about that, but I'm hesitant to go all the way (git 
add/commit/push) since that would require a clean workspace and we'd have to 
figure out `git rm` cases.  At least this can be used as a starting point and 
is less confusing than the prior `tar` instructions. 


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883577#comment-15883577
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103039403
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
+
+To generate the site locally, you need to install java and docker. 
+
+## How to change/update the website
+
+### 1. Find and edit the source files you need to change
+
+Source files for the website are in ``website/content``.  When changing 
the content of the site, find the Markdown files that you
+need to edit and make your change. If you need to change the layout or 
styling of the site, then you will probably need to change
+an HTML, JS or CSS file.
+
+### 2. Locally generate the site and test your changes
+
+To generate the site content, run the `nanoc` compiler:
+
+$ ./gradlew compile
+
+To view the generated site, run:
+
+$ ./gradlew view
+
+and point your browser at `http://localhost:3000`. To make further 
changes, stop the build, edit files, recompile, and view again.
+
+### 3. Publish your changes to the site
+
+Once you are happy with your changes, commit them to the __master__ branch.
+The changes also need to be propagated to the __asf-site__ branch. Run the
+gradle command
+
+$ ./gradlew publish
+
+to checkout the __asf-site__ branch and copy the website files.  You will
+need to manually commit and push your changes on the __asf-site__ branch.
+
+The site should update in 5-10 minutes. If it does not, 
--- End diff --

Thanks!


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103039403
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
+
+To generate the site locally, you need to install java and docker. 
+
+## How to change/update the website
+
+### 1. Find and edit the source files you need to change
+
+Source files for the website are in ``website/content``.  When changing 
the content of the site, find the Markdown files that you
+need to edit and make your change. If you need to change the layout or 
styling of the site, then you will probably need to change
+an HTML, JS or CSS file.
+
+### 2. Locally generate the site and test your changes
+
+To generate the site content, run the `nanoc` compiler:
+
+$ ./gradlew compile
+
+To view the generated site, run:
+
+$ ./gradlew view
+
+and point your browser at `http://localhost:3000`. To make further 
changes, stop the build, edit files, recompile, and view again.
+
+### 3. Publish your changes to the site
+
+Once you are happy with your changes, commit them to the __master__ branch.
+The changes also need to be propagated to the __asf-site__ branch. Run the
+gradle command
+
+$ ./gradlew publish
+
+to checkout the __asf-site__ branch and copy the website files.  You will
+need to manually commit and push your changes on the __asf-site__ branch.
+
+The site should update in 5-10 minutes. If it does not, 
--- End diff --

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103039387
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

I thought about that, but I'm hesitant to go all the way (git 
add/commit/push) since that would require a clean workspace and we'd have to 
figure out `git rm` cases.  At least this can be used as a starting point and 
is less confusing than the prior `tar` instructions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/
---

Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Kevin 
Duling, Ken Howe, Mark Bretl, and Dan Smith.


Bugs: GEODE-2461
https://issues.apache.org/jira/browse/GEODE-2461


Repository: geode


Description
---

GEODE-2461: remove unnecessary explicit dependencies

* activation - transitive via javax.mail-api
* annotations - unused
* cdi-api - unused
* classmate - transitive via springfox (swagger)
* hadoop - unused
* hbase - unused
* hibernate - unused
* hibernate-commons-annotations - unused
* hsqldb - unused
* jline - transtive via spring-shell
* jsr305 - unused
* paranamer - transitive via jackson-module-paranamer
* quartz - unused
* scala - transitive via jackson-module-scala_2.10
 
Add explicit testCompile dependency for guava to geode-core so that tests using 
guava API in both geode-junit and geode-core are using the same versions.


Diffs
-

  geode-assembly/build.gradle 3452141b030e12a5dd0bbb130b6a6a47707b7cef 
  geode-core/build.gradle 8eba6d4e8f9c6b021b214171bac5e360a0c86e7a 
  geode-web-api/build.gradle 9c491a0d9250dfe0aa089f61a8e4148acdeec5a3 
  gradle/dependency-versions.properties 
5153f0b1bde2cec3d54354b5075ba069cfbf1ab6 

Diff: https://reviews.apache.org/r/57050/diff/


Testing
---

precheckin passed (100% green)


Thanks,

Kirk Lund

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883565#comment-15883565
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103036769
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

Should the publish task also do the 'push' as well? When I think I am going 
to publish something, I would think it do all the steps.


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883566#comment-15883566
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103036407
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
+
+To generate the site locally, you need to install java and docker. 
+
+## How to change/update the website
+
+### 1. Find and edit the source files you need to change
+
+Source files for the website are in ``website/content``.  When changing 
the content of the site, find the Markdown files that you
+need to edit and make your change. If you need to change the layout or 
styling of the site, then you will probably need to change
+an HTML, JS or CSS file.
+
+### 2. Locally generate the site and test your changes
+
+To generate the site content, run the `nanoc` compiler:
+
+$ ./gradlew compile
+
+To view the generated site, run:
+
+$ ./gradlew view
+
+and point your browser at `http://localhost:3000`. To make further 
changes, stop the build, edit files, recompile, and view again.
+
+### 3. Publish your changes to the site
+
+Once you are happy with your changes, commit them to the __master__ branch.
+The changes also need to be propagated to the __asf-site__ branch. Run the
+gradle command
+
+$ ./gradlew publish
+
+to checkout the __asf-site__ branch and copy the website files.  You will
+need to manually commit and push your changes on the __asf-site__ branch.
+
+The site should update in 5-10 minutes. If it does not, 
--- End diff --

Earlier in the document it states update will have in 5-20 minutes, looking 
for consistency


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Locators with --bind-address

[Anilkumar Gingade]

I believe they need to be separate, which helps to provide better control
over application connection (who can connect to what)...

They should all have default bind address, right?

-Anil.


On Fri, Feb 24, 2017 at 12:57 PM, Kevin Duling  wrote:

> When starting a locator, gfsh has the --bind-address option to tie to a
> particular NIC.  E.g.,
>
> start locator --name=loc-sec
> --security-properties-file=./security.properties
> --classpath=/Users/kduling/gfsh-security --bind-address=localhost
>
> This address is the one the server uses to connect with.  It doesn't affect
> the JMX address, however.  To do that, one has to do something like this:
>
> gfsh start locator --name=locator1 --bind-address=192.168.1.45
> --J=-Dgemfire.jmx-manager-hostname-for-clients=192.168.1.45
>
> There are several geode tickets that bring this topic up:
>
> GEODE-2364
>
> GEODE-746
>
> GEODE-1515
>
> My question is, what is the expected behavior when using --bind-address?
> Should all services bind to that address and then be optionally overridden
> by other flags such as --http-service-bind-address and
> --hostname-for-clients?
>

[jira] [Commented] (GEODE-2507) Acquire and populate new geode-site repo for the web site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883564#comment-15883564
 ] 

ASF GitHub Bot commented on GEODE-2507:
---

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103038157
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
--- End diff --

Looks like Bash is needed, so does that mean this is linux flavors only?


> Acquire and populate new geode-site repo for the web site
> -
>
> Key: GEODE-2507
> URL: https://issues.apache.org/jira/browse/GEODE-2507
> Project: Geode
>  Issue Type: New Feature
>  Components: web-content
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Move the web site content to its own repo.
> 1. Acquire the repo.  Name it geode-site.
> 2. Populate the repo with the current web site's contents on the master branch
> 3. Request that the asf-site branch be switched from the geode repo to this 
> new geode-site repo, and test that everything works
> 4. Update the contents of LICENSE files for geode and geode-site
> 5. Setup auto-publish by creating an INFRA JIRA ticket
> 6. Revise README for publishing instructions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[scmbuildguy]

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103036407
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
+
+To generate the site locally, you need to install java and docker. 
+
+## How to change/update the website
+
+### 1. Find and edit the source files you need to change
+
+Source files for the website are in ``website/content``.  When changing 
the content of the site, find the Markdown files that you
+need to edit and make your change. If you need to change the layout or 
styling of the site, then you will probably need to change
+an HTML, JS or CSS file.
+
+### 2. Locally generate the site and test your changes
+
+To generate the site content, run the `nanoc` compiler:
+
+$ ./gradlew compile
+
+To view the generated site, run:
+
+$ ./gradlew view
+
+and point your browser at `http://localhost:3000`. To make further 
changes, stop the build, edit files, recompile, and view again.
+
+### 3. Publish your changes to the site
+
+Once you are happy with your changes, commit them to the __master__ branch.
+The changes also need to be propagated to the __asf-site__ branch. Run the
+gradle command
+
+$ ./gradlew publish
+
+to checkout the __asf-site__ branch and copy the website files.  You will
+need to manually commit and push your changes on the __asf-site__ branch.
+
+The site should update in 5-10 minutes. If it does not, 
--- End diff --

Earlier in the document it states update will have in 5-20 minutes, looking 
for consistency


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[scmbuildguy]

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103036769
  
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
  */
 
 plugins {
-  id "org.nosphere.apache.rat" version "0.3.0"
+  id 'org.nosphere.apache.rat' version '0.3.0'
+  id 'org.ajoberstar.grgit' version '1.6.0'
 }
 
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+  delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w 
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+  inputs.dir "${projectDir}/website"
+  outputs.dir "${buildDir}/content"
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+  executable 'bash'
+  args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --

Should the publish task also do the 'push' as well? When I think I am going 
to publish something, I would think it do all the steps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

[scmbuildguy]

Github user scmbuildguy commented on a diff in the pull request:

https://github.com/apache/geode-site/pull/1#discussion_r103038157
  
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
 [![Build 
Status](https://travis-ci.org/apache/geode-site.svg?branch=master)](https://travis-ci.org/apache/geode-site)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
 
 # Apache Geode Site
+
+This directory contains the source files for the project 
[website](https://geode.apache.org). Website content is written in 
[Markdown](https://help.github.com/articles/markdown-basics) and the site files 
are generated from that source by a tool called 
[Pandoc](http://johnmacfarlane.net/pandoc).
+
+Source files for the website are in `website/content`. Generated files for 
the website are in `build/content`.
+
+**NOTE:** To make changes to the [Apache Geode User 
Guide](http://geode.apache.org/docs/), which is published to the website:
+
+- Review 
[CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md)
 for information about contributing to the documentation source files.
+- Follow the 
[README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for 
information about building a local version of the guide and adding it to the 
website.
+
+The website is updated by a "sync" tool that monitors the __asf-site__ 
branch 
+of our Git repo, so after making changes you must place your updated source
+and generated files on the __asf-site__ branch and push.
+The content will be published to the
+[Geode website](http://geode.apache.org) after a 5-20 minute delay.
+
+## Prerequisites
--- End diff --

Looks like Bash is needed, so does that mean this is linux flavors only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---