[jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024031#comment-16024031
 ] 

ASF GitHub Bot commented on GEODE-2986:
---

Github user AkihiroKitada commented on the issue:

https://github.com/apache/geode/pull/534
  
Create by mistake. Close this one.


> Need not to log message when executing "gfsh compact disk-store" command 
> successfully
> -
>
> Key: GEODE-2986
> URL: https://issues.apache.org/jira/browse/GEODE-2986
> Project: Geode
>  Issue Type: Wish
>  Components: persistence
>Reporter: Akihiro Kitada
>
> When executing "gfsh compact disk-store" command, then we currently see the 
> following kind of message if the command is successfully executed for all the 
> target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not 
> send to null
> {noformat}
> This message is not friendly to know what was going on.
> Need not to log such kind of message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #534: GEODE-2986: Added null check to log message

[AkihiroKitada]

Github user AkihiroKitada closed the pull request at:

https://github.com/apache/geode/pull/534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #534: GEODE-2986: Added null check to log message

[AkihiroKitada]

Github user AkihiroKitada commented on the issue:

https://github.com/apache/geode/pull/534
  
Create by mistake. Close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024028#comment-16024028
 ] 

ASF GitHub Bot commented on GEODE-2962:
---

GitHub user AkihiroKitada opened a pull request:

https://github.com/apache/geode/pull/534

GEODE-2962: Added null check to log message

Just log message if "notExecutedMembers" is not null and not empty.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2986

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #534


commit 03e15324fe97db08395250261a9cacaced16b816
Author: Akihiro Kitada 
Date:   2017-05-25T01:48:14Z

GEODE-2962: Added null check to log message

Just log message if "notExecutedMembers" is not null and not empty.




> Need more friendly locator's log message when executing "gfsh compact 
> disk-store" command
> -
>
> Key: GEODE-2962
> URL: https://issues.apache.org/jira/browse/GEODE-2962
> Project: Geode
>  Issue Type: Wish
>  Components: persistence
>Reporter: Akihiro Kitada
>Priority: Minor
>
> When executing "gfsh compact disk-store" command, then we currently see the 
> following kind of issue if the command is successfully executed for all the 
> target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not 
> send to null
> {noformat}
> This message is not friendly to know what was going on.
> Need more friendly log message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: What to do with the geode-spark-connector

[Kirk Lund]

+1 for A

On Wed, May 24, 2017 at 5:50 PM, Jianxia Chen  wrote:

> I prefer option A: Move it into it's own repository, with it's own release
> cycle.
>
> On Wed, May 24, 2017 at 5:17 PM, Dan Smith  wrote:
>
> > Our geode-spark-connector needs some work. It's currently building
> against
> > geode 1.0.0-incubating, because it has it's own separate build process.
> > It's also somewhat out of date, we're building against spark 1.3. Is
> anyone
> > actually using the spark connector?
> >
> > I think we need to get the spark connector out of the main geode repo
> since
> > people are currently modifying code in the connector without even
> compiling
> > it, since it's not linked into the gradle build.
> >
> > What do the geode devs think we should do with the geode-spark-connector?
> >
> > A) Move it into it's own repository, with it's own release cycle
> > B) Delete it
> > C) Other??
> >
> > -Dan
> >
>

[jira] [Created] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

[Akihiro Kitada (JIRA)]

Akihiro Kitada created GEODE-2986:
-

 Summary: Need not to log message when executing "gfsh compact 
disk-store" command successfully
 Key: GEODE-2986
 URL: https://issues.apache.org/jira/browse/GEODE-2986
 Project: Geode
  Issue Type: Wish
  Components: persistence
Reporter: Akihiro Kitada


When executing "gfsh compact disk-store" command, then we currently see the 
following kind of message if the command is successfully executed for all the 
target members.

{noformat}
compact disk-store "DEFAULT" message was scheduled to be sent to but was not 
send to null
{noformat}

This message is not friendly to know what was going on.

Need not to log such kind of message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59404/#review175971
---




geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java
Lines 293 (patched)


Only one thread will invoke this method from 
InitialImageOperation.getFromOne.


- Eric Shu


On May 25, 2017, 12:51 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59404/
> ---
> 
> (Updated May 25, 2017, 12:51 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-2939
> https://issues.apache.org/jira/browse/GEODE-2939
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Event tracker initilization for bucket region is delayed until after GII, and 
> will be initialized from the GII provider.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 
> 886d678 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java
>  e4a7957 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
>  c1d1e77 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  485835b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java 
> 2c86aed 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
>  fb5f0cf 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java
>  3faf41f 
> 
> 
> Diff: https://reviews.apache.org/r/59404/diff/4/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

[Eric Shu]

> On May 24, 2017, 4:59 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
> > Lines 209 (patched)
> > 
> >
> > Why is this Map  ?
> > I can see on EventTracker.recordState we have: Map > EventSeqnoHolder>
> > 
> > But then on LocalRegion.recordEventState we just have "Map". Would it 
> > be hard to fix this to consistently use Map > EventSeqnoHolder>?

Will not be able to change the LocalRegion impl as HARegionQueue overrides the 
LocalRegion.recordEventState, and it does not uses Map.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59404/#review175956
---


On May 25, 2017, 12:51 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59404/
> ---
> 
> (Updated May 25, 2017, 12:51 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-2939
> https://issues.apache.org/jira/browse/GEODE-2939
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Event tracker initilization for bucket region is delayed until after GII, and 
> will be initialized from the GII provider.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 
> 886d678 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java
>  e4a7957 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
>  c1d1e77 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  485835b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java 
> 2c86aed 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
>  fb5f0cf 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java
>  3faf41f 
> 
> 
> Diff: https://reviews.apache.org/r/59404/diff/4/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59404/
---

(Updated May 25, 2017, 12:51 a.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
Gallinat.


Changes
---

fix review comments.


Bugs: GEODE-2939
https://issues.apache.org/jira/browse/GEODE-2939


Repository: geode


Description
---

Event tracker initilization for bucket region is delayed until after GII, and 
will be initialized from the GII provider.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 
886d678 
  
geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java
 e4a7957 
  
geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
 c1d1e77 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 
485835b 
  geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java 
2c86aed 
  
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
 fb5f0cf 
  
geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java
 3faf41f 


Diff: https://reviews.apache.org/r/59404/diff/4/

Changes: https://reviews.apache.org/r/59404/diff/3-4/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: What to do with the geode-spark-connector

[Jianxia Chen]

I prefer option A: Move it into it's own repository, with it's own release
cycle.

On Wed, May 24, 2017 at 5:17 PM, Dan Smith  wrote:

> Our geode-spark-connector needs some work. It's currently building against
> geode 1.0.0-incubating, because it has it's own separate build process.
> It's also somewhat out of date, we're building against spark 1.3. Is anyone
> actually using the spark connector?
>
> I think we need to get the spark connector out of the main geode repo since
> people are currently modifying code in the connector without even compiling
> it, since it's not linked into the gradle build.
>
> What do the geode devs think we should do with the geode-spark-connector?
>
> A) Move it into it's own repository, with it's own release cycle
> B) Delete it
> C) Other??
>
> -Dan
>

Re: What to do with the geode-spark-connector

[Anilkumar Gingade]

The spark has come a long way after 1.3...The connector needs to be
upgraded to be meaningful
+1 for A
The existing code could be used as a reference in the future...

-Anil.


On Wed, May 24, 2017 at 5:17 PM, Dan Smith  wrote:

> Our geode-spark-connector needs some work. It's currently building against
> geode 1.0.0-incubating, because it has it's own separate build process.
> It's also somewhat out of date, we're building against spark 1.3. Is anyone
> actually using the spark connector?
>
> I think we need to get the spark connector out of the main geode repo since
> people are currently modifying code in the connector without even compiling
> it, since it's not linked into the gradle build.
>
> What do the geode devs think we should do with the geode-spark-connector?
>
> A) Move it into it's own repository, with it's own release cycle
> B) Delete it
> C) Other??
>
> -Dan
>

Review Request 59562: GEODE-2941 Pulse documentation is outdated

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59562/
---

Review request for geode, Jinmei Liao and Joey McAllister.


Repository: geode


Description
---

GEODE-2941 Pulse documentation is outdated


Diffs
-

  geode-book/master_middleman/source/subnavs/geode-subnav.erb 
c97e5ec3ee961c500d0f006f9cb04ec5d569224d 
  geode-docs/configuring/cluster_config/gfsh_persist.html.md.erb 
45f73f9f3ffbb569c554f2c89ad86713af1695e6 
  geode-docs/getting_started/15_minute_quickstart_gfsh.html.md.erb 
894b9985a24ff9e0775b2fc755ee0b6d1ba15984 
  geode-docs/managing/management/jmx_manager_node.html.md.erb 
97ca066ca581689c87da5fe1d93e38ff4d13f64d 
  geode-docs/managing/management/management_system_overview.html.md.erb 
ecf69f5fb104850a54a57eaf69ce6f6a7d78e3bb 
  geode-docs/managing/management/mm_overview.html.md.erb 
89a8df5c2957f23d9cdacffc8a6062ed40cccb47 
  geode-docs/tools_modules/book_intro.html.md.erb 
e7390c5d00f6ade80fe3fd01ad9e729bbdd75f11 
  geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb 
e2a4edccddb7fa63b060002c243d955a7182ed7d 
  geode-docs/tools_modules/lucene_integration.html.md.erb 
e97ce061838228d46568fb80b5799cc361f74148 
  geode-docs/tools_modules/pulse/chapter_overview.html.md.erb 
19de8f1d28f84402d46cb4efdf71bedb720f14a1 
  geode-docs/tools_modules/pulse/pulse-auth.html.md.erb PRE-CREATION 
  geode-docs/tools_modules/pulse/pulse-embedded.html.md.erb PRE-CREATION 
  geode-docs/tools_modules/pulse/pulse-hosted.html.md.erb PRE-CREATION 
  geode-docs/tools_modules/pulse/pulse-views.html.md.erb PRE-CREATION 
  geode-docs/tools_modules/pulse/quickstart.html.md.erb 
6bcf1dc1d7c3b23c5d70a6c542103faf3970152e 
  geode-docs/tools_modules/pulse/system_requirements.html.md.erb 
05dffe65a1ea67d66040c5ac1f3cde3788a5e10d 
  geode-docs/tools_modules/redis_adapter.html.md.erb 
47da3fcf211e41a374da58f369ac20e346002bb6 


Diff: https://reviews.apache.org/r/59562/diff/1/


Testing
---

Compiled user guide (with bookbinder) - no broken links. Selected sections 
reviewed by developers while in draft form.


Thanks,

Dave Barnes

What to do with the geode-spark-connector

[Dan Smith]

Our geode-spark-connector needs some work. It's currently building against
geode 1.0.0-incubating, because it has it's own separate build process.
It's also somewhat out of date, we're building against spark 1.3. Is anyone
actually using the spark connector?

I think we need to get the spark connector out of the main geode repo since
people are currently modifying code in the connector without even compiling
it, since it's not linked into the gradle build.

What do the geode devs think we should do with the geode-spark-connector?

A) Move it into it's own repository, with it's own release cycle
B) Delete it
C) Other??

-Dan

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023932#comment-16023932
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/518
  
Closed by merge: 096c22d5c73dc609651caf2887b4d95f162230ad.


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires DATA:WRITE
> ** destroy index requires DATA:MANAGE:region
> * A user cannot create a Lucene index on a region that has eviction 
> configured with local destroy. If using Lucene indexing, eviction can only be 
> configured with overflow to disk. In this case, only the region data is 
> 

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023933#comment-16023933
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/518


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires DATA:WRITE
> ** destroy index requires DATA:MANAGE:region
> * A user cannot create a Lucene index on a region that has eviction 
> configured with local destroy. If using Lucene indexing, eviction can only be 
> configured with overflow to disk. In this case, only the region data is 
> overflowed to disk, *NOT* the Lucene index. An 

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023929#comment-16023929
 ] 

ASF subversion and git services commented on GEODE-2913:


Commit 096c22d5c73dc609651caf2887b4d95f162230ad in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=096c22d ]

GEODE-2913 Update Lucene index documentation


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires DATA:WRITE
> ** destroy index requires DATA:MANAGE:region
> * A user cannot create a Lucene index on a region that has eviction 
> configured with local destroy. If using Lucene indexing, eviction can 

[jira] [Commented] (GEODE-2944) lucene queries on String values (vs. objects) requires obscure/undocumented defaultField (__REGION_VALUE_FIELD)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023924#comment-16023924
 ] 

ASF GitHub Bot commented on GEODE-2944:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/533

GEODE-2944: Added __REGION_VALUE_FIELD explanation to Lucene create i…

…ndex help

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2944

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #533


commit 1f944192b8657da5e7f07f4af1d03a5539ee3025
Author: David Anuta 
Date:   2017-05-25T00:05:33Z

GEODE-2944: Added __REGION_VALUE_FIELD explanation to lucene create index 
help




> lucene queries on String values (vs. objects) requires obscure/undocumented 
> defaultField (__REGION_VALUE_FIELD)
> ---
>
> Key: GEODE-2944
> URL: https://issues.apache.org/jira/browse/GEODE-2944
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: David Anuta
>
> When a lucene index is created, one must indicate the field to create the 
> index on.  When the object value is a simple String, that must be specified 
> as --field=__REGION_VALUE_FIELD.
> For example,
> create lucene index --name=newIndex --region=testRegion 
> --field=__REGION_VALUE_FIELD
> However, the lucene help text (for the gfsh command) does not provide this 
> detail.  In addition, it seems that when executing a lucene search, this must 
> be entered again as --defaultField=__REGION_VALUE_FIELD.
> While this is probably not something one would use in production, I imagine 
> it will be used by developers experimenting with Lucene, so we should 
> consider adding this to the help text.
> {noformat}
> gfsh>help create lucene index
> NAME
> create lucene index
> IS AVAILABLE
> true
> SYNOPSIS
> Create a lucene index that can be used to execute queries.
> SYNTAX
> create lucene index --name=value --region=value --field=value(,value)* 
> [--analyzer=value(,value)*]
> PARAMETERS
> name
> Name of the lucene index to create.
> Required: true
> region
> Name/Path of the region on which to create the lucene index.
> Required: true
> field
> fields on the region values which are stored in the lucene index.
> Required: true
> analyzer
> Type of the analyzer for each field.
> Required: false
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation ...

[DivineEnder]

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/533

GEODE-2944: Added __REGION_VALUE_FIELD explanation to Lucene create i…

…ndex help

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2944

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #533


commit 1f944192b8657da5e7f07f4af1d03a5539ee3025
Author: David Anuta 
Date:   2017-05-25T00:05:33Z

GEODE-2944: Added __REGION_VALUE_FIELD explanation to lucene create index 
help




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-231) Remove deprecated AttributesMutator.setCacheListener

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023905#comment-16023905
 ] 

ASF GitHub Bot commented on GEODE-231:
--

Github user shankarh commented on the issue:

https://github.com/apache/geode/pull/507
  
Thanks @ameybarve15 @dschneider-pivotal for review. 
Do I need to resubmit this PR after resolving conflicts? 
or we resolve conflicts while merging?


> Remove deprecated AttributesMutator.setCacheListener
> 
>
> Key: GEODE-231
> URL: https://issues.apache.org/jira/browse/GEODE-231
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Shankar Hundekar
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> It looks like AttributesMutator.setCacheListener is currently only called 
> from test code. All of these calls can be replaced with 
> AttributesMutator.initCacheListeners with an array of one listener.
> It is probably not safe to use AttributesMutator.addCacheListener since it 
> leaves an original listeners in place.
> The method is called in about 25 different tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Geode Nightly build is consistently RED

[Kirk Lund]

If other people are ignoring the results of the flakyTest target and that's
the reason that people do not want to add FlakyTest category to tests that
aren't currently marked with FlakyTest then here's my proposal... we delete
FlakyTest category (well actually just rename it) and replace it with
TestsThatFailMoreFrequentlyAndNeedToRunInFreshJVM category and we educate
all geode developers to NOT ignore the results. If the test keeps failing
when run in isolation under
"TestsThatFailMoreFrequentlyAndNeedToRunInFreshJVM" then that means it
needs to be fixed asap and not ignored. Thoughts?

On Wed, May 24, 2017 at 4:50 PM, Kirk Lund  wrote:

> Geode Nightly build is staying consistently RED... each night the tests
> that fail vary some. Do we still want to not add FlakyTest category to
> these tests and just live with a RED nightly build?
>
> What do you all want to do? Any ideas what to do to get it consistently
> GREEN?
>
> The only way I know to get it GREEN is either a) we drop everything we're
> working on and fix flaky tests or b) we add FlakyTest category to flaky
> tests. The flakyTest target still runs the FlakyTest tests but it does so
> with a fresh JVM. In my opinion we should NOT ignore the results of
> flakyTest (and I personally do not ignore these results). I think it's a
> useful way to run DUnit tests that have special needs.
>

[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...

[shankarh]

Github user shankarh commented on the issue:

https://github.com/apache/geode/pull/507
  
Thanks @ameybarve15 @dschneider-pivotal for review. 
Do I need to resubmit this PR after resolving conflicts? 
or we resolve conflicts while merging?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Geode Nightly build is consistently RED

[Kirk Lund]

Geode Nightly build is staying consistently RED... each night the tests
that fail vary some. Do we still want to not add FlakyTest category to
these tests and just live with a RED nightly build?

What do you all want to do? Any ideas what to do to get it consistently
GREEN?

The only way I know to get it GREEN is either a) we drop everything we're
working on and fix flaky tests or b) we add FlakyTest category to flaky
tests. The flakyTest target still runs the FlakyTest tests but it does so
with a fresh JVM. In my opinion we should NOT ignore the results of
flakyTest (and I personally do not ignore these results). I think it's a
useful way to run DUnit tests that have special needs.

[jira] [Commented] (GEODE-240) Remove deprecated methods on TransactionEvent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023899#comment-16023899
 ] 

ASF GitHub Bot commented on GEODE-240:
--

Github user shankarh commented on the issue:

https://github.com/apache/geode/pull/515
  
Thanks @ameybarve15  @dschneider-pivotal @davinash for the review.


> Remove deprecated methods on TransactionEvent
> -
>
> Key: GEODE-240
> URL: https://issues.apache.org/jira/browse/GEODE-240
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Shankar Hundekar
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The following methods should all be deleted from TransactionEvent and callers 
> should be changed to instead use getEvents. The caller may have to do its own 
> filtering on getEvents to find the event(s) it is interested in.
> - getCreateEvents
> - getDestroyEvents
> - getPutEvents
> - getInvalidateEvents
> Some of the existing unit tests depend on the filtering done by these methods 
> so that filtering will need to move to some test util methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2981) Fix the line feed code of the test expected value

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-2981:

Component/s: management

> Fix the line feed code of the test expected value
> -
>
> Key: GEODE-2981
> URL: https://issues.apache.org/jira/browse/GEODE-2981
> Project: Geode
>  Issue Type: Test
>  Components: management, tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I mainly use the Windows. When I run the test on Windows, because Assertion 
> fails due to the difference in line feed code, I want to change this so that 
> it does not depend on the runtime environment.
> The target classes are as follows:
> - org.apache.geode.management.internal.cli.shell.GfshJunitTest
> - org.apache.geode.management.internal.cli.help.HelpBlockUnitTest
> - org.apache.geode.management.internal.cli.help.HelperUnitTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2944) lucene queries on String values (vs. objects) requires obscure/undocumented defaultField (__REGION_VALUE_FIELD)

[David Anuta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta reassigned GEODE-2944:
--

Assignee: David Anuta

> lucene queries on String values (vs. objects) requires obscure/undocumented 
> defaultField (__REGION_VALUE_FIELD)
> ---
>
> Key: GEODE-2944
> URL: https://issues.apache.org/jira/browse/GEODE-2944
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: David Anuta
>
> When a lucene index is created, one must indicate the field to create the 
> index on.  When the object value is a simple String, that must be specified 
> as --field=__REGION_VALUE_FIELD.
> For example,
> create lucene index --name=newIndex --region=testRegion 
> --field=__REGION_VALUE_FIELD
> However, the lucene help text (for the gfsh command) does not provide this 
> detail.  In addition, it seems that when executing a lucene search, this must 
> be entered again as --defaultField=__REGION_VALUE_FIELD.
> While this is probably not something one would use in production, I imagine 
> it will be used by developers experimenting with Lucene, so we should 
> consider adding this to the help text.
> {noformat}
> gfsh>help create lucene index
> NAME
> create lucene index
> IS AVAILABLE
> true
> SYNOPSIS
> Create a lucene index that can be used to execute queries.
> SYNTAX
> create lucene index --name=value --region=value --field=value(,value)* 
> [--analyzer=value(,value)*]
> PARAMETERS
> name
> Name of the lucene index to create.
> Required: true
> region
> Name/Path of the region on which to create the lucene index.
> Required: true
> field
> fields on the region values which are stored in the lucene index.
> Required: true
> analyzer
> Type of the analyzer for each field.
> Required: false
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...

[AkihiroKitada]

Github user AkihiroKitada closed the pull request at:

https://github.com/apache/geode/pull/525


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

[AkihiroKitada]

Github user AkihiroKitada commented on the issue:

https://github.com/apache/geode/pull/525
  
Hello Darrel,

I'm sorry to make this PR confused. I updated this PR from other 
environment and it made this PR cause some differences in terms of my fork.

I'll close this PR and create other one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023877#comment-16023877
 ] 

ASF GitHub Bot commented on GEODE-2950:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/532
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #532: GEODE-2950: Adding validation checks on create Lucene inde...

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/532
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023875#comment-16023875
 ] 

ASF GitHub Bot commented on GEODE-2950:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/532

GEODE-2950: Adding validation checks on create Lucene index parameter…

… names

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #532


commit db35110899adad1372f1f832344608dcf457a639
Author: David Anuta 
Date:   2017-05-24T23:21:33Z

GEODE-2950: Adding validation checks on create lucene index parameter names




> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...

[DivineEnder]

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/532

GEODE-2950: Adding validation checks on create Lucene index parameter…

… names

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #532


commit db35110899adad1372f1f832344608dcf457a639
Author: David Anuta 
Date:   2017-05-24T23:21:33Z

GEODE-2950: Adding validation checks on create lucene index parameter names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023870#comment-16023870
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/518
  
Thanks @boglesby . I've incorporated all suggestions but the last one in 
your review.  When we change the error message for destroying a region (before 
the associated index), then let's also update the docs. No need to do it ahead 
of time, esp. with the possibility that that change won't be in the Geode 1.2 
release, while this doc effort will.


> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires 

[GitHub] geode issue #518: GEODE-2913 Update Lucene index documentation

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/518
  
Thanks @boglesby . I've incorporated all suggestions but the last one in 
your review.  When we change the error message for destroying a region (before 
the associated index), then let's also update the docs. No need to do it ahead 
of time, esp. with the possibility that that change won't be in the Geode 1.2 
release, while this doc effort will.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59546/#review176013
---




geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
Lines 234 (patched)


we seem to assume here that `this.host != null`... the same cannot be said 
for the `getHost()` method


- Udo Kohlmeyer


On May 24, 2017, 10:30 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59546/
> ---
> 
> (Updated May 24, 2017, 10:30 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Patch from Bruce. Modified couple of tests.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
>  c1bfc93 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
>  01c6157 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
>  5ab1bed 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
>  1dc2fd1 
>   
> geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
>  dc73f04 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
>  9f6c5fb 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt
>  9cff80d 
>   
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
>  d6d5d7c 
> 
> 
> Diff: https://reviews.apache.org/r/59546/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

[jira] [Comment Edited] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[Emily Yeh (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023852#comment-16023852
 ] 

Emily Yeh edited comment on GEODE-2203 at 5/24/17 11:01 PM:


{code}
gfsh>status locator
null ==> We want something more like status server's message, like...
Locator in  on  is currently not responding.
{code}


was (Author: eyeh):
gfsh> start locator --port=40001

(locator starts and gfsh auto-connects to locator)

gfsh> status locator
null
Expectation: because gfsh is connected to locator, it should automatically give 
status for "locator --port=40001"

gfsh> status locator --port=40001


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[Emily Yeh (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023852#comment-16023852
 ] 

Emily Yeh commented on GEODE-2203:
--

gfsh> start locator --port=40001

(locator starts and gfsh auto-connects to locator)

gfsh> status locator
null
Expectation: because gfsh is connected to locator, it should automatically give 
status for "locator --port=40001"

gfsh> status locator --port=40001


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2955) gfsh create lucene index command should validate the region name parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023851#comment-16023851
 ] 

ASF subversion and git services commented on GEODE-2955:


Commit f271667b172191429412799327ad53efed6864e4 in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f271667 ]

GEODE-2955: Added / to the allowed list of characters in region name


> gfsh create lucene index command should validate the region name parameter
> --
>
> Key: GEODE-2955
> URL: https://issues.apache.org/jira/browse/GEODE-2955
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> The gfsh command to create the lucene index should not only validate the 
> lucene index name but also the region name.  It currently is possible to pass 
> an invalid region name as a parameter.  The region will then not be able to 
> be created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #564 was SUCCESSFUL (with 1848 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #564 was successful.
---
Scheduled
1850 tests in total.

https://build.spring.io/browse/SGF-NAG-564/





--
This message is automatically generated by Atlassian Bamboo

Broken: apache/geode#2661 (develop - ee9ca4e)

[Travis CI]

Build Update for apache/geode
-

Build: #2661
Status: Broken

Duration: 9 minutes and 20 seconds
Commit: ee9ca4e (develop)
Author: David Anuta
Message: GEODE-2955: Validating region names when creating lucene index

This closes #531

View the changeset: 
https://github.com/apache/geode/compare/662358fdba33...ee9ca4e81761

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/235837228?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/#review176008
---


Ship it!




Ship It!

- Jared Stewart


On May 24, 2017, 10:20 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59542/
> ---
> 
> (Updated May 24, 2017, 10:20 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Change GemFire to Geode in method names and message string
> 
> This is change to simply correct the Gfsh command error strings where 
> "GemFire" appears. With additional work on Gfsh command error handling 
> pending (see GEODE-2984), no attempt has been made within the scope of this 
> issue to reorganize or otherwise improve Gfsh command error messages.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
>  18940fc0c6c0f36a7dd5cab5723d426d80df3cb9 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
>  6d3f50ff2bcdf9d0450dd40a8defb83c2f2f6e04 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
>  b8ebc4917d88ce089ec2a19d606e004c1e5c6b33 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
>  a38e54504e949905f222d9891f624e373219364b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
>  4018beb8dfbd4bb639aec559991452226f15c908 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
>  4232d91edc9a74db144d49542d79f7cfd9f4a98b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
>  bcbfcf0ca72876dbfb3d41613159aa051726870e 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java
>  ea101826493bfbc9211b4c673c596d7514a7f431 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
>  b824bc915d453defe1c665eb7811a782f2c72fdf 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
>  5f2184889d28f441eb639d7ddf4ec2b7abfa293b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
>  2007e4af516274ac815cc3b06b9928f1aaed313f 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
>  a4ba64c608f184fb130eb5ca3a05822f6cf82818 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java
>  415dd691cc6ed14bc67626881eecf65d5e446c99 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
>  0d714f4c295e2aded0c0fd28bbf4f72ffcdd14a7 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java
>  0ce8ec272eee9f07a05aa0ac478e136163ee41e6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
>  6208adb63cc29f213c035849c78c3809f61b3f16 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
>  561d4b8514c5b4500bf870e0b9d0ef3bcdbaf40d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  ad344ff598db5474846d1b6b334d377e01c5fbd7 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
>  feeb3533e84fafbf22e5f9283690fe2ef0edf27e 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
>  fe88fc98d397fa748f8f54b900b1511eb114c0b6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
>  c2c6e1425d71af9d2ea59046b17afd70ad30dd68 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
>  6332540aa4ff6d210ed7f3ba167057de9a0a5023 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
>  2b39bedd1bcceef50e3f4933e17581048142a29b 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
>  5e17f6e55e6726f22cc39ddaba1ec608ca5cab9d 
> 
> 
> Diff: https://reviews.apache.org/r/59542/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin is 

Review Request 59546: GEODE-2940 Remove verification of locator host on start

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59546/
---

Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.


Repository: geode


Description
---

Patch from Bruce. Modified couple of tests.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
 c1bfc93 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
 01c6157 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f 
  
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
 5ab1bed 
  
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
 1dc2fd1 
  
geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
 dc73f04 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
 9f6c5fb 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 
9cff80d 
  
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
 d6d5d7c 


Diff: https://reviews.apache.org/r/59546/diff/1/


Testing
---


Thanks,

Hitesh Khamesra

[jira] [Commented] (GEODE-2955) gfsh create lucene index command should validate the region name parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023804#comment-16023804
 ] 

ASF subversion and git services commented on GEODE-2955:


Commit ee9ca4e8176183a6d0128322d21c47e5c4a0ffdf in geode's branch 
refs/heads/develop from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ee9ca4e ]

GEODE-2955: Validating region names when creating lucene index

This closes #531


> gfsh create lucene index command should validate the region name parameter
> --
>
> Key: GEODE-2955
> URL: https://issues.apache.org/jira/browse/GEODE-2955
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> The gfsh command to create the lucene index should not only validate the 
> lucene index name but also the region name.  It currently is possible to pass 
> an invalid region name as a parameter.  The region will then not be able to 
> be created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh reassigned GEODE-2203:


Assignee: Emily Yeh  (was: Alyssa Kim)

> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/
---

Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

Change GemFire to Geode in method names and message string

This is change to simply correct the Gfsh command error strings where "GemFire" 
appears. With additional work on Gfsh command error handling pending (see 
GEODE-2984), no attempt has been made within the scope of this issue to 
reorganize or otherwise improve Gfsh command error messages.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
 18940fc0c6c0f36a7dd5cab5723d426d80df3cb9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
 6d3f50ff2bcdf9d0450dd40a8defb83c2f2f6e04 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 b8ebc4917d88ce089ec2a19d606e004c1e5c6b33 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
 a38e54504e949905f222d9891f624e373219364b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
 4018beb8dfbd4bb639aec559991452226f15c908 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 4232d91edc9a74db144d49542d79f7cfd9f4a98b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
 bcbfcf0ca72876dbfb3d41613159aa051726870e 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java
 ea101826493bfbc9211b4c673c596d7514a7f431 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
 b824bc915d453defe1c665eb7811a782f2c72fdf 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
 5f2184889d28f441eb639d7ddf4ec2b7abfa293b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 2007e4af516274ac815cc3b06b9928f1aaed313f 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
 a4ba64c608f184fb130eb5ca3a05822f6cf82818 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java
 415dd691cc6ed14bc67626881eecf65d5e446c99 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 0d714f4c295e2aded0c0fd28bbf4f72ffcdd14a7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java
 0ce8ec272eee9f07a05aa0ac478e136163ee41e6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 6208adb63cc29f213c035849c78c3809f61b3f16 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
 561d4b8514c5b4500bf870e0b9d0ef3bcdbaf40d 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
 ad344ff598db5474846d1b6b334d377e01c5fbd7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
 feeb3533e84fafbf22e5f9283690fe2ef0edf27e 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 fe88fc98d397fa748f8f54b900b1511eb114c0b6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
 c2c6e1425d71af9d2ea59046b17afd70ad30dd68 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
 6332540aa4ff6d210ed7f3ba167057de9a0a5023 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
 2b39bedd1bcceef50e3f4933e17581048142a29b 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
 5e17f6e55e6726f22cc39ddaba1ec608ca5cab9d 


Diff: https://reviews.apache.org/r/59542/diff/1/


Testing
---

precheckin is running


Thanks,

Ken Howe

[jira] [Commented] (GEODE-2913) Update Lucene documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023793#comment-16023793
 ] 

ASF GitHub Bot commented on GEODE-2913:
---

Github user boglesby commented on the issue:

https://github.com/apache/geode/pull/518
  
The default analyzer is Geode's not Lucene's so I think the sentence should 
be something like:

When no analyzer is specified, the 
org.apache.lucene.analysis.standard.StandardAnalyzer will be used.
or
The default analyzer is the 
org.apache.lucene.analysis.standard.StandardAnalyzer if none is specified.

For this sentence: To use the entire value as a single field set the 
required --field option to be __REGION_VALUE_FIELD.

You might add something like: This is only supported when the region entry 
value is a String, Long, Integer, Float, Double.

In the xml section, you might want to add a field that uses the default 
analyzer like:



The error message (below) when attempting to destroy a region with an index 
is probably going to change. It'll be more like: All lucene indexes must be 
destroyed before destroying the data region.

java.lang.IllegalStateException: The parent region [/orders] in colocation 
chain
 cannot be destroyed, unless all its children [[/indexName#_orders.files]] 
are
 destroyed



> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener 

Re: Review Request 59544: GEODE-2966: RefactorLauncherLifecycleCommands

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/
---

(Updated May 24, 2017, 10:10 p.m.)


Review request for geode.


Changes
---

Spotless


Repository: geode


Description
---

- Extract several commands into their own classes.
 - Extract utility methods into their own classes.
 - Rename AbstractCommandsSupport to GfshCommand, and convert it from an 
abstract class to an interface


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
 27bc098 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
 2a1662e 
  geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
ce66057 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
43ab546 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
a6d3064 
  geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca4 
  
geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java
 18fca98 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
 26b903b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
 18940fc 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
 6d3f50f 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 b8ebc49 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
 a38e545 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
 4018beb 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 4232d91 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
 bcbfcf0 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java
 ea10182 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
 b824bc9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 2007e4a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java
 da13cdf 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
 a4ba64c 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 74acfd6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java
 415dd69 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 0d714f4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java
 0ce8ec2 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 6208adb 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
 561d4b8 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
 ad344ff 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java
 29627f3 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
 feeb353 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 cbeee99 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 78921c5 
  

Review Request 59544: GEODE-2966: RefactorLauncherLifecycleCommands

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/
---

Review request for geode.


Repository: geode


Description
---

- Extract several commands into their own classes.
 - Extract utility methods into their own classes.
 - Rename AbstractCommandsSupport to GfshCommand, and convert it from an 
abstract class to an interface


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
 27bc098d77c05d7385856e6fa4b769a7a2247a0e 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
 2a1662e318986b1520940403e7c881a2713c8920 
  geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
ce660578f4ddef1e733562e94f84a944cf1d3427 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
43ab546fadb3553cbe440a700d31f65e0500cb66 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
a6d3064404a247f5d669ea7aff0cdd37e11e4583 
  geode-core/src/main/java/org/apache/geode/internal/Assert.java 
4f54ca464cac82820dbffed7cbdadc3b21d878e7 
  
geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java
 18fca984b5792f096cc8b1755b09e65efbdd0d05 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
 26b903b3895f7f01f01684c44cc320129c80f81e 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
 18940fc0c6c0f36a7dd5cab5723d426d80df3cb9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
 6d3f50ff2bcdf9d0450dd40a8defb83c2f2f6e04 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 b8ebc4917d88ce089ec2a19d606e004c1e5c6b33 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
 a38e54504e949905f222d9891f624e373219364b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
 4018beb8dfbd4bb639aec559991452226f15c908 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 4232d91edc9a74db144d49542d79f7cfd9f4a98b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
 bcbfcf0ca72876dbfb3d41613159aa051726870e 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java
 ea101826493bfbc9211b4c673c596d7514a7f431 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
 b824bc915d453defe1c665eb7811a782f2c72fdf 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 2007e4af516274ac815cc3b06b9928f1aaed313f 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java
 da13cdfc31cd3e3533c1305394ee1eb28415db5c 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
 a4ba64c608f184fb130eb5ca3a05822f6cf82818 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java
 415dd691cc6ed14bc67626881eecf65d5e446c99 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 0d714f4c295e2aded0c0fd28bbf4f72ffcdd14a7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java
 0ce8ec272eee9f07a05aa0ac478e136163ee41e6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 6208adb63cc29f213c035849c78c3809f61b3f16 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
 561d4b8514c5b4500bf870e0b9d0ef3bcdbaf40d 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
 ad344ff598db5474846d1b6b334d377e01c5fbd7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java
 29627f3b598d698d021fa079c434dc6ef5e03da1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
 feeb3533e84fafbf22e5f9283690fe2ef0edf27e 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java
 PRE-CREATION 
  

[jira] [Commented] (GEODE-2974) Geode throws GemFire error

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023754#comment-16023754
 ] 

Kenneth Howe commented on GEODE-2974:
-

I think "Geode error" is better than than "server error" as some errors may 
come from geode clients.

For more information of Gfsh command error handling see GEODE-2984

> Geode throws GemFire error
> --
>
> Key: GEODE-2974
> URL: https://issues.apache.org/jira/browse/GEODE-2974
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Dave Barnes
>Assignee: Kenneth Howe
>
> While running Geode 1.1, I ran into a problem with a gfsh command (documented 
> elsewhere) that gave me a GemFire error:
> Could not process command due to GemFire error. Error while processing 
> command...
> Shouldn't this say "Geode error", or better yet, "server error"?
> The offending string is defined in:
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[David Anuta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta reassigned GEODE-2950:
--

Assignee: David Anuta

> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #527: GEODE-2961: Fixed distinct multiple OR query return...

[DivineEnder]

Github user DivineEnder closed the pull request at:

https://github.com/apache/geode/pull/527


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: What to do with Singletons

[John Blum]

On a side but related note, it would be nice if Geode had the notion of
useful, "canned" Functions provided OOTB.  Some of the *Gfsh* functions
would be quite useful for applications in fact, or particularly for
framework/tools to use as well.  Sometime ago I sent a list of Functions I
thought would be nice to have.

Food for thought.

On Wed, May 24, 2017 at 1:41 PM, Kirk Lund  wrote:

> Thanks for pointing out that DistributionManager is internal -- I forgot
> about that. I'm primarily concerned with internal Functions, such as those
> for GFSH commands, so maybe an internal version of FunctionContext which
> exposes more would be good for those.
>
> On Wed, May 24, 2017 at 11:39 AM, Darrel Schneider 
> wrote:
>
> > FunctionContext is an external interface so it can not expose internal
> > interfaces like DistributionManager.
> > But it could expose Cache. DistributedSystem is external so you could
> have
> > it exposed from FunctionContext but it is already exposed from Cache.
> > SecurityService is also internal.
> > Are you thinking that for internal Functions you would cast
> FunctionContext
> > to an internal that would then expose these internal classes?
> >
> >
> >
> > On Thu, May 18, 2017 at 5:13 PM, Kirk Lund  wrote:
> >
> > > I've been digging through our code with close attention to the
> > singletons.
> > > I believe the majority of singletons in Geode exist for two main
> reasons:
> > >
> > > 1) Insufficient context or lack of service lookup for Function,
> > > DistributionMessage and (Client)Command implementations.
> > >
> > > 2) Poor OO design. This is where you see code in one class invoking
> > > concrete methods on another class outside of its concerns. Many of
> these
> > > need to be teased apart and replaced with some sort of Observer that
> > > isolates the reaction from the source of the originating event.
> > >
> > > Right now my focus is on #1 because that's the area that's currently an
> > > obstacle for me.
> > >
> > > Function, DistributionMessage and (Client)Command classes need to have
> > more
> > > context provided to them (Cache, Security, etc) or they need a better
> > > mechanism to look up these services. Currently these classes reach out
> to
> > > singletons in order to "get" what they need.
> > >
> > > *A) Function*
> > >
> > > The main entry-point which injects services into the Function is:
> > >
> > > public void execute(FunctionContext context);
> > >
> > > The FunctionContext needs to provide the service(s) that any Function
> > might
> > > require. This could include Cache, DistributionManager and maybe
> > > SecurityService (anything else?).
> > >
> > > *B) (Peer-to-peer) DistributionMessage*
> > >
> > > The main entry-point which injects services into the
> DistributionMessage
> > > is:
> > >
> > > protected abstract void process(DistributionManager dm);
> > >
> > > We could provide multiple arguments or a single new DistributionContext
> > > which then provides DistributionManager and Cache (anything else?).
> > >
> > > *C) (Client) Command*
> > >
> > > The main entry-point which injects services into the Command is:
> > >
> > > public void execute(Message msg, ServerConnection servConn);
> > >
> > > ServerConnection is huge but it does already expose Cache. BaseCommand
> is
> > > the only Command that implements "execute" and it defines a new
> > entry-point
> > > for injection:
> > >
> > > abstract public void cmdExecute(Message msg, ServerConnection servConn,
> > > long start) throws IOException, ClassNotFoundException,
> > > InterruptedException;
> > >
> > > We might want to clean that up and define a new CommandContext which
> > > provides the Cache or anything else that the Command may need.
> > >
> > > Thoughts or additional ideas?
> > >
> >
>



-- 
-John
john.blum10101 (skype)

Re: Review Request 59422: GEODE-2954 Old client gets null memberID in cache listener

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59422/#review175993
---


Ship it!




Ship It!

- Udo Kohlmeyer


On May 19, 2017, 10:48 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59422/
> ---
> 
> (Updated May 19, 2017, 10:48 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2954
> https://issues.apache.org/jira/browse/GEODE-2954
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I've added a new test that demonstrates that a new-version server sends an 
> EventID to a client that the client is unable to deserialize completely.  It 
> gets an error when deserializing its member ID, causing cache listeners to 
> get a null when requesting the ID of the member that effected the change.
> 
> The fix is to reserialize the member ID in EventID.toData if the destination 
> stream is for an older version, such as a 1.1.0 client.  This ensures the 
> proper on-wire format is used for that version of Geode.
> 
> I've also bumped up the version ordinal for 1.2 since version 59 is marked as 
> unusable in Version.java.
> 
> I've changed the Banner to show the version ordinal because the other version 
> information in the banner isn't completely trustworthy.  It looks for a 
> GemFireVersion.properties file on the classpath to get this information and 
> so it may not get it from the Geode jar file as expected.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/Banner.java 
> b6a89bfc530fa5f4766f61e124839479dff2b664 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 1c131e8d08fc4b3f8004ffaca78fb6fac910ee2b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 87835ffa5a9782fecec5f6ae7adfe9829ac2fc26 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  be0ac6b080652179f12ccaf0e0a14f7acc299269 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  b4f3185ea71e47fc32c8ef1b3e656f4026056526 
> 
> 
> Diff: https://reviews.apache.org/r/59422/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin, new unit test.  I have to fix up the database for 
> AnalyzeSerializablesJUnitTest - I'm not including that in this review's diff.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: What to do with Singletons

[Kirk Lund]

Thanks for pointing out that DistributionManager is internal -- I forgot
about that. I'm primarily concerned with internal Functions, such as those
for GFSH commands, so maybe an internal version of FunctionContext which
exposes more would be good for those.

On Wed, May 24, 2017 at 11:39 AM, Darrel Schneider 
wrote:

> FunctionContext is an external interface so it can not expose internal
> interfaces like DistributionManager.
> But it could expose Cache. DistributedSystem is external so you could have
> it exposed from FunctionContext but it is already exposed from Cache.
> SecurityService is also internal.
> Are you thinking that for internal Functions you would cast FunctionContext
> to an internal that would then expose these internal classes?
>
>
>
> On Thu, May 18, 2017 at 5:13 PM, Kirk Lund  wrote:
>
> > I've been digging through our code with close attention to the
> singletons.
> > I believe the majority of singletons in Geode exist for two main reasons:
> >
> > 1) Insufficient context or lack of service lookup for Function,
> > DistributionMessage and (Client)Command implementations.
> >
> > 2) Poor OO design. This is where you see code in one class invoking
> > concrete methods on another class outside of its concerns. Many of these
> > need to be teased apart and replaced with some sort of Observer that
> > isolates the reaction from the source of the originating event.
> >
> > Right now my focus is on #1 because that's the area that's currently an
> > obstacle for me.
> >
> > Function, DistributionMessage and (Client)Command classes need to have
> more
> > context provided to them (Cache, Security, etc) or they need a better
> > mechanism to look up these services. Currently these classes reach out to
> > singletons in order to "get" what they need.
> >
> > *A) Function*
> >
> > The main entry-point which injects services into the Function is:
> >
> > public void execute(FunctionContext context);
> >
> > The FunctionContext needs to provide the service(s) that any Function
> might
> > require. This could include Cache, DistributionManager and maybe
> > SecurityService (anything else?).
> >
> > *B) (Peer-to-peer) DistributionMessage*
> >
> > The main entry-point which injects services into the DistributionMessage
> > is:
> >
> > protected abstract void process(DistributionManager dm);
> >
> > We could provide multiple arguments or a single new DistributionContext
> > which then provides DistributionManager and Cache (anything else?).
> >
> > *C) (Client) Command*
> >
> > The main entry-point which injects services into the Command is:
> >
> > public void execute(Message msg, ServerConnection servConn);
> >
> > ServerConnection is huge but it does already expose Cache. BaseCommand is
> > the only Command that implements "execute" and it defines a new
> entry-point
> > for injection:
> >
> > abstract public void cmdExecute(Message msg, ServerConnection servConn,
> > long start) throws IOException, ClassNotFoundException,
> > InterruptedException;
> >
> > We might want to clean that up and define a new CommandContext which
> > provides the Cache or anything else that the Command may need.
> >
> > Thoughts or additional ideas?
> >
>

[jira] [Assigned] (GEODE-2985) Doc task: making/using backups when there are indexes

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-2985:
--

Assignee: Karen Smoler Miller

> Doc task: making/using backups when there are indexes
> -
>
> Key: GEODE-2985
> URL: https://issues.apache.org/jira/browse/GEODE-2985
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> We should document that making a backup or using a backup to restore a system 
> when that system also has/had indexes can be problematic.
> When taking a backup on a system that has an index, if there are region 
> operations in progress, the asynchronous nature of propagating the results of 
> the operations to an index means that the index content may be inconsistent 
> with the region content.  If the backup were later used to restore a system, 
> the inconsistency will be introduced back into the system.
> The fix for this is to make sure that the system is quiescent with respect to 
> region operations when a backup is taken.
> In addition, the restoration procedure should rebuild indexes.
> This issue exists for both regular (OQL) indexes and for Lucene indexes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2985) Doc task: making/using backups when there are indexes

[Karen Smoler Miller (JIRA)]

Karen Smoler Miller created GEODE-2985:
--

 Summary: Doc task: making/using backups when there are indexes
 Key: GEODE-2985
 URL: https://issues.apache.org/jira/browse/GEODE-2985
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Karen Smoler Miller


We should document that making a backup or using a backup to restore a system 
when that system also has/had indexes can be problematic.

When taking a backup on a system that has an index, if there are region 
operations in progress, the asynchronous nature of propagating the results of 
the operations to an index means that the index content may be inconsistent 
with the region content.  If the backup were later used to restore a system, 
the inconsistency will be introduced back into the system.

The fix for this is to make sure that the system is quiescent with respect to 
region operations when a backup is taken.

In addition, the restoration procedure should rebuild indexes.

This issue exists for both regular (OQL) indexes and for Lucene indexes.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59422: GEODE-2954 Old client gets null memberID in cache listener

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59422/#review175989
---


Ship it!




Ship It!

- Hitesh Khamesra


On May 19, 2017, 10:48 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59422/
> ---
> 
> (Updated May 19, 2017, 10:48 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2954
> https://issues.apache.org/jira/browse/GEODE-2954
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I've added a new test that demonstrates that a new-version server sends an 
> EventID to a client that the client is unable to deserialize completely.  It 
> gets an error when deserializing its member ID, causing cache listeners to 
> get a null when requesting the ID of the member that effected the change.
> 
> The fix is to reserialize the member ID in EventID.toData if the destination 
> stream is for an older version, such as a 1.1.0 client.  This ensures the 
> proper on-wire format is used for that version of Geode.
> 
> I've also bumped up the version ordinal for 1.2 since version 59 is marked as 
> unusable in Version.java.
> 
> I've changed the Banner to show the version ordinal because the other version 
> information in the banner isn't completely trustworthy.  It looks for a 
> GemFireVersion.properties file on the classpath to get this information and 
> so it may not get it from the Geode jar file as expected.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/Banner.java 
> b6a89bfc530fa5f4766f61e124839479dff2b664 
>   geode-core/src/main/java/org/apache/geode/internal/Version.java 
> 1c131e8d08fc4b3f8004ffaca78fb6fac910ee2b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventID.java 
> 87835ffa5a9782fecec5f6ae7adfe9829ac2fc26 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
>  be0ac6b080652179f12ccaf0e0a14f7acc299269 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  b4f3185ea71e47fc32c8ef1b3e656f4026056526 
> 
> 
> Diff: https://reviews.apache.org/r/59422/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin, new unit test.  I have to fix up the database for 
> AnalyzeSerializablesJUnitTest - I'm not including that in this review's diff.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023555#comment-16023555
 ] 

ASF subversion and git services commented on GEODE-2741:


Commit 7eea002484ea49f5690e68b57ea53a629745beba in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=7eea002 ]

GEODE-2741: Fixes dependency installs.

- Fixes .NET 3.5 install.
- Fixes ActivePerl install.

> Use C++11 shared pointer over custom shared pointer
> ---
>
> Key: GEODE-2741
> URL: https://issues.apache.org/jira/browse/GEODE-2741
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared 
> pointer over the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2958) create replicate region with lucene index may restore destroyed defined lucene index

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby resolved GEODE-2958.
--
Resolution: Fixed

> create replicate region with lucene index may restore destroyed defined 
> lucene index 
> -
>
> Key: GEODE-2958
> URL: https://issues.apache.org/jira/browse/GEODE-2958
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
> Fix For: 1.2.0
>
>
> Executing the below commands in gfsh will result in the destroyed index being 
> created.  It appears that the combination of destroying the lucene index 
> while specifying the region name and index name, along with attempting to 
> create a replicate region can cause the destroyed index to be restored and 
> created when a partition region with the same name finally is created.
> create lucene index --name="GHOST_INDEX" --region="test" --field=name
> list lucene indexes
> destroy lucene index --region=test --name="GHOST_INDEX"
> create lucene index --name="LUCENE_INDEX" --region="test" --field=name
> create region --name=test --type=REPLICATE
> create region --name=test --type=PARTITION
> list lucene indexes
> If the --name parameter of the index was not supplied on the destroy, then 
> things work fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: What to do with Singletons

[Darrel Schneider]

FunctionContext is an external interface so it can not expose internal
interfaces like DistributionManager.
But it could expose Cache. DistributedSystem is external so you could have
it exposed from FunctionContext but it is already exposed from Cache.
SecurityService is also internal.
Are you thinking that for internal Functions you would cast FunctionContext
to an internal that would then expose these internal classes?



On Thu, May 18, 2017 at 5:13 PM, Kirk Lund  wrote:

> I've been digging through our code with close attention to the singletons.
> I believe the majority of singletons in Geode exist for two main reasons:
>
> 1) Insufficient context or lack of service lookup for Function,
> DistributionMessage and (Client)Command implementations.
>
> 2) Poor OO design. This is where you see code in one class invoking
> concrete methods on another class outside of its concerns. Many of these
> need to be teased apart and replaced with some sort of Observer that
> isolates the reaction from the source of the originating event.
>
> Right now my focus is on #1 because that's the area that's currently an
> obstacle for me.
>
> Function, DistributionMessage and (Client)Command classes need to have more
> context provided to them (Cache, Security, etc) or they need a better
> mechanism to look up these services. Currently these classes reach out to
> singletons in order to "get" what they need.
>
> *A) Function*
>
> The main entry-point which injects services into the Function is:
>
> public void execute(FunctionContext context);
>
> The FunctionContext needs to provide the service(s) that any Function might
> require. This could include Cache, DistributionManager and maybe
> SecurityService (anything else?).
>
> *B) (Peer-to-peer) DistributionMessage*
>
> The main entry-point which injects services into the DistributionMessage
> is:
>
> protected abstract void process(DistributionManager dm);
>
> We could provide multiple arguments or a single new DistributionContext
> which then provides DistributionManager and Cache (anything else?).
>
> *C) (Client) Command*
>
> The main entry-point which injects services into the Command is:
>
> public void execute(Message msg, ServerConnection servConn);
>
> ServerConnection is huge but it does already expose Cache. BaseCommand is
> the only Command that implements "execute" and it defines a new entry-point
> for injection:
>
> abstract public void cmdExecute(Message msg, ServerConnection servConn,
> long start) throws IOException, ClassNotFoundException,
> InterruptedException;
>
> We might want to clean that up and define a new CommandContext which
> provides the Cache or anything else that the Command may need.
>
> Thoughts or additional ideas?
>

[jira] [Commented] (GEODE-2958) create replicate region with lucene index may restore destroyed defined lucene index

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023420#comment-16023420
 ] 

ASF subversion and git services commented on GEODE-2958:


Commit 662358fdba33ce2ea99cadfe07303361b26ead56 in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=662358f ]

GEODE-2958: Destroying a defined index now removes the RegionListener


> create replicate region with lucene index may restore destroyed defined 
> lucene index 
> -
>
> Key: GEODE-2958
> URL: https://issues.apache.org/jira/browse/GEODE-2958
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
> Fix For: 1.2.0
>
>
> Executing the below commands in gfsh will result in the destroyed index being 
> created.  It appears that the combination of destroying the lucene index 
> while specifying the region name and index name, along with attempting to 
> create a replicate region can cause the destroyed index to be restored and 
> created when a partition region with the same name finally is created.
> create lucene index --name="GHOST_INDEX" --region="test" --field=name
> list lucene indexes
> destroy lucene index --region=test --name="GHOST_INDEX"
> create lucene index --name="LUCENE_INDEX" --region="test" --field=name
> create region --name=test --type=REPLICATE
> create region --name=test --type=PARTITION
> list lucene indexes
> If the --name parameter of the index was not supplied on the destroy, then 
> things work fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2955) gfsh create lucene index command should validate the region name parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023419#comment-16023419
 ] 

ASF GitHub Bot commented on GEODE-2955:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/531
  
@upthewaterspout @nabarunnag @ladyVader @jhuynh1 @boglesby 


> gfsh create lucene index command should validate the region name parameter
> --
>
> Key: GEODE-2955
> URL: https://issues.apache.org/jira/browse/GEODE-2955
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> The gfsh command to create the lucene index should not only validate the 
> lucene index name but also the region name.  It currently is possible to pass 
> an invalid region name as a parameter.  The region will then not be able to 
> be created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2955) gfsh create lucene index command should validate the region name parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023416#comment-16023416
 ] 

ASF GitHub Bot commented on GEODE-2955:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/531

GEODE-2955: Validating region names when creating lucene index

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2955

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #531


commit 37449b92a7b67010e6ccac03ea8e8e1f8fa8c92f
Author: David Anuta 
Date:   2017-05-24T18:34:39Z

GEODE-2955: Validating region names when creating lucene index




> gfsh create lucene index command should validate the region name parameter
> --
>
> Key: GEODE-2955
> URL: https://issues.apache.org/jira/browse/GEODE-2955
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> The gfsh command to create the lucene index should not only validate the 
> lucene index name but also the region name.  It currently is possible to pass 
> an invalid region name as a parameter.  The region will then not be able to 
> be created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #531: GEODE-2955: Validating region names when creating lucene i...

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/531
  
@upthewaterspout @nabarunnag @ladyVader @jhuynh1 @boglesby 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023388#comment-16023388
 ] 

ASF GitHub Bot commented on GEODE-2962:
---

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/525
  
Your diffs now show 51 files changed. It now shows a removal of deprecated 
FunctionService API. Perhaps you are picking this up from changes others made?
You might need to close this PR and start a new one but can you get it back 
only showing the changes you are making?


> Need more friendly locator's log message when executing "gfsh compact 
> disk-store" command
> -
>
> Key: GEODE-2962
> URL: https://issues.apache.org/jira/browse/GEODE-2962
> Project: Geode
>  Issue Type: Wish
>  Components: persistence
>Reporter: Akihiro Kitada
>Priority: Minor
>
> When executing "gfsh compact disk-store" command, then we currently see the 
> following kind of issue if the command is successfully executed for all the 
> target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not 
> send to null
> {noformat}
> This message is not friendly to know what was going on.
> Need more friendly log message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

[dschneider-pivotal]

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/525
  
Your diffs now show 51 files changed. It now shows a removal of deprecated 
FunctionService API. Perhaps you are picking this up from changes others made?
You might need to close this PR and start a new one but can you get it back 
only showing the changes you are making?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #845

[Apache Jenkins Server]

See 


Changes:

[nag] GEODE-2956: Trimmed analyzer strings in create index

[nag] GEODE-269 :  Removing deprecated API's from FunctionService.

[khowe] GEODE-2420: Enable export logs size estimation and user warning

[khowe] GEODE-2420: Resolve conflicts with recent checkin

[khowe] GEODE-2420: Renamed methods that had signatures changed

[Anil] GEODE-2918 Close cache when ConflictingPersistentDataException is

[boglesby] GEODE-2943: Wildcard and space queries are now handled correctly

[boglesby] GEODE-2951: Removed --pageSize option

[nnag] GEODE-2967: ResultCollection instead of StructCollection

[nnag] GEODE-2961: Fixed distinct multiple OR query returning partial results

[jiliao] GEODE-2964: add common-collections to gfsh dependencies

--
[...truncated 124.15 KB...]
at 
org.apache.geode.management.internal.cli.result.AbstractResultData.readFileDataAndDump(AbstractResultData.java:267)
at 
org.apache.geode.management.internal.cli.result.CommandResult.saveIncomingFiles(CommandResult.java:575)
at 
org.apache.geode.management.internal.cli.commands.ShowDeadlockDUnitTest.lambda$testDistributedDeadlockWithFunction$0(ShowDeadlockDUnitTest.java:154)

6851 tests completed, 4 failed, 604 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a 

[jira] [Created] (GEODE-2983) gfsh doesn't return user friendly error message when java property has comma separated values

[Hitesh Khamesra (JIRA)]

Hitesh Khamesra created GEODE-2983:
--

 Summary: gfsh doesn't return user friendly error message when java 
property has comma separated values
 Key: GEODE-2983
 URL: https://issues.apache.org/jira/browse/GEODE-2983
 Project: Geode
  Issue Type: Bug
  Components: gfsh
Reporter: Hitesh Khamesra


Here is the gfsh command and output. It is telling "Error: Could not find or 
load main class http", which slightly misleading

-bash-4.2$ gfsh start locator --dir=gemfire-locator --name=locator --port=56661 
--enable-cluster-configuration=true --force=true 
--J=-Dgemfire.OSProcess.ENABLE_OUTPUT_REDIRECTION=true 
--J=-Dgemfire.http-service-port=8080  
--J=-Dgemfire.security-manager=SecurityManager 
--J=-Dgemfire.security-enabled-components=server,http,jmx,gateway
.The Locator process terminated unexpectedly with exit status 1. Please refer 
to the log file in /poland1/users/hiteshk/work/tmp/gemfire-locator for full 
details.

Error: Could not find or load main class http




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2908) Swagger UI Tags seems broken in Latest

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023260#comment-16023260
 ] 

Anthony Baker commented on GEODE-2908:
--

Sorry about that, I'll reopen.

> Swagger UI Tags seems broken in Latest
> --
>
> Key: GEODE-2908
> URL: https://issues.apache.org/jira/browse/GEODE-2908
> Project: Geode
>  Issue Type: Bug
>Reporter: Avinash Dongre
>Assignee: Prasad Subhash Indulkar
> Fix For: 1.2.0
>
> Attachments: After.png, Before.png
>
>
> Swagger UI Tags seems broken in Latest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (GEODE-2964) NPE on gfsh put command

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar closed GEODE-2964.
---

> NPE on gfsh put command
> ---
>
> Key: GEODE-2964
> URL: https://issues.apache.org/jira/browse/GEODE-2964
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
> Fix For: 1.2.0
>
>
> After seeing up one locator one server, I created a partitioned region and 
> try to put a value in it from gfsh which resulted in a NPE:
> {noformat}
> gfsh>start locator --name=loc1
> gfsh>start server --name=serv1
> gfsh>create region --name=foo --type=PARTITION
> gfsh>put --key=1 --value=one --region=/foo
> Exception in thread "Gfsh Launcher" java.lang.NoClassDefFoundError: 
> org/apache/commons/collections/CollectionUtils
>   at 
> org.apache.geode.management.internal.cli.commands.DataCommands.put(DataCommands.java:895)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
>   at 
> org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:113)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
>   at 
> org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
>   at 
> org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1597)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
>   at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
>   at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
>   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346)
>   at sun.rmi.transport.Transport$1.run(Transport.java:200)
>   at sun.rmi.transport.Transport$1.run(Transport.java:197)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 

[jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023210#comment-16023210
 ] 

ASF GitHub Bot commented on GEODE-1994:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/528
  
Merged as dff937f


> Change geode StringUtils to extend commons StringUtils
> --
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
>  Issue Type: Wish
>  Components: general, management
>Reporter: Kirk Lund
>Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in 
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null, 
> while geode version returns false if string is null



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/528
  
Merged as dff937f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Reopened] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reopened GEODE-2951:


Not yet completed.  Docs need to be updated, but the docs update is blocked, 
waiting for completion of GEODE-2913.

> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-2951:
--

Assignee: Karen Smoler Miller

> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023202#comment-16023202
 ] 

ASF subversion and git services commented on GEODE-1994:


Commit dff937f32b1cb1cce6269226dc17263484685bf1 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=dff937f ]

GEODE-1994: Removed two references to ServerLauncher.setMemberName that are 
guaranteed to throw under the changes introduced by d16d192.


> Change geode StringUtils to extend commons StringUtils
> --
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
>  Issue Type: Wish
>  Components: general, management
>Reporter: Kirk Lund
>Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in 
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null, 
> while geode version returns false if string is null



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023135#comment-16023135
 ] 

ASF GitHub Bot commented on GEODE-1994:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/528
  
Green across the board.


> Change geode StringUtils to extend commons StringUtils
> --
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
>  Issue Type: Wish
>  Components: general, management
>Reporter: Kirk Lund
>Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in 
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null, 
> while geode version returns false if string is null



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/528
  
Green across the board.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2908) Swagger UI Tags seems broken in Latest

[Avinash Dongre (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023118#comment-16023118
 ] 

Avinash Dongre commented on GEODE-2908:
---

Hi [~amb] This is not merged to developed yet, since the review is still 
pending.

> Swagger UI Tags seems broken in Latest
> --
>
> Key: GEODE-2908
> URL: https://issues.apache.org/jira/browse/GEODE-2908
> Project: Geode
>  Issue Type: Bug
>Reporter: Avinash Dongre
>Assignee: Prasad Subhash Indulkar
> Fix For: 1.2.0
>
> Attachments: After.png, Before.png
>
>
> Swagger UI Tags seems broken in Latest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2970) CI Failure: org.apache.geode.management.internal.cli.commands.ConfigCommandsDUnitTest.testAlterRuntimeConfigOnAllMembers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023110#comment-16023110
 ] 

ASF subversion and git services commented on GEODE-2970:


Commit ca12f781c14409ee87873f604be64d98952c0a9a in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ca12f78 ]

GEODE-2970: clearing LogWriterAppender when shutting down locator.

* Do not bury the NPE in AlterRuntimeConfigFunction
* destroy the LogWriterAppender when removing the locator
* added test


> CI Failure: 
> org.apache.geode.management.internal.cli.commands.ConfigCommandsDUnitTest.testAlterRuntimeConfigOnAllMembers
> 
>
> Key: GEODE-2970
> URL: https://issues.apache.org/jira/browse/GEODE-2970
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>
> https://builds.apache.org/job/Geode-nightly/840/testReport/junit/org.apache.geode.management.internal.cli.commands/ConfigCommandsDUnitTest/testAlterRuntimeConfigOnAllMembers/
> Error Message
> java.lang.AssertionError: expected: but was:
> Stacktrace
> java.lang.AssertionError: expected: but was:
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.geode.management.internal.cli.commands.ConfigCommandsDUnitTest.testAlterRuntimeConfigOnAllMembers(ConfigCommandsDUnitTest.java:424)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor45.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> 

Build failed in Jenkins: Geode-spark-connector #162

[Apache Jenkins Server]

See 


Changes:

[kmiller] GEODE-2777 Update docs to be for Geode version 1.2

[jiliao] GEODE-2730: refactor rules

[klund] GEODE-2762: fix varargs warnings

[klund] GEODE-2647: remove unnecessary client puts from

[nnag] GEODE-2764: Addition checks on region name

[dschneider] GEODE-2097: check offheap limit during recovery

[gzhou] GEODE-2787: When distribution happened, it calls startOperation() to

[jiliao] GEODE-2730: refactor rules - review changes

[jstewart] GEODE-2686: Remove JarClassLoader

[jstewart] GEODE-2705: Jars undeployed from cluster configuration will not be

[jstewart] GEODE-2686: Add more logging to JarDeployer

[jstewart] GEODE-2290: Limit scanning of deployed jars

[jiliao] GEODE-2770 - Move the shutdown of the rest interface to the same place

[jiliao] GEODE-2775: Corrected setting of Pulse SSL Manager flag from System

[jstewart] GEODE-2290: Add license headers to rest resources

[jstewart] GEODE-2290: Fix DeployCommandRedeployDUnitTest

[huynhja] GEODE-2768: Lucene Queries executed before index is fully created 
should

[klund] GEODE-2632: refactor code to use InternalCache and

[huynhja] GEODE-2703: Improve exception message when executing lucene within a

[ukohlmeyer] GEODE-2653: Fix testRemoveMember and remove FlakyTest. This closes 
#437

[kmiller] GEODE-2103 Update gfsh start server|locator command reference page.

[klund] GEODE-2632: refactor code to use interfaces instead of impls

[kmiller] GEODE-2103 Revise http-service-port defn per review

[boglesby] GEODE-2605: Modified gfsh search lucene to require DATA:WRITE 
privilege

[bschuchardt] GEODE-510 Bug48571DUnitTest.testStatsMatchWithSize failed

[upthewaterspout] GEODE-728: Rename Execution.withArgs to Execution.setArguments

[jstewart] GEODE-2796: ClassPathLoader does not blow up with null TCCL

[upthewaterspout] GEODE-728: Using the correct parameter in withArgs

[bschuchardt] GEODE-576 & GEODE-516: GemFireDeadlockDetectorDUnitTest failures

[gzhou] GEODE-2806: if the batch is dispatched, even the bucket is no longer

[klund] GEODE-2632: refactor code to use InternalCache instead of

[eshu] GEODE-2799: Handle different types of KeyInfo set when creating the

[klund] GEODE-2632: refactor code to reduce GemFireCacheImpl dependencies

[upthewaterspout] GEODE-2808 - Fixing lock ordering issues in DeltaSession

[dschneider] GEODE-2097: fix flaky test

[dbarnes] GEODE-2809 Geode docs: Clarify SSL setup for client This closes #473

[eshu] GEODE-2785: Fix a test issue to allow certain additional afterSecondary

[adongre] GEODE-289: Removed depcreated LicenseException class This closes #471

[adongre] GEODE-267: Removed deprecated ThreadInterruptedException class This

[adongre] GEODE-236: Removed deprecated CacheEvent methods

[bschuchardt] GEODE-2752: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails 
on

[bschuchardt] GEODE-1228:

[lgallinat] GEODE-2398: fix oplog corruption in overflow oplogs

[adongre] GEODE-266: Remove the deprecated ObjectSizerImpl class This closes 
#469

[adongre] GEODE-260: Removed deprecated and not used RemoteTransactionException

[adongre] GEODE-255: Removed deprecated DataSerializer.register(Class,byte) This

[adongre] GEODE-253: Removed depreated and not used EntryNotFoundInRegion class

[khowe] GEODE-2681: prevent synchronization hang on getAnyInstance

[boglesby] GEODE-2689: Modified to ignore duplicate index definition

[klund] GEODE-2632: cleanup GemFireCacheImpl

[klund] GEODE-2632: fix ParallelQueueRemovalMessageJUnitTest

[Anil] GEODE-2802 Tombstone version vector to contain only the members that

[dbarnes] GEODE-2821 - Geode User Guide: Add running heads with logo

[nag] GEODE-2816: Redundancy recovery inititated even if redundancy set to 0

[dschneider] GEODE-2801: change krfIds to be thread safe

[dschneider] GEODE-2811: close OffHeapEvictor when cache is closed

[jiliao] GEODE-1597: use Spring shell's parser and delete our own parsing code

[klund] GEODE-2632: make GemFireCacheImpl.getRegion(String) non-final

[klund] GEODE-2632: minor fixes from code review

[adongre] GEODE-2723: Removed localCacheEnabled field, and associated dead code.

[jstewart] GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[jiliao] GEODE-2840: add a DUnit test to test concurrent deploy

[boglesby] GEODE-2823: The listener now forces a copy of the value to be made

[klund] GEODE-2632: prevent ClassCastException from ConnectionCountProbe to

[klund] GEODE-2857: add getProcess to ProcessWrapper for tests

[dbarnes] GEODE-2843 User Guide - example should specify 

[dbarnes] User Guide typo repair (no JIRA ticket) secuirty => security

[dbarnes] GEODE-2778: gfsh help now uses log4j log levels: update user guide 
This

[huynhja] GEODE-2825: Lucene query function will wait until index is returned if

[dbarnes] GEODE-2830 Required permission for executing a function should be

[nnag] GEODE-2828: AEQ created 

Re: Geode Exception: cluster configuration service not available

[Jinmei Liao]

Aravind, can you provide us with your startup script and the relevant
locator/server properties file? Is there any reason you want to set the
server's "disable-auto-reconnect" to false?

On Wed, May 24, 2017 at 4:41 AM, Aravind Musigumpula <
aravind.musigump...@amdocs.com> wrote:

>
> Hi,
>
> I am using a cluster configuration in geode 1.1.1 . I am starting two
> locators on different hosts and one server for each locator. When I stop
> them and restart the cluster, I can see that in one of the locator view ,
> it is receiving only one locator. In gfsh list members, I can see only one
> locator of that host but no server and no other locator and its server.
>
> I tried enabling the following parameters:
> In locator-specific-props: I have set "enable-cluster-configuration=true"
> In sever-common-props: I have set "disable-auto-reconnect=false" ,
> "use-cluster-configuration=true"
>
> In Server cache log, I am getting an exception :
> Cache server error
> org.apache.geode.GemFireConfigException: cluster configuration service
> not available
> at org.apache.geode.internal.cache.GemFireCacheImpl.
> requestSharedConfiguration(GemFireCacheImpl.java:1067)
> at org.apache.geode.internal.cache.GemFireCacheImpl.
> initialize(GemFireCacheImpl.java:1200)
> at org.apache.geode.internal.cache.GemFireCacheImpl.
> basicCreate(GemFireCacheImpl.java:798)
> at org.apache.geode.internal.cache.GemFireCacheImpl.create(
> GemFireCacheImpl.java:783)
> at org.apache.geode.cache.CacheFactory.create(
> CacheFactory.java:178)
> at org.apache.geode.cache.CacheFactory.create(
> CacheFactory.java:171)
> at org.apache.geode.internal.cache.CacheServerLauncher.
> createCache(CacheServerLauncher.java:813)
> at org.apache.geode.internal.cache.CacheServerLauncher.
> server(CacheServerLauncher.java:657)
> at org.apache.geode.internal.cache.CacheServerLauncher.
> main(CacheServerLauncher.java:201)
> Caused by: org.apache.geode.internal.process.
> ClusterConfigurationNotAvailableException: Unable to retrieve cluster
> configuration from the locator.
> at org.apache.geode.internal.cache.ClusterConfigurationLoader.
> requestConfigurationFromLocators(ClusterConfigurationLoader.java:245)
> at org.apache.geode.internal.cache.GemFireCacheImpl.
> requestSharedConfiguration(GemFireCacheImpl.java:1029)
> ... 8 more
> VM is exiting - shutting down distributed system
> In one of the locator log, I can see this:
> Region /_ConfigurationRegion has potentially stale data. It is waiting for
> another member to recover the latest data.
> .
> .
> .
>
>  tid=0x39] View Creator is processing 2
> requests for the next membership view
>
> received new view: View ...  members: ..  shutdown: ...
> old view is: View... members...
> Peer locator received new membership view: View members: ...
>  shutdown: ...
>  tid=0x39] no recipients for new view aside
> from myself
>
>
> This seems to be solved in geode 1.1.1 . https://issues.apache.org/
> jira/browse/GEODE-1986
> Can anybody help me with this issue.
>
>
> Thanks,
> Aravind
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>



-- 
Cheers

Jinmei

Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59287/#review175940
---




geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Lines 145 (patched)


is this method called anywhere else with a different first parameter? 

If only called once, seems redundant that the method throws an exception 
and the caller directly catches that exception only to get the message. We can 
either directly build the message here or have the method return the message.



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Lines 203 (patched)


We've already passed the size check before, and already generated the zip 
on the locator, I don't think we need this extra check here.


- Jinmei Liao


On May 23, 2017, 3:45 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59287/
> ---
> 
> (Updated May 23, 2017, 3:45 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adds 'export logs' option, --file-limit-size, to allow user to set
> maximun size of the epxorted logs zip file.
> 
> When size checking is enabled (file-limit-size > 0) then the check
> will also prevent filling up the disk on each member while consolidating
> and filtering the logs.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
>  7170f209ffa169fb6efdc851d35b61a2031888b7 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
>  20ec1f5702aea341ace5aa3b103c34cbdce1ae87 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  663a08e15624ed3dbc032460133fe3c62fc5ac26 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
>  c175e1ae3def869890692461bd129891350b383c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
>  8d20dc05c14bf558462893c4dd4cbbc474df4077 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  68d055cbd61ca35ef7409ff3370214a005da3d9b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogExporter.java
>  a0be7fbd83918fccb5254b4a48ba7bf14a0fb344 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
>  0a799f6c85dada2791da57585234fa2e47ef0b3d 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
>  a02c07f2c28156e097306f4b57174cddeda78845 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  96ac76588662b1de5d5bf41c24ab115d90fc0a85 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
>  ec2bcfe8ea876172c6946c43c005659d23d055e0 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
>  90a92f33247ecec8ee300ecb80a5d8ab27193c94 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
>  0bfbefa90af7813a8cf20529d36c9cbe5111f9d9 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
>  d8f2f2db937fc51ab5f917659e766f338b9ae847 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
>  e70a750f48a8f7cc3b10b89be9b5934944addb0d 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterTest.java
>  a387af3b70f61256b5d9303de29e9402bbdd71e6 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
>  c7b3ab934ce1cf97c0a70bc23b50f0f5ca08bb40 
> 
> 
> Diff: https://reviews.apache.org/r/59287/diff/5/
> 
> 
> Testing
> ---
> 
> Precheckin is in progress - all green so far with only DistributedTest still 
> running
> 
> 5/22 - Precheckin being re-run. Currently Green expcet for the known 
> LocatorLauncher test failures. DistributedTests still running
> 
> 5/23 - Re-running precheckin after syncing with current state of develop
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Build failed in Jenkins: Geode-spark-connector #161

[Apache Jenkins Server]

See 

--
Started by user abaker
[EnvInject] - Loading node environment variables.
Building remotely on couchdb-macos1 (couchdb) in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1169)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1279)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1169)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1279)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1169)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1279)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Recording test results
ERROR: Build step failed with exception
 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:127)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:107)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2731)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at hudson.remoting.Engine$1$1.run(Engine.java:94)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to JNLP4-connect connection from 
91.65.50.62/91.65.50.62:51038(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1545)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:830)
at hudson.FilePath.act(FilePath.java:985)
at hudson.FilePath.act(FilePath.java:974)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:103)
at 
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:128)
at 
hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:149)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:186)

Re: Review Request 59492: GEODE-2966: Refactor LauncherLifecycleCommands (Part 1)

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59492/#review175932
---



Or you can have all your newly create commmands directly implement 
CommandMarker and directly reference the static methods in 
AbstractCommandSupport. But I would leave those methods in 
AbstractCommandSupport as package protected though (not public).

- Jinmei Liao


On May 23, 2017, 9:54 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59492/
> ---
> 
> (Updated May 23, 2017, 9:54 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Extract several commands out of LauncherLifecycleCommands into their 
> distinct own classes.
>  - Extract some utility methods from LauncherLifecycleCommands into more 
> appropriate locations.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  27bc098 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
>  2a1662e 
>   geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java 
> ce66057 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> 12c5c21 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> a6d3064 
>   
> geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java
>  18fca98 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
>  26b903b 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  b6c11c4 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  68d055c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfiguration.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59492/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[jira] [Updated] (GEODE-2890) Incorrect debug log location in AbstractGatewaySenderEventProcessor.processQueue()

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2890:
-
Fix Version/s: 1.2.0

> Incorrect debug log location in 
> AbstractGatewaySenderEventProcessor.processQueue() 
> ---
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Amey Barve
> Fix For: 1.2.0
>
>
> The following code snippet in processQueue() for AEQ's appears to be outside 
> of an if condition where we check to see if the node is primary still or not. 
>  This line prints for every event and I believe it should be inside the 
> previous if condition. 
> {noformat}
> if (qpr != null) {
>BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
>if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
>  event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
>}
> }
> if (isDebugEnabled) {
>   logger.debug( "Bucket id: {} is no longer primary on this node. The event 
> {} will be dispatched from this node with possibleDuplicate set to true.", 
> bucketId, event);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2890) Incorrect debug log location in AbstractGatewaySenderEventProcessor.processQueue()

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023054#comment-16023054
 ] 

Anthony Baker commented on GEODE-2890:
--

Closing as this appears to be resolved.

> Incorrect debug log location in 
> AbstractGatewaySenderEventProcessor.processQueue() 
> ---
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Amey Barve
> Fix For: 1.2.0
>
>
> The following code snippet in processQueue() for AEQ's appears to be outside 
> of an if condition where we check to see if the node is primary still or not. 
>  This line prints for every event and I believe it should be inside the 
> previous if condition. 
> {noformat}
> if (qpr != null) {
>BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
>if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
>  event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
>}
> }
> if (isDebugEnabled) {
>   logger.debug( "Bucket id: {} is no longer primary on this node. The event 
> {} will be dispatched from this node with possibleDuplicate set to true.", 
> bucketId, event);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2908) Swagger UI Tags seems broken in Latest

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2908.
--
Resolution: Fixed

> Swagger UI Tags seems broken in Latest
> --
>
> Key: GEODE-2908
> URL: https://issues.apache.org/jira/browse/GEODE-2908
> Project: Geode
>  Issue Type: Bug
>Reporter: Avinash Dongre
>Assignee: Prasad Subhash Indulkar
> Fix For: 1.2.0
>
> Attachments: After.png, Before.png
>
>
> Swagger UI Tags seems broken in Latest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2908) Swagger UI Tags seems broken in Latest

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023045#comment-16023045
 ] 

Anthony Baker commented on GEODE-2908:
--

Closing as this appears to be fixed.

> Swagger UI Tags seems broken in Latest
> --
>
> Key: GEODE-2908
> URL: https://issues.apache.org/jira/browse/GEODE-2908
> Project: Geode
>  Issue Type: Bug
>Reporter: Avinash Dongre
>Assignee: Prasad Subhash Indulkar
> Fix For: 1.2.0
>
> Attachments: After.png, Before.png
>
>
> Swagger UI Tags seems broken in Latest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023024#comment-16023024
 ] 

Anthony Baker commented on GEODE-2951:
--

This appears to be fixed, closing.

> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2951:
-
Fix Version/s: 1.2.0

> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2958) create replicate region with lucene index may restore destroyed defined lucene index

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2958:
-
Fix Version/s: 1.2.0

> create replicate region with lucene index may restore destroyed defined 
> lucene index 
> -
>
> Key: GEODE-2958
> URL: https://issues.apache.org/jira/browse/GEODE-2958
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
> Fix For: 1.2.0
>
>
> Executing the below commands in gfsh will result in the destroyed index being 
> created.  It appears that the combination of destroying the lucene index 
> while specifying the region name and index name, along with attempting to 
> create a replicate region can cause the destroyed index to be restored and 
> created when a partition region with the same name finally is created.
> create lucene index --name="GHOST_INDEX" --region="test" --field=name
> list lucene indexes
> destroy lucene index --region=test --name="GHOST_INDEX"
> create lucene index --name="LUCENE_INDEX" --region="test" --field=name
> create region --name=test --type=REPLICATE
> create region --name=test --type=PARTITION
> list lucene indexes
> If the --name parameter of the index was not supplied on the destroy, then 
> things work fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2964) NPE on gfsh put command

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2964:
-
Fix Version/s: 1.2.0

> NPE on gfsh put command
> ---
>
> Key: GEODE-2964
> URL: https://issues.apache.org/jira/browse/GEODE-2964
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
> Fix For: 1.2.0
>
>
> After seeing up one locator one server, I created a partitioned region and 
> try to put a value in it from gfsh which resulted in a NPE:
> {noformat}
> gfsh>start locator --name=loc1
> gfsh>start server --name=serv1
> gfsh>create region --name=foo --type=PARTITION
> gfsh>put --key=1 --value=one --region=/foo
> Exception in thread "Gfsh Launcher" java.lang.NoClassDefFoundError: 
> org/apache/commons/collections/CollectionUtils
>   at 
> org.apache.geode.management.internal.cli.commands.DataCommands.put(DataCommands.java:895)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
>   at 
> org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:113)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
>   at 
> org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
>   at 
> org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1597)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
>   at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
>   at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
>   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346)
>   at sun.rmi.transport.Transport$1.run(Transport.java:200)
>   at sun.rmi.transport.Transport$1.run(Transport.java:197)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 

[jira] [Commented] (GEODE-2964) NPE on gfsh put command

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023009#comment-16023009
 ] 

Anthony Baker commented on GEODE-2964:
--

Closing as this issue seems to be resolved.

> NPE on gfsh put command
> ---
>
> Key: GEODE-2964
> URL: https://issues.apache.org/jira/browse/GEODE-2964
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
> Fix For: 1.2.0
>
>
> After seeing up one locator one server, I created a partitioned region and 
> try to put a value in it from gfsh which resulted in a NPE:
> {noformat}
> gfsh>start locator --name=loc1
> gfsh>start server --name=serv1
> gfsh>create region --name=foo --type=PARTITION
> gfsh>put --key=1 --value=one --region=/foo
> Exception in thread "Gfsh Launcher" java.lang.NoClassDefFoundError: 
> org/apache/commons/collections/CollectionUtils
>   at 
> org.apache.geode.management.internal.cli.commands.DataCommands.put(DataCommands.java:895)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
>   at 
> org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:113)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
>   at 
> org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
>   at 
> org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1597)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
>   at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
>   at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
>   at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
>   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
>   at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346)
>   at sun.rmi.transport.Transport$1.run(Transport.java:200)
>   at sun.rmi.transport.Transport$1.run(Transport.java:197)
>   at 

[jira] [Commented] (GEODE-2967) Internal Errors thrown while executing queries involving self join

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023001#comment-16023001
 ] 

Anthony Baker commented on GEODE-2967:
--

Can this issue be closed?

> Internal Errors thrown while executing queries involving self join
> --
>
> Key: GEODE-2967
> URL: https://issues.apache.org/jira/browse/GEODE-2967
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>
> Issue:
> While executing queries like
> SELECT * FROM /pos p1 WHERE p1.id = p1.id
> leads to an internal error if Indexes are used.
> Solution:
> ResultCollection needs to be created instead of StructCollection in this 
> particular situation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2973) A lucene index element defined outside the context of a region element in xml throws a ClassCastException

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2973:
-
Fix Version/s: 1.2.0

> A lucene index element defined outside the context of a region element in xml 
> throws a ClassCastException
> -
>
> Key: GEODE-2973
> URL: https://issues.apache.org/jira/browse/GEODE-2973
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If a {{lucene:index}} element is defined directly below the {{cache}} element 
> like this:
> {noformat}
> 
>   
> 
> {noformat}
> Then a ClassCastException like below is thrown rather than a 
> {{SAXParseException}} (or maybe a more specific exception):
> {noformat}
> Exception in thread "main" org.apache.geode.cache.CacheXmlException: While 
> reading Cache XML 
> file:/Users/boglesby/Dev/Tests/client-server/lucene/nyc-311/geode-lucene/config/gemfire-server.xml.
>  While parsing XML, caused by java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.CacheCreation cannot be cast to 
> org.apache.geode.internal.cache.xmlcache.RegionCreation
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:267)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.loadCacheXml(GemFireCacheImpl.java:4282)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1390)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1195)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:758)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:745)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:173)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:212)
>   at TestBase.initializeServerCache(TestBase.java:22)
>   at TestServer.main(TestServer.java:12)
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.CacheCreation cannot be cast to 
> org.apache.geode.internal.cache.xmlcache.RegionCreation
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startIndex(LuceneXmlParser.java:71)
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startElement(LuceneXmlParser.java:47)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.startElement(CacheXmlParser.java:2748)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser$DefaultHandlerDelegate.startElement(CacheXmlParser.java:3369)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:509)
>   at 
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.startElement(XMLSchemaValidator.java:749)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:379)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2786)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:333)
>   at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:224)
>   ... 9 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2972) An incorrectly named lucene element in xml throws a ClassCastException

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2972:
-
Fix Version/s: 1.2.0

> An incorrectly named lucene element in xml throws a ClassCastException
> --
>
> Key: GEODE-2972
> URL: https://issues.apache.org/jira/browse/GEODE-2972
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If a region is defined like this:
> {noformat}
> 
>   
>   
>   
> 
> {noformat}
> Then the {{lucene:indexxx}}  element is ignored, and a {{ClassCastException}} 
> like below is thrown when the {{lucene:field}} element is processed rather 
> than a {{SAXParseException}} (or maybe a more specific exception).
> {noformat}
> Exception in thread "main" org.apache.geode.cache.CacheXmlException: While 
> reading Cache XML 
> file:/Users/boglesby/Dev/Tests/client-server/lucene/nyc-311/geode-lucene/config/gemfire-server.xml.
>  While parsing XML, caused by java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.RegionCreation cannot be cast to 
> org.apache.geode.cache.lucene.internal.xml.LuceneIndexCreation
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:267)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.loadCacheXml(GemFireCacheImpl.java:4282)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1390)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1195)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:758)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:745)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:173)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:212)
>   at TestBase.initializeServerCache(TestBase.java:22)
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.RegionCreation cannot be cast to 
> org.apache.geode.cache.lucene.internal.xml.LuceneIndexCreation
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startField(LuceneXmlParser.java:59)
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startElement(LuceneXmlParser.java:50)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.startElement(CacheXmlParser.java:2748)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser$DefaultHandlerDelegate.startElement(CacheXmlParser.java:3369)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:509)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:182)
>   at 
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.emptyElement(XMLSchemaValidator.java:780)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:356)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2786)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:333)
>   at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:224)
>   ... 9 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2972) An incorrectly named lucene element in xml throws a ClassCastException

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022995#comment-16022995
 ] 

Anthony Baker commented on GEODE-2972:
--

I this the same issue as GEODE-2975?

> An incorrectly named lucene element in xml throws a ClassCastException
> --
>
> Key: GEODE-2972
> URL: https://issues.apache.org/jira/browse/GEODE-2972
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If a region is defined like this:
> {noformat}
> 
>   
>   
>   
> 
> {noformat}
> Then the {{lucene:indexxx}}  element is ignored, and a {{ClassCastException}} 
> like below is thrown when the {{lucene:field}} element is processed rather 
> than a {{SAXParseException}} (or maybe a more specific exception).
> {noformat}
> Exception in thread "main" org.apache.geode.cache.CacheXmlException: While 
> reading Cache XML 
> file:/Users/boglesby/Dev/Tests/client-server/lucene/nyc-311/geode-lucene/config/gemfire-server.xml.
>  While parsing XML, caused by java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.RegionCreation cannot be cast to 
> org.apache.geode.cache.lucene.internal.xml.LuceneIndexCreation
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:267)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.loadCacheXml(GemFireCacheImpl.java:4282)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1390)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1195)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:758)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:745)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:173)
>   at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:212)
>   at TestBase.initializeServerCache(TestBase.java:22)
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.xmlcache.RegionCreation cannot be cast to 
> org.apache.geode.cache.lucene.internal.xml.LuceneIndexCreation
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startField(LuceneXmlParser.java:59)
>   at 
> org.apache.geode.cache.lucene.internal.xml.LuceneXmlParser.startElement(LuceneXmlParser.java:50)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.startElement(CacheXmlParser.java:2748)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser$DefaultHandlerDelegate.startElement(CacheXmlParser.java:3369)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:509)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:182)
>   at 
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.emptyElement(XMLSchemaValidator.java:780)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:356)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2786)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
>   at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
>   at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
>   at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
>   at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:333)
>   at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
>   at 
> org.apache.geode.internal.cache.xmlcache.CacheXmlParser.parse(CacheXmlParser.java:224)
>   ... 9 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2979) Adding server after defining Lucene index results in unusable cluster

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2979:
-
Fix Version/s: 1.2.0

> Adding server after defining Lucene index results in unusable cluster
> -
>
> Key: GEODE-2979
> URL: https://issues.apache.org/jira/browse/GEODE-2979
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
> Fix For: 1.2.0
>
>
> Here are the gfsh commands I used:
> {noformat}
> ## start locator
> start locator --name=locator1 --port=12345
> ## start first server
> start server --name=server50505 --server-port=50505 
> --locators=localhost[12345] --start-rest-api --http-service-port=8080 
> --http-service-bind-address=localhost
> ## create lucene index on region testRegion
> create lucene index --name=testIndex --region=testRegion 
> --field=__REGION_VALUE_FIELD
> ## start second server
> start server --name=server50506 --server-port=50506 
> --locators=localhost[12345] --start-rest-api --http-service-port=8080 
> --http-service-bind-address=localhost
> ## list indexes - NOTE lucene index only listed on first server
> gfsh>list members
>Name | Id
> --- | -
> locator1| 192.168.1.57(locator1:60525:locator):1024
> server50505 | 192.168.1.57(server50505:60533):1025
> server50506 | 192.168.1.57(server50506:60587):1026
> gfsh>list lucene indexes --with-stats
> Index Name | Region Path | Server Name | Inde.. | Field Anal.. | Status  | 
> Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- |  | --- | 
>  | --- | --- | -
> testIndex  | /testRegion | server50505 | [__R.. | {__REGION_.. | Defined | NA 
>   | NA  | NA  | NA
> ## Create region testRegion
> gfsh>create region --name=testRegion --type=PARTITION_REDUNDANT_PERSISTENT
>   Member| Status
> --- | 
> 
> server50506 | ERROR: Must create Lucene index testIndex on region /testRegion 
> because it is defined in another member.
> server50505 | Region "/testRegion" created on "server50505"
> ## Add data to region - NOTE this causes a crash with an NPE
> gfsh>put --key=1 --value=value1 --region=testRegion
> Exception in thread "Gfsh Launcher" java.lang.NoClassDefFoundError: 
> org/apache/commons/collections/CollectionUtils
>   at 
> org.apache.geode.management.internal.cli.commands.DataCommands.put(DataCommands.java:895)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
>   at 
> org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:113)
>   at 
> org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
>   at 
> org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
>   at 
> org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1597)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
>   at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
>   at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
>   at 
> 

[jira] [Updated] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2428:
-
Fix Version/s: (was: 1.2.0)

> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2912) Real hot deploy of functions via gfsh

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022977#comment-16022977
 ] 

Anthony Baker commented on GEODE-2912:
--

Closing as this appears to be resolved.

> Real hot deploy of functions via gfsh
> -
>
> Key: GEODE-2912
> URL: https://issues.apache.org/jira/browse/GEODE-2912
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> A user ought to be able to deploy a Jar file containing a new version of a 
> Function without resulting in any failed function executions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2913) Update Lucene documentation

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2913:
-
Fix Version/s: 1.2.0

> Update Lucene documentation
> ---
>
> Key: GEODE-2913
> URL: https://issues.apache.org/jira/browse/GEODE-2913
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Improvements to the code base that need to be reflected in the docs:
> * Change LuceneService.createIndex to use a factory pattern
> {code:java}
> luceneService.createIndex(region, index, ...)
> {code}
> changes to
> {code:java}
> luceneService.createIndexFactory()
> .addField("field1name")
> .addField("field2name")
> .create()
> {code}
> *  Lucene indexes will *NOT* be stored in off-heap memory.
> * Document how to configure an index on accessors - you still need to create 
> the Lucene index before creating the region, even though this member does not 
> hold any region data.
> If the index is not defined on the accessor, an exception like this will be 
> thrown while attempting to create the region:
> {quote}
> [error 2017/05/02 15:19:26.018 PDT  tid=0x1] 
> java.lang.IllegalStateException: Must create Lucene index full_index on 
> region /data because it is defined in another member.
> Exception in thread "main" java.lang.IllegalStateException: Must create 
> Lucene index full_index on region /data because it is defined in another 
> member.
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.handleCacheDistributionAdvisee(CreateRegionProcessor.java:478)
> at 
> org.apache.geode.internal.cache.CreateRegionProcessor$CreateRegionMessage.process(CreateRegionProcessor.java:379)
> {quote}
> * Do not need to create a Lucene index on a client with a Proxy cache. The 
> Lucene search will always be done on the server.  Besides, _you can't create 
> an index on a client._
> * If you configure Invalidates for region entries (alone or as part of 
> expiration), these will *NOT* invalidate the Lucene indexes.
> The problem with this is the index contains the keys, but the region doesn't, 
> so the query produces results that don't exist.
> In this test, the first time the query is run, it produces N valid results. 
> The second time it is run it produces N empty results:
> ** load entries
> ** run query
> ** invalidate entries
> ** run query again
> *  Destroying a region will *NOT* automatically destroy any Lucene index 
> associated with that region. Instead, attempting to destroy a region with a 
> Lucene index will throw a colocated region exception. 
> An IllegalStateException is thrown:
> {quote}
> java.lang.IllegalStateException: The parent region [/data] in colocation 
> chain cannot be destroyed, unless all its children 
> [[/cusip_index#_data.files]] are destroyed
> at 
> org.apache.geode.internal.cache.PartitionedRegion.checkForColocatedChildren(PartitionedRegion.java:7231)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.destroyRegion(PartitionedRegion.java:7243)
> at 
> org.apache.geode.internal.cache.AbstractRegion.destroyRegion(AbstractRegion.java:308)
> at 
> DestroyLuceneIndexesAndRegionFunction.destroyRegion(DestroyLuceneIndexesAndRegionFunction.java:46)
> {quote}
> * The process to change a Lucene index using gfsh: 
>   1. export region data
>   2. destroy Lucene index, destroy region 
>   3. create new index, create new region without user-defined business 
> logic callbacks
>   4. import data with option to turn on callbacks (to invoke Lucene Async 
> Event Listener to index the data)
>   5. alter region to add user-defined business logic callbacks
> * Make sure there are no references to replicated regions as they are not 
> supported.
> * Document security implementation and defaults.  If a user has security 
> configured for their cluster, creating a Lucene index requires DATA:MANAGE 
> privilege (similar to OQL), but doing Lucene queries requires DATA:WRITE 
> privilege because a function is called (different from OQL which requires 
> only DATA:READ privilege). Here are all the required privileges for the gfsh 
> commands:
> ** create index requires DATA:MANAGE:region
> ** describe index requires CLUSTER:READ
> ** list indexes requires CLUSTER:READ
> ** search index requires DATA:WRITE
> ** destroy index requires DATA:MANAGE:region
> * A user cannot create a Lucene index on a region that has eviction 
> configured with local destroy. If using Lucene indexing, eviction can only be 
> configured with overflow to disk. In this case, only the region data is 
> overflowed to disk, *NOT* the Lucene index. An UnsupportedOperationException 
> is thrown:
> {quote}
> [error 2017/05/02 16:12:32.461 PDT  tid=0x1] 
> java.lang.UnsupportedOperationException: