date:20170614

Build failed in Jenkins: Geode-nightly-flaky #36

2017-06-14 Thread Apache Jenkins Server

See 


Changes:

[jiliao] GEODE-2294: revert to avoid rest protocol change

[jiliao] Resolve Eclipse/IntelliJ import order disagreement in style files.

[jiliao] GEODE-2818: add alias to any command's options that involves "group",

[jiliao] GEODE-2818: add aliases to the undeploy command

[klund] GEODE-3062: create new SecurityService after receiving cluster config

[klund] GEODE-2558: Upgrade mockito to 2.7.11 and powermock to 1.7.0RC2

[klund] GEODE-2622: Fix GMSMembershipManagerJUnitTest use of Mockito 2.7.11

[klund] GEODE-2628: fix StatisticsImplTest use of Mockito 2.7.11

[klund] GEODE-2626: fix FastLoggerJUnitTest use of Mockito 2.7.11

[klund] GEODE-2629: fix ConnectionJUnitTest use of Mockito 2.7.11

[klund] GEODE-2558: Upgrade Powermock version to fix failing tests

[jstewart] GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

[kmiller] GEODE-3070: Fix gemfire.jar to be geode-dependencies.jar

[klund] Revert "GEODE-3062: create new SecurityService after receiving cluster

--
[...truncated 112.87 KB...]

java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 1767

[error 2017/06/15 04:35:08.354 UTC  
tid=0x2d5] Exception deserializing message payload: [dst: 
asf914.gq1.ygridcore.net:32771, src: asf914.gq1.ygridcore.net:32770 (2 
headers), size=1388 bytes, flags=OOB|DONT_BUNDLE|NO_FC|SKIP_BARRIER]
java.lang.Exception: Message id is -150
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readEncryptedMessage(JGroupsMessenger.java:1109)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readJGMessage(JGroupsMessenger.java:1010)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1278)
at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
at org.jgroups.JChannel.up(JChannel.java:741)
at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
at org.jgroups.protocols.TP.receive(TP.java:1654)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at 
org.apache.geode.distributed.internal.membership.gms.messenger.GMSEncrypt.getClusterSecretKey(GMSEncrypt.java:103)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.GMSEncrypt.getClusterEncryptor(GMSEncrypt.java:290)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.GMSEncrypt.decryptData(GMSEncrypt.java:153)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readEncryptedMessage(JGroupsMessenger.java:1088)
... 20 more

---
Found suspect string in log4j at line 1820

[error 2017/06/15 04:35:18.333 UTC  
tid=0x2d5] Exception deserializing message payload: [dst: 
asf914.gq1.ygridcore.net:32771, src: asf914.gq1.ygridcore.net:32770 (2 
headers), size=218 bytes, flags=OOB|DONT_BUNDLE|NO_FC|SKIP_BARRIER]
java.lang.Exception: Message id is -153
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readEncryptedMessage(JGroupsMessenger.java:1109)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.readJGMessage(JGroupsMessenger.java:1010)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1278)
at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
at

Build failed in Jenkins: Geode-nightly #866

2017-06-14 Thread Apache Jenkins Server

See 


Changes:

[jiliao] GEODE-2294: revert to avoid rest protocol change

[jiliao] Resolve Eclipse/IntelliJ import order disagreement in style files.

--
[...truncated 134.84 KB...]
at java.net.Socket.connect(Socket.java:538)
at java.net.Socket.(Socket.java:434)
at java.net.Socket.(Socket.java:211)
at 
sun.rmi.transport.proxy.RMIDirectSocketFactory.createSocket(RMIDirectSocketFactory.java:40)
at 
sun.rmi.transport.proxy.RMIMasterSocketFactory.createSocket(RMIMasterSocketFactory.java:148)
at 
sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:613)
... 13 more

org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.client.internal.LocatorTestBase$1.run in VM 1 running on 
Host asf912.gq1.ygridcore.net with 4 VMs

Caused by:
java.rmi.ConnectException: Connection refused to host: 67.195.81.156; 
nested exception is: 
java.net.ConnectException: Connection refused (Connection 
refused)

Caused by:
java.net.ConnectException: Connection refused (Connection refused)

org.apache.geode.rest.internal.web.controllers.RestAPIsWithSSLDUnitTest > 
testSSLWithoutKeyStoreTypeLegacy[1] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.test.dunit.NamedRunnable.run in VM 1 running on Host 
asf912.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.execute(VM.java:453)
at org.apache.geode.test.dunit.VM.invoke(VM.java:370)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:280)
at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:57)
at 
org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.disconnectAllFromDS(JUnit4DistributedTestCase.java:308)
at 
org.apache.geode.rest.internal.web.controllers.RestAPIsWithSSLDUnitTest.preSetUp(RestAPIsWithSSLDUnitTest.java:108)

Caused by:
java.rmi.ConnectException: Connection refused to host: 67.195.81.156; 
nested exception is: 
java.net.ConnectException: Connection refused (Connection 
refused)
at sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:619)
at 
sun.rmi.transport.tcp.TCPChannel.createConnection(TCPChannel.java:216)
at 
sun.rmi.transport.tcp.TCPChannel.newConnection(TCPChannel.java:202)
at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:130)
at 
java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:227)
at 
java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:179)
at com.sun.proxy.$Proxy51.executeMethodOnObject(Unknown Source)
at org.apache.geode.test.dunit.VM.execute(VM.java:450)
... 6 more

Caused by:
java.net.ConnectException: Connection refused (Connection refused)
at java.net.PlainSocketImpl.socketConnect(Native Method)
at 
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
at 
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
at 
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at java.net.Socket.connect(Socket.java:538)
at java.net.Socket.(Socket.java:434)
at java.net.Socket.(Socket.java:211)
at 
sun.rmi.transport.proxy.RMIDirectSocketFactory.createSocket(RMIDirectSocketFactory.java:40)
at 
sun.rmi.transport.proxy.RMIMasterSocketFactory.createSocket(RMIMasterSocketFactory.java:148)
at 
sun.rmi.transport.tcp.TCPEndpoint.newSocket(TCPEndpoint.java:613)
... 13 more

org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.client.internal.LocatorTestBase$1.run in VM 1 running on 
Host asf912.gq1.ygridcore.net with 4 VMs

Caused by:
java.rmi.ConnectException: Connection refused to host: 67.195.81.156; 
nested exception is: 
java.net.ConnectException: Connection refused (Connection 
refused)

Caused by:
java.net.ConnectException: Connection refused (Connection refused)

org.apache.geode.rest.internal.web.controllers.RestAPIsWithSSLDUnitTest > 
testMutualAuthentication[1] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.test.dunit.NamedRunnable.run in VM 1 running on Host 
asf912.gq1.ygridcore.net with 4 VMs
at

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60028/
---

(Updated June 15, 2017, 3:33 a.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Changed the SecuirtyManagerInitializer to SecurityManagerProvider after 
discussion with Kirk. This should help better mocking and better unit tests.


Repository: geode


Description
---

* combine EnabledSecurityService and CustomSecurityService into 
IntegratedSecurityService
* combine DisabledSecurityService and LegacySecurityService
* combine ConfigInitalizer and RealmInitilizer
* provide default impelementations of SecurityService
* consolidate SecurityService creation.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 22edb6f06c7791929cc9a033ca1a1bfed5751a47 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
  
geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
 3ff632d3857189513243959ee96da89da66d5a27 
  
geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
 0ba1cb62468f15fda60a94dac9c781fe1793b28f 
  
geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
 b50569036db1acac927f08ee5c1771c72ede3c1d 
  
geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
 f0568c0ebc2b17c47b5059c60aa4f8bd500c5d6c 
  
geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
 44562537bc426e47a42d680bb410dc59bf9bd854 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 a4041e198f1a9a4961915504c51256d0b03aa7c2 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
 02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
 8ae76d22b628b3175db45116b80dfcfbe34aba1d 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
 60f014b9c33732a4ea134a654e666a9439b210bb 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
 51449fdd5570494f3cf91325985a5eb9fc9f6d57 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
 978c4dd0ab92afde53972f7feb9d8f018d0bf662 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
 a0c3cf3074051990cc50755131f8024db0b1faad 
  
geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
 cacbeed957c3b87d08c93db74e38e0134565f699 
  
geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java
 fca7eae9413cee98d351db5349fd950d3aa56180 
  
geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
 70823443b5c4f776c86bb28ed49a73e690c5c872 
  
geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
 ca4e6b7fb462bb4e3fefbc5db8a9503c6b13a865 
  
geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java
 89070123978c22c4cfa8684fbb5b033dc9d83ffa 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java
 f027a4367b38681f83dad2d4c4add67759633644 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java
 44893520962331bcd41e972afa661538c28d4fb2 
  
geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java
 857c0be8940b4acde2aa4992fac0122b687391c2 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java
 01d6bb6488e76fb3cf652ad211e9f7e2fac51389 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java
 1caedbcede239d6a96640381cc6941948637b442 
  
geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java
 cdb90f1b580edaf6a2762883d4159a45d69c4728 
  
geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleDistributedTest.java
 a9048b9219a494f61e3873ee3f2908da04bf6154 
  geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java 
63f907cb007846626a9a66dc6b1ef28e0bb6db45 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java
 767588d3717fccbb0b9c7dec7c5439e16d5381aa 


Diff:

Re: Revert gradle upgrade

2017-06-14 Thread Mark Bretl

I think I figured it out.

Here is what I did:
Fix was to declare the version of Antlr in the dependencies{} because if no
version is set, the ANTLR plugin would default to 2.7.7. This was causing
issues since the ANTLR plugin was trying to 'change' the version after
dependency resolution for its configuration.

I successfully tested imported into Eclipse, so I have checked in the
changes on the feature/gradle-3.4.1 branch. Would others take some time to
see if it works for them now?

--Mark

On Tue, May 9, 2017 at 10:51 AM, Udo Kohlmeyer 
wrote:

> I think we have to check the ANTLR plugin to understand it's requirements..
>
> maybe there is a newer plugin version for ANTLR
>
>
> On 5/9/17 10:00, Kirk Lund wrote:
>
>> I've reverted the upgrade to gradle 3.4.1. I also went ahead and created a
>> branch that repeats the upgrade:
>>
>> feature/gradle-3.4.1
>>
>> Feel free to experiment with that branch.
>>
>> On Tue, May 9, 2017 at 9:53 AM, Kirk Lund  wrote:
>>
>> I'll go ahead and revert the upgrade. Hopefully we can eventually find the
>>> cause so we can repeat the upgrade.
>>>
>>> On Mon, May 8, 2017 at 4:19 PM, Bruce Schuchardt >> >
>>> wrote:
>>>
>>> The "eclipse" target fails, too.

 Le 5/8/2017 à 3:32 PM, Kirk Lund a écrit :

 I want to revert the gradle upgrade because it breaks IntelliJ and the
> idea
> gradle task. Please let me know if you have a problem with this.
>
> PS: Please be prepared to help me if you vote against me reverting the
> upgrade ;) I really want to be able to work again. Thanks!
>
>
>
>

Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-14 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60106/
---

Review request for geode and Hitesh Khamesra.

Bugs: GEODE-3052
https://issues.apache.org/jira/browse/GEODE-3052

Repository: geode

Description
---

There were four problems that new unit tests hit:
1. when recovering a view from disk we were treating it as a definitive (live)
view. I've moved it to a new variable in GMSLocator and set its viewId to -1.
At the same time I set the initial GMSJoinLeave SearchState.viewId to -100 so
it will be overridden by the one returned by the locator. These changes allow
GmsJoinLeave to know that the potential coordinator is from a recovered view.
2. when trying to join with a recovered view GMSJoinLeave.join() was giving up
after the second ID in the view and becoming the coordinator. It needs to keep
trying until the list is exhausted, and it shouldn't sleep between attempts.
3. GMSLocator wasn't returning registrants for use in
findCoordinatorFromView(). This was causing it to choose itself as the
coordinator instead of using registrant sort order and choosing a different
registrant as the coordinator.
4. During concurrent startup GMSLocator didn't know when the decision was made
to become coordinator. It is now notified of this decision and
processRequest() uses this flag to have it override anything in the registrants
set or in the recovered view.

Diffs
-

geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java
26b03276b0abbf6210a5602a8c551abe38edc261

geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java
c6bef571134c6444a297cc8fe0bb0b7eb95f41f4

geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/Locator.java
c5fdf45411581a36feca220e14a0551f3197d368

geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
93fa9dab4ec2c8e43fc41cfd3b8ad986f96cf00f

geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
8abcc456e42ad00a558a93f87bd3ae74ce88d146
geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java
7ecca6146f6b7a542ae9864d7fabd48c9794ecac

geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java
df1d8d1101a5f9d04c402922955a283353aa3b7c

geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java
19cee066a488198471ebf4093045853e36d5ba78

Diff: https://reviews.apache.org/r/60106/diff/1/

Testing
---

New unit tests, regression testing (under way), precheckin (under way)

Thanks,

Bruce Schuchardt

Re: release 1.2

2017-06-14 Thread Anthony Baker

Agreed.  Please merge to release/1.2.0 when ready.

Anthony

> On Jun 14, 2017, at 1:46 PM, Lynn Hughes-Godfrey  
> wrote:
> 
> We would like to include the fix for (GEODE-3072) Events do not get removed
> from the client queue when 1.0 clients connect to 1.2 servers
> 
> On Wed, Jun 14, 2017 at 12:25 PM, Fred Krone  wrote:
> 
>> Reviewing our JTA transaction manager implementation during a recent issue
>> we thought it would be useful to log message for users when our
>> implementation is being used (which is by default but potentially unknown).
>> 
>> 
>> It's small but not critical -- we thought we might get it in if the 1.2
>> release lingered.  Eric was running pre-check-in on it.
>> 
>> On Wed, Jun 14, 2017 at 12:17 PM, Anthony Baker  wrote:
>> 
>>> 
 On Jun 14, 2017, at 12:03 PM, Eric Shu  wrote:
 
 I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE
 implementation of JTA transaction manager)
 
 -Eric
>>> 
>>> Thanks Eric.  Can you make a case for why this change needs to go into
>>> 1.2.0?  We’re pretty locked down on 1.2.0 changes and unless it’s a
>>> critical issue I’d prefer to not introduce more changes.
>>> 
>>> Has the deprecation of this feature been discussed?
>>> 
>>> Anthony
>>> 
>>> 
>>

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Darrel Schneider


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60051/#review177963
---


Ship it!




Ship It!

- Darrel Schneider


On June 14, 2017, 3:24 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60051/
> ---
> 
> (Updated June 14, 2017, 3:24 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-2301
> https://issues.apache.org/jira/browse/GEODE-2301
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> User should use third-party JTA transaction manager.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/GlobalTransaction.java 
> 03eeb20 
>   geode-core/src/main/java/org/apache/geode/internal/jta/TransactionImpl.java 
> a5e80b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/TransactionManagerImpl.java
>  15ab1f8 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/UserTransactionImpl.java
>  2471e02 
>   geode-core/src/main/java/org/apache/geode/internal/jta/XidImpl.java 865f0aa 
> 
> 
> Diff: https://reviews.apache.org/r/60051/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Darrel Schneider


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60051/#review177962
---




geode-core/src/main/java/org/apache/geode/internal/jta/TransactionManagerImpl.java
Lines 110 (patched)


add final to this field


- Darrel Schneider


On June 14, 2017, 3:24 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60051/
> ---
> 
> (Updated June 14, 2017, 3:24 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-2301
> https://issues.apache.org/jira/browse/GEODE-2301
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> User should use third-party JTA transaction manager.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/GlobalTransaction.java 
> 03eeb20 
>   geode-core/src/main/java/org/apache/geode/internal/jta/TransactionImpl.java 
> a5e80b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/TransactionManagerImpl.java
>  15ab1f8 
>   
> geode-core/src/main/java/org/apache/geode/internal/jta/UserTransactionImpl.java
>  2471e02 
>   geode-core/src/main/java/org/apache/geode/internal/jta/XidImpl.java 865f0aa 
> 
> 
> Diff: https://reviews.apache.org/r/60051/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-06-14 Thread upthewaterspout

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/570#discussion_r122085382
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
@@ -1472,6 +1472,19 @@ public boolean removeBucket(int bucketId, boolean 
forceRemovePrimary) {
   }
 
   BucketAdvisor bucketAdvisor = bucketRegion.getBucketAdvisor();
+  InternalDistributedMember primary = bucketAdvisor.getPrimary();
+  InternalDistributedMember myId =
+  
this.partitionedRegion.getDistributionManager().getDistributionManagerId();
+  if (primary == null || myId.equals(primary)) {
--- End diff --

This seems similar to the logic a few lines down where we say "if 
(!forceRemovePrimary && bucketAdvisor.isPrimary()) {..."

Unlike that line, your new logic doesn't honor the forceRemovePrimary flag. 
Should it? I don't actually see any cases where that is passed in as true, so 
maybe we should just remove that flag?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #585 was SUCCESSFUL (with 1868 tests)

2017-06-14 Thread Spring CI


---
Spring Data GemFire > Nightly-ApacheGeode > #585 was successful.
---
Scheduled
1870 tests in total.

https://build.spring.io/browse/SGF-NAG-585/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

2017-06-14 Thread Eric Shu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60051/
---

(Updated June 14, 2017, 10:24 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Swapnil Bawaskar.


Changes
---

Fix review comments, add a warning message if Geode JTA transaction manager is 
used in JTA transaction.


Bugs: GEODE-2301
https://issues.apache.org/jira/browse/GEODE-2301


Repository: geode


Description
---

User should use third-party JTA transaction manager.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/jta/GlobalTransaction.java 
03eeb20 
  geode-core/src/main/java/org/apache/geode/internal/jta/TransactionImpl.java 
a5e80b6 
  
geode-core/src/main/java/org/apache/geode/internal/jta/TransactionManagerImpl.java
 15ab1f8 
  
geode-core/src/main/java/org/apache/geode/internal/jta/UserTransactionImpl.java 
2471e02 
  geode-core/src/main/java/org/apache/geode/internal/jta/XidImpl.java 865f0aa 


Diff: https://reviews.apache.org/r/60051/diff/2/

Changes: https://reviews.apache.org/r/60051/diff/1-2/


Testing
---


Thanks,

Eric Shu

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/580#discussion_r122067285
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
 ---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria(Object row, 
ExecutionContext context)
 // No op
   }
 
+  private int compareHelperMethod(Object obj1, Object obj2) {
+if (obj1 == null || obj2 == null) {
+  return compareIfOneOrMoreNull(obj1, obj2);
+} else if (obj1 == QueryService.UNDEFINED || obj2 == 
QueryService.UNDEFINED) {
+  return compareIfOneOrMoreQueryServiceUndefined(obj1, obj2);
+} else {
+  return compareTwoObjects(obj1, obj2);
+}
+  }
+
+  private int compareIfOneOrMoreNull(Object obj1, Object obj2) {
+if (obj1 == null) {
+  return obj2 == null ? 0 : -1;
+} else {
+  return 1;
+}
+  }
+
+  private int compareIfOneOrMoreQueryServiceUndefined(Object obj1, Object 
obj2) {
+if (obj1 == QueryService.UNDEFINED) {
+  return obj2 == QueryService.UNDEFINED ? 0 : -1;
+} else {
+  return 1;
+}
+  }
+
+  private int compareTwoObjects(Object obj1, Object obj2) {
+if (obj1 instanceof Number && obj2 instanceof Number) {
+  return compareTwoNumbers(obj1, obj2);
+} else {
+  return compareTwoStrings(obj1, obj2);
+}
+  }
+
+  private int compareTwoNumbers(Object obj1, Object obj2) {
--- End diff --

Oh no, that's very true! I'll fix this and update the PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/580#discussion_r122066276
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
 ---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria(Object row, 
ExecutionContext context)
 // No op
   }
 
+  private int compareHelperMethod(Object obj1, Object obj2) {
+if (obj1 == null || obj2 == null) {
+  return compareIfOneOrMoreNull(obj1, obj2);
+} else if (obj1 == QueryService.UNDEFINED || obj2 == 
QueryService.UNDEFINED) {
+  return compareIfOneOrMoreQueryServiceUndefined(obj1, obj2);
+} else {
+  return compareTwoObjects(obj1, obj2);
+}
+  }
+
+  private int compareIfOneOrMoreNull(Object obj1, Object obj2) {
+if (obj1 == null) {
+  return obj2 == null ? 0 : -1;
+} else {
+  return 1;
+}
+  }
+
+  private int compareIfOneOrMoreQueryServiceUndefined(Object obj1, Object 
obj2) {
+if (obj1 == QueryService.UNDEFINED) {
+  return obj2 == QueryService.UNDEFINED ? 0 : -1;
+} else {
+  return 1;
+}
+  }
+
+  private int compareTwoObjects(Object obj1, Object obj2) {
+if (obj1 instanceof Number && obj2 instanceof Number) {
+  return compareTwoNumbers(obj1, obj2);
+} else {
+  return compareTwoStrings(obj1, obj2);
+}
+  }
+
+  private int compareTwoNumbers(Object obj1, Object obj2) {
--- End diff --

I see it was not introduced by your changes, but the subtraction on 177 is 
not a safe way to compare doubles as it can result in under/overflow.  For 
example, consider the result of `compareTwoNumbers( Double.MAX_VALUE, -1d)`.  
Here's a safer way to do it:

```
  private int compareTwoNumbers(Object obj1, Object obj2) {
Number number1 = (Number) obj1;
Number number2 = (Number) obj2 ;
return Double.compare(number1.doubleValue(), number2.doubleValue());
  }
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Patrick Rhomberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60028/#review177951
---



I pulled this diff and incorporated everything into my finer-grained-security 
things, since we were overlapping a lot.

- Patrick Rhomberg


On June 13, 2017, 9:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60028/
> ---
> 
> (Updated June 13, 2017, 9:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * combine EnabledSecurityService and CustomSecurityService into 
> IntegratedSecurityService
> * combine DisabledSecurityService and LegacySecurityService
> * combine ConfigInitalizer and RealmInitilizer
> * provide default impelementations of SecurityService
> * consolidate SecurityService creation.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  3ff632d3857189513243959ee96da89da66d5a27 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  0ba1cb62468f15fda60a94dac9c781fe1793b28f 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  b50569036db1acac927f08ee5c1771c72ede3c1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
>  f0568c0ebc2b17c47b5059c60aa4f8bd500c5d6c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  44562537bc426e47a42d680bb410dc59bf9bd854 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  a4041e198f1a9a4961915504c51256d0b03aa7c2 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  8ae76d22b628b3175db45116b80dfcfbe34aba1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  60f014b9c33732a4ea134a654e666a9439b210bb 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  51449fdd5570494f3cf91325985a5eb9fc9f6d57 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
>  978c4dd0ab92afde53972f7feb9d8f018d0bf662 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ShiroSecurityManagerInitializer.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
>  a0c3cf3074051990cc50755131f8024db0b1faad 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
>  cacbeed957c3b87d08c93db74e38e0134565f699 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java
>  fca7eae9413cee98d351db5349fd950d3aa56180 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
>  70823443b5c4f776c86bb28ed49a73e690c5c872 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
>  ca4e6b7fb462bb4e3fefbc5db8a9503c6b13a865 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java
>  89070123978c22c4cfa8684fbb5b033dc9d83ffa 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java
>  f027a4367b38681f83dad2d4c4add67759633644 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java
>  44893520962331bcd41e972afa661538c28d4fb2 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java
>  857c0be8940b4acde2aa4992fac0122b687391c2 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java
>  01d6bb6488e76fb3cf652ad211e9f7e2fac51389 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java
>  1caedbcede239d6a96640381cc6941948637b442 
>   
> geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java
>

Re: release 1.2

2017-06-14 Thread Lynn Hughes-Godfrey

We would like to include the fix for (GEODE-3072) Events do not get removed
from the client queue when 1.0 clients connect to 1.2 servers

On Wed, Jun 14, 2017 at 12:25 PM, Fred Krone  wrote:

> Reviewing our JTA transaction manager implementation during a recent issue
> we thought it would be useful to log message for users when our
> implementation is being used (which is by default but potentially unknown).
>
>
> It's small but not critical -- we thought we might get it in if the 1.2
> release lingered.  Eric was running pre-check-in on it.
>
> On Wed, Jun 14, 2017 at 12:17 PM, Anthony Baker  wrote:
>
> >
> > > On Jun 14, 2017, at 12:03 PM, Eric Shu  wrote:
> > >
> > > I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE
> > > implementation of JTA transaction manager)
> > >
> > > -Eric
> >
> > Thanks Eric.  Can you make a case for why this change needs to go into
> > 1.2.0?  We’re pretty locked down on 1.2.0 changes and unless it’s a
> > critical issue I’d prefer to not introduce more changes.
> >
> > Has the deprecation of this feature been discussed?
> >
> > Anthony
> >
> >
>

Build failed in Jenkins: Geode-release-flaky #14

2017-06-14 Thread Apache Jenkins Server

See 


Changes:

[jiliao] GEODE-2294: revert to avoid rest protocol change

[abaker] Update LICENSE after review

[abaker] GEODE-3024 race condition between server locator preparing membership

[abaker] GEODE-3024 race condition between server locator preparing membership

--
[...truncated 114.09 KB...]
:geode-assembly:testClasses
:geode-assembly:flakyTest

org.apache.geode.management.internal.configuration.ClusterConfigurationServiceEndToEndDUnitTest
 > testStartServerAndExecuteCommands FAILED
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.geode.management.internal.configuration.ClusterConfigurationServiceEndToEndDUnitTest.startServers(ClusterConfigurationServiceEndToEndDUnitTest.java:158)
at 
org.apache.geode.management.internal.configuration.ClusterConfigurationServiceEndToEndDUnitTest.testStartServerAndExecuteCommands(ClusterConfigurationServiceEndToEndDUnitTest.java:131)

1 test completed, 1 failed
:geode-assembly:flakyTest FAILED
:geode-benchmarks:compileTestJava UP-TO-DATE
:geode-benchmarks:processTestResources UP-TO-DATE
:geode-benchmarks:testClasses UP-TO-DATE
:geode-benchmarks:flakyTest UP-TO-DATE
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:flakyTest
:geode-core:flakyTest

org.apache.geode.internal.cache.execute.FunctionServiceMultipleOnMemberDUnitTest
 > classMethod FAILED
java.lang.RuntimeException: Unable to launch dunit VMs

Caused by:
java.lang.RuntimeException: VMs did not start up within 120 seconds

282 tests completed, 1 failed, 6 skipped
:geode-core:flakyTest FAILED
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:flakyTest
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:flakyTest UP-TO-DATE
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:flakyTest
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-phonetic/6.4.1/lucene-analyzers-phonetic-6.4.1.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.4.0/randomizedtesting-parent-2.4.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-phonetic/6.4.1/lucene-analyzers-phonetic-6.4.1.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:flakyTest
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:flakyTest
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-pulse:compileTestJava
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-test/4.3.6.RELEASE/spring-test-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.jar
Download

[GitHub] geode pull request #579: GEODE-3070: Fix gemfire.jar to be geode-dependencie...

2017-06-14 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/579


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/580#discussion_r122055572
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
 ---
@@ -45,78 +44,50 @@ public OrderByComparator(List 
orderByAttrs, ObjectType ob
   }
 
   /**
-   * Yogesh : This methods evaluates sort criteria and returns a ArrayList 
of Object[] arrays of
-   * evaluated criteria
+   * This method evaluates sort criteria and returns an ArrayList of 
Object[] arrays of the
+   * evaluated criteria.
* 
-   * @param value
-   * @return Object[]
+   * @param value the criteria to be evaluated.
+   * @return an Object array of Object arrays of the evaluated criteria.
*/
   protected Object[] evaluateSortCriteria(Object value) {
-
 CompiledSortCriterion csc;
 Object[] array = null;
 if (orderByAttrs != null) {
   array = new Object[orderByAttrs.size()];
-  Iterator orderiter = orderByAttrs.iterator();
+  Iterator orderIter = orderByAttrs.iterator();
   int i = 0;
-  while (orderiter.hasNext()) {
-csc = (CompiledSortCriterion) orderiter.next();
-Object[] arr = new Object[2];
-arr[0] = csc.evaluate(value, context);
-arr[1] = Boolean.valueOf(csc.getCriterion());
+  while (orderIter.hasNext()) {
--- End diff --

Fixed, and updating the PR now - thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: release 1.2

2017-06-14 Thread Fred Krone

Reviewing our JTA transaction manager implementation during a recent issue
we thought it would be useful to log message for users when our
implementation is being used (which is by default but potentially unknown).

It's small but not critical -- we thought we might get it in if the 1.2
release lingered.  Eric was running pre-check-in on it.

On Wed, Jun 14, 2017 at 12:17 PM, Anthony Baker  wrote:

>
> > On Jun 14, 2017, at 12:03 PM, Eric Shu  wrote:
> >
> > I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE
> > implementation of JTA transaction manager)
> >
> > -Eric
>
> Thanks Eric.  Can you make a case for why this change needs to go into
> 1.2.0?  We’re pretty locked down on 1.2.0 changes and unless it’s a
> critical issue I’d prefer to not introduce more changes.
>
> Has the deprecation of this feature been discussed?
>
> Anthony
>
>

Re: release 1.2

2017-06-14 Thread Anthony Baker

> On Jun 14, 2017, at 12:03 PM, Eric Shu  wrote:
> 
> I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE
> implementation of JTA transaction manager)
> 
> -Eric

Thanks Eric.  Can you make a case for why this change needs to go into 1.2.0?  
We’re pretty locked down on 1.2.0 changes and unless it’s a critical issue I’d 
prefer to not introduce more changes.

Has the deprecation of this feature been discussed?

Anthony

Re: release 1.2

2017-06-14 Thread Eric Shu

I'd like to include GEODE-2301 in the release 1.2.0 (deprecate GEODE
implementation of JTA transaction manager)

-Eric

On Wed, Jun 14, 2017 at 11:50 AM, Anthony Baker  wrote:

> Status update:
>
> - I think we have all changes needed in the release/1.2.0 branch [1].
> Please shout out if not.
> - The last 2 Geode-release jenkins runs have timed out / hung [2].  Please
> review to see if there are changes needed.
> - I’ve completed the LICENSE review [3].
>
> Anthony
>
> [1] https://github.com/apache/geode/tree/release/1.2.0 <
> https://github.com/apache/geode/tree/release/1.2.0>
> [2] https://builds.apache.org/job/Geode-release/ <
> https://builds.apache.org/job/Geode-release/>
> [3] https://github.com/apache/geode/commit/24192d4fbc8739d0f4dae2b4de5c8f
> d00b82ad32  24192d4fbc8739d0f4dae2b4de5c8fd00b82ad32>
>
>
> > On Jun 13, 2017, at 9:44 AM, Anthony Baker  wrote:
> >
> > Vahram,
> >
> > Thanks for advocating for this issue!  While the release it pretty
> locked down for changes, this looks like a low risk change for an important
> issue.  I’ll cherry-pick the changes onto release/1.2.0.
> >
> > I also see that a breaking change to the REST API was made in
> ‘c39585395a’.  Can someone take a look at the message vs cause naming for
> errors?
> >
> > Anthony
> >
> >> On Jun 12, 2017, at 9:43 AM, Vahram Aharonyan  > wrote:
> >>
> >> Hi All,
> >>
> >> We really think fix done for GEODE-3023 should be considered for 1.2
> version as well. Especially since similar fix(GEODE-2898) has been already
> made it to 1.2 version. So shipping a partial/incomplete fix in 1.2 version
> for the same kind of problem does not really provide value, and still
> leaves the system exposed with a resiliency problem in case of network
> problems.
> >>
> >> The problem is indeed critical, it is hitting on nearly every
> meaningfully large environment which has reasonable amount of network
> issues. It turns out that this problem is impacting entire Geode cluster,
> whenever there is Geode client with let say imperfect quality of network
> connectivity.  To overcome this SSL should be disabled for the cluster,
> which is not the best way to proceed.
> >>
> >> Thanks,
> >> Vahram.
> >>
> >> -Original Message-
> >> From: Anthony Baker [mailto:aba...@pivotal.io  >]
> >> Sent: Monday, June 12, 2017 7:42 PM
> >> To: dev@geode.apache.org 
> >> Subject: Re: release 1.2
> >>
> >> Got it, thanks!
> >>
> >> Anthony
> >>
> >>> On Jun 10, 2017, at 7:15 PM, Udo Kohlmeyer  > wrote:
> >>>
> >>> I thought we had moved GEODE-3052 to a later release, given that we
> have a work around for this.
> >>>
> >>> --Udo
> >>>
> >>>
> >>> On 6/10/17 10:15, Anthony Baker wrote:
>  Status update:
> 
>  We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a
> clean run of the Geode-release jenkins job.  So as soon as we can finish
> off these issues and get another clean run through Jenkins I’ll create a
> release candidate.  How does early next week sound?
> 
>  Anthony
> 
> > On Jun 8, 2017, at 5:38 PM, Anthony Baker  > wrote:
> >
> > Sounds good.  Please cherry-pick these changes onto release/1.2.0
> when ready.
> >
> > Anthony
> >
> >
> >> On Jun 8, 2017, at 3:15 PM, Jared Stewart  > wrote:
> >>
> >> I think we probably ought to include GEODE-3045 <
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__issues.apache.org_jira_browse_GEODE-2D3045=DwIFaQ&
> c=uilaK90D4TOVoH58JNXRgQ=wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=
> 3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=9jqjvxoQ-
> RJtsGGvTMldMcrooymcWVqjQhb4GoQ1GQ8=  proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_
> browse_GEODE-2D3045=DwIFaQ=uilaK90D4TOVoH58JNXRgQ=
> wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=
> 3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=9jqjvxoQ-
> RJtsGGvTMldMcrooymcWVqjQhb4GoQ1GQ8=> > as well.
> >>
> >>> On Jun 8, 2017, at 3:12 PM, Kenneth Howe  > wrote:
> >>>
> >>> I think we should also include the fix for GEODE-3054 in 1.2. This
> is a bug that was introduced in the recent changes to the Gfsh parser, and
> affects Windows pathnames specified in options to gfsh commands.
> >>>
> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.
> apache.org_jira_browse_GEODE-2D3054=DwIFaQ=uilaK90D4TOVoH58JNXRgQ=
> wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=
> 3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=
> jSeNlEnjklIGLNnCF8I6cG0t06n2NT5xLBe86ewSmXc=  proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_
>

Re: release 1.2

2017-06-14 Thread Anthony Baker

Status update:

- I think we have all changes needed in the release/1.2.0 branch [1].  Please 
shout out if not.
- The last 2 Geode-release jenkins runs have timed out / hung [2].  Please 
review to see if there are changes needed.
- I’ve completed the LICENSE review [3].

Anthony

[1] https://github.com/apache/geode/tree/release/1.2.0 

[2] https://builds.apache.org/job/Geode-release/ 

[3] 
https://github.com/apache/geode/commit/24192d4fbc8739d0f4dae2b4de5c8fd00b82ad32 



> On Jun 13, 2017, at 9:44 AM, Anthony Baker  wrote:
> 
> Vahram, 
> 
> Thanks for advocating for this issue!  While the release it pretty locked 
> down for changes, this looks like a low risk change for an important issue.  
> I’ll cherry-pick the changes onto release/1.2.0.
> 
> I also see that a breaking change to the REST API was made in ‘c39585395a’.  
> Can someone take a look at the message vs cause naming for errors?
> 
> Anthony
> 
>> On Jun 12, 2017, at 9:43 AM, Vahram Aharonyan > > wrote:
>> 
>> Hi All,
>> 
>> We really think fix done for GEODE-3023 should be considered for 1.2 version 
>> as well. Especially since similar fix(GEODE-2898) has been already made it 
>> to 1.2 version. So shipping a partial/incomplete fix in 1.2 version for the 
>> same kind of problem does not really provide value, and still leaves the 
>> system exposed with a resiliency problem in case of network problems.
>> 
>> The problem is indeed critical, it is hitting on nearly every meaningfully 
>> large environment which has reasonable amount of network issues. It turns 
>> out that this problem is impacting entire Geode cluster, whenever there is 
>> Geode client with let say imperfect quality of network connectivity.  To 
>> overcome this SSL should be disabled for the cluster, which is not the best 
>> way to proceed.
>> 
>> Thanks,
>> Vahram.
>> 
>> -Original Message-
>> From: Anthony Baker [mailto:aba...@pivotal.io ] 
>> Sent: Monday, June 12, 2017 7:42 PM
>> To: dev@geode.apache.org 
>> Subject: Re: release 1.2
>> 
>> Got it, thanks!
>> 
>> Anthony
>> 
>>> On Jun 10, 2017, at 7:15 PM, Udo Kohlmeyer >> > wrote:
>>> 
>>> I thought we had moved GEODE-3052 to a later release, given that we have a 
>>> work around for this.
>>> 
>>> --Udo
>>> 
>>> 
>>> On 6/10/17 10:15, Anthony Baker wrote:
 Status update:
 
 We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a clean 
 run of the Geode-release jenkins job.  So as soon as we can finish off 
 these issues and get another clean run through Jenkins I’ll create a 
 release candidate.  How does early next week sound?
 
 Anthony
 
> On Jun 8, 2017, at 5:38 PM, Anthony Baker  > wrote:
> 
> Sounds good.  Please cherry-pick these changes onto release/1.2.0 when 
> ready.
> 
> Anthony
> 
> 
>> On Jun 8, 2017, at 3:15 PM, Jared Stewart > > wrote:
>> 
>> I think we probably ought to include GEODE-3045 
>> >  
>> 
>>  > as well.
>> 
>>> On Jun 8, 2017, at 3:12 PM, Kenneth Howe >> > wrote:
>>> 
>>> I think we should also include the fix for GEODE-3054 in 1.2. This is a 
>>> bug that was introduced in the recent changes to the Gfsh parser, and 
>>> affects Windows pathnames specified in options to gfsh commands.
>>> 
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_GEODE-2D3054=DwIFaQ=uilaK90D4TOVoH58JNXRgQ=wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=jSeNlEnjklIGLNnCF8I6cG0t06n2NT5xLBe86ewSmXc=
>>>  
>>> 
>>>   
>>>

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

2017-06-14 Thread YehEmily

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/580

GEODE-2936: Refactoring OrderByComparator

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-2936)

`OrderByComparator.java` contained a lot of redundant and confusing code, 
as well as somewhat misleading comments (for example, the `compare` method was 
supposed to throw a `ClassCastException` if the parameters given could not be 
compared using this comparator, but it didn't. This has been fixed). Code that 
is shared by both the `compare` and `evaluateSortCriteria` methods has been 
moved to helper methods to improve readability and reduce redundancy.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2936-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #580


commit 3ff6d0a2b4f097947e337f5567b641aeadfb0e22
Author: Jinmei Liao 
Date:   2017-06-07T23:10:56Z

GEODE-2936: Refactoring OrderByComparator to reduce redundant code and 
improve readability.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release #63

2017-06-14 Thread Apache Jenkins Server

See 


Changes:

[abaker] GEODE-3023: TcpServer move soTimout for the socket for SSL Locators

[abaker] GEODE-3023: removing incorrect assertion

[abaker] Fix spotless failure

--
[...truncated 52.58 KB...]
:extensions/geode-modules-session:signArchives SKIPPED
:extensions/geode-modules-session:assemble
:extensions/geode-modules-assembly:distAppServer
:extensions/geode-modules-tomcat7:compileJava
:extensions/geode-modules-tomcat7:processResources UP-TO-DATE
:extensions/geode-modules-tomcat7:classes
:extensions/geode-modules-tomcat7:jar
:extensions/geode-modules-tomcat7:javadoc
:extensions/geode-modules-tomcat7:javadocJar
:extensions/geode-modules-tomcat7:sourcesJar
:extensions/geode-modules-tomcat7:signArchives SKIPPED
:extensions/geode-modules-tomcat7:assemble
:extensions/geode-modules-tomcat8:compileJava
:extensions/geode-modules-tomcat8:processResources UP-TO-DATE
:extensions/geode-modules-tomcat8:classes
:extensions/geode-modules-tomcat8:jar
:extensions/geode-modules-tomcat8:javadoc
:extensions/geode-modules-tomcat8:javadocJar
:extensions/geode-modules-tomcat8:sourcesJar
:extensions/geode-modules-tomcat8:signArchives SKIPPED
:extensions/geode-modules-tomcat8:assemble
:extensions/geode-modules-assembly:distTcServer
:extensions/geode-modules-assembly:distTcServer30
:extensions/geode-modules-assembly:distTomcat
:extensions/geode-modules-assembly:dist
:extensions/geode-modules-assembly:build
:extensions/geode-modules-assembly:distributedTest UP-TO-DATE
:extensions/geode-modules-assembly:integrationTest UP-TO-DATE
:extensions/geode-modules-session:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-session:processTestResources
:extensions/geode-modules-session:testClasses
:extensions/geode-modules-session:checkMissedTests
:extensions/geode-modules-session:spotlessJavaCheck
:extensions/geode-modules-session:spotlessCheck
:extensions/geode-modules-session:test
:extensions/geode-modules-session:check
:extensions/geode-modules-session:build
:extensions/geode-modules-session:distributedTest
:extensions/geode-modules-session:integrationTest
:extensions/geode-modules-session-internal:javadocJar
:extensions/geode-modules-session-internal:sourcesJar
:extensions/geode-modules-session-internal:signArchives SKIPPED
:extensions/geode-modules-session-internal:assemble
:extensions/geode-modules-session-internal:compileTestJava UP-TO-DATE
:extensions/geode-modules-session-internal:processTestResources UP-TO-DATE
:extensions/geode-modules-session-internal:testClasses UP-TO-DATE
:extensions/geode-modules-session-internal:checkMissedTests UP-TO-DATE
:extensions/geode-modules-session-internal:spotlessJavaCheck
:extensions/geode-modules-session-internal:spotlessCheck
:extensions/geode-modules-session-internal:test UP-TO-DATE
:extensions/geode-modules-session-internal:check
:extensions/geode-modules-session-internal:build
:extensions/geode-modules-session-internal:distributedTest UP-TO-DATE
:extensions/geode-modules-session-internal:integrationTest UP-TO-DATE
:extensions/geode-modules-tomcat7:compileTestJava
:extensions/geode-modules-tomcat7:processTestResources
:extensions/geode-modules-tomcat7:testClasses
:extensions/geode-modules-tomcat7:checkMissedTests
:extensions/geode-modules-tomcat7:spotlessJavaCheck
:extensions/geode-modules-tomcat7:spotlessCheck
:extensions/geode-modules-tomcat7:test
:extensions/geode-modules-tomcat7:check
:extensions/geode-modules-tomcat7:build
:extensions/geode-modules-tomcat7:distributedTest
:extensions/geode-modules-tomcat7:integrationTest
:extensions/geode-modules-tomcat8:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-tomcat8:processTestResources
:extensions/geode-modules-tomcat8:testClasses
:extensions/geode-modules-tomcat8:checkMissedTests
:extensions/geode-modules-tomcat8:spotlessJavaCheck
:extensions/geode-modules-tomcat8:spotlessCheck
:extensions/geode-modules-tomcat8:test
:extensions/geode-modules-tomcat8:check
:extensions/geode-modules-tomcat8:build
:extensions/geode-modules-tomcat8:distributedTest
:extensions/geode-modules-tomcat8:integrationTest
:geode-assembly:compileJava UP-TO-DATE
:geode-assembly:processResources UP-TO-DATE
:geode-assembly:classes UP-TO-DATE
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
:geode-benchmarks:compileJava UP-TO-DATE
:geode-benchmarks:processResources UP-TO-DATE
:geode-benchmarks:classes UP-TO-DATE

Upgrade to Mockito 2.8.9 and PowerMock 1.7.0RC4

2017-06-14 Thread Kirk Lund

In February, I started upgrading our use of Mockito from 1.10.19 to 2.7.11.
I'm happy to report that we have completed this with the help of Srikanth
and Jared.

A few more releases of Mockito have come out since 2.7.11, so we are now
upgraded to Mockito 2.8.9 and PowerMock 1.7.0RC4.

Thanks,
Kirk

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Ken Howe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177928
---


Ship it!




Ship It!

- Ken Howe


On June 13, 2017, 4:29 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> ---
> 
> (Updated June 13, 2017, 4:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
> GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can 
> be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and 
> properties there. Create new SecurityService in constructor and overwrite the 
> SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
> from Cache to InternalDistributedSystem construction so that IDS can be 
> created with gemfire.properties from cluster config. At that time we would 
> rip out both cluster config request and creation of security service from 
> Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Jared Stewart



> On June 12, 2017, 7:59 p.m., Jared Stewart wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
> > Lines 327 (patched)
> > 
> >
> > Are you sure that we want to keep this response around as a member 
> > variable?  I'm afraid that it might be stale (in the sense that the cluster 
> > config has since been changed) if this response is referred to later on.
> 
> Kirk Lund wrote:
> Please see the new diff. I changed it from final to volatile and null it 
> out when the GemFireCacheImpl is finished using it. The only other way to 
> handle it would be as a ThreadLocal instead of a member variable. The 
> advantage of a ThreadLocal is that it wouldn't permanently use an object 
> header worth of heap memory after initialization completes.

Ah, I see - `initialize()` is not called by the constructor but rather through 
.  I was going to propose passing `configurationReponse` as an argument to 
`intialize`, but that won't work here given the way `initialize` is called.


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177668
---


On June 13, 2017, 4:29 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> ---
> 
> (Updated June 13, 2017, 4:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
> GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can 
> be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and 
> properties there. Create new SecurityService in constructor and overwrite the 
> SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
> from Cache to InternalDistributedSystem construction so that IDS can be 
> created with gemfire.properties from cluster config. At that time we would 
> rip out both cluster config request and creation of security service from 
> Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

2017-06-14 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177927
---


Ship it!




Ship It!

- Jared Stewart


On June 13, 2017, 4:29 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> ---
> 
> (Updated June 13, 2017, 4:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
> GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can 
> be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and 
> properties there. Create new SecurityService in constructor and overwrite the 
> SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
> from Cache to InternalDistributedSystem construction so that IDS can be 
> created with gemfire.properties from cluster config. At that time we would 
> rip out both cluster config request and creation of security service from 
> Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

2017-06-14 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60028/#review177920
---


Ship it!




Ship It!

- Kirk Lund


On June 13, 2017, 9:28 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60028/
> ---
> 
> (Updated June 13, 2017, 9:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * combine EnabledSecurityService and CustomSecurityService into 
> IntegratedSecurityService
> * combine DisabledSecurityService and LegacySecurityService
> * combine ConfigInitalizer and RealmInitilizer
> * provide default impelementations of SecurityService
> * consolidate SecurityService creation.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  3ff632d3857189513243959ee96da89da66d5a27 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  0ba1cb62468f15fda60a94dac9c781fe1793b28f 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  b50569036db1acac927f08ee5c1771c72ede3c1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
>  f0568c0ebc2b17c47b5059c60aa4f8bd500c5d6c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  44562537bc426e47a42d680bb410dc59bf9bd854 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  a4041e198f1a9a4961915504c51256d0b03aa7c2 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  8ae76d22b628b3175db45116b80dfcfbe34aba1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  60f014b9c33732a4ea134a654e666a9439b210bb 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  51449fdd5570494f3cf91325985a5eb9fc9f6d57 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
>  978c4dd0ab92afde53972f7feb9d8f018d0bf662 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ShiroSecurityManagerInitializer.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
>  a0c3cf3074051990cc50755131f8024db0b1faad 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
>  cacbeed957c3b87d08c93db74e38e0134565f699 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java
>  fca7eae9413cee98d351db5349fd950d3aa56180 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
>  70823443b5c4f776c86bb28ed49a73e690c5c872 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
>  ca4e6b7fb462bb4e3fefbc5db8a9503c6b13a865 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java
>  89070123978c22c4cfa8684fbb5b033dc9d83ffa 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java
>  f027a4367b38681f83dad2d4c4add67759633644 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java
>  44893520962331bcd41e972afa661538c28d4fb2 
>   
> geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java
>  857c0be8940b4acde2aa4992fac0122b687391c2 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java
>  01d6bb6488e76fb3cf652ad211e9f7e2fac51389 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java
>  1caedbcede239d6a96640381cc6941948637b442 
>   
> geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java
>  cdb90f1b580edaf6a2762883d4159a45d69c4728 
>   
>

Re: [VOTE] Using Pull Requests over Review Board

2017-06-14 Thread Kenneth Howe

-1 per my comments on the [DISCUSS] thread

> On Jun 11, 2017, at 9:51 AM, Jacob Barrett  wrote:
> 
> After a few days of discussion [1] this thread has quieted down so I would
> like to take it to a vote. The proposal is to modify the workflow of
> committers to match that of non-committers such that committers shall:
> 
> * Perform all work in progress on branches in their personal forks on
> GitHub rather than directly on the ASF Geode repositories.
> 
> * Submit GitHub pull requests, following all current rules for pull
> requests, for changes that would require peer review before committing to
> the production branches.
> 
> * Register their GitHub accounts with the ASF so that committers can be
> identified in the GitHub mirror repositories.
> 
> 
> Please cast your vote.
> 
> [   ] +1  Approve
> [   ] +0  No opinion
> [   ] -1  Disapprove (and reason why)
> 
> 
> [1] [DISCUSS] Using Pull Requests over Review Board
> 
> 
> -Jake

[GitHub] geode pull request #564: GEODE-3023 TcpServer thread can be blocked in proce...

2017-06-14 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/564


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly-flaky #36

Build failed in Jenkins: Geode-nightly #866

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

Re: Revert gradle upgrade

Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

Re: release 1.2

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #585 was SUCCESSFUL (with 1868 tests)

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

Re: release 1.2

Build failed in Jenkins: Geode-release-flaky #14

[GitHub] geode pull request #579: GEODE-3070: Fix gemfire.jar to be geode-dependencie...

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Re: release 1.2

Re: release 1.2

Re: release 1.2

Re: release 1.2

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Build failed in Jenkins: Geode-release #63

Upgrade to Mockito 2.8.9 and PowerMock 1.7.0RC4

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

Re: [VOTE] Using Pull Requests over Review Board

[GitHub] geode pull request #564: GEODE-3023 TcpServer thread can be blocked in proce...

31 matches

Site Navigation

Mail list logo

Footer information