Re: New Committer: Deepak Dixit

[Anthony Baker]

Welcome Deepak!

Anthony

Sent from my iPhone

> On Jul 14, 2017, at 4:46 PM, Mark Bretl  wrote:
> 
> The Apache Geode Project Management Committee has invited Deepak Dixit to
> be committer on the project. We are pleased to announce he has accepted.
> 
> Please join me in welcoming Deepak!
> 
> Thanks,
> 
> Mark
> On behalf of the Apache Geode PMC

Re: Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/#review180612
---


Ship it!




Ship It!

- Darrel Schneider


On July 14, 2017, 1:02 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60874/
> ---
> 
> (Updated July 14, 2017, 1:02 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3204
> https://issues.apache.org/jira/browse/GEODE-3204
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> txApplyInvalidate no longer modify region entry with a removed token.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  7f12eab 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
>  60b93a9 
> 
> 
> Diff: https://reviews.apache.org/r/60874/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60881: GEODE-3207 Swagger library updates: update user guide

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60881/#review180608
---


Ship it!




Ship It!

- Karen Miller


On July 14, 2017, 8:02 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60881/
> ---
> 
> (Updated July 14, 2017, 8:02 p.m.)
> 
> 
> Review request for geode and Jared Stewart.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3207 Swagger library updates: update user guide
> 
> 
> Diffs
> -
> 
>   geode-docs/rest_apps/setup_config.html.md.erb 
> c557f4f5a92a7331a434d670b99d24928a415e6a 
>   geode-docs/rest_apps/using_swagger.html.md.erb 
> 05f41295057e5c684b7b6403bc3273e33df821c1 
> 
> 
> Diff: https://reviews.apache.org/r/60881/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled manual to verify formatting, executed examples to verify that they 
> work as advertised.
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Review Request 60873: GEODE-2189 Docs: Update Swagger UI links Added link to OpenAPI specification.

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60873/#review180607
---


Ship it!




Ship It!

- Karen Miller


On July 14, 2017, 5:08 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60873/
> ---
> 
> (Updated July 14, 2017, 5:08 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2189 Docs: Update Swagger UI links Added link to OpenAPI specification.
> 
> 
> Diffs
> -
> 
>   geode-docs/rest_apps/using_swagger.html.md.erb 
> 05f41295057e5c684b7b6403bc3273e33df821c1 
> 
> 
> Diff: https://reviews.apache.org/r/60873/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled the user manual, verified that the links connect as they should.
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

New Committer: Deepak Dixit

[Mark Bretl]

The Apache Geode Project Management Committee has invited Deepak Dixit to
be committer on the project. We are pleased to announce he has accepted.

Please join me in welcoming Deepak!

Thanks,

Mark
On behalf of the Apache Geode PMC

Passed: apache/geode#3162 (develop - 9905794)

[Travis CI]

Build Update for apache/geode
-

Build: #3162
Status: Passed

Duration: 22 minutes and 4 seconds
Commit: 9905794 (develop)
Author: Galen O'Sullivan
Message: GEODE-3170: Closed socket doesn't result in an infinite loop. This 
closes #633

* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to close.
* Added a couple of JUnit tests.

Signed-off-by: Hitesh Khamesra 
Signed-off-by: Galen O'Sullivan 

View the changeset: 
https://github.com/apache/geode/compare/4fddda9e3983...9905794eb041

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/253773624?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #616 was SUCCESSFUL (with 1953 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #616 was successful.
---
Scheduled
1955 tests in total.

https://build.spring.io/browse/SGF-NAG-616/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #638: Feature/geode 2860

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/638

Feature/geode 2860

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-2860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 38ccfe68de766ddfaba60adb542986277119f27e
Author: Nick Reich 
Date:   2017-06-30T23:05:58Z

GEODE-2860: Refactor use of EventTracker

  * change EventTracker to an interface with two implementations
  * move as much logic out of LocalRegion down into subclasses that
make use EventTracker
  * move and refactor static inner classes in EventTracker into own
class files
  * migrate some of event-focused classes into a new sub package
  * add tests for existing logic from EventTracker

commit 34479be343181694667c7296488d5bfeaddf7474
Author: Nick Reich 
Date:   2017-07-14T17:31:05Z

GEODE-2860: Fix bug in logic around transactions

commit c054221a9f4aa7e796923a889c00c37bfbbdbda0
Author: Nick Reich 
Date:   2017-07-14T21:46:06Z

GEODE-2860: update serialization info for moved class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Stored procedures on Apache Geode.

[Michael Stolz]

Pivotal provides a closed-source connector to link commercial GemFire to
commercial Greenplum.
Pivotal has no intention of opening that connector at this time.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Fri, Jul 14, 2017 at 2:33 AM, marios390  wrote:

> Hi John,
>
> Just a quick one,
> Geode could be integrated with green plum and if not what alternatives for
> this.
>
> Thanks
> Ms
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> ml+s70738n24325...@n6.nabble.com]
> Sent: Thursday, July 13, 2017 11:33 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> It seems you and your team could be / mostly are likely dealing with a
> high-volume of sensitive information, but without knowing a lot about your
> UC(s) or particular application requirements/SLAs, I would recommend
> starting small, simple and scale based on need.
>
> Geode is a highly concurrent and distributed system with strong consistency
> guarantees.  Prematurely breaking the logic down into many individual
> microservices early (especially for individual Stored Procedures... how
> complex are these?) might unduly add complexity to your application and
> system architecture.
>
> So my advice is to really evaluate the need to create individual
> microservices first (which usually involves a platform like [Pivotal's]
> CloudFoundry on an IaaS (or private infra) to manage effectively) vs.
> starting small and just converting the Stored Procs into Geode Functions.
>
> Geode Function executions can be distributed across the cluster (similarly
> to Map-Reduce, but far more robust) in a highly available and reliable
> fashion.
>
> You might want to also read up on Geode's Partitioned Regions [1] for
> effectively managing (partitioning and distributing/arranging your data).
>
> Hope this helps.
>
> -John
>
> [1]
> http://gemfire90.docs.pivotal.io/geode/developing/
> partitioned_regions/chapter_overview.html yrjldnY3TtixZu9rDvLgvAx0M0bPn0iR_AzXTlMikrJPQ7v4gcrUCAFodHRwOi8
> vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9aXRubjJWd0otbE1xQm
> NKbU01T3Q1RU1ZSHRrUWgyc1E4Q08zemVsZjZnJnU9aHR0cCUzYSUyZiUyZm
> dlbWZpcmU5MCUyZWRvY3MlMmVwaXZvdGFsJTJlaW8lMmZnZW9kZSUyZmRldm
> Vsb3BpbmclMmZwYXJ0aXRpb25lZCU1ZnJlZ2lvbnMlMmZjaGFwdGVyJTVmb3
> ZlcnZpZXclMmVodG1s>
>
>
> On Thu, Jul 13, 2017 at 1:09 PM, marios390 <[hidden
> email]
> > wrote:
>
> >
> > 
> > From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> > [hidden email]]
> > Sent: Thursday, July 13, 2017 9:16 PM
> > To: Marios Sofocleous/IT/CREDITSAFE
> > Subject: Re: Stored procedures on Apache Geode.
> >
> > Right.
> >
> > You can also review the Apache Geode documentation on Function Execution
> > [1].  And if you are a *Spring* user, you can use *Spring Data Geode's*
> > convenient Function annotation support for both Function implementation
> as
> > well as execution, here [2].
> >
> > NOTE: you will probably notice the link [2] refers to *Spring Data
> > GemFire's* docs.  *Spring Data GemFire* and *Spring Data Geode* are
> > virtually the same with no differences.  Eventually *Spring Data Geode*
> > will have its own home with its own doc locations since it is finally
> > becoming a top-level SD module [3].
> >
> > -j
> >
> > [1]
> > http://geode.apache.org/docs/guide/11/developing/function_<
> redir.aspx?REF=9WC8AmXblm4Q_zDPwbP3MZWeTU5A8b8TcK6A7zAo07x
> PQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9aXRubjJWd0otbE1xQmNKbU01T3Q1RU1ZSHRrUWgyc1E4QzIx
> bWVsWTd3JnU9aHR0cCUzYSUyZiUyZmdlb2RlJTJlYXBhY2hlJTJlb3JnJTJm
> ZG9jcyUyZmd1aWRlJTJmMTElMmZkZXZlbG9waW5nJTJmZnVuY3Rpb24lNWY.>
> > exec/chapter_overview.html  keRPQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9>
> > j7nn2bxZOwcngUOelB5ZmyW7oHpBqfFPnKkha5eWJQ=http%3a%2f%
> > 2fgeode%2eapache%2eorg%2fdocs%2fguide%2f11%2fdeveloping%
> > 2ffunction%5fexec%2fchapter%5foverview%2ehtml>
> > [2]
> > http://docs.spring.io/spring-data-gemfire/docs/current/ FeI05aGSUMelSXs5C8eNCYF4w7WOQTrcPuikgbSqvPtPQ7v4gcrUCAFodHRw
> Oi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9aXRubjJWd0otbE1xQm
> NKbU01T3Q1RU1ZSHRrUWgyc1E4SExsbmJ0ZTZnJnU9aHR0cCUzYSUyZiUyZm
> RvY3MlMmVzcHJpbmclMmVpbyUyZnNwcmluZy1kYXRhLWdlbWZpcmUlMmZkb2
> NzJTJmY3VycmVudCUyZg..>
> > reference/html/#function-annotations redir.aspx?REF=yjGtUyX_IqBoLNjffMmotpM0mcz7gdL1cjWOZj
> T4YBFPQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWw.>.
> > trustwave.com/?c=7422=j7nn2bxZOwcngUOelB5ZmyW7oHpBqf
>  pZUTH3A6h1PQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9aXRubjJWd0otbE1xQmNKbU01T3Q1RU1ZSHRrUWgyc1E4SGV6
> 

[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/633


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/633#discussion_r127550540
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 ---
@@ -68,9 +56,8 @@ protected void doOneMessage() {
   messageHandler.receiveMessage(inputStream, outputStream, 
this.getCache());
 } catch (IOException e) {
   logger.warn(e);
-  // TODO?
+  this.setFlagProcessMessagesAsFalse(); // TODO: better shutdown.
--- End diff --

https://issues.apache.org/jira/browse/GEODE-3079 should cover it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #633: GEODE-3170: Closed socket doesn't result in an infinite lo...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/633
  
@hiteshk25 @pivotal-amurmann 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #631: GEODE-3051: Remove unreachable exception handling i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/631


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #637: GEODE-2612 Document new import data option

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/637


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60875: GEODE-2654: Backups can capture different members from different points in time

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60875/#review180588
---



I like where you are going with this and I think this will make the backup a 
lot more consistent. I think what you are doing with the oplogs looks good. 
However, the changes made to DiskInitFile don't look like they are threadsafe 
to me. I have some comments below.

I'd also like to see some tests associated with this change that prove the new 
behavior is working.


geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java
Lines 70 (patched)


I think the backup thread still needs to get the lock here.

Perhaps other threads can't modify the disk files, but I think you still 
need to protect all access to the state of DiskInitFile and BackupLock. For 
example, backupThread is not volatile, so without getting the lock here we may 
actually see a state value for that variable. That's just one variable, I think 
DiskInitFile has a lot more state than that.



geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java
Line 384 (original), 389 (patched)


The fact that you have two different locks protecting the state of this 
class I think is confusing. What variables are protected by backupLock vs. what 
variables are protected by this new lock? I think it's much safer and more 
understandable for future developers if there is only a single lock.n

In fact I can see that this is not safe because I can see that we are 
modifying drMapByName under one lock but getting the value of drMapByName under 
a different lock.


- Dan Smith


On July 14, 2017, 5:40 p.m., Lynn Gallinat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60875/
> ---
> 
> (Updated July 14, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> An online backup was not taking a snapshot of a single point in time. The 
> solution is for operations that change the disk files to acquire the backup 
> lock, causing them to wait until backup has rolled the op logs.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java 
> 4b4fb10 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
> 0925d28 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> 3e97d0e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 5399d5a 
> 
> 
> Diff: https://reviews.apache.org/r/60875/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin.
> 
> 
> Thanks,
> 
> Lynn Gallinat
> 
>

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Fred Krone]

+1

Downloaded and built from source.  gfsh -- new string partition resolver
for region.  Worked.

10/10 would partition resolve again.

On Fri, Jul 14, 2017 at 1:08 PM, Kenneth Howe  wrote:

> +1
>
> Downloaded and built from source. Basic operations from gfsh - create
> cluster simple puts and queries
>
> > On Jul 14, 2017, at 12:45 PM, Bruce Schuchardt 
> wrote:
> >
> > +1
> >
> > downloaded apache-geode-1.2.0.tar.gz
> >
> > ran through the 15-minute startup guide with no issues
> >
> >
> > On 7/12/17 7:58 AM, Anthony Baker wrote:
> >> This is the second release candidate for Apache Geode, version 1.2.0.
> >> Thanks to all the community members for their contributions to this
> >> release!  This release candidate fixes a number of backwards
> compatibility
> >> and rolling upgrade issues found in RC1.
> >>
> >> *** Please download, test and vote by Saturday, July 15, 0800 hrs
> >> US Pacific. ***
> >>
> >> It fixes the following issues:
> >>
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12339257
> >>
> >> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
> >>
> >> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=
> 964f2749065ce9c6898fd27983b43f1bd9fc77d0
> >>
> >> https://git-wip-us.apache.org/repos/asf?p=geode-examples.
> git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
> >>
> >> Commit ID:
> >>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
> >>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
> >>
> >> Source and binary files:
> >>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
> >>
> >> Maven staging repo:
> >>   https://repository.apache.org/content/repositories/
> orgapachegeode-1020
> >>
> >> Geode's KEYS file containing PGP keys we use to sign the release:
> >>
> >> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_
> plain;f=KEYS;hb=HEAD
> >>
> >> pub  4096R/C72CFB64 2015-10-01
> >>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
> >>
> >> Anthony
> >>
> >
>
>

[GitHub] geode pull request #635: GEODE-2594 Remove tools.jar and --pid options from ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/635


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/633#discussion_r127540044
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 ---
@@ -68,9 +56,8 @@ protected void doOneMessage() {
   messageHandler.receiveMessage(inputStream, outputStream, 
this.getCache());
 } catch (IOException e) {
   logger.warn(e);
-  // TODO?
+  this.setFlagProcessMessagesAsFalse(); // TODO: better shutdown.
--- End diff --

Can we raise a ticket for this to complete this TODO


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Kenneth Howe]

+1 

Downloaded and built from source. Basic operations from gfsh - create cluster 
simple puts and queries

> On Jul 14, 2017, at 12:45 PM, Bruce Schuchardt  wrote:
> 
> +1
> 
> downloaded apache-geode-1.2.0.tar.gz
> 
> ran through the 15-minute startup guide with no issues
> 
> 
> On 7/12/17 7:58 AM, Anthony Baker wrote:
>> This is the second release candidate for Apache Geode, version 1.2.0.
>> Thanks to all the community members for their contributions to this
>> release!  This release candidate fixes a number of backwards compatibility
>> and rolling upgrade issues found in RC1.
>> 
>> *** Please download, test and vote by Saturday, July 15, 0800 hrs
>> US Pacific. ***
>> 
>> It fixes the following issues:
>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257
>> 
>> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
>> 
>> Commit ID:
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>> 
>> Source and binary files:
>>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>> 
>> Maven staging repo:
>>   https://repository.apache.org/content/repositories/orgapachegeode-1020
>> 
>> Geode's KEYS file containing PGP keys we use to sign the release:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD
>> 
>> pub  4096R/C72CFB64 2015-10-01
>>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>> 
>> Anthony
>> 
> 

Re: Review Request 60881: GEODE-3207 Swagger library updates: update user guide

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60881/#review180581
---


Ship it!




Ship It!

- Joey McAllister


On July 14, 2017, 8:02 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60881/
> ---
> 
> (Updated July 14, 2017, 8:02 p.m.)
> 
> 
> Review request for geode and Jared Stewart.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3207 Swagger library updates: update user guide
> 
> 
> Diffs
> -
> 
>   geode-docs/rest_apps/setup_config.html.md.erb 
> c557f4f5a92a7331a434d670b99d24928a415e6a 
>   geode-docs/rest_apps/using_swagger.html.md.erb 
> 05f41295057e5c684b7b6403bc3273e33df821c1 
> 
> 
> Diff: https://reviews.apache.org/r/60881/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled manual to verify formatting, executed examples to verify that they 
> work as advertised.
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token

[Eric Shu]

> On July 14, 2017, 7:07 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
> > Lines 2515 (patched)
> > 
> >
> > Is't this means the invalidate failed within the tx context? the entry 
> > got changed while applying the tx.
> > 
> > E.g:
> > begin tx
> > invalidate(key1)
> > commit tx
> > 
> > It should invalidate the re under tx lock; if its not able to lock, 
> > then it should have thrown tx conflict exception; or if its removed before 
> > taking the lock, it should have thrown entry-not-found exception...
> > 
> > Now it looks like the invalidate returns true, even if the enty is not 
> > invalidated.

This will not occur on the node performing the tx (hosting the TXState). It 
will throw EntryNotFoundException during the invalidate operation in the 
transaction.
This only occurs on the farside of transaction and in a no-ack region. In a 
no-ack region, commit message processing does not ack so that destroy message 
and invalidate message could be recieved out of order on the farside.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/#review180570
---


On July 14, 2017, 5:13 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60874/
> ---
> 
> (Updated July 14, 2017, 5:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3204
> https://issues.apache.org/jira/browse/GEODE-3204
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> txApplyInvalidate no longer modify region entry with a removed token.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  7f12eab 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
>  60b93a9 
> 
> 
> Diff: https://reviews.apache.org/r/60874/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Review Request 60881: GEODE-3207 Swagger library updates: update user guide

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60881/
---

Review request for geode and Jared Stewart.


Repository: geode


Description
---

GEODE-3207 Swagger library updates: update user guide


Diffs
-

  geode-docs/rest_apps/setup_config.html.md.erb 
c557f4f5a92a7331a434d670b99d24928a415e6a 
  geode-docs/rest_apps/using_swagger.html.md.erb 
05f41295057e5c684b7b6403bc3273e33df821c1 


Diff: https://reviews.apache.org/r/60881/diff/1/


Testing
---

Compiled manual to verify formatting, executed examples to verify that they 
work as advertised.


Thanks,

Dave Barnes

Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60834/#review180578
---


Ship it!




Ship It!

- Udo Kohlmeyer


On July 13, 2017, 12:35 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60834/
> ---
> 
> (Updated July 13, 2017, 12:35 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3051
> https://issues.apache.org/jira/browse/GEODE-3051
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This removes handling of SSL exceptions from the AccepterImpl.accept call, as 
> the SSL handling code is now all done in another thread.
> The exception handling being done in the other thread appears to be correct, 
> as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  3c424d397 
> 
> 
> Diff: https://reviews.apache.org/r/60834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Bruce Schuchardt]

+1

downloaded apache-geode-1.2.0.tar.gz

ran through the 15-minute startup guide with no issues


On 7/12/17 7:58 AM, Anthony Baker wrote:

This is the second release candidate for Apache Geode, version 1.2.0.
Thanks to all the community members for their contributions to this
release!  This release candidate fixes a number of backwards compatibility
and rolling upgrade issues found in RC1.

*** Please download, test and vote by Saturday, July 15, 0800 hrs
US Pacific. ***

It fixes the following issues:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257

Note that we are voting upon the source tags:  rel/v1.2.0.RC2

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0

https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8

Commit ID:
   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)

Source and binary files:
   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2

Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachegeode-1020

Geode's KEYS file containing PGP keys we use to sign the release:

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD

pub  4096R/C72CFB64 2015-10-01
   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64

Anthony

[GitHub] geode issue #634: Feature/geode 3175

[bschuchardt]

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/634
  
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Stored procedures on Apache Geode.

[marios390]

Hi John,

Thank you very much for all this information. I will check it out.
Appreciate it!.
Thanks
MS

From: John Blum [via Apache Geode (Incubating) Developers Forum] 
[ml+s70738n24351...@n6.nabble.com]
Sent: Friday, July 14, 2017 6:35 PM
To: Marios Sofocleous/IT/CREDITSAFE
Subject: Re: Stored procedures on Apache Geode.

Hi Marios-

I may not be the best person to answer this.  There is a Pivotal GemFire /
Greenplum Connector available for download here...

https://network.pivotal.io/products/pivotal-gemfire/#/releases/5376/file_groups/495

More information on the Connector can be found here...

http://ggc.docs.pivotal.io/ggc/relnotes/release_notes30.html

As you may know, Apache Geode is the open source core of Pivotal GemFire (
https://pivotal.io/pivotal-gemfire).
  Theoretically, it probably
would/should work to connect Geode with Greenplum, though I have not done
this and I am not sure it is a combination Pivotal nor the Apache Geode
community supports.

There is example of using this Connector with Geode here...

https://github.com/mgoddard-pivotal/FraudDetection-wwko

Which was the basis for this presentation/article...

https://content.pivotal.io/blog/big-data-meets-fast-data-to-fight-fraud-and-more

-j



On Thu, Jul 13, 2017 at 11:33 PM, marios390 <
[hidden email]> wrote:

> Hi John,
>
> Just a quick one,
> Geode could be integrated with green plum and if not what alternatives for
> this.
>
> Thanks
> Ms
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> [hidden email]]
> Sent: Thursday, July 13, 2017 11:33 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> It seems you and your team could be / mostly are likely dealing with a
> high-volume of sensitive information, but without knowing a lot about your
> UC(s) or particular application requirements/SLAs, I would recommend
> starting small, simple and scale based on need.
>
> Geode is a highly concurrent and distributed system with strong consistency
> guarantees.  Prematurely breaking the logic down into many individual
> microservices early (especially for individual Stored Procedures... how
> complex are these?) might unduly add complexity to your application and
> system architecture.
>
> So my advice is to really evaluate the need to create individual
> microservices first (which usually involves a platform like [Pivotal's]
> CloudFoundry on an IaaS (or private infra) to manage effectively) vs.
> starting small and just converting the Stored Procs into Geode Functions.
>
> Geode Function executions can be distributed across the cluster (similarly
> to Map-Reduce, but far more robust) in a highly available and reliable
> fashion.
>
> You might want to also read up on Geode's Partitioned Regions [1] for
> effectively managing (partitioning and distributing/arranging your data).
>
> Hope this helps.
>
> -John
>
> [1]
> http://gemfire90.docs.pivotal.io/geode/developing/
> partitioned_regions/chapter_overview.html yrjldnY3TtixZu9rDvLgvAx0M0bPn0iR_AzXTlMikrJPQ7v4gcrUCAFodHRwOi8
> vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9aXRubjJWd0otbE1xQm
> 

Re: Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/#review180570
---




geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
Lines 2515 (patched)


Is't this means the invalidate failed within the tx context? the entry got 
changed while applying the tx.

E.g:
begin tx
invalidate(key1)
commit tx

It should invalidate the re under tx lock; if its not able to lock, then it 
should have thrown tx conflict exception; or if its removed before taking the 
lock, it should have thrown entry-not-found exception...

Now it looks like the invalidate returns true, even if the enty is not 
invalidated.


- anilkumar gingade


On July 14, 2017, 5:13 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60874/
> ---
> 
> (Updated July 14, 2017, 5:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3204
> https://issues.apache.org/jira/browse/GEODE-3204
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> txApplyInvalidate no longer modify region entry with a removed token.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  7f12eab 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
>  60b93a9 
> 
> 
> Diff: https://reviews.apache.org/r/60874/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/#review180569
---




geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
Lines 2515 (patched)


You need to do this part "Token.isRemoved(re.getValueAsToken())" inside 
"synchronized(re)".
By doing it outside the sync it allows it to still be true once you get 
inside the sync.


- Darrel Schneider


On July 14, 2017, 10:13 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60874/
> ---
> 
> (Updated July 14, 2017, 10:13 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3204
> https://issues.apache.org/jira/browse/GEODE-3204
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> txApplyInvalidate no longer modify region entry with a removed token.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  7f12eab 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
>  60b93a9 
> 
> 
> Diff: https://reviews.apache.org/r/60874/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #636: GEODE-3198: Allow bucket creation when over local-m...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #637: GEODE-2612 Document new import data option

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/637#discussion_r127525516
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/import.html.md.erb ---
@@ -40,16 +40,17 @@ Import user data from a file to a region.
 **Syntax:**
 
 ``` pre
- import data --region=value --file=value --member=value
+ import data --region=value --file=value --member=value 
[--invoke-callbacks=value]
 ```
 
 
 
-| Name   | Description 


 |

-||--|
-| \\-\\-region | *Required.* Region 
into which data will be imported.   

  |
-| \\-\\-file   | *Required.* File 
from which the imported data will be read. The file must have an extension of 
".gfd" and must be on the file system of the member (or accessible to that 
member via NFS) that is being targeted for the import. |
-| member | *Required.* 
Name/Id of a member which hosts the region. The data will be imported from the 
specified file on the host where the member is running. 
  |
+| Name   | Description 


 | Default Value |

+||--||
+| \\-\\-region | *Required.* Region 
into which data will be imported. | |
+| \\-\\-file   | *Required.* File 
from which the imported data will be read. The file must have an extension of 
".gfd" and must be on the file system of the member (or accessible to that 
member via NFS) that is being targeted for the import. | |
+| member | *Required.* 
Name/Id of a member which hosts the region. The data will be imported from the 
specified file on the host where the member is running. | |
--- End diff --

Change "Name/Id of a member which hosts the region" to "Name/ID of a member 
that hosts the region." (Id > ID; which > that)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #635: GEODE-2594 Remove tools.jar and --pid options from ...

[karensmolermiller]

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/635#discussion_r127524976
  
--- Diff: geode-docs/configuring/running/running_the_locator.html.md.erb ---
@@ -35,7 +35,7 @@ You can run the locator standalone or embedded within 
another Geode process. Run
 
 Locator configuration and log files have the following properties:
 
--   When you start a standalone locator using `gfsh`, `gfsh` will 
automatically load the required JAR files 
(`$GEMFIRE/lib/locator-dependencies.jar`) into the CLASSPATH of the JVM 
process. If you start a standalone locator using the `LocatorLauncher` API, you 
must specify `$GEMFIRE/lib/locator-dependencies.jar` inside the command used to 
launch the locator process. For more information on CLASSPATH settings in 
Geode, see [CLASSPATH Settings for Geode 
Processes](../../getting_started/setup_classpath.html). You can modify the 
CLASSPATH by specifying the `--classpath` parameter.
+-   When you start a standalone locator using `gfsh`, `gfsh` will 
automatically load the required JAR file 
(`$GEMFIRE/lib/locator-dependencies.jar`) into the CLASSPATH of the JVM 
process. If you start a standalone locator using the `LocatorLauncher` API, you 
must specify `$GEMFIRE/lib/locator-dependencies.jar` inside the command used to 
launch the locator process. For more information on CLASSPATH settings in 
Geode, see [CLASSPATH Settings for Geode 
Processes](../../getting_started/setup_classpath.html). You can modify the 
CLASSPATH by specifying the `--classpath` parameter.
--- End diff --

That task is being tracked with Geode-3208.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #635: GEODE-2594 Remove tools.jar and --pid options from ...

[karensmolermiller]

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/635#discussion_r127524936
  
--- Diff: 
geode-docs/configuring/running/running_the_cacheserver.html.md.erb ---
@@ -31,7 +31,7 @@ The Geode server is used primarily for hosting long-lived 
data regions and for r
 
 The `gfsh` utility uses a working directory for its configuration files 
and log files. These are the defaults and configuration options:
 
--   When you start a standalone server using `gfsh`, `gfsh` will 
automatically load the required JAR files 
`$GEMFIRE/lib/server-dependencies.jar` and `$JAVA_HOME/lib/tools.jar` into the 
CLASSPATH of the JVM process. If you start a standalone server using the 
ServerLauncher API, you must specify `$GEMFIRE/lib/server-dependencies.jar` 
inside your command to launch the process. For more information on CLASSPATH 
settings in Geode, see [Setting Up the 
CLASSPATH](../../getting_started/setup_classpath.html).
+-   When you start a standalone server using `gfsh`, `gfsh` will 
automatically load the required JAR file `$GEMFIRE/lib/server-dependencies.jar` 
into the CLASSPATH of the JVM process. If you start a standalone server using 
the ServerLauncher API, you must specify `$GEMFIRE/lib/server-dependencies.jar` 
inside your command to launch the process. For more information on CLASSPATH 
settings in Geode, see [Setting Up the 
CLASSPATH](../../getting_started/setup_classpath.html).
--- End diff --

That task is being tracked with Geode-3208.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: No nulls

[John Blum]

IMO, I think they are very useful, especially since the IDE (e.g. IntelliJ
IDEA) can use them to detect problems (e.g. NPEs) earlier rather than later.

For example, *Spring* 5 just introduced 2 new annotations: @Nullable [1]
(declaring possible null parameters, returns values or fields) and
@NonNullApi [2] to declare the opposite, non-null parameters and return
values.

These are very similar in purpose to IntellIJ IDEA's own Null Inspection
annotations [3].

It is a simple matter in IJ to configure additional annotations for the IDE
to detect *null-safe* and *non-null/required* cases in code.

Preferences > Inspections > Java > Probable Bugs > Constant conditions &
exceptions > Configure annotations

[image: Inline image 1]

I am sure Eclipse has similar facilities.

It seems many libraries and their APIs are following similar approaches
(Google, Findbugs, Vaadin, etc).

Also see...

https://jcp.org/en/jsr/detail?id=305

And...

https://github.com/amaembo/jsr-305/tree/master/ri/src/main/java/javax/annotation

For instance...

https://github.com/amaembo/jsr-305/blob/master/ri/src/main/java/javax/annotation/Nonnull.java
https://github.com/amaembo/jsr-305/blob/master/ri/src/main/java/javax/annotation/Nullable.java

Anyway, seems there are several options/approaches you can take.

-j


[1]
http://docs.spring.io/spring/docs/5.0.0.BUILD-SNAPSHOT/javadoc-api/org/springframework/lang/Nullable.html
[2]
http://docs.spring.io/spring/docs/5.0.0.BUILD-SNAPSHOT/javadoc-api/org/springframework/lang/NonNullApi.html
[3]
https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html


On Fri, Jul 14, 2017 at 9:47 AM, Galen O'Sullivan 
wrote:

> What's the general opinion of @NotNull annotations? Would they be useful?
>
> On Fri, Jul 14, 2017 at 9:23 AM, John Blum  wrote:
>
> > +1 as well.
> >
> > However, I will caution this... use Java 8's new java.util.Optional class
> > in your codebase judiciously.  Using it everywhere, especially on
> critical
> > code paths can and most likely will affect your performance.
> >
> > Internally, j.u.Optional allocates new objects for nearly every operation
> > (e.g. Optional.of(..), Optional.ofNullable(), etc).  Be careful of
> Optional
> > operations that take a *Lambda* since creating a *Lambda* involves
> > constructing a new object (exactly like anonymous inner construction).
> >
> > We just went through this exercise on the *Spring Data* team, introducing
> > Java 8 types (e.g.) to our Repository infrastructure and other parts of
> the
> > SD Commons API and it negatively impacted performance, cutting perf in
> half
> > (due to Object allocation).  As such, we rolled back and took another
> > approach to Nullability, primarily by using Annotations and IDE support.
> >
> > Finally, while it is common to return a Optional from a method call,
> it
> > is not appropriate to generally accept Optional parameters in your APIs.
> > Generally speaking, there is no substitute for validating method
> arguments
> > than adding assertions (which does not imply just the Java assert
> facility
> > (that is unreliable since it must explicitly be enabled... $ java ... -ea
> > ...), rather, use something like using java.util.Objects or AssertJ)..
> > NPEs are not user mistakes, they are library mistakes/bugs.
> >
> > Food for thought,
> >
> > -j
> >
> >
> > On Thu, Jul 13, 2017 at 6:13 PM, Jacob Barrett 
> > wrote:
> >
> > > +1
> > >
> > > We are taking a similar approach to refactoring of the C++ client.
> > > Specifically with refer to nullptr we are trying to eliminate it from
> all
> > > public APIs.
> > >
> > > Sent from my iPhone
> > >
> > > > On Jul 13, 2017, at 3:17 PM, Kirk Lund  wrote:
> > > >
> > > > Please try to imagine a world of no nulls.
> > > >
> > > > https://www.oracle.com/corporate/features/library-in-
> > > java-best-practices.html?evite=WWMK170414P4
> > >
> >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>



-- 
-John
john.blum10101 (skype)

[GitHub] geode pull request #637: GEODE-2612 Document new import data option

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/637

GEODE-2612 Document new import data option

@boglesby @joeymcallister @davebarnes97 Please review.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2612

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #637


commit 29c6b8a0bc899652b40e6a5f636d7f91ddeece4d
Author: Karen Miller 
Date:   2017-07-14T17:41:59Z

GEODE-2612 Document new import data option

- gfsh import data man page updated
- import is used when changing a Lucene index, so point out how
to get the callback invoked to rebuild the index




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Jared Stewart]

+1

Built from src and ran some basic operations on a small cluster.


> On Jul 14, 2017, at 11:30 AM, Dick Cavender  wrote:
> 
> +1
> 
> Reviewed 1.2.0 javadocs and Geode docs
> 
> Ubuntu 12.04 & JDK8 Update 111
> 
>Downloaded src dist and successfully built
>Verified full version through gfsh using both binary and built source 
> product
>Ran though tutorial on binary dist
> 
> SPARC Solaris 11.2 & JDK8 Update 111
> 
>Downloaded src dist and successfully built
>Verified full version through gfsh on both binary and built source product
>Started and stopped a locator and two servers from gfsh on binary dist
> 
> 
> On 7/12/2017 7:58 AM, Anthony Baker wrote:
>> This is the second release candidate for Apache Geode, version 1.2.0.
>> Thanks to all the community members for their contributions to this
>> release!  This release candidate fixes a number of backwards compatibility
>> and rolling upgrade issues found in RC1.
>> 
>> *** Please download, test and vote by Saturday, July 15, 0800 hrs
>> US Pacific. ***
>> 
>> It fixes the following issues:
>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257
>> 
>> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
>> 
>> Commit ID:
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>>   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>> 
>> Source and binary files:
>>   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>> 
>> Maven staging repo:
>>   https://repository.apache.org/content/repositories/orgapachegeode-1020
>> 
>> Geode's KEYS file containing PGP keys we use to sign the release:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD
>> 
>> pub  4096R/C72CFB64 2015-10-01
>>   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>> 
>> Anthony
>> 
> 

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Dick Cavender]

+1

Reviewed 1.2.0 javadocs and Geode docs

Ubuntu 12.04 & JDK8 Update 111

Downloaded src dist and successfully built
Verified full version through gfsh using both binary and built 
source product

Ran though tutorial on binary dist

SPARC Solaris 11.2 & JDK8 Update 111

Downloaded src dist and successfully built
Verified full version through gfsh on both binary and built source 
product

Started and stopped a locator and two servers from gfsh on binary dist


On 7/12/2017 7:58 AM, Anthony Baker wrote:

This is the second release candidate for Apache Geode, version 1.2.0.
Thanks to all the community members for their contributions to this
release!  This release candidate fixes a number of backwards compatibility
and rolling upgrade issues found in RC1.

*** Please download, test and vote by Saturday, July 15, 0800 hrs
US Pacific. ***

It fixes the following issues:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257

Note that we are voting upon the source tags:  rel/v1.2.0.RC2

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0

https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8

Commit ID:
   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
   7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)

Source and binary files:
   https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2

Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachegeode-1020

Geode's KEYS file containing PGP keys we use to sign the release:

https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD

pub  4096R/C72CFB64 2015-10-01
   Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64

Anthony

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Jinmei Liao]

+1

1) download the executable.
2) run gfsh and start locator, server, and random commands.
3) verify pulse is started and running.


On Fri, Jul 14, 2017 at 10:37 AM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> +1
> same as Dan!!
>
> On Wednesday, July 12, 2017, 1:38:44 PM PDT, Dan Smith 
> wrote:
>
> +0
>
> I ran geode-release-check
>  against this
> project. It all looks good except that the md5sum and sha256 sums tasks
> don't pass because the .md5 and .sha256 files are in the wrong format. I
> created GEODE-3196. I don't think that should hold up the release.
>
> There's another issue with the example source though. It looks like trying
> to build an example is prompting me for me gpg key so it can sign the
> artifacts. Given that our README is telling users to run ../gradlew build
> this is a bit annoying.
>
> Awesome job making the examples build point at 1.2 but allowing me to
> override the repo url so we can actually test them!
>
> -Dan
>
> On Wed, Jul 12, 2017 at 7:58 AM, Anthony Baker  wrote:
>
> > This is the second release candidate for Apache Geode, version 1.2.0.
> > Thanks to all the community members for their contributions to this
> > release!  This release candidate fixes a number of backwards
> compatibility
> > and rolling upgrade issues found in RC1.
> >
> > *** Please download, test and vote by Saturday, July 15, 0800 hrs
> > US Pacific. ***
> >
> > It fixes the following issues:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12318420=12339257
> >
> > Note that we are voting upon the source tags:  rel/v1.2.0.RC2
> >
> > https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=
> > 964f2749065ce9c6898fd27983b43f1bd9fc77d0
> >
> > https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=
> > 7f93d95ad06a6f2afee54312585f48435fff11e8
> >
> > Commit ID:
> >  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
> >  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
> >
> > Source and binary files:
> >  https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
> >
> > Maven staging repo:
> >  https://repository.apache.org/content/repositories/orgapachegeode-1020
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >
> > https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_
> > plain;f=KEYS;hb=HEAD
> >
> > pub  4096R/C72CFB64 2015-10-01
> >  Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
> >
> > Anthony
> >
>



-- 
Cheers

Jinmei

[GitHub] geode pull request #636: GEODE-3198: Allow bucket creation when over local-m...

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/636

GEODE-3198: Allow bucket creation when over local-max-memory

  * the bucket will not be created on a member that is over local max
  * memory, unless all members have failed to create the bucket and
  * a "force" flag is set to true in the call to ensure bucket creation

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-3198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #636


commit 6a29c6ed4392fcc43b82dc3d0554d0107722b4fc
Author: Nick Reich 
Date:   2017-07-14T18:09:31Z

GEODE-3198: Allow bucket creation when over local-max-memory

  * the bucket will not be created on a member that is over local max
  * memory, unless all members have failed to create the bucket and
  * a "force" flag is set to true in the call to ensure bucket creation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #635: GEODE-2594 Remove tools.jar and --pid options from ...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/635#discussion_r127515789
  
--- Diff: geode-docs/configuring/running/running_the_locator.html.md.erb ---
@@ -35,7 +35,7 @@ You can run the locator standalone or embedded within 
another Geode process. Run
 
 Locator configuration and log files have the following properties:
 
--   When you start a standalone locator using `gfsh`, `gfsh` will 
automatically load the required JAR files 
(`$GEMFIRE/lib/locator-dependencies.jar`) into the CLASSPATH of the JVM 
process. If you start a standalone locator using the `LocatorLauncher` API, you 
must specify `$GEMFIRE/lib/locator-dependencies.jar` inside the command used to 
launch the locator process. For more information on CLASSPATH settings in 
Geode, see [CLASSPATH Settings for Geode 
Processes](../../getting_started/setup_classpath.html). You can modify the 
CLASSPATH by specifying the `--classpath` parameter.
+-   When you start a standalone locator using `gfsh`, `gfsh` will 
automatically load the required JAR file 
(`$GEMFIRE/lib/locator-dependencies.jar`) into the CLASSPATH of the JVM 
process. If you start a standalone locator using the `LocatorLauncher` API, you 
must specify `$GEMFIRE/lib/locator-dependencies.jar` inside the command used to 
launch the locator process. For more information on CLASSPATH settings in 
Geode, see [CLASSPATH Settings for Geode 
Processes](../../getting_started/setup_classpath.html). You can modify the 
CLASSPATH by specifying the `--classpath` parameter.
--- End diff --

All references to $GEMFIRE/lib/locator-dependencies.jar should change to 
$GEODE/lib/geode-dependencies.jar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #635: GEODE-2594 Remove tools.jar and --pid options from ...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/635#discussion_r127515650
  
--- Diff: 
geode-docs/configuring/running/running_the_cacheserver.html.md.erb ---
@@ -31,7 +31,7 @@ The Geode server is used primarily for hosting long-lived 
data regions and for r
 
 The `gfsh` utility uses a working directory for its configuration files 
and log files. These are the defaults and configuration options:
 
--   When you start a standalone server using `gfsh`, `gfsh` will 
automatically load the required JAR files 
`$GEMFIRE/lib/server-dependencies.jar` and `$JAVA_HOME/lib/tools.jar` into the 
CLASSPATH of the JVM process. If you start a standalone server using the 
ServerLauncher API, you must specify `$GEMFIRE/lib/server-dependencies.jar` 
inside your command to launch the process. For more information on CLASSPATH 
settings in Geode, see [Setting Up the 
CLASSPATH](../../getting_started/setup_classpath.html).
+-   When you start a standalone server using `gfsh`, `gfsh` will 
automatically load the required JAR file `$GEMFIRE/lib/server-dependencies.jar` 
into the CLASSPATH of the JVM process. If you start a standalone server using 
the ServerLauncher API, you must specify `$GEMFIRE/lib/server-dependencies.jar` 
inside your command to launch the process. For more information on CLASSPATH 
settings in Geode, see [Setting Up the 
CLASSPATH](../../getting_started/setup_classpath.html).
--- End diff --

All references to $GEMFIRE/lib/server-dependencies.jar should change to 
$GEODE/lib/geode-dependencies.jar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

[Hitesh Khamesra]

+1
same as Dan!!

On Wednesday, July 12, 2017, 1:38:44 PM PDT, Dan Smith  
wrote:

+0

I ran geode-release-check
 against this
project. It all looks good except that the md5sum and sha256 sums tasks
don't pass because the .md5 and .sha256 files are in the wrong format. I
created GEODE-3196. I don't think that should hold up the release.

There's another issue with the example source though. It looks like trying
to build an example is prompting me for me gpg key so it can sign the
artifacts. Given that our README is telling users to run ../gradlew build
this is a bit annoying.

Awesome job making the examples build point at 1.2 but allowing me to
override the repo url so we can actually test them!

-Dan

On Wed, Jul 12, 2017 at 7:58 AM, Anthony Baker  wrote:

> This is the second release candidate for Apache Geode, version 1.2.0.
> Thanks to all the community members for their contributions to this
> release!  This release candidate fixes a number of backwards compatibility
> and rolling upgrade issues found in RC1.
>
> *** Please download, test and vote by Saturday, July 15, 0800 hrs
> US Pacific. ***
>
> It fixes the following issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12339257
>
> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
>
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=
> 964f2749065ce9c6898fd27983b43f1bd9fc77d0
>
> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=
> 7f93d95ad06a6f2afee54312585f48435fff11e8
>
> Commit ID:
>  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
>
> Source and binary files:
>  https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
>
> Maven staging repo:
>  https://repository.apache.org/content/repositories/orgapachegeode-1020
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_
> plain;f=KEYS;hb=HEAD
>
> pub  4096R/C72CFB64 2015-10-01
>      Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>
> Anthony
>

Review Request 60875: GEODE-2654: Backups can capture different members from different points in time

[Lynn Gallinat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60875/
---

Review request for geode, anilkumar gingade, Darrel Schneider, and Dan Smith.


Repository: geode


Description
---

An online backup was not taking a snapshot of a single point in time. The 
solution is for operations that change the disk files to acquire the backup 
lock, causing them to wait until backup has rolled the op logs.


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java 
4b4fb10 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java 
0925d28 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
3e97d0e 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 5399d5a 


Diff: https://reviews.apache.org/r/60875/diff/1/


Testing
---

Precheckin.


Thanks,

Lynn Gallinat

[GitHub] geode pull request #616: GEODE-2860: Refactor use of EventTracker

[nreich]

Github user nreich closed the pull request at:

https://github.com/apache/geode/pull/616


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/
---

Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Nick Reich.


Bugs: GEODE-3204
https://issues.apache.org/jira/browse/GEODE-3204


Repository: geode


Description
---

txApplyInvalidate no longer modify region entry with a removed token.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java 
7f12eab 
  
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
 60b93a9 


Diff: https://reviews.apache.org/r/60874/diff/1/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180549
---


Ship it!




Ship It!

- Bruce Schuchardt


On July 14, 2017, 10:06 a.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> ---
> 
> (Updated July 14, 2017, 10:06 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
> 
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
> 
> added unit test for it.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  2c56f5b 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  9591673 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  d8c12e2 
> 
> 
> Diff: https://reviews.apache.org/r/60856/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Review Request 60873: GEODE-2189 Docs: Update Swagger UI links Added link to OpenAPI specification.

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60873/
---

Review request for geode.


Repository: geode


Description
---

GEODE-2189 Docs: Update Swagger UI links Added link to OpenAPI specification.


Diffs
-

  geode-docs/rest_apps/using_swagger.html.md.erb 
05f41295057e5c684b7b6403bc3273e33df821c1 


Diff: https://reviews.apache.org/r/60873/diff/1/


Testing
---

Compiled the user manual, verified that the links connect as they should.


Thanks,

Dave Barnes

Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60834/#review180546
---


Ship it!




Ship It!

- Galen O'Sullivan


On July 13, 2017, 12:35 a.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60834/
> ---
> 
> (Updated July 13, 2017, 12:35 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3051
> https://issues.apache.org/jira/browse/GEODE-3051
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This removes handling of SSL exceptions from the AccepterImpl.accept call, as 
> the SSL handling code is now all done in another thread.
> The exception handling being done in the other thread appears to be correct, 
> as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  3c424d397 
> 
> 
> Diff: https://reviews.apache.org/r/60834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

[Hitesh Khamesra]

> On July 14, 2017, 12:18 a.m., Bruce Schuchardt wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
> > Lines 288 (patched)
> > 
> >
> > remove debug logging or set to debug/trace level.  If you keep it you 
> > should use info("GMSLocator has coordinator flag {}", isCoordinator)

changed log message to debug.


- Hitesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180497
---


On July 14, 2017, 5:06 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> ---
> 
> (Updated July 14, 2017, 5:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
> 
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
> 
> added unit test for it.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  2c56f5b 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  9591673 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  d8c12e2 
> 
> 
> Diff: https://reviews.apache.org/r/60856/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/
---

(Updated July 14, 2017, 5:06 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, and Udo Kohlmeyer.


Changes
---

Changed log message to  debug


Repository: geode


Description
---

isCoordinator flag ensures that this process is becoming the
coordinator thus other process should join this process. But
when network parttion happens, we were not resetting this flag.

Now we reset isCoordinator flag when viewCreator thread shutdowns.

added unit test for it.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
 2c56f5b 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 9591673 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 d8c12e2 


Diff: https://reviews.apache.org/r/60856/diff/2/

Changes: https://reviews.apache.org/r/60856/diff/1-2/


Testing
---


Thanks,

Hitesh Khamesra

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180545
---


Ship it!




Ship It!

- Udo Kohlmeyer


On July 13, 2017, 11:28 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> ---
> 
> (Updated July 13, 2017, 11:28 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
> 
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
> 
> added unit test for it.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  2c56f5b 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  9591673 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  d8c12e2 
> 
> 
> Diff: https://reviews.apache.org/r/60856/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

[GitHub] geode issue #630: GEODE-3141: GetRegion Operation implemented

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/630
  
Looks like Spotless is failing in CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: No nulls

[Galen O'Sullivan]

What's the general opinion of @NotNull annotations? Would they be useful?

On Fri, Jul 14, 2017 at 9:23 AM, John Blum  wrote:

> +1 as well.
>
> However, I will caution this... use Java 8's new java.util.Optional class
> in your codebase judiciously.  Using it everywhere, especially on critical
> code paths can and most likely will affect your performance.
>
> Internally, j.u.Optional allocates new objects for nearly every operation
> (e.g. Optional.of(..), Optional.ofNullable(), etc).  Be careful of Optional
> operations that take a *Lambda* since creating a *Lambda* involves
> constructing a new object (exactly like anonymous inner construction).
>
> We just went through this exercise on the *Spring Data* team, introducing
> Java 8 types (e.g.) to our Repository infrastructure and other parts of the
> SD Commons API and it negatively impacted performance, cutting perf in half
> (due to Object allocation).  As such, we rolled back and took another
> approach to Nullability, primarily by using Annotations and IDE support.
>
> Finally, while it is common to return a Optional from a method call, it
> is not appropriate to generally accept Optional parameters in your APIs.
> Generally speaking, there is no substitute for validating method arguments
> than adding assertions (which does not imply just the Java assert facility
> (that is unreliable since it must explicitly be enabled... $ java ... -ea
> ...), rather, use something like using java.util.Objects or AssertJ)..
> NPEs are not user mistakes, they are library mistakes/bugs.
>
> Food for thought,
>
> -j
>
>
> On Thu, Jul 13, 2017 at 6:13 PM, Jacob Barrett 
> wrote:
>
> > +1
> >
> > We are taking a similar approach to refactoring of the C++ client.
> > Specifically with refer to nullptr we are trying to eliminate it from all
> > public APIs.
> >
> > Sent from my iPhone
> >
> > > On Jul 13, 2017, at 3:17 PM, Kirk Lund  wrote:
> > >
> > > Please try to imagine a world of no nulls.
> > >
> > > https://www.oracle.com/corporate/features/library-in-
> > java-best-practices.html?evite=WWMK170414P4
> >
>
>
>
> --
> -John
> john.blum10101 (skype)
>

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

[Alexander Murmann]

> On July 13, 2017, 1:40 a.m., Galen O'Sullivan wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
> > Lines 38 (patched)
> > 
> >
> > I had thought of operation handlers as being stateless. Is this not the 
> > case?
> 
> Brian Rowe wrote:
> Hmm, now that you mention it, this will likely fail spectacularly the 
> first time two threads run getAlls at the same time.  Good catch.  I'll see 
> if Alexander and Udo can fix this as part of the refactoring work they're 
> currently doing.

>From a code maintainability perspective I'd rather have us make a fresh 
>handler for each request rather than having something that's supposed to be 
>used like a singleton but isn't actually a singleton. Turning this into a 
>singleton is also something I'd rather avoid.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/#review180369
---


On July 12, 2017, 6:27 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60718/
> ---
> 
> (Updated July 12, 2017, 6:27 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2997
> https://issues.apache.org/jira/browse/GEODE-2997
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Changed get response to indicate if LookupFailure was a missing key or key 
> with null value, added test
> Added GetAllRequestOperationHandler and unit test
> Added PutAllRequestOperationHandler and unit test
> Added an integration test covering the putAll and getAll operations
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  714639274 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  13b156f99 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  fecf01d7b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
>  e1fef85b4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
>  b246a501b 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
>  d6ef2788e 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
>  924979329 
>   geode-protobuf/src/main/proto/clientProtocol.proto d94c0f312 
>   geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> fee9448af 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  612b9c9a4 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  b7d52019e 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60718/diff/4/
> 
> 
> Testing
> ---
> 
> Added unit tests for new operation handlers
> Added integration test covering new operations
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: No nulls

[John Blum]

+1 as well.

However, I will caution this... use Java 8's new java.util.Optional class
in your codebase judiciously.  Using it everywhere, especially on critical
code paths can and most likely will affect your performance.

Internally, j.u.Optional allocates new objects for nearly every operation
(e.g. Optional.of(..), Optional.ofNullable(), etc).  Be careful of Optional
operations that take a *Lambda* since creating a *Lambda* involves
constructing a new object (exactly like anonymous inner construction).

We just went through this exercise on the *Spring Data* team, introducing
Java 8 types (e.g.) to our Repository infrastructure and other parts of the
SD Commons API and it negatively impacted performance, cutting perf in half
(due to Object allocation).  As such, we rolled back and took another
approach to Nullability, primarily by using Annotations and IDE support.

Finally, while it is common to return a Optional from a method call, it
is not appropriate to generally accept Optional parameters in your APIs.
Generally speaking, there is no substitute for validating method arguments
than adding assertions (which does not imply just the Java assert facility
(that is unreliable since it must explicitly be enabled... $ java ... -ea
...), rather, use something like using java.util.Objects or AssertJ)..
NPEs are not user mistakes, they are library mistakes/bugs.

Food for thought,

-j


On Thu, Jul 13, 2017 at 6:13 PM, Jacob Barrett  wrote:

> +1
>
> We are taking a similar approach to refactoring of the C++ client.
> Specifically with refer to nullptr we are trying to eliminate it from all
> public APIs.
>
> Sent from my iPhone
>
> > On Jul 13, 2017, at 3:17 PM, Kirk Lund  wrote:
> >
> > Please try to imagine a world of no nulls.
> >
> > https://www.oracle.com/corporate/features/library-in-
> java-best-practices.html?evite=WWMK170414P4
>



-- 
-John
john.blum10101 (skype)

Re: Need to enable authentication in Locator JMX

[Jinmei Liao]

Hi, Dinesh, which version of Geode you are using? If you are using the
latest one. By simply specify a security-manager in your locator.properties
will turn on the authentication for jmx. Please see the instruction on this
page:

http://geode.apache.org/docs/guide/11/managing/security/enable_security.html
https://cwiki.apache.org/confluence/display/GEODE/Using+Custom+SecurityManager

On Fri, Jul 14, 2017 at 5:00 AM, Dinesh Akhand  wrote:

> Hi Team,
>
> I need to enable the JMX authentication in geode for clients like pulse .
> could you please suggest what is correct procedure.
>
> I did the below things:
> JMX is enabled:
>
> jmx-manager-start=true
> jmx-manager=true
>
> Add entry
> Locator.properties:
>
> jmx-manager-password-file=/users/xpiwrk1/GemFire/Server/properties/jmxremote.password
>// permission is 400
> jmx-manager-access-file=/users/xpiwrk1/GemFire/Server/
> properties/jmxremote.access
>
>
> cat jmxremote.access
> admin readwrite
>
>
> cat jmxremote.password
> admin admin
>
> I am getting below exception in one of JVM:
>
> Exception in thread "main" java.lang.StackOverflowError
>at java.security.AccessController.doPrivileged(Native
> Method)
>at sun.rmi.transport.tcp.TCPEndpoint.getHostnameProperty(
> TCPEndpoint.java:97)
>at sun.rmi.transport.tcp.TCPEndpoint.resampleLocalHost(
> TCPEndpoint.java:256)
>at sun.rmi.transport.tcp.TCPEndpoint.getLocalEndpoint(
> TCPEndpoint.java:201)
>at sun.rmi.transport.tcp.TCPEndpoint.getOutboundTransport(
> TCPEndpoint.java:368)
>at sun.rmi.transport.tcp.TCPEndpoint.getChannel(
> TCPEndpoint.java:418)
>at sun.rmi.transport.LiveRef.getChannel(LiveRef.java:152)
>at sun.rmi.server.UnicastRef.newCall(UnicastRef.java:342)
>at sun.rmi.registry.RegistryImpl_Stub.lookup(Unknown
> Source)
>at com.sun.jndi.rmi.registry.RegistryContext.lookup(
> RegistryContext.java:118)
>at com.sun.jndi.toolkit.url.GenericURLContext.lookup(
> GenericURLContext.java:205)
>at javax.naming.InitialContext.lookup(InitialContext.java:
> 417)
>at javax.management.remote.rmi.RMIConnector.
> findRMIServerJNDI(RMIConnector.java:1955)
>at javax.management.remote.rmi.RMIConnector.findRMIServer(
> RMIConnector.java:1922)
>at javax.management.remote.rmi.RMIConnector.connect(
> RMIConnector.java:287)
>at javax.management.remote.JMXConnectorFactory.connect(
> JMXConnectorFactory.java:270)
>at org.apache.geode.management.internal.cli.shell.
> JmxOperationInvoker.(JmxOperationInvoker.java:149)
>at org.apache.geode.management.internal.cli.commands.
> ShellCommands.jmxConnect(ShellCommands.java:347)
>at org.apache.geode.management.internal.cli.commands.
> ShellCommands.jmxConnect(ShellCommands.java:372)
>
> Please suggest.
>
> After that I want to enable 
> org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder
> for password encoding & decoding in JMX . please guide.
>
> Thanks,
> Dinesh Akhand
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>



-- 
Cheers

Jinmei

[GitHub] geode pull request #632: GEODE-3203: fixing protobuf build.gradle to respect...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/632


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Stored procedures on Apache Geode.

[John Blum]

Hi Marios-

I may not be the best person to answer this.  There is a Pivotal GemFire /
Greenplum Connector available for download here...

https://network.pivotal.io/products/pivotal-gemfire/#/releases/5376/file_groups/495

More information on the Connector can be found here...

http://ggc.docs.pivotal.io/ggc/relnotes/release_notes30.html

As you may know, Apache Geode is the open source core of Pivotal GemFire (
https://pivotal.io/pivotal-gemfire).  Theoretically, it probably
would/should work to connect Geode with Greenplum, though I have not done
this and I am not sure it is a combination Pivotal nor the Apache Geode
community supports.

There is example of using this Connector with Geode here...

https://github.com/mgoddard-pivotal/FraudDetection-wwko

Which was the basis for this presentation/article...

https://content.pivotal.io/blog/big-data-meets-fast-data-to-fight-fraud-and-more

-j



On Thu, Jul 13, 2017 at 11:33 PM, marios390 <
marios.sofocle...@creditsafe.com> wrote:

> Hi John,
>
> Just a quick one,
> Geode could be integrated with green plum and if not what alternatives for
> this.
>
> Thanks
> Ms
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> ml+s70738n24325...@n6.nabble.com]
> Sent: Thursday, July 13, 2017 11:33 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> It seems you and your team could be / mostly are likely dealing with a
> high-volume of sensitive information, but without knowing a lot about your
> UC(s) or particular application requirements/SLAs, I would recommend
> starting small, simple and scale based on need.
>
> Geode is a highly concurrent and distributed system with strong consistency
> guarantees.  Prematurely breaking the logic down into many individual
> microservices early (especially for individual Stored Procedures... how
> complex are these?) might unduly add complexity to your application and
> system architecture.
>
> So my advice is to really evaluate the need to create individual
> microservices first (which usually involves a platform like [Pivotal's]
> CloudFoundry on an IaaS (or private infra) to manage effectively) vs.
> starting small and just converting the Stored Procs into Geode Functions.
>
> Geode Function executions can be distributed across the cluster (similarly
> to Map-Reduce, but far more robust) in a highly available and reliable
> fashion.
>
> You might want to also read up on Geode's Partitioned Regions [1] for
> effectively managing (partitioning and distributing/arranging your data).
>
> Hope this helps.
>
> -John
>
> [1]
> http://gemfire90.docs.pivotal.io/geode/developing/
> partitioned_regions/chapter_overview.html yrjldnY3TtixZu9rDvLgvAx0M0bPn0iR_AzXTlMikrJPQ7v4gcrUCAFodHRwOi8
> vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9aXRubjJWd0otbE1xQm
> NKbU01T3Q1RU1ZSHRrUWgyc1E4Q08zemVsZjZnJnU9aHR0cCUzYSUyZiUyZm
> dlbWZpcmU5MCUyZWRvY3MlMmVwaXZvdGFsJTJlaW8lMmZnZW9kZSUyZmRldm
> Vsb3BpbmclMmZwYXJ0aXRpb25lZCU1ZnJlZ2lvbnMlMmZjaGFwdGVyJTVmb3
> ZlcnZpZXclMmVodG1s>
>
>
> On Thu, Jul 13, 2017 at 1:09 PM, marios390 <[hidden
> email]
> > wrote:
>
> >
> > 
> > From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> > [hidden email]]
> > Sent: Thursday, July 13, 2017 9:16 PM
> > To: Marios Sofocleous/IT/CREDITSAFE
> > Subject: Re: Stored procedures on Apache Geode.
> >
> > Right.
> >
> > You can also review the Apache Geode documentation on Function Execution
> > [1].  And if you are a *Spring* user, you can use *Spring Data Geode's*
> > convenient Function annotation support for both Function implementation
> as
> > well as execution, here [2].
> >
> > NOTE: you will probably notice the link [2] refers to *Spring Data
> > GemFire's* docs.  *Spring Data GemFire* and *Spring Data Geode* are
> > virtually the same with no differences.  Eventually *Spring Data Geode*
> > will have its own home with its own doc locations since it is finally
> > becoming a top-level SD module [3].
> >
> > -j
> >
> > [1]
> > http://geode.apache.org/docs/guide/11/developing/function_<
> redir.aspx?REF=9WC8AmXblm4Q_zDPwbP3MZWeTU5A8b8TcK6A7zAo07x
> PQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9aXRubjJWd0otbE1xQmNKbU01T3Q1RU1ZSHRrUWgyc1E4QzIx
> bWVsWTd3JnU9aHR0cCUzYSUyZiUyZmdlb2RlJTJlYXBhY2hlJTJlb3JnJTJm
> ZG9jcyUyZmd1aWRlJTJmMTElMmZkZXZlbG9waW5nJTJmZnVuY3Rpb24lNWY.>
> > exec/chapter_overview.html  keRPQ7v4gcrUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9>
> > j7nn2bxZOwcngUOelB5ZmyW7oHpBqfFPnKkha5eWJQ=http%3a%2f%
> > 2fgeode%2eapache%2eorg%2fdocs%2fguide%2f11%2fdeveloping%
> > 2ffunction%5fexec%2fchapter%5foverview%2ehtml>
> > [2]
> > http://docs.spring.io/spring-data-gemfire/docs/current/ 

Need to enable authentication in Locator JMX

[Dinesh Akhand]

Hi Team,

I need to enable the JMX authentication in geode for clients like pulse . could 
you please suggest what is correct procedure.

I did the below things:
JMX is enabled:

jmx-manager-start=true
jmx-manager=true

Add entry
Locator.properties:

jmx-manager-password-file=/users/xpiwrk1/GemFire/Server/properties/jmxremote.password
 // permission is 400
jmx-manager-access-file=/users/xpiwrk1/GemFire/Server/properties/jmxremote.access


cat jmxremote.access
admin readwrite


cat jmxremote.password
admin admin

I am getting below exception in one of JVM:

Exception in thread "main" java.lang.StackOverflowError
   at java.security.AccessController.doPrivileged(Native Method)
   at 
sun.rmi.transport.tcp.TCPEndpoint.getHostnameProperty(TCPEndpoint.java:97)
   at 
sun.rmi.transport.tcp.TCPEndpoint.resampleLocalHost(TCPEndpoint.java:256)
   at 
sun.rmi.transport.tcp.TCPEndpoint.getLocalEndpoint(TCPEndpoint.java:201)
   at 
sun.rmi.transport.tcp.TCPEndpoint.getOutboundTransport(TCPEndpoint.java:368)
   at 
sun.rmi.transport.tcp.TCPEndpoint.getChannel(TCPEndpoint.java:418)
   at sun.rmi.transport.LiveRef.getChannel(LiveRef.java:152)
   at sun.rmi.server.UnicastRef.newCall(UnicastRef.java:342)
   at sun.rmi.registry.RegistryImpl_Stub.lookup(Unknown Source)
   at 
com.sun.jndi.rmi.registry.RegistryContext.lookup(RegistryContext.java:118)
   at 
com.sun.jndi.toolkit.url.GenericURLContext.lookup(GenericURLContext.java:205)
   at javax.naming.InitialContext.lookup(InitialContext.java:417)
   at 
javax.management.remote.rmi.RMIConnector.findRMIServerJNDI(RMIConnector.java:1955)
   at 
javax.management.remote.rmi.RMIConnector.findRMIServer(RMIConnector.java:1922)
   at 
javax.management.remote.rmi.RMIConnector.connect(RMIConnector.java:287)
   at 
javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFactory.java:270)
   at 
org.apache.geode.management.internal.cli.shell.JmxOperationInvoker.(JmxOperationInvoker.java:149)
   at 
org.apache.geode.management.internal.cli.commands.ShellCommands.jmxConnect(ShellCommands.java:347)
   at 
org.apache.geode.management.internal.cli.commands.ShellCommands.jmxConnect(ShellCommands.java:372)

Please suggest.

After that I want to enable 
org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder for password 
encoding & decoding in JMX . please guide.

Thanks,
Dinesh Akhand

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

RE: Query for JMX "Async Event Queue properties"

[Dinesh Akhand]

Thanks Barry,

It solved the problem .

if (bean == null) {//try with function because internal region does't have 
bean
  Set matchedMembers = new HashSet();
  matchedMembers = CliUtil.getMembersForeRegionViaFunction(cache, region, 
true);
  return matchedMembers;
}

Can we publish this fix over open community.

Thanks,
Dinesh Akhand

-Original Message-
From: Barry Oglesby [mailto:bogle...@pivotal.io] 
Sent: Monday, July 10, 2017 11:58 PM
To: dev@geode.apache.org
Subject: Re: Query for JMX "Async Event Queue properties"

Dinesh,

The getRegionAssociatedMembers method looks like it could be improved.

It currently does this:

- gets the distributed MBean for the region
- if one doesn't exist it returns null
- if one does exist, it gets the members for that bean (which are the members 
with that region)
- if there are none, it tries to get the members using a function
- returns the members

Instead of returning null if the MBean can't be found, it could try using the 
function.

I made a hack fix to do that and the query worked:

Cluster-1 gfsh>query --query="select * from 
/AsyncEventQueue_db_PARALLEL_GATEWAY_SENDER_QUEUE"

Result : true
startCount : 0
endCount   : 20
Rows   : 1

DSFID | action | bucketId | callbackArgument | creationTime  |
deserializedValue |   enumListenerEvent
   | eventId |
 eventSequenceID   | initialized | key | keyToConflate |
numberOfParts |operation | possibleDuplicate |
 rawValue  | region | regionPath | regionToConflate |
  senderCallbackArgument |  serializedValue   |
serializedValueNotAvailable | serializedValueSize | shadowKey | sizeInBytes
| substituteValue | value
 | valueIsObject | valueToConflate | versionTimeStamp
- | -- |  |  | - |
- |
-- |
--- |
-- | --- | --- |
- | - |  |
- | -- | -- | -- |
 |
-- |
-- | --- | --- |
- | --- | --- |
-- | - |
--- | 
-134  | 0  | 0| null | 1499708631487 | 0
  | org.apache.geode.internal.cache.EnumListenerEvent.AFTER_CREATE | 
org.apache.geode.internal.cache.EventID |
org.apache.geode.cache.wan.EventSequenceID | true| 0   | 0
| 9 | org.apache.geode.cache.Operation | false
| org.json.JSONArray | null   | /data  | /data|
org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackArgument |
org.json.JSONArray | false   | 17  |
113   | 365 | null|
org.apache.geode.internal.cache.VMCachedDeserializable | 1 | 0
  | 1499708631486

You could write your own function to do the same thing.

I tried that and got:

Cluster-1 gfsh>execute function --id=QueryAsyncEventQueueRegionFunction
--result-collector=QueryAsyncEventQueueRegionFunctionResultCollector
Execution summary

  Member ID/Name| Function Execution Result
--- |
--
server1(40603):1027 |
SenderEventImpl[id=EventIDid=25bytes;threadID=0x1|1;sequenceID=0;bucketId=0];action=0;operation=CREATE;region=/data;key=0;value=0;valueIsObject=1;numberOfParts=9;callbackArgument=GatewaySenderEventCallbackArgumen..


Thanks,
Barry Oglesby


On Fri, Jun 16, 2017 at 5:38 AM, Dinesh Akhand  wrote:

> Hi Team
>
> Regarding the following metrics:
>
> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.
> dataStoreEntryCount
> /AsyncEventQueue_XYZ_PARALLEL_GATEWAY_SENDER_QUEUE:PartitionedRegionStats.
> dataStoreBytesInUse
>
>
> I found only count for async queue in JMX , it called here 
> EventQueueSize = PartitionedRegionStats.dataStoreEntryCount
>
> /** AsyncEventQueue Stats **/
>   public static final String ASYNCEVENTQUEUE_EVENTS_QUEUE_SIZE = 
> "eventQueueSize"
>
> we having Missing  PartitionedRegionStats.dataStoreBytesInUse in JMX 
> for Async Qeueue.
>
> Can you help me , which property I need to map for it.
>
> Thanks,
> Dinesh Akhand
>
>
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
>
> you may review at 

RE: need information about SerialGatewaySenderQueue/ParallelGatewaySenderQueue Clear

[Dinesh Akhand]

Hi Team,



Please reply . why we don't have implementation of clear method in  
ParallelGatewaySenderQueue/ SerialGatewaySenderQueue in geode. Requirement: we 
want to clear the queue data.



I have implement below method in our code.

--

Class ParallelGatewaySenderQueue.java



//clear the partition region

private void clearPartitionedRegion(PartitionedRegion partitionedRegion)

{

LocalDataSet lds = 
(LocalDataSet)PartitionRegionHelper.getLocalPrimaryData(partitionedRegion);

Setset = lds.getBucketSet(); // this returns 
bucket ids in the function context



for (Integer bucketId : set) {

Bucket bucket = 
partitionedRegion.getRegionAdvisor().getBucket(bucketId);

if (bucket instanceof ProxyBucketRegion 
== false) {

if (bucket 
instanceof BucketRegion) {


BucketRegion bucketRegion = (BucketRegion) bucket;


Set keySet = bucketRegion.keySet();


for (Iterator iterator = keySet.iterator(); iterator.hasNext();) {


Object key = iterator.next();


bucketRegion.remove(key);


}

}

}

}

}

-

Class : SerialGatewaySenderQueue.java

 @Override

  public void clearQueue() {



this.sender.getLifeCycleLock().readLock().lock();

Set keys = this.region.keys();

for (Long key : keys) {

  this.region.remove(key);

}

this.sender.getLifeCycleLock().readLock().unlock();



  }

-



Any comment in above code will welcome.





Thanks,

Dinesh Akhand



-Original Message-
From: Dinesh Akhand
Sent: Monday, May 15, 2017 2:39 PM
To: dev@geode.apache.org
Subject: need information about RegionQueue





Hi Team,



Why we do't have support to clear complete queue.  Is there any limitation for 
it?.



public void clear(PartitionedRegion pr, int bucketId) {

   throw new RuntimeException("This method(clear)is not supported by 
ParallelGatewaySenderQueue");

  }



Class : ParallelGatewaySenderQueue

Class : SerialGatewaySenderQueue



Thanks,

Dinesh Akhand



This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,



you may review at https://www.amdocs.com/about/email-disclaimer 

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer