[GitHub] geode issue #664: Fix for GEODE-3292

2017-07-31 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/664 Hi Juan, Thanks for your contribution! Your changes look good to me, but our [Criteria for Code

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

2017-07-31 Thread WireBaron
GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/673 GEODE-3284: New flow: getAvailableServers @galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25 @pivotal-amurmann Signed-off-by: Bruce Schuchardt Thank

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-07-31 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/672 GEODE-3256: Refactoring DataCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3256) `DataCommands.java` was a large class that contained multiple commands.

Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

2017-07-31 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61231/#review181866 --- Ship it! Ship It! - Jared Stewart On July 28, 2017, 8:41

[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #667: GEODE-3324 Document finer-grained security permissi...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #633 was SUCCESSFUL (with 1987 tests)

2017-07-31 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #633 was successful. --- Scheduled 1989 tests in total. https://build.spring.io/browse/SGF-NAG-633/ -- This

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-07-31 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 31, 2017, 10:37 p.m.) Review request for geode, Emily Yeh, Jared

Passed: apache/geode#3342 (develop - 9db5c8e)

2017-07-31 Thread Travis CI
Build Update for apache/geode - Build: #3342 Status: Passed Duration: 14 minutes and 3 seconds Commit: 9db5c8e (develop) Author: Patrick Rhomberg Message: GEODE-2971: Introduce ExitCode to resolve inconsistency of shell exit values. * this closes #652 *

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-07-31 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/671 GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3255) `CreateAlterDestroyRegionCommands` was a

[GitHub] geode pull request #670: GEODE-3336: Refactor IndexCommandsDUnitTest to use ...

2017-07-31 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/670 GEODE-3336: Refactor IndexCommandsDUnitTest to use test rules [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3336) Thank you for submitting a contribution to

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-07-31 Thread Jared Stewart
> On July 30, 2017, 5:05 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java > > Lines 66 (patched) > > > > > > looks like only the

[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...

2017-07-31 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/669 GEODE-2226: SessionReplicationIntegrationTests do not run on Windows * Disable SessionReplicationIntegrationTests on Windows @nabarunnag, @jhuynh1 Thank you for submitting a

Build failed in Jenkins: Geode-nightly #912

2017-07-31 Thread Apache Jenkins Server
See -- [...truncated 112.49 KB...] Note: Recompile with -Xlint:unchecked for details. :geode-cq:processTestResources :geode-cq:testClasses :geode-cq:checkMissedTests

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

2017-07-31 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/652 Precheckin came back fully green. PR squashed and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does