[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130782011 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -0,0 +1,110 @@

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130781962 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -0,0 +1,110 @@

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/676 It looks like this is failing in Travis due to `:rat`, but you've got a license in your only new file. I'm a bit mystified. Closing the pull request and reopening it can be a good way to

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130781436 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java --- @@ -95,8 +97,8 @@

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/676#discussion_r130781170 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/661#discussion_r130494367 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java --- @@ -0,0 +1,47 @@ +/* + *

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/661#discussion_r130495450 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java --- @@ -0,0 +1,47 @@ +/* + *

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/661#discussion_r130494791 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java --- @@ -0,0 +1,47 @@ +/* + *

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/661#discussion_r130779627 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java --- @@ -50,10 +50,7 @@

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r130765375 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044 @@ +/* + * Licensed

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r130765402 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044 @@ +/* + * Licensed

[GitHub] geode pull request #658: GEODE-3315: Replaced PreferBytes... with VMCachedDe...

Github user upthewaterspout closed the pull request at: https://github.com/apache/geode/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] geode issue #658: GEODE-3315: Replaced PreferBytes... with VMCachedDeseriali...

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/658 Merged to develop in 56ea940d3c826e98b16d6b508fc834f7bd50220c. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

GitHub user WireBaron opened a pull request: https://github.com/apache/geode/pull/676 GEODE-3321: Adding ErrorCode values to protobuf protocol @pivotal-amurmann @kohlmu-pivotal @hiteshk25 @galen-pivotal @bschuchardt Signed-off-by: Bruce Schuchardt

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/663 @pivotal-amurmann I'd like to write a unit test. @hiteshk25 and I took a stab at it this afternoon but after an hour or two, got lost in mocks and the tangle of

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61281/#review181924 ---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #634 was SUCCESSFUL (with 2024 tests). Change made by John Blum.

--- Spring Data GemFire > Nightly-ApacheGeode > #634 was successful. --- Scheduled with changes by John Blum. 2026 tests in total.

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181921 --- Ship it! Ship It! - Jinmei Liao On Aug. 1, 2017, 6:31 p.m.,

[GitHub] geode pull request #655: GEODE-3030: Set possibleDuplicate=true for all buck...

Github user upthewaterspout closed the pull request at: https://github.com/apache/geode/pull/655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61281/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat,

[GitHub] geode issue #570: GEODE-3055: waitUntilFlush should use data region's bucket...

Github user gesterzhou commented on the issue: https://github.com/apache/geode/pull/570 The forceRemovePrimary was useless and it can be removed because it always use "false". But when I added the logic to remove the leader region bucket (when the shadow bucket failed to

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r130729615 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -1472,6 +1472,19 @@ public boolean

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/674#discussion_r130727639 --- Diff: geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java --- @@ -500,6 +502,81 @@ public void run2() throws CacheException

Build failed in Jenkins: Geode-nightly-flaky #82

See Changes: [jiliao] GEODE-2971: Introduce ExitCode to resolve inconsistency of shell exit [jstewart] GEODE-3317: Fix UniversalMembershipListenerAdapterDUnitTest [kmiller] GEODE-3324 Document finer-grained

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 1, 2017, 6:31 p.m.) Review request for geode, Emily Yeh, Jared

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130677475 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java --- @@ -99,7 +99,6 @@ protected Launcher() {

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130678413 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java --- @@ -633,8 +631,8 @@ public

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r130677047 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -260,6 +265,7 @@ private JMXServiceURL

[GitHub] geode pull request #675: GEODE-3339: Refactoring ClusterConfigurationService...

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/675 GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3339)

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/672#discussion_r130673499 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java --- @@ -0,0 +1,311 @@ +/* + *

Build failed in Jenkins: Geode-nightly #913

See Changes: [hiteshk25] GEODE-3286: Failing to cleanup connections from ConnectionTable receiver [browe] GEODE-3286: incorporating review feedback [browe] GEODE-3286: Improving closed connection check [jiliao]

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/671#discussion_r130668398 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java --- @@ -1143,4 +721,26 @@ private

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130658877 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130661310 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandDUnitTest.java --- @@ -0,0 +1,181 @@ +/*

Re: 2 unit tests fail in geode-core

I actually have a change that will be ready to merge to develop soon in which I've rewritten LocatorLauncherTest and ServerLauncherTest. The changes I have will fix these two failures that you're seeing. I'm not aware of any recent changes that would've broken these two tests -- the two bind

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/674#discussion_r130654524 --- Diff: geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java --- @@ -500,6 +502,81 @@ public void run2() throws CacheException

RE: 2 unit tests fail in geode-core

Hi Nabarun, My connectivity to the Internet is done via HTTP proxy. Maybe this can be the reason. But it is not an excuse for a test not to pass. Two weeks ago the tests passed, and now they don't. Seems like something was broken in the code. BR, Anton -Original Message- From: Nabarun

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130647800 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@ -0,0

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130646564 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/GetAvailableServersDUnitTest.java --- @@ -0,0 +1,108 @@ +/* + * Licensed

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130646340 --- Diff: geode-protobuf/src/main/proto/clientProtocol.proto --- @@ -43,13 +43,12 @@ message Request { GetAllRequest getAllRequest = 5;

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130646425 --- Diff: geode-protobuf/src/main/proto/clientProtocol.proto --- @@ -64,15 +63,14 @@ message Response { GetAllResponse getAllResponse =

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130646177 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java --- @@ -140,7 +141,7 @@ /**

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130645759 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -0,0 +1,98 @@

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130644766 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -0,0 +1,98 @@

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/673#discussion_r130642543 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -0,0 +1,98 @@

Re: 2 unit tests fail in geode-core

Hi Anton, I was able to reproduce the issue if I shut down my wifi and remove my ethernet cable from my Mac [no network connections active / on]. Once wifi is switched on or ethernet is connected to the machine the tests pass. Regards Nabarun Nag > On Aug 1, 2017, at 7:48 AM, Anton Mironenko

2 unit tests fail in geode-core

Hello, 2 unit tests fail in geode-core on the latest commit 9d59402b71beea84199c79399aa0260955a19d2c (August 1). Whereas all unit tests passed on aa4878ef19d27a78454dc10b451199f088a2f37d (July 18). What is an easiest way to fix it? gradlew geode-core:test ...

[GitHub] geode issue #664: Fix for GEODE-3292

Github user jujoramos commented on the issue: https://github.com/apache/geode/pull/664 Hey @jaredjstewart, Thanks for looking at this. I'll write the tests, no worries at all. Cheers. --- If your project is set up for it, you can reply to this email and have your