[GitHub] geode pull request #743: GEODE-3131: Increasing the time

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/743


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r135158491
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java ---
@@ -46,6 +44,14 @@ void receiveMessage(InputStream inputStream, 
OutputStream outputStream,
   boolean isAuthenticated();
 
   /**
+   * Return an authorization object which can be used to determine which 
permissions this stream has
+   * according to the provided securityManager.
+   *
+   * Calling this before authentication has succeeded may result in a null 
return object.
--- End diff --

I kind of prefer a comment or even annotation saying nullable -- optionals 
themselves can be null, and have some cost.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/737#discussion_r135157183
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java
 ---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.serialization.codec;
+
+import static java.util.Arrays.asList;
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.distributed.ConfigurationProperties;
+import org.apache.geode.internal.cache.GemFireCacheImpl;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.pdx.JSONFormatter;
+import org.apache.geode.pdx.PdxInstance;
+import org.apache.geode.pdx.PdxInstanceFactory;
+import org.apache.geode.pdx.WritablePdxInstance;
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.LinkedList;
+import java.util.List;
+
+@Category(UnitTest.class)
+public class JSONCodecJUnitTest {
+
+  private String complexJSONString = "{\n" + "\"_id\": 
\"599c7d885df276ac3e0bf10a\",\n"
+  + "\"index\": 0,\n" + "\"guid\": 
\"395902d8-36ed-4178-ad70-2f720c557c55\",\n"
+  + "\"isActive\": true,\n" + "\"balance\": \"$3,152.82\",\n"
+  + "\"picture\": \"http://placehold.it/32x32\",\n; + "
\"age\": 27,\n"
+  + "\"eyeColor\": \"blue\",\n" + "\"name\": \"Kristina 
Norman\",\n"
+  + "\"gender\": \"female\",\n" + "\"company\": \"ORBALIX\",\n"
+  + "\"email\": \"kristinanor...@orbalix.com\",\n"
+  + "\"phone\": \"+1 (983) 526-3433\",\n"
+  + "\"address\": \"400 Vermont Court, Denio, Wyoming, 7142\",\n"
+  + "\"about\": \"Mollit nostrud irure excepteur veniam aliqua. 
Non id tempor magna nisi ipsum minim. Culpa velit tempor culpa mollit cillum 
deserunt nisi culpa irure ut nostrud enim consectetur voluptate. Elit veniam 
velit enim minim. Sunt nostrud ea duis enim sit cillum.\",\n"
+  + "\"registered\": \"2015-03-11T02:22:45 +07:00\",\n" + "
\"latitude\": -0.853065,\n"
+  + "\"longitude\": -29.749358,\n" + "\"tags\": [\n" + "  
\"laboris\",\n"
+  + "  \"velit\",\n" + "  \"non\",\n" + "  \"est\",\n" + " 
 \"anim\",\n"
+  + "  \"amet\",\n" + "  \"cupidatat\"\n" + "],\n" + "
\"friends\": [\n"
+  + "  {\n" + "\"id\": 0,\n" + "\"name\": 
\"Roseann Roy\"\n" + "  },\n"
+  + "  {\n" + "\"id\": 1,\n" + "\"name\": 
\"Adriana Perry\"\n"
+  + "  },\n" + "  {\n" + "\"id\": 2,\n"
+  + "\"name\": \"Tyler Mccarthy\"\n" + "  }\n" + "],\n"
+  + "\"greeting\": \"Hello, Kristina Norman! You have 8 unread 
messages.\",\n"
+  + "\"favoriteFruit\": \"apple\"\n" + "  }";
+  private Cache cache;
+
+  @Before
+  public void setUp() throws Exception {
+CacheFactory cacheFactory = new CacheFactory();
+cacheFactory.set(ConfigurationProperties.MCAST_PORT, "0");
+cacheFactory.set(ConfigurationProperties.USE_CLUSTER_CONFIGURATION, 
"false");
+cacheFactory.set(ConfigurationProperties.ENABLE_CLUSTER_CONFIGURATION, 
"false");
+cache = cacheFactory.create();
+  }
+
+  @After
+  public void tearDown() throws Exception {
+if (cache != null) {
+  cache.close();
+}
+  }
+
+  @Test
+  public void testSimpleJSONEncode() throws Exception {
+PdxInstanceFactory pdxInstanceFactory =
+((GemFireCacheImpl) 

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/737#discussion_r135156514
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 ---
@@ -119,7 +119,14 @@ public void setup() throws Exception {
 }
 
 CacheFactory cacheFactory = new CacheFactory(properties);
-cacheFactory.set("mcast-port", "0"); // sometimes it isn't due to 
other tests.
+cacheFactory.set(ConfigurationProperties.MCAST_PORT, "0"); // 
sometimes it isn't due to other
+   // tests.
+cacheFactory.set(ConfigurationProperties.ENABLE_CLUSTER_CONFIGURATION, 
"false"); // sometimes it
+   
  // isn't due to
+   
  // other tests.
--- End diff --

I realize this is following existing style, but could we be more explicit 
in the comment and say what `it isn't`? Something like `sometimes it is not set 
to "false" due to test pollution` would be clearer. Or Even just `guard against 
test pollution`. II had to read the comment multiple times to understand what 
was going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r135154701
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/AuthorizationIntegrationTest.java
 ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.protocol;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.same;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.Socket;
+import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
+import org.awaitility.Awaitility;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.contrib.java.lang.system.RestoreSystemProperties;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.server.CacheServer;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.management.internal.security.ResourceConstants;
+import org.apache.geode.protocol.protobuf.AuthenticationAPI;
+import org.apache.geode.protocol.protobuf.ClientProtocol;
+import org.apache.geode.protocol.protobuf.ProtobufSerializationService;
+import org.apache.geode.protocol.protobuf.ProtocolErrorCode;
+import org.apache.geode.protocol.protobuf.RegionAPI;
+import 
org.apache.geode.protocol.protobuf.serializer.ProtobufProtocolSerializer;
+import org.apache.geode.protocol.protobuf.utilities.ProtobufUtilities;
+import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.security.SecurityManager;
+import 
org.apache.geode.serialization.registry.exception.CodecAlreadyRegisteredForTypeException;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+
+@Category(IntegrationTest.class)
+public class AuthorizationIntegrationTest {
--- End diff --

Hugs for not adding this to the existing Roundtrip test! 🤗


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r135153161
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java ---
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.security;
+
+public interface StreamAuthorizer {
--- End diff --

Does it make sense to remove the `Stream` part of this name? There seems to 
be nothing about this interface that is related to streams at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r135153564
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
 ---
@@ -41,20 +43,29 @@ public void receiveMessage(InputStream inputStream, 
OutputStream outputStream,
 properties.setProperty(ResourceConstants.USER_NAME, 
authenticationRequest.getUsername());
 properties.setProperty(ResourceConstants.PASSWORD, 
authenticationRequest.getPassword());
 
+authorizer = null; // authenticating a new user clears current 
authorizer
 try {
   Object principal = securityManager.authenticate(properties);
-  authenticated = principal != null;
+  if (principal != null) {
+authorizer = new ProtobufSimpleAuthorizer(principal, 
securityManager);
+  }
 } catch (AuthenticationFailedException e) {
-  authenticated = false;
+  authorizer = null;
 }
 
-
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(authenticated)
+
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(isAuthenticated())
 .build().writeDelimitedTo(outputStream);
   }
 
   @Override
   public boolean isAuthenticated() {
-return authenticated;
+// note: an authorizer is only created if the user has been 
authenticated
+return authorizer != null;
--- End diff --

this would be nicer as well if `Optional`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r135153452
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 ---
@@ -44,9 +46,15 @@ public ProtobufOpsProcessor(SerializationService 
serializationService,
 ClientProtocol.Response.Builder builder;
 Result result;
 try {
-  result = 
operationContext.getOperationHandler().process(serializationService,
-  operationContext.getFromRequest().apply(request), context);
-} catch (InvalidExecutionContextException e) {
+  if 
(context.getAuthorizer().authorize(operationContext.getAccessPermissionRequired()))
 {
+result = 
operationContext.getOperationHandler().process(serializationService,
+operationContext.getFromRequest().apply(request), context);
+  } else {
--- End diff --

We might want to log this. Logging all security related events can be a 
life saver during or after a security incident.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/740#discussion_r135150238
  
--- Diff: 
extensions/geode-modules-session/src/main/java/org/apache/geode/modules/session/filter/SessionListener.java
 ---
@@ -22,6 +22,11 @@
 import javax.servlet.http.HttpSessionEvent;
 import javax.servlet.http.HttpSessionListener;
 
+/**
--- End diff --

modify_war should no longer add this session listener.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/740#discussion_r135150926
  
--- Diff: 
extensions/session-testing-war/src/main/java/org/apache/geode/modules/session/SessionCountingListener.java
 ---
@@ -12,28 +12,35 @@
  * or implied. See the License for the specific language governing 
permissions and limitations under
  * the License.
  */
+package org.apache.geode.modules.session;
 
-package org.apache.geode.modules.session.internal.filter;
-
-import org.apache.geode.modules.session.filter.SessionCachingFilter;
-
-import javax.servlet.http.HttpSession;
+import java.util.concurrent.atomic.AtomicInteger;
 import javax.servlet.http.HttpSessionEvent;
 import javax.servlet.http.HttpSessionListener;
 
-public class HttpSessionListenerImpl2 extends AbstractListener implements 
HttpSessionListener {
+public class SessionCountingListener extends ListenerStoredInSessionContext
+implements HttpSessionListener {
+  private final AtomicInteger sessionCount = new AtomicInteger();
--- End diff --

Is this sessionCount field used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/740#discussion_r135151782
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/Jetty9CachingClientServerTest.java
 ---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.session.tests;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+import java.net.URISyntaxException;
+import java.util.concurrent.TimeUnit;
+
+import javax.servlet.http.HttpSession;
+
+import org.awaitility.Awaitility;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.modules.session.functions.GetSessionCount;
+import org.apache.geode.test.dunit.DUnitEnv;
+
+/**
+ * Jetty 9 Client Server tests
+ *
+ * Runs all the tests in {@link CargoTestBase} on the Jetty 9 install, 
setup in the
+ * {@link #setupJettyInstall()} method before tests are run.
+ */
+public class Jetty9CachingClientServerTest extends 
GenericAppServerClientServerTest {
+  private static ContainerInstall install;
+
+  @BeforeClass
+  public static void setupJettyInstall() throws Exception {
+install = new 
GenericAppServerInstall(GenericAppServerInstall.GenericAppServerVersion.JETTY9,
+ContainerInstall.ConnectionType.CACHING_CLIENT_SERVER,
+ContainerInstall.DEFAULT_INSTALL_DIR + "Jetty9ClientServerTest");
--- End diff --

Change this install directory?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #743: GEODE-3131: Increasing the time

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/743

GEODE-3131: Increasing the time

* Increasing the time elapsed before the dispatchers are started.
* All validations must be done before the dispatcher start dispatching.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #743


commit ab1988b765d6192101aa0fccbce9e0ac9f8e3b14
Author: nabarun 
Date:   2017-08-24T23:02:21Z

GEODE-3131: Increasing the time

* Increasing the time elapsed before the dispatchers are started.
* All validations must be done before the dispatcher start dispatching.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #657 was SUCCESSFUL (with 2027 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #657 was successful.
---
Scheduled
2029 tests in total.

https://build.spring.io/browse/SGF-NAG-657/





--
This message is automatically generated by Atlassian Bamboo

Re: [GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...

[Jacob Barrett]

Udo,

Once we switch to git box we will be able to close prs.

Sent from my iPhone

> On Aug 24, 2017, at 3:16 PM, kohlmu-pivotal  wrote:
> 
> Github user kohlmu-pivotal commented on the issue:
> 
>https://github.com/apache/geode/pull/245
> 
>@doribd @fdaniel7 could you please close this PR if it is not required 
> anymore.
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/740#discussion_r135148933
  
--- Diff: 
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/attributes/AbstractSessionAttributes.java
 ---
@@ -66,6 +66,8 @@
*/
   protected String jvmOwnerId;
 
+  protected long creationTime;
--- End diff --

Does this field need to be serialized?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #325: merge new version

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/325
  
@zmyer could you please confirm that this PR is still relevant. If not I 
will close it CoB tomorrow ( 25 Aug)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/245
  
@doribd @fdaniel7 could you please close this PR if it is not required 
anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/
---

(Updated Aug. 24, 2017, 10:02 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Additional changes in the launchers due to tests that were failing from 
expected/actual mismatches of localhost address in 
LocatorLauncherRemoteIntegrationTest and ServerLauncherRemoteIntegrationTest.

Fixed a bug in LocatorLauncher.LocatorState.getBindAddressAsString(), 
apparently from when legacy code was open sourced and geode's StringUtils was 
replaced by the StringUtils in Apache Commons. (!StringUtils.isBlank) was at 
some point copy/pasted incorrectly without the '!'.

Updated tests ```*LauncherRemoteIntegrationTest``` to take into account the 
updated information in the LocatorState & ServerState classes.


Repository: geode


Description
---

Updated tests for changes in the error constructors for ServerState and
LocatorState.

Minor spelling corrections.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 3a98373938e3de21da6badcf460dae3648218ac6 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
83c1ab533e3dea323a8a99f7002b9464a54dfc25 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
ae64691605130c9b212a3a33bb65ae37b28af02b 
  
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
 409a96dbe416a6f96c2389356b9d823d1adb793f 
  
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
 cc42a53772f3064b800ca1ac1ae894be6c715399 
  
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java
 733a1082ae9993fbdb646712380af7dcc1cca560 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
 dd5841f4cffca38da07a11f381cf4174d7264349 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 e7f17ef208a1708f385c7c4041affb70fd309a4c 


Diff: https://reviews.apache.org/r/61701/diff/5/

Changes: https://reviews.apache.org/r/61701/diff/4-5/


Testing (updated)
---

Precheckin from earlier ran green.

8/23/17: Re-running precheckin with this additional refactoring.

8/24/17: Once more around the precheckin merry-go-round


Thanks,

Ken Howe

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/742
  
@pivotal-amurmann no files should have been moved. Only class import 
locations have changed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/#review183799
---



Would it be possible to add a unit test for this fix?

- Darrel Schneider


On Aug. 24, 2017, 1:13 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61895/
> ---
> 
> (Updated Aug. 24, 2017, 1:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3516
> https://issues.apache.org/jira/browse/GEODE-3516
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove the thread from waiting thread queue after successfully resumed the 
> transaction
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java 
> a0a4d7c 
> 
> 
> Diff: https://reviews.apache.org/r/61895/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183798
---


Ship it!




Ship It!


geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
Lines 96 (patched)


I'm curious, what's the result of this method? Does in interleave stdout 
and stderr in someway?

Another alternative is to use ProcessBuilder.redirectErrorStream so they 
become interleaved chronologically. The downside is you can't differentiate 
between the two. But there's probably some other way to synchronize the two 
chronologically using a stream tee or union.


- Kirk Lund


On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> ---
> 
> (Updated Aug. 23, 2017, 8:18 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3510: GfshRule displays output from StdError
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  47f030471a988055400a71e5b564f3b24397c2e8 
> 
> 
> Diff: https://reviews.apache.org/r/61860/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Nightly build failures caused by attempted use of default ports

[Kirk Lund]

Vince just told me that we can't use Docker in Windows. So that's one
downside.

On Thu, Aug 24, 2017 at 7:27 AM, Darrel Schneider 
wrote:

> I like the sound of #1:
> 1) use Docker for AcceptanceTest and IntegrationTest targets?
>
> Does anyone know of a downside to running these tests in docker?
>
> On Wed, Aug 23, 2017 at 12:06 PM, Jared Stewart 
> wrote:
>
> > I think we just need to have AcceptanceTest (and possibly
> IntegrationTest)
> > run inside Docker like DistributedTest already does.
> >
> > - Jared.
> >
> > > On Aug 23, 2017, at 11:32 AM, Anilkumar Gingade 
> > wrote:
> > >
> > >>> 1) use Docker for AcceptanceTest and IntegrationTest targets?
> > > To be clear, the failing tests are only in Acceptance Test and
> > Integration
> > > Tests? And distributed tests are not seeing this issue as they are
> > running
> > > in docker nowIf moving docker address this issue, my vote is for
> > moving
> > > docker; this makes all the tests to be run in similar environment.
> > >
> > >>> 2) not test default ports?
> > > If the product supports default port; we need to have test for
> > that...Most
> > > of the early product evaluation is done with default port...
> > >
> > > -Anil.
> > >
> > >
> > > On Wed, Aug 23, 2017 at 11:15 AM, Kirk Lund  wrote:
> > >
> > >> The following nightly build failures are tests that are testing
> default
> > >> ports which are failing because the port is not available.
> > >>
> > >> Should we:
> > >>
> > >> 1) use Docker for AcceptanceTest and IntegrationTest targets?
> > >>
> > >> 2) not test default ports?
> > >>
> > >> 3) use a hacky System property to force Geode to think that some other
> > port
> > >> is the default port?
> > >>
> > >> 4) some other solution?
> > >>
> > >> testGet – org.apache.geode.rest.internal.web.RestServersJUnitTest
> > >> a few seconds
> > >> testServerStartedOnDefaultPort –
> > >> org.apache.geode.rest.internal.web.RestServersJUnitTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedWhenConnected_server_dir –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedWhenConnected_server_pid –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> onlineStatusCommandShouldSucceedWhenConnected_locator_host_and_port –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_dir –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_pid –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> onlineStatusCommandShouldSucceedWhenConnected_server_name –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedWhenConnected_locator_dir –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> offlineStatusCommandShouldSucceedWhenConnected_locator_pid –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> onlineStatusCommandShouldSucceedWhenConnected_locator_name –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> onlineStatusCommandShouldSucceedWhenConnected_locator_port –
> > >> org.apache.geode.management.internal.cli.shell.
> > >> GfshExitCodeStatusCommandsTest
> > >> a few seconds
> > >> statusLocatorSucceedsWhenConnected –
> > >> org.apache.geode.management.internal.cli.commands.
> > >> StatusLocatorRealGfshTest
> > >>
> >
> >
>

Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/
---

Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Nick Reich.


Bugs: GEODE-3516
https://issues.apache.org/jira/browse/GEODE-3516


Repository: geode


Description
---

Remove the thread from waiting thread queue after successfully resumed the 
transaction


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java 
a0a4d7c 


Diff: https://reviews.apache.org/r/61895/diff/1/


Testing
---

precheckin.


Thanks,

Eric Shu

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

[pivotal-amurmann]

Github user pivotal-amurmann commented on the issue:

https://github.com/apache/geode/pull/742
  
This looks good. However, I'd like to understand what the plan is for 
moving the files to the location suggested by the package name/path. Maybe the 
Commit message could clarify that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #742: GEODE-3473: Initial commit of the internal package renamin...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/742
  
@galen-pivotal @bschuchardt @pivotal-amurmann @WireBaron @hiteshk25 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #742: GEODE-3473: Initial commit of the internal package ...

[kohlmu-pivotal]

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/742

GEODE-3473: Initial commit of the internal package renaming refactor.

Changing the protobuf file refactor first.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3473

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #742


commit acc9cebcb996da8413e9bfd47cc0bf20976ebf23
Author: Udo Kohlmeyer 
Date:   2017-08-24T19:54:38Z

GEODE-3473: Initial commit of the internal package renaming refactor.
Changing the protobuf file refactor first.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Updating Spotless

[Anilkumar Gingade]

+1 for consistency...

-Anil.


On Wed, Aug 23, 2017 at 4:42 PM, Kirk Lund  wrote:

> I'm for making our spotless better match our style guide, and it's easy
> enough to update branches with this.
>
> On Wed, Aug 23, 2017 at 4:31 PM, Patrick Rhomberg 
> wrote:
>
> > [tl;dr:]
> > - We are inconsistent with our own established style rules.
> > - We should become not that.
> > - How do we coordinate becoming better?
> > - Do you have any other areas where we can become more spotless?
> >
> > --
> > Hello, devs.
> >
> >   There are a great many instances throughout the geode codebase that are
> > in direct contention with our documented style guide [1].  These strike
> me
> > as glaring broken windows, but thankfully fixing some of these issues is
> a
> > very low-hanging fruit (the mixing of metaphors notwithstanding).
> >
> >   I've explored some updates to spotlessApply can that correct some of
> > these issues.  These changes can be seen on my repo, linked below
> ([2]).  I
> > have covered the following:
> > - adherence to the import ordering given in
> > /etc/eclipseOrganizeImports.importorder
> > - adherence to modifier ordering, as given in our adoption of the Google
> > Style Guide ([3])
> > - removal of dead code in the form of commented-out import statements.
> >
> >   If anyone has any insight on how to improve spotless beyond this, we
> > should coordinate to minimize impact on the git log.  Also, I suspect we
> > will want to coordinate these changes with a release cycle, for greater
> > clarity in each individual file history.
> >
> >   What do you think?
> >
> > Imagination is Change.
> > ~Patrick
> >
> > ---
> > [1] https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide
> > [2] https://github.com/PurelyApplied/geode/blob/spotless/build.gradle
> > [3] https://google.github.io/styleguide/javaguide.html#s4.8.7-modifiers
> >
> > ---
> > Impact of corrections made by these changes to spotless, as rebased
> against
> > 2017-08-23's commit 039edfc...
> >
> > -- 2,525 files with incorrect import ordering corrected.
> > -- 115 pointless lines of commented-out import statements removed.
> > -- 1,988 lines across 480 files with incorrect modifier ordering
> corrected
> >
>

Re: Visibility of Skipped tests in Jenkins

[William Markito Oliveira]

Yup. I've tested accessing that same page without any authentication and
seems to work fine here as well..

On Thu, Aug 24, 2017 at 1:29 PM, Mark Bretl  wrote:

> Hi Kirk,
>
> I think you are looking for this page, https://builds.apache.
> org/blue/organizations/jenkins/Geode-nightly/detail/
> Geode-nightly/930/tests?
>
> I see 'Skipped' under the Failed tests.
>
> --Mark
>
> On Thu, Aug 24, 2017 at 11:09 AM, Kirk Lund  wrote:
>
>> In local instances of Jenkins, I can see a list of "Skipped" tests --
>> these are JUnit tests which were skipped because they are marked with
>> @Ignore or because they have an org.junit.Assume check that wasn't
>> satisfied (example: Assume.assumeTrue(isWindows())). I can't figure out
>> where that view is in the ASF Jenkins for Geode Nightly Build. Is it there
>> and I'm just missing it or I have insufficient permissions?
>>
>>
>


-- 
~/William

Re: Visibility of Skipped tests in Jenkins

[Mark Bretl]

Hi Kirk,

I think you are looking for this page,
https://builds.apache.org/blue/organizations/jenkins/Geode-nightly/detail/Geode-nightly/930/tests
?

I see 'Skipped' under the Failed tests.

--Mark

On Thu, Aug 24, 2017 at 11:09 AM, Kirk Lund  wrote:

> In local instances of Jenkins, I can see a list of "Skipped" tests --
> these are JUnit tests which were skipped because they are marked with
> @Ignore or because they have an org.junit.Assume check that wasn't
> satisfied (example: Assume.assumeTrue(isWindows())). I can't figure out
> where that view is in the ASF Jenkins for Geode Nightly Build. Is it there
> and I'm just missing it or I have insufficient permissions?
>
>

[GitHub] geode pull request #741: GEODE-3512 Doc removal of gfsh encrypt password

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/741

GEODE-3512 Doc removal of gfsh encrypt password

This revises the documentation to go with GEODE-1958.

@jaredjstewart @jinmeiliao @davebarnes97 @joeymcallister, please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3512

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #741


commit c1f4b32e8ebf9f1aa5519eeba9efcb294b47dfe9
Author: Karen Miller 
Date:   2017-08-24T17:55:32Z

GEODE-3512 Doc removal of gfsh encrypt password

This revises the documentation to go with GEODE-1958.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r135089666
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
 ---
@@ -50,51 +37,23 @@
   @Override
   public Result process(
   SerializationService serializationService, 
ServerAPI.GetAvailableServersRequest request,
-  Cache cache) {
-
-InternalDistributedSystem distributedSystem =
-(InternalDistributedSystem) cache.getDistributedSystem();
-Properties properties = distributedSystem.getProperties();
-String locatorsString = 
properties.getProperty(ConfigurationProperties.LOCATORS);
+  MessageExecutionContext executionContext) throws 
InvalidExecutionContextException {
 
-HashSet locators = new HashSet();
-StringTokenizer stringTokenizer = new StringTokenizer(locatorsString, 
",");
-while (stringTokenizer.hasMoreTokens()) {
-  String locator = stringTokenizer.nextToken();
-  if (StringUtils.isNotEmpty(locator)) {
-locators.add(new DistributionLocatorId(locator));
-  }
+InternalLocator locator = executionContext.getLocator();
+ArrayList serversFromSnapshot =
--- End diff --

I very much agree with Galen that this should be refactored. This is a big 
demeter violation which is pointing at some worse code in ServerLocator which 
currently know how to answered requests and how to get the information to 
answer them. If that was split out into one class that can talk whatever 
protocol it's talking and another class that can get information from the 
locator this could get cleaned up quite a bit and also make unit tests much 
easier. Since we are talking about switching to Netty that might be wasted 
effort at this time. On the other hand we should extract the business logic 
from the transport logic anyways when moving to Netty and doing this beforehand 
might make that move easier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Visibility of Skipped tests in Jenkins

[Kirk Lund]

In local instances of Jenkins, I can see a list of "Skipped" tests -- these
are JUnit tests which were skipped because they are marked with @Ignore or
because they have an org.junit.Assume check that wasn't satisfied (example:
Assume.assumeTrue(isWindows())). I can't figure out where that view is in
the ASF Jenkins for Geode Nightly Build. Is it there and I'm just missing
it or I have insufficient permissions?

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

[pivotal-amurmann]

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r135087207
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
 ---
@@ -297,6 +297,8 @@ public Object call() throws IOException {
 // able to do so successfully anyway
 p.setProperty(DISABLE_AUTO_RECONNECT, "true");
 
+System.setProperty("geode.feature-protobuf-protocol", "true");
--- End diff --

Ideally we would not set this all the time. However, it would be a 
non-trivial effort to only set this when we need it and the feature flag should 
go away soon entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #740: GEODE-3513: Removing the use of native sessions session ca...

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/740
  
@jhuynh1 @boglesby 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #740: GEODE-3513: Removing the use of native sessions ses...

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode/pull/740

GEODE-3513: Removing the use of native sessions session caching

In the session module for generic app servers, we were asking the
application server for a 'native' session and then wrapping it on our
own GemfireHttpSession. However, we were not cleaning up that native
session, which means that in PROXY mode we were leaving these sessions
on the client with them being useful.

The GemfireHttpSession now no longer wraps a native session. We are
still temporarily creating a native session because it is the only way
for us to get the session timeout value that was configured in web.xml,
but the native session is immediately invalidated.

Adding and extending cargo session tests to test how sessions are being
cleaned up from the clients and the server.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/incubator-geode 
feature/GEODE-3513

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #740


commit 93163bf8077cd6363dfcb9c1e1a37d1876e1669e
Author: Dan Smith 
Date:   2017-08-11T16:46:40Z

GEODE-3513: Removing the use of native sessions session caching

In the session module for generic app servers, we were asking the
application server for a 'native' session and then wrapping it on our
own GemfireHttpSession. However, we were not cleaning up that native
session, which means that in PROXY mode we were leaving these sessions
on the client with them being useful.

The GemfireHttpSession now no longer wraps a native session. We are
still temporarily creating a native session because it is the only way
for us to get the session timeout value that was configured in web.xml,
but the native session is immediately invalidated.

Adding and extending cargo session tests to test how sessions are being
cleaned up from the clients and the server.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: eviction files

[Dan Smith]

Hi Roi,

I would probably start from NewLRUClockHand. That's the class that
maintains the actual state of what entries are least recently used.

You can follow the callers of getLRUEntry back to see how it's being used.
One key place is AbstractLRUMap.lruUpdateCallback, which gets called after
updates to the region data. In there, it checks with a
LRUCapacityController to see if something needs to be evicted, and uses
NewLRUClockHand to figure out what to evict.

-Dan

On Thu, Aug 24, 2017 at 9:02 AM, Roi Apelker  wrote:

> Hi,
>
> I am looking into the internals of the eviction process,
>
> Can anyone point me to the most important classes, the main mechanism
> "wheels" etc.?
>
> Thanks,
>
> Roi
>

[GitHub] geode issue #734: GEODE-3508: Remove unused internal deprecated classes.

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/734
  
Precheckin green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183747
---


Ship it!





geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
Lines 24 (patched)


Left a straggler.


- Patrick Rhomberg


On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> ---
> 
> (Updated Aug. 23, 2017, 8:18 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3510: GfshRule displays output from StdError
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  47f030471a988055400a71e5b564f3b24397c2e8 
> 
> 
> Diff: https://reviews.apache.org/r/61860/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

eviction files

[Roi Apelker]

Hi,

I am looking into the internals of the eviction process,

Can anyone point me to the most important classes, the main mechanism "wheels" 
etc.?

Thanks,

Roi

-Original Message-
From: Roi Apelker 
Sent: Wednesday, August 16, 2017 8:38 PM
To: dev@geode.apache.org
Subject: RE: continuous query internal mechanism questions

It seems like the code in the native client (in the version I have, which may 
be old) send the message to all servers:

CqResultsPtr CqQueryImpl::executeWithInitialResults(uint32_t timeout) {
  ...

  TcrMessage msg(TcrMessage::EXECUTECQ_WITH_IR_MSG_TYPE, m_cqName, 
m_queryString, CqState::RUNNING, isDurable(), m_tccdm);
  TcrMessage reply(true, m_tccdm);
  ChunkedQueryResponse* resultCollector = (new ChunkedQueryResponse(reply));
  reply.setChunkedResultHandler(static_cast(resultCollector));
  reply.setTimeout(timeout);

  GfErrType err = GF_NOERR;
  err = m_tccdm->sendSyncRequest(msg, reply); ..

And sendSyncRequest:
...

for (std::vector::iterator ep = m_endpoints.begin(); ep != 
m_endpoints.end(); ++ep) {
if ((*ep)->connected()) {
  (*ep)->setDM(this);
  opErr = sendRequestToEP(request, reply, *ep);//this will go to 
ThinClientDistributionManager

...


Can this be causing the issue?



-Roi





-Original Message-
From: Jason Huynh [mailto:jasonhu...@apache.org]
Sent: Tuesday, August 15, 2017 9:25 PM
To: dev@geode.apache.org
Subject: Re: continuous query internal mechanism questions

I am not quite sure how native client registers cqs. From my understanding:
with the java api, I believe there is only one message (ExecuteCQ message) that 
is executed on the server side and then replicated to the other nodes through 
the profile (OperationMessage).

It seems the extra ExecuteCQ message failing and then closing the cq might be 
putting the system in a weird state...

On Tue, Aug 15, 2017 at 7:56 AM Roi Apelker  wrote:

> Hi,
>
> I have been examining the continuous query registration mechanism for 
> quite some time This is related to an issue that I have, where 
> sometimes a node crashes (1 node out of 2), and the other one does not 
> send CQ events. The CQ is registered on a partitioned region which 
> resides on these 2 nodes.
>
> I noticed the following behavior, and I wonder if anyone can comment 
> regarding it, if it is justified or not and what is the reason:
>
> 1. When the software using the client (native client) registers for 
> the CQ, a CQ command (ExecuteCQ61) is received on both servers.
>  -- is this normal behaviour? Does the client actually send this 
> command to both servers?
>
> 2. When this command is received by a server, and the CQ is 
> registered, another registration message is sent to the other node via 
> an OperationMessage (REGISTER_CQ)
>  -- it seems that regularly, the server can handle this situation as 
> the second registration identifies the previous one and does not 
> affect it. but the question, why do we need this 2nd registration, if 
> there is a command sent to each server?
>
> 3. For some reason, sometimes there is a failure to complete the first 
> registration (executed by ExecuteCQ61) and then this failure causes a 
> closure to the CQ, which is accompanied with a close request to the 
> other node.
>  -- I assume by now, since 2 registrations and one closure have 
> occurred on node 2, the CQ is still active and the client receives 
> notifications.
>
> 4. Sometimes, 1 out of 5, once node 1 crashes, I get a cleanup 
> operation, caused by the crash (via MemberCrashedEvent), and this also 
> closes the existing CQ, and in this case the CQ in node 2 does not 
> operate anymore and the client receives no notifications.
>  -- fact is, that 4 out of 4 times, I do not get this cleanup by 
> MemberCrashedEvent (maybe due to some other error), and that the CQ 
> notifications are received normally.
>
> Can anyone clear things up for me? Any comment on any of the 
> statements above will be greatly appreciated.
>
> Thanks,
>
> Roi
>
>
> -Original Message-
> From: Roi Apelker
> Sent: Wednesday, August 09, 2017 3:21 PM
> To: dev@geode.apache.org
> Subject: RE: continuous query internal mechanism
>
> Dhanyavad
>
> -Original Message-
> From: Anilkumar Gingade [mailto:aging...@pivotal.io]
> Sent: Tuesday, August 08, 2017 9:55 PM
> To: dev@geode.apache.org
> Subject: Re: continuous query internal mechanism
>
> Registered events, i meant, are events generated for interest 
> registration "region.registerInterest(*)". And CqEvents are for CQs 
> registered.
>
> -Anil.
>
>
> On Tue, Aug 8, 2017 at 12:27 AM, Roi Apelker 
> wrote:
>
> > Shukriya
> >
> > What is the difference between registered events and CQ events?
> >
> > -Original Message-
> > From: Anilkumar Gingade [mailto:aging...@pivotal.io]
> > Sent: Monday, August 07, 2017 10:12 PM
> > To: dev@geode.apache.org
> > Subject: Re: continuous query internal mechanism
> >

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/739#discussion_r135055785
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 ---
@@ -50,26 +53,52 @@
   .makeErrorResponse(ProtocolErrorCode.REGION_NOT_FOUND.codeValue, 
"Region not found"));
 }
 
-try {
-  Set keys = new HashSet<>();
-  for (BasicTypes.EncodedValue key : request.getKeyList()) {
-keys.add(ProtobufUtilities.decodeValue(serializationService, key));
-  }
-  Map results = region.getAll(keys);
-  Set entries = new HashSet<>();
-  for (Map.Entry entry : results.entrySet()) {
-entries.add(
-ProtobufUtilities.createEntry(serializationService, 
entry.getKey(), entry.getValue()));
-  }
-  return 
Success.of(RegionAPI.GetAllResponse.newBuilder().addAllEntries(entries).build());
-} catch (UnsupportedEncodingTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue, "Encoding not 
supported."));
-} catch (CodecNotRegisteredForTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue,
-  "Codec error in protobuf deserialization."));
+Map resultsCollection = 
request.getKeyList().stream()
+.map((key) -> processOneMessage(serializationService, region, key))
+.collect(Collectors.partitioningBy(x -> x instanceof 
BasicTypes.Entry));
+RegionAPI.GetAllResponse.Builder responseBuilder = 
RegionAPI.GetAllResponse.newBuilder();
+
+for (Object entry : resultsCollection.get(true)) {
+  responseBuilder.addEntries((BasicTypes.Entry) entry);
+}
+
+for (Object entry : resultsCollection.get(false)) {
+  responseBuilder.addFailures((BasicTypes.KeyedError) entry);
 }
+
+return Success.of(responseBuilder.build());
   }
 
+  private Object processOneMessage(SerializationService 
serializationService, Region region,
+  BasicTypes.EncodedValue key) {
+try {
+  Object decodedKey = 
ProtobufUtilities.decodeValue(serializationService, key);
+  Object value = region.get(decodedKey);
+  return ProtobufUtilities.createEntry(serializationService, 
decodedKey, value);
+} catch (CodecNotRegisteredForTypeException | 
UnsupportedEncodingTypeException ex) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue)
+  .setMessage("Encoding not supported."))
+  .build();
+} catch (org.apache.geode.distributed.LeaseExpiredException | 
TimeoutException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.OPERATION_TIMEOUT.codeValue)
+  .setMessage("Operation timed out: " + e.getMessage()))
+  .build();
+} catch (CacheLoaderException | PartitionedRegionStorageException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.DATA_UNREACHABLE.codeValue)
+  .setMessage("Data unreachable: " + e.getMessage()))
+  .build();
+} catch (NullPointerException | IllegalArgumentException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.CONSTRAINT_VIOLATION.codeValue)
+  .setMessage("Invalid input: " + e.getMessage()))
+  .build();
--- End diff --

Also, it would be A LOT nicer to have some utility method that states 
`createErrorMessage(code,description)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/739#discussion_r135055386
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 ---
@@ -50,26 +53,52 @@
   .makeErrorResponse(ProtocolErrorCode.REGION_NOT_FOUND.codeValue, 
"Region not found"));
 }
 
-try {
-  Set keys = new HashSet<>();
-  for (BasicTypes.EncodedValue key : request.getKeyList()) {
-keys.add(ProtobufUtilities.decodeValue(serializationService, key));
-  }
-  Map results = region.getAll(keys);
-  Set entries = new HashSet<>();
-  for (Map.Entry entry : results.entrySet()) {
-entries.add(
-ProtobufUtilities.createEntry(serializationService, 
entry.getKey(), entry.getValue()));
-  }
-  return 
Success.of(RegionAPI.GetAllResponse.newBuilder().addAllEntries(entries).build());
-} catch (UnsupportedEncodingTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue, "Encoding not 
supported."));
-} catch (CodecNotRegisteredForTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue,
-  "Codec error in protobuf deserialization."));
+Map resultsCollection = 
request.getKeyList().stream()
+.map((key) -> processOneMessage(serializationService, region, key))
+.collect(Collectors.partitioningBy(x -> x instanceof 
BasicTypes.Entry));
+RegionAPI.GetAllResponse.Builder responseBuilder = 
RegionAPI.GetAllResponse.newBuilder();
+
+for (Object entry : resultsCollection.get(true)) {
+  responseBuilder.addEntries((BasicTypes.Entry) entry);
+}
+
+for (Object entry : resultsCollection.get(false)) {
+  responseBuilder.addFailures((BasicTypes.KeyedError) entry);
 }
+
+return Success.of(responseBuilder.build());
   }
 
+  private Object processOneMessage(SerializationService 
serializationService, Region region,
+  BasicTypes.EncodedValue key) {
+try {
+  Object decodedKey = 
ProtobufUtilities.decodeValue(serializationService, key);
+  Object value = region.get(decodedKey);
+  return ProtobufUtilities.createEntry(serializationService, 
decodedKey, value);
+} catch (CodecNotRegisteredForTypeException | 
UnsupportedEncodingTypeException ex) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue)
+  .setMessage("Encoding not supported."))
+  .build();
+} catch (org.apache.geode.distributed.LeaseExpiredException | 
TimeoutException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.OPERATION_TIMEOUT.codeValue)
+  .setMessage("Operation timed out: " + e.getMessage()))
+  .build();
+} catch (CacheLoaderException | PartitionedRegionStorageException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.DATA_UNREACHABLE.codeValue)
+  .setMessage("Data unreachable: " + e.getMessage()))
+  .build();
+} catch (NullPointerException | IllegalArgumentException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.CONSTRAINT_VIOLATION.codeValue)
+  .setMessage("Invalid input: " + e.getMessage()))
+  .build();
--- End diff --

Do we have any tests that prove that these exceptions are thrown and 
correctly handled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Nightly build failures caused by attempted use of default ports

[Darrel Schneider]

I like the sound of #1:
1) use Docker for AcceptanceTest and IntegrationTest targets?

Does anyone know of a downside to running these tests in docker?

On Wed, Aug 23, 2017 at 12:06 PM, Jared Stewart  wrote:

> I think we just need to have AcceptanceTest (and possibly IntegrationTest)
> run inside Docker like DistributedTest already does.
>
> - Jared.
>
> > On Aug 23, 2017, at 11:32 AM, Anilkumar Gingade 
> wrote:
> >
> >>> 1) use Docker for AcceptanceTest and IntegrationTest targets?
> > To be clear, the failing tests are only in Acceptance Test and
> Integration
> > Tests? And distributed tests are not seeing this issue as they are
> running
> > in docker nowIf moving docker address this issue, my vote is for
> moving
> > docker; this makes all the tests to be run in similar environment.
> >
> >>> 2) not test default ports?
> > If the product supports default port; we need to have test for
> that...Most
> > of the early product evaluation is done with default port...
> >
> > -Anil.
> >
> >
> > On Wed, Aug 23, 2017 at 11:15 AM, Kirk Lund  wrote:
> >
> >> The following nightly build failures are tests that are testing default
> >> ports which are failing because the port is not available.
> >>
> >> Should we:
> >>
> >> 1) use Docker for AcceptanceTest and IntegrationTest targets?
> >>
> >> 2) not test default ports?
> >>
> >> 3) use a hacky System property to force Geode to think that some other
> port
> >> is the default port?
> >>
> >> 4) some other solution?
> >>
> >> testGet – org.apache.geode.rest.internal.web.RestServersJUnitTest
> >> a few seconds
> >> testServerStartedOnDefaultPort –
> >> org.apache.geode.rest.internal.web.RestServersJUnitTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedWhenConnected_server_dir –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedWhenConnected_server_pid –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> onlineStatusCommandShouldSucceedWhenConnected_locator_host_and_port –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_dir –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_pid –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> onlineStatusCommandShouldSucceedWhenConnected_server_name –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedWhenConnected_locator_dir –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> offlineStatusCommandShouldSucceedWhenConnected_locator_pid –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> onlineStatusCommandShouldSucceedWhenConnected_locator_name –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> onlineStatusCommandShouldSucceedWhenConnected_locator_port –
> >> org.apache.geode.management.internal.cli.shell.
> >> GfshExitCodeStatusCommandsTest
> >> a few seconds
> >> statusLocatorSucceedsWhenConnected –
> >> org.apache.geode.management.internal.cli.commands.
> >> StatusLocatorRealGfshTest
> >>
>
>

Build failed in Jenkins: Geode-nightly-flaky #101

[Apache Jenkins Server]

See 


Changes:

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide -

[huynhja] GEODE-3184: Cleaned up Cargo tests

[lgallinat] GEODE-3507 PartitionedRegionRedundancyTracker now does not allow

[kmiller] GEODE-3249 Document geode.allow-internal-messages-without-credentials

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Basic

[nnag] GEODE-3276: Managing race conditions while the senders are stopped

--
[...truncated 103.65 KB...]
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/classmate/1.3.1/classmate-1.3.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin/1.2.0.RELEASE/spring-plugin-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct-parent/1.0.0.Final/mapstruct-parent-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-ui/2.6.1/springfox-swagger-ui-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/hateoas/spring-hateoas/0.23.0.RELEASE/spring-hateoas-0.23.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-paranamer/2.8.6/jackson-module-paranamer-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.jar
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-protobuf:jar
:geode-protobuf:javadoc
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war

Jenkins build is back to normal : Geode-release-flaky #31

[Apache Jenkins Server]

See 

Build failed in Jenkins: Geode-nightly #933

[Apache Jenkins Server]

See 


Changes:

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide -

[huynhja] GEODE-3184: Cleaned up Cargo tests

[lgallinat] GEODE-3507 PartitionedRegionRedundancyTracker now does not allow

[kmiller] GEODE-3249 Document geode.allow-internal-messages-without-credentials

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Basic

[nnag] GEODE-3276: Managing race conditions while the senders are stopped

--
[...truncated 190.27 KB...]

18: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':geode-web:distributedTest'.
> Could not find matching constructor for: 
> org.gradle.process.internal.worker.DefaultWorkerProcessFactory(org.gradle.api.logging.LogLevel,
>  com.pedjak.gradle.plugins.dockerizedtest.DockerizedTestPlugin$MessageServer, 
> org.gradle.api.internal.DefaultClassPathRegistry, 
> org.gradle.internal.id.LongIdGenerator, java.io.File, 
> org.gradle.api.internal.file.TmpDirTemporaryFileProvider, 
> com.sun.proxy.$Proxy80)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

19: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':geode-web-api:distributedTest'.
> Could not find matching constructor for: 
> org.gradle.process.internal.worker.DefaultWorkerProcessFactory(org.gradle.api.logging.LogLevel,
>  com.pedjak.gradle.plugins.dockerizedtest.DockerizedTestPlugin$MessageServer, 
> org.gradle.api.internal.DefaultClassPathRegistry, 
> org.gradle.internal.id.LongIdGenerator, java.io.File, 
> org.gradle.api.internal.file.TmpDirTemporaryFileProvider, 
> com.sun.proxy.$Proxy80)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

20: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':extensions/geode-modules-assembly:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

21: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':geode-common:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

22: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':geode-core:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

23: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':geode-cq:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.