Re: [DISCUSS] Request to setup test pipelines for Apache Geode 1.7.0 release

2018-05-22 Thread Nabarun Nag
Sorry about that.
release/1.7.0 branch has been created for Apache geode-examples repo

Regards
Nabarun Nag
On Tue, May 22, 2018 at 11:26 AM Anthony Baker  wrote:

> Sure thing Naba.  We still need a release branch for geode-examples though.
>
> Anthony
>
>
> > On May 21, 2018, at 4:51 PM, Nabarun Nag  wrote:
> >
> > Hi Geode Community,
> >
> > As we have created a release branch for Apache Geode 1.7.0 , we request
> CI
> > test pipeline to be established for the branch - "release/1.7.0" in order
> > to prepare for the release.
> >
> > Regards
> > Nabarun Nag
>
>


[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #925 was SUCCESSFUL (with 2406 tests)

2018-05-22 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #925 was successful.
---
Scheduled
2408 tests in total.

https://build.spring.io/browse/SGF-NAG-925/





--
This message is automatically generated by Atlassian Bamboo

Re: geode.apache.org and GDPR

2018-05-22 Thread Dan Smith
+1 to remove it.

-Dan

On Tue, May 22, 2018 at 12:05 PM, Mark Bretl  wrote:

> Thanks Anthony for bringing this to attention as the GDPR deadline is
> looming. +1 for removing.
>
> --Mark
>
> On Mon, May 21, 2018 at 3:12 PM, Joey McAllister 
> wrote:
>
> > +1 to removing this. Thanks, Anthony!
> >
> > On Mon, May 21, 2018 at 3:03 PM Michael Stolz  wrote:
> >
> > > +1 to remove it
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer, GemFire Product Lead
> > > Mobile: +1-631-835-4771 <(631)%20835-4771>
> > > Download the GemFire book here.
> > > <
> > > https://content.pivotal.io/ebooks/scaling-data-services-
> > with-pivotal-gemfire
> > > >
> > >
> > > On Mon, May 21, 2018 at 11:31 AM, Greg Chase  wrote:
> > >
> > > > Part of GDPR: Don’t collect or store data you don’t intend to use.
> > > >
> > > > +1 to remove it.
> > > >
> > > > This email encrypted by tiny buttons & fat thumbs, beta voice
> > > recognition,
> > > > and autocorrect on my iPhone.
> > > >
> > > > > On May 21, 2018, at 8:29 AM, Anthony Baker 
> > wrote:
> > > > >
> > > > > The geode website uses Google Analytics [1].  IANAL but there are
> > some
> > > > constraints that will apply when GPDR takes effect [2].
> Specifically,
> > > > users can opt-out of data collection.  Given how little use we’ve
> made
> > of
> > > > this data, I think it would be simpler to just remove the GA tracker
> > from
> > > > our website.
> > > > >
> > > > > Thoughts?
> > > > >
> > > > >
> > > > > Anthony
> > > > >
> > > > > [1] https://github.com/apache/geode-site/blob/master/
> > > > website/layouts/header.html#L40  > > > geode-site/blob/master/website/layouts/header.html#L40>
> > > > > [2] https://issues.apache.org/jira/browse/MSKINS-143 <
> > > > https://issues.apache.org/jira/browse/MSKINS-143>
> > > > >
> > > >
> > >
> >
>


Re: wiki userid locked

2018-05-22 Thread Mark Bretl
Hi Barbara,

Unfortunately, we can not help you with login issues. You will need to
contact Apache INFRA team by emailing us...@infra.apache.org to unlock your
account.

--Mark

On Tue, May 22, 2018 at 8:51 AM, Barbara Pruijn  wrote:

> Hi,
>
> It looks like my geode wiki userid is locked.
> My userid is bpruijn.
> I have reset my password several times, but I cannot log in with any new
> password created. I think my account is in a locked state.
>
> Can someone please unlock it?
>
> Thanks,
> Barbara
>
>


Re: geode.apache.org and GDPR

2018-05-22 Thread Mark Bretl
Thanks Anthony for bringing this to attention as the GDPR deadline is
looming. +1 for removing.

--Mark

On Mon, May 21, 2018 at 3:12 PM, Joey McAllister 
wrote:

> +1 to removing this. Thanks, Anthony!
>
> On Mon, May 21, 2018 at 3:03 PM Michael Stolz  wrote:
>
> > +1 to remove it
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Lead
> > Mobile: +1-631-835-4771 <(631)%20835-4771>
> > Download the GemFire book here.
> > <
> > https://content.pivotal.io/ebooks/scaling-data-services-
> with-pivotal-gemfire
> > >
> >
> > On Mon, May 21, 2018 at 11:31 AM, Greg Chase  wrote:
> >
> > > Part of GDPR: Don’t collect or store data you don’t intend to use.
> > >
> > > +1 to remove it.
> > >
> > > This email encrypted by tiny buttons & fat thumbs, beta voice
> > recognition,
> > > and autocorrect on my iPhone.
> > >
> > > > On May 21, 2018, at 8:29 AM, Anthony Baker 
> wrote:
> > > >
> > > > The geode website uses Google Analytics [1].  IANAL but there are
> some
> > > constraints that will apply when GPDR takes effect [2].  Specifically,
> > > users can opt-out of data collection.  Given how little use we’ve made
> of
> > > this data, I think it would be simpler to just remove the GA tracker
> from
> > > our website.
> > > >
> > > > Thoughts?
> > > >
> > > >
> > > > Anthony
> > > >
> > > > [1] https://github.com/apache/geode-site/blob/master/
> > > website/layouts/header.html#L40  > > geode-site/blob/master/website/layouts/header.html#L40>
> > > > [2] https://issues.apache.org/jira/browse/MSKINS-143 <
> > > https://issues.apache.org/jira/browse/MSKINS-143>
> > > >
> > >
> >
>


Re: [DISCUSS] Request to setup test pipelines for Apache Geode 1.7.0 release

2018-05-22 Thread Anthony Baker
Sure thing Naba.  We still need a release branch for geode-examples though.

Anthony


> On May 21, 2018, at 4:51 PM, Nabarun Nag  wrote:
> 
> Hi Geode Community,
> 
> As we have created a release branch for Apache Geode 1.7.0 , we request CI
> test pipeline to be established for the branch - "release/1.7.0" in order
> to prepare for the release.
> 
> Regards
> Nabarun Nag



wiki userid locked

2018-05-22 Thread Barbara Pruijn
Hi,

It looks like my geode wiki userid is locked.
My userid is bpruijn.
I have reset my password several times, but I cannot log in with any new 
password created. I think my account is in a locked state.

Can someone please unlock it?

Thanks,
Barbara



Re: Reviews and Conflicts in Pull Requests

2018-05-22 Thread Bruce Schuchardt
I don't think the "single commit" notion is even a good one for an 
original PR.  I've discussed this with other people and we think it's 
okay for the PR to have multiple commits if they serve different 
purposes such as renaming variables or restructuring code before 
attacking a problem.  Likewise it's okay to address review comments in 
an additional commit.  The PR template just addresses the initial PR 
being a single commit anyway.


That being said, if the changes required by reviewers are so substantial 
that the PR becomes difficult to review it should be pulled and a new PR 
should be created.  Otherwise who's going to bother with it?


Regarding conflicts, that's between the contributor and the committer.  
A PR that picks up conflicts due to other peoples' work isn't invalid.  
Most conflicts are easy to resolve but if it's too gnarly would the 
contributor want someone else to do the work and maybe mess up?



On 5/22/18 2:41 AM, Ju@N wrote:

Hello geode devs,

The Geode Wiki has a lot of useful information, not only about the
usage/internal architecture of Geode, but also explanations and guidelines
about how Code Contributions [1] should be made. However, some common cases
are not explained in detail and, as such, contributors (and also reviewers)
might have a hard time trying to deal with these situations in an
*standardize* manner. In particular, I'm referring to the following two
scenarios, which can happen for every single pull request:

- *Reviewers request a change: *do contributors have to make the changes
and just add another commit to the original pull request?. Do
contributors have to make changes and squash everything in one single
commit (executing a *push --force *afterwards)?. Do contributors have to
close the pull request and open a new one with everything squashed?.


- *Pull Request looks good but, after a while without being merged,
somebody else makes a change in develop, causing the original pull request
to become conflictive with the current develop branch: *should the
committer merging the pull request solve these conflicts as well?. Do
contributors have to solve the conflict locally?, if so, do they have to
add a new commit to the pull request or squash everything in one single
commit (executing a *push --force *afterwards)?.

It would be good if we could add these details to the Wiki so everyone
knows how to proceed whenever they hit this situations (git commands will
also be helpful). Would anyone be able to add this to the Wiki?, or reply
to this thread so the approved/recommended process is documented somewhere?.
Cheers.

[1]: https://cwiki.apache.org/confluence/display/GEODE/Code+contributions