[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1022 was SUCCESSFUL (with 2423 tests)

2018-08-27 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1022 was successful. --- Scheduled 2425 tests in total. https://build.spring.io/browse/SGF-NAG-1022/ --

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Bruce Schuchardt
great!  thanks On 8/27/18 1:42 PM, Nabarun Nag wrote: I completely agree. Once the branch is created, it will undergo all compatibility and upgrade tests. The commit that you have mentioned will be reverted in 1.7.0, as well as any related commits Regards Nabarun Nag On Mon, Aug 27, 2018 at

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
I completely agree. Once the branch is created, it will undergo all compatibility and upgrade tests. The commit that you have mentioned will be reverted in 1.7.0, as well as any related commits Regards Nabarun Nag On Mon, Aug 27, 2018 at 1:34 PM Bruce Schuchardt wrote: > I don't think it's as

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Bruce Schuchardt
I don't think it's as easy as doing a rebase.  Someone added the 1.8 version to Version.java and we need to revert that.  We also need to see if it's being used anywhere for backward-compatibility.  If it's in use those changes need to be examined and probably undone on the branch if they're

DiskRegionJUnitTest

2018-08-27 Thread Kirk Lund
I'm working on fixing some flaky failures in DiskRegionJUnitTest and I plan to overhaul the entire test. I'll probably extract multiple test classes from it as well. I recommend avoiding this test to avoid git conflicts!

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
Hi Geode Developers, >From the discussion in this email thread we are waiting on couple of GEODE JIRAs to be resolved to continue with 1.7.0 release process. GEODE-5615 - resolved. GEODE-5601 - In-progress [DanSmith / Kenneth Howe ] GEODE-5594 - Open [Sai Boorlagadda] GEODE-5338 - Open [Sai

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
@Bruce those changes were done when 1.7.0 release process was in-progress, and a release branch was already created. But we stopped that process mid way. This happened in May 2018. We are planning to rebase the 1.7.0 brach with the current develop pretty soon. Regards Nabarun On Mon, Aug 27, 2018

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
I am about to change the fixed version in GEODE JIRAs to 1.7.0 for those tickets which are marked closed or resolved with 1.8.0 as the fix version. Please do let me know if there are any concerns. The new release branch has not been created yet. Regards Nabarun Nag On Mon, Aug 27, 2018 at 10:17

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Bruce Schuchardt
It looks like we've cut a 1.7.0 release branch that says its 1.8.0.  Is that intentional? private static final byte GEODE_180_ORDINAL =95; public static final VersionGEODE_180 = new Version("GEODE","1.8.0", (byte)1, (byte)8, (byte)0, (byte)0,GEODE_180_ORDINAL); On 8/27/18 9:50 AM, Sai

Re: [DISCUSS] Remove CatchException testing dependency

2018-08-27 Thread Kirk Lund
Jira ticket as been filed for this: GEODE-5639: Replace usage of CatchException with AssertJ and remove CatchException dependency On Thu, Aug 23, 2018 at 4:03 PM, Kirk Lund wrote: > I goofed on #1. We should be using* org.assertj.core.api.**Assertions* > directly, not

Re: [DISCUSS] Remove CatchException testing dependency

2018-08-27 Thread Kirk Lund
For black box testing expected exceptions thrown by background threads of Geode, we'll need to add appropriate User APIs on a case-by-case basis. Neither CatchException or AssertJ will help in this case unless there's a way to get a reference to what was thrown. On Fri, Aug 24, 2018 at 4:55 PM,

Re: Wiki housekeeping request

2018-08-27 Thread Anthony Baker
I wanted to make better “space shortcuts”, like adding the ReleaseNotes. Overall, I think our wiki is in pretty good shape but there are a few places I wanted to clean up, simplify, and make easier to find. Anthony > On Aug 27, 2018, at 9:31 AM, Dan Smith wrote: > > Hi Anthony, > > I went

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Sai Boorlagadda
After reading through the weekend, validating against CN as a fallback should be acceptable and dont have any further concerns with default JDK's implementation as expressed[1]. Planning to merge GEODE-5594 today and following with GEODE-5338. Sai [1]

Re: Wiki housekeeping request

2018-08-27 Thread Kirk Lund
I just checked and it looks like you have admin permissions. Not sure if someone just flipped that on for you or if you were already an admin. If there's something you can't do, let me know! On Mon, Aug 27, 2018 at 8:05 AM, Anthony Baker wrote: > Hi all, > > I am working on some housekeeping

Re: Wiki housekeeping request

2018-08-27 Thread Dan Smith
Hi Anthony, I went ahead and added you as a space admin, but I'm curious what you couldn't do as a non-admin? -Dan On Mon, Aug 27, 2018 at 8:05 AM, Anthony Baker wrote: > Hi all, > > I am working on some housekeeping on the Geode wiki and would like space > admin privileges. Can someone

Wiki housekeeping request

2018-08-27 Thread Anthony Baker
Hi all, I am working on some housekeeping on the Geode wiki and would like space admin privileges. Can someone (Mark, Dan, Kirk, William) upgrade my account? My username is abaker. Thanks, Anthony