Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Anthony Baker
How do you retrieve git metadata when building from a source distribution (not a repo)? That is why .buildinfo exists *in the source distribution*. Anthony > On Sep 12, 2018, at 4:30 PM, Patrick Rhomberg wrote: > > Okay. So that information is definitely coming from the >

Re: [discuss] Should we evaluate at commit messages as part of PR review?

2018-09-12 Thread Jianxia Chen
There is a good article on this topic that Anthony recommended a while ago: http://chris.beams.io/posts/git-commit/ Jianxia On Wed, Sep 12, 2018 at 4:30 PM Michael Stolz wrote: > +1 to descriptive commit messages > > Done well they will save time on every post commit access to that commit. > >

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Anthony Baker
1) User downloads source distribution [1] 2) User runs `gradle build` 3) User runs `gfsh version --full` The .buildinfo file contains the information that should go into the GemFireVersion.properties file. Does that help? Anthony [1]

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Alexander Murmann
+1 for revert On Wed, Sep 12, 2018 at 4:42 PM, Nabarun Nag wrote: > Reverting them on release/1.7.0 will bring it to the previous status quo, > how all previous releases were done. I don't think anyone will build > release/1.7.0 repeatedly, hence there is no advantage of making build > process

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Nabarun Nag
Reverting them on release/1.7.0 will bring it to the previous status quo, how all previous releases were done. I don't think anyone will build release/1.7.0 repeatedly, hence there is no advantage of making build process faster for that branch. Whereas on develop a more appropriate solution can be

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Patrick Rhomberg
Okay. So that information is definitely coming from the GemFireVersion.properties file, which explains this issue. Either reverting the previous GEODE-5600 changes or resolving merge conflicts from PR 2457 would address this issue. My concern remains about the .buildinfo file, however.Is

Re: [discuss] Should we evaluate at commit messages as part of PR review?

2018-09-12 Thread Michael Stolz
+1 to descriptive commit messages Done well they will save time on every post commit access to that commit. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Sep 12, 2018 4:15 PM, "Alexander Murmann" wrote: > While our wiki page primarily calls out the 50/74

Re: [discuss] Should we evaluate at commit messages as part of PR review?

2018-09-12 Thread Alexander Murmann
While our wiki page primarily calls out the 50/74 rule which is important, my bigger concern is in that I'd love to see commit messages that explain why a change was made. Sometimes that information is in the reference JIRA ticket, but not always. Especially with bug fixes we tend to not explain

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Nabarun Nag
@patrick if you build geode release branch 1.7.0 "./gradlew clean build -Dskip.tests=true -xdocs -xjavadoc" and start gfsh from geode-assembly/build/install/apache-geode/bin/gfsh And then type `version --full` you get this gfsh>version --full Build-Date: 2018-09-12 16:07:03 -0700 Build-Id: nnag 0

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1038 was SUCCESSFUL (with 2456 tests)

2018-09-12 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1038 was successful. --- Scheduled 2458 tests in total. https://build.spring.io/browse/SGF-NAG-1038/ --

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Patrick Rhomberg
I'm happy to work on those reverts, although if Anthony could elaborate on where exactly the version information was missing, that assuage some of my own worries as to whether it's the right approach. It's still not clear to me where .buildinfo is intended to be consumed. On Wed, Sep 12, 2018 at

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Nabarun Nag
Yes Alexander, we are still waiting on the build info reverts from Patrick, so, I think that this can be put into release/1.7.0. Sure Jinmei, you can go ahead and merge the change into release/1.7.0 branch too when you merge the PR. Please do close the fixed version in the JIRA as 1.7.0 Regards

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Alexander Murmann
While there is a workaround this looks like a highly visible bug with a fairly safe fix. I am in favor of merging, since the branch is still distressed anyways. Other opinions? On Wed, Sep 12, 2018 at 2:29 PM, Jinmei Liao wrote: > Should we include the fix for GEODE-5727 in the 1.7 release as

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Jinmei Liao
Should we include the fix for GEODE-5727 in the 1.7 release as well? Without the fix, the command "export cluster-config --zip-file-name=x.zip" would fail with NPE, user has to use "export cluster-config --zip-file-name=./x.zip" in order for export to work. PR for this fix is ready and could be

Re: [discuss] Should we evaluate at commit messages as part of PR review?

2018-09-12 Thread Pulkit Chandra
Have we thought about git hooks as a way to enforce policy https://git-scm.com/book/en/v2/Customizing-Git-An-Example-Git-Enforced-Policy ? *Pulkit Chandra* On Wed, Sep 12, 2018 at 2:46 PM Alexander Murmann wrote: > Hi everyone, > > We have a wiki page >

[discuss] Should we evaluate at commit messages as part of PR review?

2018-09-12 Thread Alexander Murmann
Hi everyone, We have a wiki page that discusses why good commit messages matter and links to a even better article on the topic. In addition to what's described in those documents, better commit messages also would make it

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Patrick Rhomberg
I'm not sure PR 2457 will help with an ignored .buildinfo, but I'm not sure as to why .buildinfo would be getting ignored by anything, either. PR 2457 deals with the still-needs-to-be-renamed GemFireVersion.properties file and when it is generated. Previously, it was whenever the git index

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-12 Thread Alexander Murmann
Hi everyone, It seems like that PR doesn't address the missing SHA issue either and I am not aware of any proposals to properly fix this. How viable is it to revert the relevant Gradle build changes on support/1.7? We could continue make the new Gradle approach work with our release process on

Re: please give me (bburcham) permission to assign himself Jira tickets

2018-09-12 Thread Dan Smith
Done! You should have access now. -Dan On Wed, Sep 12, 2018 at 10:05 AM, Bill Burcham wrote: > I made a ticket and would like to assign it to myself. Please let me. > > -Bill >

please give me (bburcham) permission to assign himself Jira tickets

2018-09-12 Thread Bill Burcham
I made a ticket and would like to assign it to myself. Please let me. -Bill